make_taggable 0.6.6 → 0.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 492754c144e670799533ba98bf6870d05451845d02ee347b0cca8ee8c4f7bc36
-  data.tar.gz: 2641b641d09c7a99ef706f6b446d568ddc1d9de24d9a7d1c9f007dafb5079288
+  metadata.gz: c3f8ba23e2c0ef116d6ecf1a84bc4005f844e273043fdc6851fd81d2cdcc4c12
+  data.tar.gz: 264f1cfb9480eb07793175f4793c3d868b5e51ca30ab6d04adf014aeeadf9a35
 SHA512:
-  metadata.gz: 24385c88d803dd0b4d222b998b14f6b7f9e4f2f7e84b59dd7eacf0a3ba0739e35eacda6c9ef4238b27da342c12dc75ce42f714f1ed701f3f2a70d28d4ea0d7ed
-  data.tar.gz: bf6030ccd267d19db82a6b08072ded0740f6e9674faa05cb974053289438bcc144f7da6ac97ff875fc5be8f6f585d289739ae2a80f63250fefec7eb5f658b826
+  metadata.gz: 43307738e342679e858293c5801d1bf21bafee7363ac9620de63800590903c448a3aea03a1a3ab3d258b2482f42a12bb5f4baad1065f2648a569b86b0c966eac
+  data.tar.gz: e6e2a45780ebdac2539107fe5ff87709975666f6d436cff09129d90c04d444e93ae72a56beef2f7b99af55385969c84cb33b56f0e2ef4593bacc2fd859969258

data/.dummyrc

@@ -0,0 +1,17 @@
+--skip-bootsnap
+--skip-webpack
+--skip-action-cable
+--skip-spring
+--skip-coffee
+--skip-turbolinks
+--skip-listen
+--skip-action-text
+--skip-active-storage
+--skip-action-cable
+--skip-action-mailer
+--skip-action-mailbox
+--skip-active-job
+--skip-javascript
+--skip-test
+
+--template=spec/template/test_app_template.rb

data/.github/workflows/ci.yml

@@ -1,4 +1,5 @@
-name: Tests
+---
+name: CI
 
 on:
   pull_request:
@@ -8,40 +9,132 @@ on:
     branches:
       - master
 jobs:
-  test:
+  # SQLITE
+  sqlite:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby: [ '2.7', '2.6', '2.5' ]
-    steps:
-      - uses: actions/checkout@master
+        ruby: ['2.6', '2.7', '3.0']
+        gemfile:
+          - rails_5
+          - rails_6
+          - rails_6_1
+          - rails_master
+        exclude:
+          - ruby: '3.0'
+            gemfile: rails_5
+          # Rails 7 requires Ruby 2.7 or higher
+          - ruby: '2.6'
+            gemfile: rails_master
+    env:
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
+      BUNDLE_PATH_RELATIVE_TO_CWD: true
 
-      - name: Set up Ruby
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby ${{ matrix.ruby }}
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - name: Run tests
+        env:
+          RAILS_ENV: test
+        run: |
+          bundle exec rake create_test_app
+          bundle exec rake
+
 
-      - name: Cache gems
-        uses: actions/cache@v1
+  # MYSQL
+  mysql:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: ['2.6', '2.7', '3.0']
+        gemfile:
+          - rails_5
+          - rails_6
+          - rails_6_1
+          - rails_master
+        exclude:
+          - ruby: '3.0'
+            gemfile: rails_5
+          # Rails 7 requires Ruby 2.7 or higher
+          - ruby: '2.6'
+            gemfile: rails_master
+    env:
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
+      BUNDLE_PATH_RELATIVE_TO_CWD: true
+
+    services:
+      mysql:
+        image: mysql:8
+        env:
+          MYSQL_ROOT_PASSWORD: password
+          MSQL_DATABASE: test
+        ports: ['3306:3306']
+        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
         with:
-          path: vendor/bundle
-          key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-gem-
-      - name: Install dependencies
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - name: Run tests
+        env:
+          DATABASE_URL: mysql2://root:password@127.0.0.1:3306/test
+          RAILS_ENV: test
         run: |
-          sudo apt-get update
-          sudo apt-get install libsqlite3-dev
-          gem update --system
-          gem install bundler
-          bundle install --jobs 4 --retry 3
-          bundle exec appraisal install
+          bundle exec rake create_test_app
+          bundle exec rake
+
+
+  # POSTGRES
+  postgres:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: ['2.6', '2.7', '3.0']
+        gemfile:
+          - rails_5
+          - rails_6
+          - rails_6_1
+          - rails_master
+        exclude:
+          - ruby: '3.0'
+            gemfile: rails_5
+          # Rails 7 requires Ruby 2.7 or higher
+          - ruby: '2.6'
+            gemfile: rails_master
+    env:
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
+      BUNDLE_PATH_RELATIVE_TO_CWD: true
+
+    services:
+      postgres:
+        image: postgres:12
+        env:
+          POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: password
+          POSTGRES_DB: test
+        ports: ['5432:5432']
 
-      - name: StandardRb check
-        run: bundle exec standardrb
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
 
       - name: Run tests
         env:
+          DATABASE_URL: postgres://postgres:password@localhost:5432/test
           RAILS_ENV: test
         run: |
-          bundle exec appraisal rake
+          bundle exec rake create_test_app
+          bundle exec rake

data/.github/workflows/standard-ci.yml

@@ -0,0 +1,27 @@
+---
+name: Standard Rb
+
+on:
+  pull_request:
+    branches:
+      - '*'
+  push:
+    branches:
+      - master
+jobs:
+  # STANDARD RB
+  standard:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: ['3.0']
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - name: Run Standard Rb
+        run: bundle exec standardrb --format progress

data/.gitignore

@@ -4,6 +4,8 @@
 .bundle
 .ruby-version
 spec/internal/config/database.yml
+dummy
+spec/dummy
 tmp*.sw?
 *.sw?
 tmp
@@ -11,3 +13,5 @@ tmp
 *.lock
 *.iml
 /.idea
+spec/dummy/db/schema.rb
+spec/dummy/db/migrate/[!0]*

data/Appraisals

@@ -6,6 +6,10 @@ appraise "rails-6" do
   gem "rails", "~> 6.0.0"
 end
 
+appraise "rails-6-1" do
+  gem "rails", "~> 6.1.0"
+end
+
 appraise "rails-master" do
   gem "rails", github: "rails/rails"
 end

data/CONTRIBUTING.md

@@ -1,21 +1,8 @@
-<!-- START doctoc generated TOC please keep comment here to allow auto update -->
-<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
-**Table of Contents**  *generated with [DocToc](https://github.com/thlorenz/doctoc)*
-
-- [How to contribute:](#how-to-contribute)
-  - [Bug reports / Issues](#bug-reports--issues)
-  - [Code](#code)
-    - [Commit Messages](#commit-messages)
-    - [About Pull Requests (PR's)](#about-pull-requests-prs)
-  - [Documentation](#documentation)
-
-<!-- END doctoc generated TOC please keep comment here to allow auto update -->
-
 # How to contribute:
 
 ## Bug reports / Issues
 
-  * Is something broken or not working as expected? Check for an existing issue or [create a new one](https://github.com/mbleigh/acts-as-taggable-on/issues/new)
+  * Is something broken or not working as expected? Check for an existing issue or [create a new one](https://github.com/MatthewKennedy/make_taggable/issues/new)
   * IMPORTANT: Include the version of the gem, if you've install from git, what Ruby and Rails you are running, etc.
 
 ## Code
@@ -23,15 +10,14 @@
 1. [Fork and clone the repo](https://help.github.com/articles/fork-a-repo)
 2. Install the gem dependencies: `bundle install`
 3. Make the changes you want and back them up with tests.
-  * [Run the tests](https://github.com/mbleigh/acts-as-taggable-on#testing) (`bundle exec rake spec`)
-4. Update the CHANGELOG.md file with your changes and give yourself credit
-5. Commit and create a pull request with details as to what has been changed and why
+4. Run the tests](https://github.com/MatthewKennedy/make_taggable#testing)
+5. Update the CHANGELOG.md file with your changes and give yourself credit
+6. Commit and create a pull request with details as to what has been changed and why
   * Use well-described, small (atomic) commits.
   * Include links to any relevant github issues.
   * *Don't* change the VERSION file.
-6. Extra Credit: [Confirm it runs and tests pass on the rubies specified in the travis config](.travis.yml). I will otherwise confirm it runs on these.
 
-How I handle pull requests:
+## How I handle pull requests:
 
 * If the tests pass and the pull request looks good, I will merge it.
 * If the pull request needs to be changed,
@@ -40,18 +26,6 @@ How I handle pull requests:
     * by force pushing to it
   * I can make any changes myself and manually merge the code in.
 
-### Commit Messages
-
-* [A Note About Git Commit Messages](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
-* [http://stopwritingramblingcommitmessages.com/](http://stopwritingramblingcommitmessages.com/)
-* [ThoughtBot style guide](https://github.com/thoughtbot/guides/tree/master/style#git)
-
-### About Pull Requests (PR's)
-
-* [All Your Open Source Code Are Belong To Us](http://www.benjaminfleischer.com/2013/07/30/all-your-open-source-code-are-belong-to-us/)
-* [Using Pull Requests](https://help.github.com/articles/using-pull-requests)
-* [Github pull requests made easy](http://www.element84.com/github-pull-requests-made-easy.html)
-
 ## Documentation
 
 * Update the wiki

data/README.md

@@ -1,13 +1,9 @@
 # MakeTaggable
 [![Gem Version](https://badge.fury.io/rb/make_taggable.svg)](https://badge.fury.io/rb/make_taggable)
-[![Build Status](https://travis-ci.com/MatthewKennedy/make_taggable.svg?branch=master)](https://travis-ci.com/MatthewKennedy/make_taggable)
-[![Ruby Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://github.com/testdouble/standard)
+![CI](https://github.com/MatthewKennedy/make_taggable/workflows/CI/badge.svg)
+[![Standard Rb](https://github.com/MatthewKennedy/make_taggable/actions/workflows/standard-ci.yml/badge.svg)](https://github.com/MatthewKennedy/make_taggable/actions/workflows/standard-ci.yml)
 
-MakeTaggable is a fork of acts-as-taggable-on v6.5 with code updates and a new set of migrations. All credit goes to those who contributed before acts-as-taggable-on became MakeTaggable: Michael Bleigh & Joost Baaij.
-
-Why fork acts-as-taggable-on? Act As Taggable On appears stuck with a set of legacy migrations from rails pre [4.2] that added and removed indexes so much that the migrations do not run on a fresh install using MySQL.
-
-For the PostgreSQL users, this is not an issue, but if you have an app or gem that used acts-as-taggable-on, you can no longer test against MySQL, so it seems a fresh start would be useful to clear out any legacy issues and move forward.
+MakeTaggable is a tagging gem for Rails applications that allows custom tagging along dynamic contexts.
 
 ## Installation
 
@@ -22,23 +18,22 @@ bundle add make_taggable
 Install migrations
 
 ```shell
-# For the latest versions :
 rails make_taggable_engine:install:migrations
 ```
 
-Review the generated migrations then migrate :
+Review the generated migrations then migrate:
 ```shell
 rails db:migrate
 ```
 
 #### For MySql users
-You can circumvent at any time the problem of special characters [issue 623](https://github.com/mbleigh/acts-as-taggable-on/issues/623) by setting in an initializer file:
+To make MySQL play nice with spÉcial characters you can setting the following line in an initializer file:
 
 ```ruby
 MakeTaggable.force_binary_collation = true
 ```
 
-Or by running this rake task:
+Or by run this rake task:
 
 ```shell
 rails make_taggable_engine:tag_names:collate_bin
@@ -46,6 +41,7 @@ rails make_taggable_engine:tag_names:collate_bin
 
 See the Configuration section for more details.
 
+
 ## Usage
 
 Setup
@@ -176,7 +172,7 @@ MakeTaggable::Tag.least_used(10)
 
 ### Finding Tagged Objects
 
-Make Taggable uses scopes to create an association for tags.
+MakeTaggable uses scopes to create an association for tags.
 This way you can mix and match to filter down your results.
 
 ```ruby
@@ -405,6 +401,7 @@ CSS:
 .css4 { font-size: 1.6em; }
 ```
 
+
 ## Configuration
 
 If you would like to remove unused tag objects after removing taggings, add:
@@ -453,35 +450,69 @@ MakeTaggable.delimiter = ','
 *NOTE 1: SQLite by default can't upcase or downcase multibyte characters, resulting in unwanted behavior. Load the SQLite ICU extension for proper handle of such characters. [See docs](http://www.sqlite.org/src/artifact?ci=trunk&filename=ext/icu/README.txt)*
 
 
-#### Upgrading
-
-see [UPGRADING](UPGRADING.md)
+## Upgrading
 
-## Contributors
+Install new migrations by running:
 
-We have a long list of valued contributors. [Check them all](https://github.com/mbleigh/acts-as-taggable-on/contributors)
+```shell
+rails make_taggable_engine:install:migrations
+```
 
 ## Compatibility
 
-Versions 0.6.x is compatible with Ruby 2.5 + and Rails 6.
-
+Version 0.7.x is compatible with Ruby 2.5 > and Rails 5.2 >
 
-## TODO
-- Review migrations indexes they seem excessive looking at the schema.
-- See if the newer version of ActiveRecord or arel can be used instead of the MySQL workarounds.
 
 ## Testing
 
-Make Taggable uses RSpec for its test coverage. Inside the gem
-directory, you can run the specs with:
+MakeTaggable uses RSpec for its test coverage. Inside the gem directory, you can run the specs by following the steps below:
+
+Install the rquired gems:
+
+```shell
+bundle install
+```
+
+Setup the dummy test app:
+
+```shell
+bundle exec rake test_app
+```
+
+Run the spec tests against SQLite use the followiong command.
+
+```shell
+bundle exec rake
+```
+
+You can also run all the tests across all the Rails versions by running:
+
+```shell
+bundle exec appraisal install
+
+bundle exec appraisal rake
+```
+
+## Contributing
+
+Please use the following Standard Rb commands to format your code before creating a pull request:
+
+Check for code errors:
+
+```shell
+bundle exec standardrb
+```
+
+Fix code errors:
 
 ```shell
-bundle
-rake spec
+bundle exec standardrb --fix
 ```
+For more information please review the [Contributing](https://github.com/MatthewKennedy/make_taggable/blob/master/CONTRIBUTING.md) section.
 
-You can run all the tests across all the Rails versions by running `rake appraise`.  If you'd also like to [run the tests across all rubies and databases as configured for Travis CI, install and run `wwtd`](https://github.com/grosser/wwtd).
+#### Contributors
+List of valued contributors From Acts-As-Taggable-On: [Check them all](https://github.com/mbleigh/acts-as-taggable-on/contributors)
 
 
 ## License
-MIT
+This gem is available as open source under the terms of the [MIT License](https://github.com/MatthewKennedy/make_taggable/blob/master/LICENSE.md).