make_it_so 0.4.2 → 0.6.0

data/spec/features/rails/user_generates_rails_with_karma_spec.rb

@@ -0,0 +1,68 @@
+require 'spec_helper'
+
+feature "user generates rails app with karma/jasmine" do
+  def app_name
+    'dummy_rails'
+  end
+
+  def app_path
+    join_paths(tmp_path, app_name)
+  end
+
+  before(:all) do
+    make_it_so!("rails #{app_name} --js-test-lib karma")
+  end
+
+  let(:package_json_path) { File.join(app_path, 'package.json') }
+
+  it 'creates a karma.config' do
+    karma_config = File.join(app_path, 'karma.conf.js')
+    expect(FileTest.exists?(karma_config)).to eq(true)
+  end
+
+  it 'creates a testHelper.js' do
+    test_helper = File.join(app_path, 'spec/javascript/testHelper.js')
+    expect(FileTest.exists?(test_helper)).to eq(true)
+  end
+
+  it 'includes karma in package.json' do
+    in_package_json?(File.join(app_path, 'package.json')) do |json|
+      expect(json["devDependencies"]["karma"]).to_not be_nil
+    end
+  end
+
+  it 'includes jasmine in package.json' do
+    in_package_json?(File.join(app_path, 'package.json')) do |json|
+      expect(json["devDependencies"]["jasmine-core"]).to_not be_nil
+    end
+  end
+
+  it 'adds coverage/* to gitignore' do
+    expect(read_file('.gitignore')).to include("coverage/*\n")
+  end
+
+  it 'does not configure enzyme adapter in testHelper' do
+    testHelper = read_file('spec/javascript/testHelper.js')
+    expect(testHelper).to_not include("Enzyme.configure({ adapter: new EnzymeAdapter() })")
+  end
+
+  it 'includes enzyme.js with correct Enzyme config' do
+    file_subpath = "spec/javascript/support/enzyme.js"
+    support_file = File.join(app_path, file_subpath)
+    expect(FileTest.exists?(support_file)).to eq(true)
+
+    enzyme = read_file(file_subpath)
+    expect(enzyme).to include("Enzyme.configure")
+    expect(enzyme).to include("enzyme-adapter-react-16")
+  end
+
+  it 'karma.conf.js does not use @babel/polyfill' do
+    expect(read_file('karma.conf.js')).to_not include("node_modules/@babel/polyfill/dist/polyfill.js")
+  end
+
+  it 'does not add jest as the test script in package.json' do
+    in_package_json?(package_json_path) do |json|
+      expect(json["scripts"]["test"]).to_not include("jest")
+    end
+  end
+end

data/spec/features/rails/user_generates_rails_without_js_test_lib_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+feature "user generates rails app without js test framework" do
+  def app_name
+    'dummy_rails'
+  end
+
+  def app_path
+    join_paths(tmp_path, app_name)
+  end
+
+  before(:all) do
+    make_it_so!("rails #{app_name} --js-test-lib false")
+  end
+
+  let(:package_json_path) { File.join(app_path, 'package.json') }
+
+  it 'does not create a karma.config' do
+    karma_config = File.join(app_path, 'karma.conf.js')
+    expect(FileTest.exists?(karma_config)).to eq(false)
+  end
+
+  it 'does not create a testHelper.js' do
+    test_helper = File.join(app_path, 'spec/javascript/testHelper.js')
+    expect(FileTest.exists?(test_helper)).to eq(false)
+  end
+
+  it 'does not create an enzyme config file' do
+    test_helper = File.join(app_path, 'spec/javascript/support/enzyme.js')
+    expect(FileTest.exists?(test_helper)).to eq(false)
+  end
+
+  it 'does not include karma or jest in package.json' do
+    in_package_json?(File.join(app_path, 'package.json')) do |json|
+      expect(json["devDependencies"]["karma"]).to be_nil
+      expect(json["devDependencies"]["jest"]).to be_nil
+    end
+  end
+
+  it 'does not include jasmine in package.json' do
+    in_package_json?(File.join(app_path, 'package.json')) do |json|
+      expect(json["devDependencies"]["jasmine-core"]).to be_nil
+    end
+  end
+
+  it 'does not add a test script in package.json' do
+    in_package_json?(package_json_path) do |json|
+      expect(json["scripts"]["test"]).to be_nil
+    end
+  end
+end

data/spec/support/make_it_so_spec_helpers.rb

@@ -50,6 +50,29 @@ module MakeItSoSpecHelpers
     json = JSON.parse(contents)
     yield(json)
   end
+
+  def read_file(file_path)
+    File.read(File.join(app_path, file_path))
+  end
+
+  def major_version(version_string)
+    version_array(version_string)[0]
+  end
+
+  def minor_version(version_string)
+    version_array(version_string)[1]
+  end
+
+  def patch_version(version_string)
+    version_array(version_string)[2]
+  end
+
+  def version_array(version_string)
+    version_string.delete!("^")
+    version_string.delete!("~")
+    version_array = version_string.split(".")
+    version_array.map{ |string| string.to_i }
+  end
 end
 
 RSpec.configure do |config|

data/templates/rails/app/assets/javascripts/application.foundation.js

@@ -0,0 +1,18 @@
+// This is a manifest file that'll be compiled into application.js, which will include all the files
+// listed below.
+//
+// Any JavaScript/Coffee file within this directory, lib/assets/javascripts, or any plugin's
+// vendor/assets/javascripts directory can be referenced here using a relative path.
+//
+// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
+// compiled file. JavaScript code in this file should be added after the last require_* statement.
+//
+// Read Sprockets README (https://github.com/rails/sprockets#sprockets-directives) for details
+// about supported directives.
+//
+//= require jquery
+//= require jquery_ujs
+//= require foundation
+//= require_tree .
+
+$(function(){ $(document).foundation(); });

data/templates/rails/app/assets/javascripts/application.js

@@ -0,0 +1,16 @@
+// This is a manifest file that'll be compiled into application.js, which will include all the files
+// listed below.
+//
+// Any JavaScript/Coffee file within this directory, lib/assets/javascripts, or any plugin's
+// vendor/assets/javascripts directory can be referenced here using a relative path.
+//
+// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
+// compiled file. JavaScript code in this file should be added after the last require_* statement.
+//
+// Read Sprockets README (https://github.com/rails/sprockets#sprockets-directives) for details
+// about supported directives.
+//
+//= require jquery
+//= require jquery_ujs
+//= require_tree .
+

data/templates/rails/app/javascript/packs/new_application.js

@@ -2,7 +2,7 @@
 import React from 'react'
 import { render } from 'react-dom'
 
-import App from '../react/components/app'
+import App from '../react/components/App'
 import RedBox from 'redbox-react'
 
 document.addEventListener('DOMContentLoaded', () => {

data/templates/rails/app/javascript/react/components/{app.js → App.js}

@@ -4,4 +4,4 @@ export const App = (props) => {
   return (<h1>Make It So React</h1>)
 }
 
-export default App
+export default App

data/templates/rails/app/javascript/react/components/example.test.js

@@ -0,0 +1,5 @@
+describe('example test', () => {
+  it('should pass', () => {
+    expect(true).toBe(true);
+  });
+});

data/templates/rails/app/views/layouts/application.html.erb.tt

@@ -4,20 +4,13 @@
   <title><%= camelized %></title>
   <meta name="viewport" content="width=device-width, initial-scale=1.0" />
   <%%= stylesheet_link_tag 'application', media: 'all' %>
-  <% if options.foundation? %>
-    <%%= javascript_include_tag "vendor/modernizr" %>
-  <% end %>
   <%%= csrf_meta_tags %>
 </head>
 <body>
   <%- if options.devise? -%>
   <% if options.foundation? %>
   <nav class="top-bar">
-    <ul class="title-area">
-      <li class="name">
-        <h1><a href="/"><%= camelized %></a></h1>
-      </li>
-    </ul>
+    <h1><a href="/"><%= camelized %></a></h1>
 
     <section class="top-bar-section">
       <ul class="right">

data/templates/rails/babel.config.js

@@ -0,0 +1,77 @@
+module.exports = function(api) {
+  var validEnv = ['development', 'test', 'production']
+  var currentEnv = api.env()
+  var isDevelopmentEnv = api.env('development')
+  var isProductionEnv = api.env('production')
+  var isTestEnv = api.env('test')
+
+  if (!validEnv.includes(currentEnv)) {
+    throw new Error(
+      'Please specify a valid `NODE_ENV` or ' +
+        '`BABEL_ENV` environment variables. Valid values are "development", ' +
+        '"test", and "production". Instead, received: ' +
+        JSON.stringify(currentEnv) +
+        '.'
+    )
+  }
+
+  return {
+    presets: [
+      isTestEnv && [
+        require('@babel/preset-env').default,
+        {
+          targets: {
+            node: 'current'
+          }
+        }
+      ],
+      (isProductionEnv || isDevelopmentEnv) && [
+        require('@babel/preset-env').default,
+        {
+          forceAllTransforms: true,
+          useBuiltIns: 'entry',
+          corejs: 3,
+          modules: false,
+          exclude: ['transform-typeof-symbol']
+        }
+      ],
+      [
+        require('@babel/preset-react').default,
+        {
+          development: isDevelopmentEnv || isTestEnv,
+          useBuiltIns: true
+        }
+      ]
+    ].filter(Boolean),
+    plugins: [
+      require('@babel/plugin-syntax-dynamic-import').default,
+      require('@babel/plugin-transform-destructuring').default,
+      [
+        require('@babel/plugin-proposal-class-properties').default,
+        {
+          loose: true
+        }
+      ],
+      [
+        require('@babel/plugin-proposal-object-rest-spread').default,
+        {
+          useBuiltIns: true
+        }
+      ],
+      [
+        require('@babel/plugin-transform-runtime').default,
+        {
+          helpers: false,
+          regenerator: true,
+          corejs: false
+        }
+      ],
+      [
+        require('@babel/plugin-transform-regenerator').default,
+        {
+          async: false
+        }
+      ]
+    ].filter(Boolean)
+  }
+}

data/templates/rails/karma.conf.js

@@ -3,16 +3,14 @@ var path = require('path');
 module.exports = function(config) {
   config.set({
     basePath: "",
-    // use the PhantomJS browser
-    browsers: ['PhantomJS'],
+    // use the Chrome Headless browser
+    browsers: ['ChromeHeadless'],
 
     // use the Jasmine testing framework
     frameworks: ['jasmine'],
 
     // files that Karma will server to the browser
     files: [
-      // use Babel polyfill to emulate a full ES6 environment in PhantomJS
-      'node_modules/babel-polyfill/dist/polyfill.js',
       // entry file for Webpack
       'spec/javascript/testHelper.js'
     ],
@@ -36,7 +34,6 @@ module.exports = function(config) {
           // use babel-loader to transpile the test and src folders
           {
             test: /\.jsx?$/,
-            exclude: /node_modules/,
             loader: 'babel-loader'
           },
           {

data/templates/rails/spec/javascript/example.test.js

@@ -0,0 +1,5 @@
+describe('example test', () => {
+  it('should pass', () => {
+    expect(true).toBe(true);
+  });
+});

data/templates/rails/spec/javascript/support/enzyme.js

@@ -1,6 +1,4 @@
 const Enzyme = require('enzyme');
-
-const EnzymeAdapter = require('enzyme-adapter-react-15.4');
+const EnzymeAdapter = require("ADAPTER NAME GOES HERE");
 
 Enzyme.configure({ adapter: new EnzymeAdapter() });
-

data/templates/rails/spec/javascript/testHelper.js

@@ -1,13 +1,18 @@
 import { shallow, mount } from 'enzyme';
 import jasmineEnzyme from 'jasmine-enzyme';
 import React from 'react';
-import 'jasmine-ajax';
+import fetchPonyfill from 'fetch-ponyfill';
+const {fetch, Request, Response, Headers} = fetchPonyfill({});
 
 Object.assign(global, {
   jasmineEnzyme,
   mount,
   React,
   shallow,
+  fetch,
+  Request,
+  Response,
+  Headers
 });
 
 beforeEach(() => {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: make_it_so
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.6.0
 platform: ruby
 authors:
 - Dan Pickett
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-08-01 00:00:00.000000000 Z
+date: 2021-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -72,42 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
-- !ruby/object:Gem::Dependency
-  name: appraisal
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '12.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -146,18 +118,12 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
-- Appraisals
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - bin/make_it_so
-- gemfiles/rails_4_0.gemfile
-- gemfiles/rails_4_0.gemfile.lock
-- gemfiles/rails_4_1.gemfile
-- gemfiles/rails_4_1.gemfile.lock
-- gemfiles/rails_4_2.gemfile
-- gemfiles/rails_4_2.gemfile.lock
 - lib/generators/gosu_app_generator.rb
 - lib/generators/rails_app_generator.rb
 - lib/generators/sinatra_app_generator.rb
@@ -165,15 +131,19 @@ files:
 - lib/make_it_so/command_line_interface.rb
 - lib/make_it_so/rails.rb
 - lib/make_it_so/rails/app_builder.rb
+- lib/make_it_so/rails/prerequisite_check.rb
 - lib/make_it_so/version.rb
 - make_it_so.gemspec
 - snippets/rails/application_generator.rb
+- snippets/rails/js_enzyme_testing_deps.json
 - snippets/rails/js_jest_testing_deps.json
-- snippets/rails/js_testing_deps.json
+- snippets/rails/js_karma_jasmine_testing_deps.json
 - snippets/rails/react_dependencies.json
 - snippets/rails/user_factory.rb
+- spec/features/rails/user_generates_rails_spec.rb
+- spec/features/rails/user_generates_rails_with_karma_spec.rb
+- spec/features/rails/user_generates_rails_without_js_test_lib_spec.rb
 - spec/features/user_generates_gosu_spec.rb
-- spec/features/user_generates_rails_spec.rb
 - spec/features/user_generates_sinatra_spec.rb
 - spec/spec_helper.rb
 - spec/support/make_it_so_spec_helpers.rb
@@ -188,17 +158,22 @@ files:
 - templates/rails/.env
 - templates/rails/.env.example
 - templates/rails/.gitkeep
+- templates/rails/app/assets/javascripts/application.foundation.js
+- templates/rails/app/assets/javascripts/application.js
 - templates/rails/app/controllers/application_controller.rb
 - templates/rails/app/controllers/homes_controller.rb
 - templates/rails/app/javascript/packs/new_application.js
-- templates/rails/app/javascript/react/components/app.js
+- templates/rails/app/javascript/react/components/App.js
+- templates/rails/app/javascript/react/components/example.test.js
 - templates/rails/app/models/application_record.rb
 - templates/rails/app/views/homes/index.html.erb
 - templates/rails/app/views/layouts/application.html.erb.tt
+- templates/rails/babel.config.js
 - templates/rails/karma.conf.js
 - templates/rails/spec/features/user_signs_in_spec.rb
 - templates/rails/spec/features/user_signs_out_spec.rb
 - templates/rails/spec/features/user_signs_up_spec.rb
+- templates/rails/spec/javascript/example.test.js
 - templates/rails/spec/javascript/exampleTest.js
 - templates/rails/spec/javascript/support/enzyme.js
 - templates/rails/spec/javascript/support/jest-fetch-mock.js
@@ -221,7 +196,7 @@ homepage: ''
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -236,14 +211,15 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: An application generator for all things ruby
 test_files:
+- spec/features/rails/user_generates_rails_spec.rb
+- spec/features/rails/user_generates_rails_with_karma_spec.rb
+- spec/features/rails/user_generates_rails_without_js_test_lib_spec.rb
 - spec/features/user_generates_gosu_spec.rb
-- spec/features/user_generates_rails_spec.rb
 - spec/features/user_generates_sinatra_spec.rb
 - spec/spec_helper.rb
 - spec/support/make_it_so_spec_helpers.rb