makandra-rubocop 6.0.0 → 6.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3eaef81475b2680b90574634f544234f515ce30d424ff9929e8fb9d9b0172084
-  data.tar.gz: 8d48cf9e5ff40dfdeb9781a50ded7d8fa8f7b2efe01c97463b9ead845426aaba
+  metadata.gz: d9c46fcf110ed3214a90eb45a9009eda5c3427e108b716bcc9d062782aa4d249
+  data.tar.gz: fe74453161e63ad6157b97c1f901cae6e0c57e05f3de8ee638141348f09dbcff
 SHA512:
-  metadata.gz: 1191158f7a02dcc9e5ca6112d039be59693aafdf1c5dfcf1c9e1e9063a2aac3af8bd72fa79b702518291f8f7c4dc82d6adf3ea1ff1fc0870026379c6b1ba4a86
-  data.tar.gz: 74064c3c5351f6a39f049e465d777b131e0dd67941611dc96fef444045de3122fa40525c96d6e0afed80e48245e700f090c6057d8a573946d89c89ec51733ec9
+  metadata.gz: 304928637b28a2a974abc6228fe1923d86027965f68d9441b5bc9b9ba2fc6fadaac5b7b0dfa76ddf937b7992bdf9865c255e0dc5a1b371d686a45dc5ba2bed7c
+  data.tar.gz: a5b4d6d1aaaf876eb3dc625a2bbac4fb56fdc872ca54bafb97a45408f5daa815c90ac78c4cfb2b7e7345fc5ea35a6a34cf30eb0af83f66bdc35a2a293b374d84

data/CHANGELOG.md

@@ -9,6 +9,13 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html
 ### Compatible changes
 
 
+## 6.1.0 - 2021-04-30
+
+### Compatible changes
+
+- Disable `Style/AccessorGrouping`
+
+
 ## 6.0.0 - 2021-02-25
 
 ### Breaking changes

data/README.md

@@ -3,6 +3,7 @@ It is currently very relaxed, and will evolve over time.
 
 Note that we lock each version on a specific Rubocop version, as Rubocop's syntax changes regularly.
 
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -23,6 +24,7 @@ Or install it yourself as:
 $ gem install makandra-rubocop
 ```
 
+
 ## Usage
 
 Add a `.rubocop.yml` to your project with the following contents:
@@ -78,14 +80,12 @@ inherit_mode:
 ```
 
 ### Executing Rubocop on demand
-
 Run Rubocop via `bundle exec rubocop` from your project directory.
 
 For an initial run it might also useful to use the auto-correct option (`bundle exec  rubocop --auto-correct`) and carefully check in all changes.
 You can follow [this guide](https://makandracards.com/makandra/400093-adding-makandra-rubocop-to-an-existing-code-base) for bigger projects.
 
 ### Integrating Rubocop into your test suite
-
 We recommend you add an RSpec test that runs rubocop automatically and confirms that there are no offenses.
 This gem provides one. Simply add `spec/rubocop_spec.rb` to your project with the following code.
 
@@ -94,7 +94,6 @@ require 'makandra_rubocop/support/rubocop_spec'
 ```
 
 ### Configuring exceptions
-
 Some of our defaults might not fit your project. You can disable specific cops or add exclusions to `.rubocop.yml` in such cases. You basically have two options:
 
 - Disable cops for specific lines using [Ruby comments in your code](https://github.com/rubocop-hq/rubocop/blob/master/manual/configuration.md#disabling-cops-within-source-code), like so:
@@ -116,14 +115,20 @@ See [Rubocop's configuration manual](https://github.com/rubocop-hq/rubocop/blob/
 Note that disabling cops should be an exception for extremely rare cases where your code can not be aligned with Rubocop's requirements.
 If our defaults don't match your opinion, you should discuss with the team.
 
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+To install this gem onto your local machine, run `bundle exec rake install`.
 
-### Upgrading Rubocop version being used
+When you're making changes, update the version number in `version.rb`:
+- Increase the major version when you're upgrading the Rubocop dependency
+- Increase the minor version e.g. when disabling a cop
+
+For release run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
+### Upgrading Rubocop version being used
 1. Change `rubocop` dependency in gemspec to the release you want to upgrade to.
 2. `bundle`
 3. `git add remote rubocop https://github.com/rubocop-hq/rubocop.git`
@@ -135,12 +140,14 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 This procedure is the same for `rubocop-rails`.
 
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/makandra/makandra-rubocop.
 
 If you make any changes to this gem's Ruby code, make sure to run `rubocop`.
 
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/config/default.yml

@@ -2658,7 +2658,7 @@ Style/AccessModifierDeclarations:
 
 Style/AccessorGrouping:
   Description: 'Checks for grouping of accessors in `class` and `module` bodies.'
-  Enabled: true
+  Enabled: false # Was voted against, see https://github.com/makandra/makandra-rubocop/issues/27
   VersionAdded: '0.87'
   EnforcedStyle: grouped
   SupportedStyles:

data/lib/makandra_rubocop/support/rubocop_spec.rb

@@ -1,7 +1,7 @@
 require 'open3'
 
 RSpec.describe 'rubocop' do
-  it 'has no offenses' do
+  it 'should not be offended' do
     command = self.class.description
     stdout, stderr, status = Open3.capture3('bundle', 'exec', command)
     output = (stderr.size > 0) ? stderr : stdout

data/lib/makandra_rubocop/version.rb

@@ -1,3 +1,3 @@
 module MakandraRubocop
-  VERSION = '6.0.0'.freeze
+  VERSION = '6.1.0'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: makandra-rubocop
 version: !ruby/object:Gem::Version
-  version: 6.0.0
+  version: 6.1.0
 platform: ruby
 authors:
 - Arne Hartherz
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-02-25 00:00:00.000000000 Z
+date: 2021-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -126,7 +126,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: makandra's default Rubocop configuration