makandra-rubocop 11.2.0 → 12.0.0

data/config/ext/rails.yml

@@ -7,14 +7,19 @@ inherit_mode:
 
 AllCops:
   Exclude:
-    - 'node_modules/**/*'
-    - 'vendor/**/*'
     - '.git/**/*'
-    - 'bin/**/*'
-    - 'tmp/**/*'
-    - 'public/system/**/*'
-    - 'db/*schema.rb'
-    - 'log/**/*'
+    - app/assets/**/*
+    - bin/**/*
+    - db/*schema.rb
+    - node_modules/**/*
+    - log/**/*
+    - public/**/*
+    - storage/**/*
+    - tmp/**/*
+    - vendor/**/*
+  # Enable checking Active Support extensions.
+  # See: https://docs.rubocop.org/rubocop/configuration.html#enable-checking-active-support-extensions
+  ActiveSupportExtensionsEnabled: true
   # What version of Rails is the inspected code using?  If a value is specified
   # for TargetRailsVersion then it is used.  Acceptable values are specified
   # as a float (i.e. 5.1); the patch version of Rails should not be included.
@@ -46,6 +51,31 @@ Lint/NumberConversion:
     - in_milliseconds
   AllowedPatterns: []
 
+Lint/RedundantSafeNavigation:
+  # Add `presence` and `present?` methods to the default of the RuboCop core.
+  # https://github.com/rubocop/rubocop/blob/v1.51.0/config/default.yml#L2148-L2159
+  AllowedMethods:
+    - instance_of?
+    - kind_of?
+    - is_a?
+    - eql?
+    - respond_to?
+    - equal?
+    - presence
+    - present?
+
+Lint/SafeNavigationChain:
+  # Add `presence_in` method to the default of the RuboCop core:
+  # https://github.com/rubocop/rubocop/blob/v1.56.0/config/default.yml#L2265-L2271
+  AllowedMethods:
+    - present?
+    - blank?
+    - presence
+    - presence_in
+    - try
+    - try!
+    - in?
+
 Rails:
   Enabled: true
   DocumentationBaseURL: https://docs.rubocop.org/rubocop-rails
@@ -68,8 +98,9 @@ Rails/ActionControllerTestCase:
 
 Rails/ActionFilter:
   Description: 'Enforces consistent use of action filter methods.'
-  Enabled: true
+  Enabled: false
   VersionAdded: '0.19'
+  VersionChanged: '2.22'
   EnforcedStyle: action
   SupportedStyles:
     - action
@@ -145,8 +176,9 @@ Rails/AddColumnIndex:
     index might be used.
   Enabled: true
   VersionAdded: '2.11'
+  VersionChanged: '2.20'
   Include:
-    - db/migrate/*.rb
+    - db/**/*.rb
 
 Rails/AfterCommitOverride:
   Description: >-
@@ -234,12 +266,13 @@ Rails/BulkChangeTable:
     - https://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/Table.html
   Enabled: false # We'll maybe enable this later.
   VersionAdded: '0.57'
+  VersionChanged: '2.20'
   Database: null
   SupportedDatabases:
     - mysql
     - postgresql
   Include:
-    - db/migrate/*.rb
+    - db/**/*.rb
 
 Rails/CompactBlank:
   Description: 'Checks if collection can be blank-compacted with `compact_blank`.'
@@ -269,18 +302,31 @@ Rails/CreateTableWithTimestamps:
     when creating a new table.
   Enabled: true
   VersionAdded: '0.52'
+  VersionChanged: '2.20'
   Include:
-    - db/migrate/*.rb
+    - db/**/*.rb
   Exclude:
     # Respect the `active_storage_variant_records` table of `*_create_active_storage_tables.active_storage.rb`
+    # and `*_create_active_storage_variant_records.active_storage.rb`
     # auto-generated by `bin/rails active_storage:install` even if `created_at` is not specified.
-    - db/migrate/*_create_active_storage_tables.active_storage.rb
+    - db/**/*_create_active_storage_tables.active_storage.rb
+    - db/**/*_create_active_storage_variant_records.active_storage.rb
+
+Rails/DangerousColumnNames:
+  Description: >-
+                  Avoid dangerous column names.
+  Enabled: pending
+  Severity: warning
+  VersionAdded: '2.21'
+  Include:
+    - 'db/**/*.rb'
 
 Rails/Date:
   Description: >-
-    Checks the correct usage of date aware methods,
-    such as Date.today, Date.current etc.
+                  Checks the correct usage of date aware methods,
+                  such as Date.today, Date.current etc.
   Enabled: false # It's not that simple. Really.
+  SafeAutoCorrect: false
   VersionAdded: '0.30'
   VersionChanged: '2.11'
   # The value `strict` disallows usage of `Date.today`, `Date.current`,
@@ -297,7 +343,6 @@ Rails/Date:
 
 Rails/DefaultScope:
   Description: 'Avoid use of `default_scope`.'
-  StyleGuide: 'https://rails.rubystyle.guide#avoid-default-scope'
   Enabled: false
   VersionAdded: '2.7'
 
@@ -388,6 +433,11 @@ Rails/EnumUniqueness:
   Include:
     - app/models/**/*.rb
 
+Rails/EnvLocal:
+  Description: 'Use `Rails.env.local?` instead of `Rails.env.development? || Rails.env.test?`.'
+  Enabled: pending
+  VersionAdded: '2.22'
+
 Rails/EnvironmentComparison:
   Description: "Favor `Rails.env.production?` over `Rails.env == 'production'`."
   Enabled: true
@@ -440,10 +490,8 @@ Rails/FindBy:
   StyleGuide: 'https://rails.rubystyle.guide#find_by'
   Enabled: false
   VersionAdded: '0.30'
-  VersionChanged: '2.11'
+  VersionChanged: '2.21'
   IgnoreWhereFirst: true
-  Include:
-    - app/models/**/*.rb
 
 Rails/FindById:
   Description: >-
@@ -459,9 +507,7 @@ Rails/FindEach:
   Enabled: true
   Safe: false
   VersionAdded: '0.30'
-  VersionChanged: '2.19'
-  Include:
-    - app/models/**/*.rb
+  VersionChanged: '2.21'
   AllowedMethods:
     # Methods that don't work well with `find_each`.
     - order
@@ -524,6 +570,10 @@ Rails/I18nLazyLookup:
   Reference: 'https://guides.rubyonrails.org/i18n.html#lazy-lookup'
   Enabled: true
   VersionAdded: '2.14'
+  EnforcedStyle: lazy
+  SupportedStyles:
+    - lazy
+    - explicit
   Include:
     - 'app/controllers/**/*.rb'
 
@@ -629,8 +679,9 @@ Rails/MigrationClassName:
   Description: 'The class name of the migration should match its file name.'
   Enabled: true
   VersionAdded: '2.14'
+  VersionChanged: '2.20'
   Include:
-    - db/migrate/*.rb
+    - db/**/*.rb
 
 Rails/NegateInclude:
   Description: 'Prefer `collection.exclude?(obj)` over `!collection.include?(obj)`.'
@@ -644,8 +695,12 @@ Rails/NotNullColumn:
   Description: 'Do not add a NOT NULL column without a default value.'
   Enabled: true
   VersionAdded: '0.43'
+  VersionChanged: '2.20'
+  Database: null
+  SupportedDatabases:
+    - mysql
   Include:
-    - db/migrate/*.rb
+    - db/**/*.rb
 
 Rails/OrderById:
   Description: >-
@@ -750,6 +805,16 @@ Rails/ReadWriteAttribute:
   Include:
     - app/models/**/*.rb
 
+Rails/RedundantActiveRecordAllMethod:
+  Description: Detect redundant `all` used as a receiver for Active Record query methods.
+  StyleGuide: 'https://rails.rubystyle.guide/#redundant-all'
+  Enabled: false # While we agree that User.all.find is redundant, it can be useful to make relation access more explicit for other query methods.
+  Safe: false
+  AllowedReceivers:
+    - ActionMailer::Preview
+    - ActiveSupport::TimeZone
+  VersionAdded: '2.21'
+
 Rails/RedundantAllowNil:
   Description: >-
     Finds redundant use of `allow_nil` when `allow_blank` is set to
@@ -838,7 +903,7 @@ Rails/RequireDependency:
   VersionAdded: '2.10'
 
 Rails/ResponseParsedBody:
-  Description: Prefer `response.parsed_body` to `JSON.parse(response.body)`.
+  Description: Prefer `response.parsed_body` to custom parsing logic for `response.body`.
   Enabled: true
   Safe: false
   VersionAdded: '2.18'
@@ -930,6 +995,12 @@ Rails/ScopeArgs:
   Include:
     - app/models/**/*.rb
 
+Rails/SelectMap:
+  Description: 'Checks for uses of `select(:column_name)` with `map(&:column_name)`.'
+  Enabled: pending
+  Safe: false
+  VersionAdded: '2.21'
+
 Rails/ShortI18n:
   Description: 'Use the short form of the I18n methods: `t` instead of `translate` and `l` instead of `localize`.'
   StyleGuide: 'https://rails.rubystyle.guide/#short-i18n'
@@ -1058,6 +1129,7 @@ Rails/TransactionExitStatement:
     - https://github.com/rails/rails/commit/15aa4200e083
   Enabled: true # Get a head start on deprecations: https://blog.saeloun.com/2020/04/06/rails-disallow-return-break-and-throw-to-exit-transaction.html
   VersionAdded: '2.14'
+  TransactionMethods: []
 
 Rails/UniqBeforePluck:
   Description: 'Prefer the use of uniq or distinct before pluck.'
@@ -1095,6 +1167,12 @@ Rails/UnusedIgnoredColumns:
   Include:
     - app/models/**/*.rb
 
+Rails/UnusedRenderContent:
+  Description: 'Do not specify body content for a response with a non-content status code.'
+  Enabled: pending
+  Severity: warning
+  VersionAdded: '2.21'
+
 Rails/Validation:
   Description: 'Use validates :attribute, hash of validations.'
   Enabled: true
@@ -1134,6 +1212,7 @@ Rails/WhereNot:
 
 Rails/WhereNotWithMultipleConditions:
   Description: 'Do not use `where.not(...)` with multiple conditions.'
+  StyleGuide: 'https://rails.rubystyle.guide/#where-not-with-multiple-attributes'
   Enabled: true
   Severity: warning
   VersionAdded: '2.17'
@@ -1147,6 +1226,14 @@ Style/FormatStringToken:
   AllowedMethods:
     - redirect
 
+Style/InvertibleUnlessCondition:
+  InverseMethods:
+    # Active Support defines some common inverse methods. They are listed below:
+    :present?: :blank?
+    :blank?: :present?
+    :include?: :exclude?
+    :exclude?: :include?
+
 Style/SymbolProc:
   AllowedMethods:
     - define_method

data/lib/makandra_rubocop/version.rb

@@ -1,3 +1,3 @@
 module MakandraRubocop
-  VERSION = '11.2.0'.freeze
+  VERSION = '12.0.0'.freeze
 end

data/makandra-rubocop.gemspec

@@ -5,7 +5,7 @@ require 'makandra_rubocop/version'
 Gem::Specification.new do |spec|
   spec.name = 'makandra-rubocop'
   spec.version = MakandraRubocop::VERSION
-  spec.required_ruby_version = '>= 2.6.0'
+  spec.required_ruby_version = '>= 2.7.0'
   spec.authors = ['Arne Hartherz', 'Emanuel Denzel']
   spec.email = ['arne.hartherz@makandra.de', 'emanuel.denzel@makandra.de']
 
@@ -24,8 +24,8 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r(^exe/)) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.36.0'
-  spec.add_dependency 'rubocop-rails', '~> 2.19.0'
+  spec.add_dependency 'rubocop', '~> 1.60.0'
+  spec.add_dependency 'rubocop-rails', '~> 2.23.1'
   spec.add_dependency 'rubocop-rspec', '~> 2.13.2'
 
   spec.add_development_dependency 'bundler', '~> 2.0'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: makandra-rubocop
 version: !ruby/object:Gem::Version
-  version: 11.2.0
+  version: 12.0.0
 platform: ruby
 authors:
 - Arne Hartherz
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-10-18 00:00:00.000000000 Z
+date: 2024-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,28 +17,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.36.0
+        version: 1.60.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.36.0
+        version: 1.60.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.19.0
+        version: 2.23.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.19.0
+        version: 2.23.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -120,14 +120,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: makandra's default Rubocop configuration