mais_orcid_client 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37780670257a67170aacd956c9b28d77462974a7068229a221985c55993435e0
-  data.tar.gz: bb7b89396a2ac1539d7b39dfe6732e5047312c14ae0a269e8a20b9780e434642
+  metadata.gz: 4fd365e002189b3f5865c0f890851f47bdb96252dfec8c76036db3debfb55773
+  data.tar.gz: 2c1da5d83bece19afa22b0030ffe846e09de4b2d7c26ee7b8f380474e7c64d04
 SHA512:
-  metadata.gz: f64d3d4daa1150758535609ee01669850b03fa581e0a6089dbb40702373ab41a2189e4ddc0cdc2783ef8f5894e3b59bb8718ab5c6b376fac59bc5089325b729a
-  data.tar.gz: 525a539b133093d30b7b3099bfadd7d149b7ee53c64b2cee364e4325e73eb7e82876c85d4d768f2b21ea88c94bec1bb2856e84da0d83ceaa3c563197c96f99af
+  metadata.gz: 92a637eaf9bf68af95c7bb7d8da4de0fc38efd95c5f96c84590b342ff0e68b36da8304e3a6378a740a73c2d4cc26184b96570db340db596aa3d90d45ee3edfc1
+  data.tar.gz: 2c0d11e4a6bde90e0464425a0d36562f0c57f02b84217aedb4266581206a71f4804e4c788a2eee585ad46d8920acaaabbea132ca6786e34c913bee98ace88f01

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mais_orcid_client (1.0.0)
+    mais_orcid_client (1.0.1)
       activesupport (>= 4.2)
       faraday
       faraday-retry
@@ -31,33 +31,33 @@ GEM
     base64 (0.2.0)
     benchmark (0.4.0)
     bigdecimal (3.1.9)
-    byebug (11.1.3)
+    byebug (12.0.0)
     concurrent-ruby (1.3.5)
-    connection_pool (2.5.0)
+    connection_pool (2.5.2)
     crack (1.0.0)
       bigdecimal
       rexml
-    diff-lcs (1.6.0)
+    diff-lcs (1.6.1)
     docile (1.4.1)
     drb (2.2.1)
-    faraday (2.12.2)
+    faraday (2.13.1)
       faraday-net_http (>= 2.0, < 3.5)
       json
       logger
     faraday-net_http (3.4.0)
       net-http (>= 0.5.0)
-    faraday-retry (2.2.1)
+    faraday-retry (2.3.1)
       faraday (~> 2.0)
     hashdiff (1.1.2)
     hashie (5.0.0)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.10.2)
+    json (2.11.3)
     jwt (2.10.1)
       base64
     language_server-protocol (3.17.0.4)
     lint_roller (1.1.0)
-    logger (1.6.6)
+    logger (1.7.0)
     minitest (5.25.5)
     multi_xml (0.7.1)
       bigdecimal (~> 3.1)
@@ -71,13 +71,14 @@ GEM
       snaky_hash (~> 2.0)
       version_gem (~> 1.1)
     ostruct (0.6.1)
-    parallel (1.26.3)
-    parser (3.3.7.2)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
+    prism (1.4.0)
     public_suffix (6.0.1)
     racc (1.8.1)
-    rack (3.1.12)
+    rack (3.1.13)
     rainbow (3.1.1)
     rake (13.2.1)
     regexp_parser (2.10.0)
@@ -95,7 +96,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.2)
-    rubocop (1.74.0)
+    rubocop (1.75.3)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -103,22 +104,23 @@ GEM
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.41.0)
+    rubocop-ast (1.44.1)
       parser (>= 3.3.7.2)
+      prism (~> 1.4)
     rubocop-capybara (2.22.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
     rubocop-factory_bot (2.27.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-performance (1.24.0)
+    rubocop-performance (1.25.0)
       lint_roller (~> 1.1)
-      rubocop (>= 1.72.1, < 2.0)
+      rubocop (>= 1.75.0, < 2.0)
       rubocop-ast (>= 1.38.0, < 2.0)
-    rubocop-rspec (3.5.0)
+    rubocop-rspec (3.6.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
     rubocop-rspec_rails (2.31.0)
@@ -144,7 +146,7 @@ GEM
     uri (1.0.3)
     vcr (6.3.1)
       base64
-    version_gem (1.1.6)
+    version_gem (1.1.7)
     webmock (3.25.1)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
@@ -175,4 +177,4 @@ DEPENDENCIES
   webmock
 
 BUNDLED WITH
-   2.6.6
+   2.6.8

data/README.md

@@ -78,7 +78,7 @@ To record new cassettes:
 2. Add your new spec with a new cassette name (or delete a previous cassette to re-create it).
 3. Run just that new spec (important: else previous specs may use cassettes that have redacted credentials, causing your new spec to fail).
 4. You should get a new cassette with the name you specified in the spec.
-5. The cassette should have access tokens and secrets sanitized by the config in `spec_helper.rb`, but you can double check.
+5. The cassette should have access tokens and secrets sanitized by the config in `spec_helper.rb`, but you can double check.  The one exception is the access_token for each ORCID user, these need to be set to "private_access_token" in the cassette manually, as VCR filter_sensitive_data can only replace the first instance.
 6. Set your configuration at the top of the spec back to the fake client_id and client_secret values.
 7. The spec that checks for a raised exception when fetching all users may need to be handcrafted in the cassette to look it raised a 500.  It's hard to get the actual URL to produce a 500 on this call.
 7. Re-run all the specs - they should pass now without making real calls.

data/lib/mais_orcid_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class MaisOrcidClient
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/lib/mais_orcid_client.rb

@@ -64,9 +64,8 @@ class MaisOrcidClient
                                      result[:last_updated])
         return orcid_users if limit && limit == orcid_users.size
       end
-      # Currently next is always present, even on last page. (This may be changed in future.)
       next_page = response.dig(:links, :next)
-      return orcid_users if last_page?(response[:links])
+      return orcid_users if next_page.nil? || next_page.empty?
     end
   end
   # rubocop:enable Metrics/MethodLength
@@ -114,10 +113,6 @@ class MaisOrcidClient
     path
   end
 
-  def last_page?(links)
-    links[:self] == links[:last]
-  end
-
   # rubocop:disable Metrics/MethodLength
   def get_response(path, allow404: false)
     TokenWrapper.refresh(config) do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mais_orcid_client
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Peter Mangiafico
 - Justin Littman
 bindir: exe
 cert_chain: []
-date: 2025-03-28 00:00:00.000000000 Z
+date: 2025-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport