mailgun-ruby 1.4.2 → 1.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 45aed85ba39b57f41a049e86f7e4aa86e04092c2fc04c86f4a948857cea182c1
-  data.tar.gz: 4588e70de8bf2836028858adc294e1c1f1b5a8d07de6623a14a1c9797049eecd
+  metadata.gz: e4ebcbb3e9a3ff18a06515ffca7027ffa893d0250ad4f6491cd896a78e035428
+  data.tar.gz: 27750827e497452d5ea7276601a01621164d9a4decfb3e6f43b1d32c51b7aa62
 SHA512:
-  metadata.gz: 346f281a71259601f0215f33a2e7e65d2c76f5f90601522ecf06ff5f9c8c25daff473b1d8a8fc6a71474fdf6ac37c8c89c815831c74b9d1e09238392be139db7
-  data.tar.gz: 3e00ab15f716a2381735b12a792c6ddc333d32f1574c3d7b50640e293ca4c1f5a60b796c241d3e7c1447cb7b455a162a179c4167d8020bec11f21b6fa03920f1
+  metadata.gz: 7432da86b0a9b20ddaea5e0cb049c0fac6b7f8e37cc907d79bbcd5aa642550a8c8067bdd40e3c87f49679306d662906ede13c9bdbb4fd70ea19498f4325c9d92
+  data.tar.gz: 8691eac12d6cd590d8735a60965376ee7f751fe700c6533dc61cab987917292ef21d03e22d0c35c2c58584288602396b5201b8d5b55bdf9834693819a10185cc

data/.github/workflows/ci.yml

@@ -11,17 +11,39 @@ permissions:
 
 jobs:
   test:
+    permissions: write-all
     runs-on: ubuntu-latest
     strategy:
       matrix:
         ruby-version: [ '3.0', '3.1', '3.2', '3.3', '3.4', '4.0' ]
 
     steps:
-    - uses: actions/checkout@v6
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: ${{ matrix.ruby-version }}
-        bundler-cache: true 
-    - name: Run tests
-      run: bundle exec rake spec:all
+      - uses: actions/checkout@v6
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+      - name: Run tests
+        run: bundle exec rake spec:all
+      - uses: joshmfrankel/simplecov-check-action@main
+        with:
+          minimum_suite_coverage: 95
+          minimum_file_coverage: 80
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+        if: matrix.ruby-version == '4.0'
+
+  rubocop:
+    permissions: write-all
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v6
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '4.0'
+          bundler-cache: true
+      - name: Run rubocop
+        run: |
+          bundle exec rubocop --format github

data/.rubocop.yml

@@ -0,0 +1,68 @@
+AllCops:
+  NewCops: disable
+  SuggestExtensions: false
+
+plugins:
+  - rubocop-rspec
+  - rubocop-rake
+
+# temporary disable main codebase errors
+Metrics/MethodLength:
+  Enabled: false
+Metrics/BlockLength:
+  Enabled: false
+Metrics/ClassLength:
+  Enabled: false
+Metrics/CyclomaticComplexity:
+  Enabled: false
+Metrics/PerceivedComplexity:
+  Enabled: false
+Metrics/AbcSize:
+  Enabled: false
+Metrics/ParameterLists:
+  Enabled: false
+Lint/MissingSuper:
+  Enabled: false
+Style/Documentation:
+  Enabled: false
+Style/OptionalBooleanParameter:
+  Enabled: false
+Naming/FileName:
+  Exclude:
+    - 'lib/mailgun-ruby.rb'
+
+# temporary disable rspec errors
+RSpec/MultipleExpectations:
+  Enabled: false
+RSpec/ExampleLength:
+  Enabled: false
+RSpec/InstanceVariable:
+  Enabled: false
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+RSpec/StubbedMock:
+  Enabled: false
+RSpec/AnyInstance:
+  Enabled: false
+RSpec/MessageSpies:
+  Enabled: false
+RSpec/DescribeClass:
+  Enabled: false
+RSpec/VerifiedDoubles:
+  Enabled: false
+RSpec/NoExpectationExample:
+  Enabled: false
+RSpec/RepeatedDescription:
+  Enabled: false
+RSpec/NestedGroups:
+  Enabled: false
+RSpec/MultipleDescribes:
+  Enabled: false
+RSpec/BeforeAfterAll:
+  Enabled: false
+RSpec/SpecFilePathFormat:
+  Enabled: false
+RSpec/ContextWording:
+  Enabled: false
+RSpec/OverwritingSetup:
+  Enabled: false

data/Gemfile

@@ -5,5 +5,5 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in mailgun.gemspec
 gemspec
 
-gem 'json', '~> 2.1', platform: :mri_19
+gem 'json', '~> 2.1'
 gem 'mini_mime'

data/README.md

@@ -19,7 +19,7 @@ gem install mailgun-ruby
 Gemfile:
 
 ```ruby
-gem 'mailgun-ruby', '~>1.4.2'
+gem 'mailgun-ruby', '~>1.4.3'
 ```
 
 Usage

data/Rakefile

@@ -30,8 +30,3 @@ RSpec::Core::RakeTask.new('spec:all') do |t|
 end
 
 task default: 'spec:unit'
-task spec: 'spec:unit'
-
-task :console do
-  sh 'pry --gem'
-end

data/lib/mailgun/client.rb

@@ -50,14 +50,18 @@ module Mailgun
     end
 
     # Change API key
+    # rubocop:disable Naming/AccessorMethodName
     def set_api_key(api_key)
       @http_client.set_basic_auth('api', api_key)
     end
+    # rubocop:enable Naming/AccessorMethodName
 
     # Add subaccount id to headers
+    # rubocop:disable Naming/AccessorMethodName
     def set_subaccount(subaccount_id)
       @http_client.headers.merge!({ SUBACCOUNT_HEADER => subaccount_id })
     end
+    # rubocop:enable Naming/AccessorMethodName
 
     # Reset subaccount for primary usage
     def reset_subaccount
@@ -78,7 +82,7 @@ module Mailgun
     #
     # @return [Hash]
     def self.deliveries
-      @@deliveries ||= []
+      @deliveries ||= []
     end
 
     # Simple Message Sending
@@ -231,18 +235,18 @@ module Mailgun
     # Raises CommunicationError and stores response in it if present
     #
     # @param [StandardException] e upstream exception object
-    def communication_error(e)
-      if e.respond_to?(:response) && e.response
-        return case e.response_status
+    def communication_error(error)
+      if error.respond_to?(:response) && error.response
+        return case error.response_status
                when Unauthorized::CODE
-                 Unauthorized.new(e.message, e.response)
+                 Unauthorized.new(error.message, error.response)
                when BadRequest::CODE
-                 BadRequest.new(e.message, e.response)
+                 BadRequest.new(error.message, error.response)
                else
-                 CommunicationError.new(e.message, e.response)
+                 CommunicationError.new(error.message, error.response)
                end
       end
-      CommunicationError.new(e.message)
+      CommunicationError.new(error.message)
     end
 
     def perform_data_validation(working_domain, data)

data/lib/mailgun/domains/domains.rb

@@ -197,7 +197,8 @@ module Mailgun
     #
     # domain  - [String] Name of the domain (ex. domain.com)
     # options - [Hash] of
-    #   active  - [Boolean] yes or no. If set to yes, links will be overwritten and pointed to our servers so we can track clicks.
+    #   active  - [Boolean] yes or no. If set to yes, links will be overwritten and pointed to our servers
+    #                       so we can track clicks.
     #
     # Returns [Hash] Information on the tracking click settings
     def update_domain_tracking_click_settings(domain, options = {})
@@ -209,7 +210,8 @@ module Mailgun
     # domain  - [String] Name of the domain (ex. domain.com)
     # options - [Hash] of
     #   active  - [Boolean] yes or no. If set to yes, a tracking pixel will be inserted below your HTML content.
-    #   place_at_the_top  - [Boolean] yes or no. If set to yes, tracking pixel will be moved to top of your HTML content.
+    #   place_at_the_top  - [Boolean] yes or no. If set to yes, tracking pixel will be moved
+    #                                 to top of your HTML content.
     #
     # Returns [Hash] Information on the tracking open settings
     def update_domain_tracking_open_settings(domain, options = {})

data/lib/mailgun/lists/opt_in_handler.rb

@@ -32,7 +32,8 @@ module Mailgun
     #
     # @param [String] secret_app_id A secret passphrase used as a constant for the hash.
     # @param [Hash] unique_hash The hash from the user. Likely via link click.
-    # @return [Hash or Boolean] A hash with 'recipient_address' and 'mailing_list', if validates. Otherwise, boolean false.
+    # @return [Hash or Boolean] A hash with 'recipient_address' and 'mailing_list', if validates.
+    #                           Otherwise, boolean false.
     def self.validate_hash(secret_app_id, unique_hash)
       outer_payload = JSON.parse(base64_decode(CGI.unescape(unique_hash)))
 
@@ -57,9 +58,6 @@ module Mailgun
 
     # Equivalent to Base64.decode64
     def self.base64_decode(input)
-      # TODO: Condition can be droped if Ruby >= 2.4.0
-      if input.respond_to?(:unpack1)
-      end
       input.unpack1('m')
     end
 

data/lib/mailgun/messages/batch_message.rb

@@ -39,7 +39,8 @@ module Mailgun
     #
     # @param [String] recipient_type The type of recipient. "to".
     # @param [String] address The email address of the recipient to add to the message object.
-    # @param [Hash] variables A hash of the variables associated with the recipient. We recommend "first" and "last" at a minimum!
+    # @param [Hash] variables A hash of the variables associated with the recipient.
+    #                         We recommend "first" and "last" at a minimum!
     # @return [void]
     def add_recipient(recipient_type, address, variables = nil)
       # send the message when we have 1000, not before

data/lib/mailgun/messages/message_builder.rb

@@ -25,7 +25,8 @@ module Mailgun
     #
     # @param [String] recipient_type The type of recipient. "to", "cc", "bcc" or "h:reply-to".
     # @param [String] address The email address of the recipient to add to the message object.
-    # @param [Hash] variables A hash of the variables associated with the recipient. We recommend "first" and "last" at a minimum!
+    # @param [Hash] variables A hash of the variables associated with the recipient.
+    #                         We recommend "first" and "last" at a minimum!
     # @return [void]
     def add_recipient(recipient_type, address, variables = nil)
       if recipient_type == 'h:reply-to'
@@ -46,7 +47,8 @@ module Mailgun
     # Sets the from address for the message
     #
     # @param [String] address The address of the sender.
-    # @param [Hash] variables A hash of the variables associated with the recipient. We recommend "first" and "last" at a minimum!
+    # @param [Hash] variables A hash of the variables associated with the recipient.
+    #                         We recommend "first" and "last" at a minimum!
     # @return [void]
     def from(address, vars = nil)
       add_recipient(:from, address, vars)
@@ -155,12 +157,6 @@ module Mailgun
       set_multi_simple('o:testmode', bool_lookup(mode))
     end
 
-    # Deprecated: 'set_test_mode' is depreciated. Please use 'test_mode' instead.
-    def set_test_mode(mode)
-      warn 'DEPRECATION: "set_test_mode" is deprecated. Please use "test_mode" instead.'
-      test_mode(mode)
-    end
-
     # Turn DKIM on or off per message
     #
     # @param [Boolean] mode The boolean or string value(will fix itself)
@@ -169,12 +165,6 @@ module Mailgun
       set_multi_simple('o:dkim', bool_lookup(mode))
     end
 
-    # Deprecated: 'set_dkim' is deprecated. Please use 'dkim' instead.
-    def set_dkim(mode)
-      warn 'DEPRECATION: "set_dkim" is deprecated. Please use "dkim" instead.'
-      dkim(mode)
-    end
-
     # Add campaign IDs to message. Limit of 3 per message.
     #
     # @param [String] campaign_id A defined campaign ID to add to the message.
@@ -212,12 +202,6 @@ module Mailgun
       set_multi_simple('o:tracking', value)
     end
 
-    # Deprecated: 'set_open_tracking' is deprecated. Please use 'track_opens' instead.
-    def set_open_tracking(tracking)
-      warn 'DEPRECATION: "set_open_tracking" is deprecated. Please use "track_opens" instead.'
-      track_opens(tracking)
-    end
-
     # Turn Click Tracking on and off, on a per message basis.
     #
     # @param [String] mode True, False, or HTML (for HTML only tracking)
@@ -228,12 +212,6 @@ module Mailgun
       set_multi_simple('o:tracking', value)
     end
 
-    # Depreciated: 'set_click_tracking. is deprecated. Please use 'track_clicks' instead.
-    def set_click_tracking(tracking)
-      warn 'DEPRECATION: "set_click_tracking" is deprecated. Please use "track_clicks" instead.'
-      track_clicks(tracking)
-    end
-
     # Enable Delivery delay on message. Specify an RFC2822 date, and Mailgun
     # will not deliver the message until that date/time. For conversion
     # options, see Ruby "Time". Example: "October 25, 2013 10:00PM CST" will
@@ -246,12 +224,6 @@ module Mailgun
       set_multi_simple('o:deliverytime', time_str.rfc2822)
     end
 
-    # Deprecated: 'set_delivery_time' is deprecated. Please use 'deliver_at' instead.
-    def set_delivery_time(timestamp)
-      warn 'DEPRECATION: "set_delivery_time" is deprecated. Please use "deliver_at" instead.'
-      deliver_at timestamp
-    end
-
     # Add custom data to the message. The data should be either a hash or JSON
     # encoded. The custom data will be added as a header to your message.
     #

data/lib/mailgun/metrics/metrics.rb

@@ -16,7 +16,9 @@ module Mailgun
     #     start - [String] A start date (default: 7 days before current time). Must be in RFC 2822 format.
     #     end - [String] An end date (default: current time). Must be in RFC 2822 format.
     #     resolution - [String] A resolution in the format of 'day' 'hour' 'month'. Default is day.
-    #     duration - [String] A duration in the format of '1d' '2h' '2m'. If duration is provided then it is calculated from the end date and overwrites the start date.
+    #     duration - [String] A duration in the format of '1d' '2h' '2m'.
+    #                         If duration is provided then it is calculated from the end date
+    #                         and overwrites the start date.
     #     dimensions - [Array] Attributes of the metric data such as 'subaccount'.
     #     metrics - [Array] Name of the metrics to receive the stats for such as 'processed_count'
     #     filter - [Object]
@@ -40,7 +42,9 @@ module Mailgun
     #     start - [String] A start date (default: 7 days before current time). Must be in RFC 2822 format.
     #     end - [String] An end date (default: current time). Must be in RFC 2822 format.
     #     resolution - [String] A resolution in the format of 'day' 'hour' 'month'. Default is day.
-    #     duration - [String] A duration in the format of '1d' '2h' '2m'. If duration is provided then it is calculated from the end date and overwrites the start date.
+    #     duration - [String] A duration in the format of '1d' '2h' '2m'.
+    #                         If duration is provided then it is calculated from the end date and
+    #                         overwrites the start date.
     #     dimensions - [Array] Attributes of the metric data such as 'subaccount'.
     #     metrics - [Array] Name of the metrics to receive the stats for such as 'processed_count'
     #     filter - [Object]

data/lib/mailgun/response.rb

@@ -13,9 +13,9 @@ module Mailgun
     attr_accessor :body, :status, :code
 
     ResponseHash = Struct.new(:body, :status)
-    def self.from_hash(h)
+    def self.from_hash(hash)
       # Create a "fake" response object with the data passed from h
-      new ResponseHash.new(h[:body], h[:status])
+      new ResponseHash.new(hash[:body], hash[:status])
     end
 
     def initialize(response)

data/lib/mailgun/tags/analytics_tags.rb

@@ -26,15 +26,19 @@ module Mailgun
     # Public: Post query to list account tags or search for single tag
     #
     # options - [Hash] of
-    #     include_subaccounts  - [Boolean] Boolean indicating whether or not to include data from all subaccounts. Default false.
-    #     include_metrics      - [Boolean] Boolean indicating whether or not to include metrics for tags. Default false. When true max limit is 20.
-    #     tag                  - [string] The tag or tag prefix.
+    #     include_subaccounts  - [Boolean] Boolean indicating whether or not to include data from all subaccounts.
+    #                                      Default false.
+    #     include_metrics      - [Boolean] Boolean indicating whether or not to include metrics for tags.
+    #                                      Default false. When true max limit is 20.
+    #     tag                  - [String]  The tag or tag prefix.
     #     pagination           - [Object]
-    #         sort          - [String] Colon-separated value indicating column name and sort direction e.g. 'timestamp:desc'.
+    #         sort          - [String]  Colon-separated value indicating column name and sort direction
+    #                                   e.g. 'timestamp:desc'.
     #         skip          - [Integer] The number of items to skip over when satisfying the request.
     #         limit         - [Integer] The maximum number of items returned (100 max).
     #         total         - [Integer] The total number of tags matching the search criteria.
-    #         include_total - [Boolean] Boolean indicating whether or not to include total number of items. Default false.
+    #         include_total - [Boolean] Boolean indicating whether or not to include total number of items.
+    #                                   Default false.
 
     #
     # Returns [Hash] Information on the requested tags.

data/lib/mailgun/tags/tags.rb

@@ -63,10 +63,12 @@ module Mailgun
     # tag    - [String] Tag name to lookup for
     # options - [Hash] of
     #     event - [String] The type of the event. Required. (ex. accepted, delivered, failed, opened)
-    #     start - [String] The starting time. Should be in RFC 282 or unix epoch format. Default: 7 days from the current time.
+    #     start - [String] The starting time. Should be in RFC 282 or unix epoch format.
+    #                      Default: 7 days from the current time.
     #     end   - [String] The ending date. Should be in RFC 2822 or unix epoch time in seconds. Default: current time.
     #     resolution   - [String] Can be either hour, day or month. Default: day
-    #     duration   - [String] Period of time with resolution encoded. If provided, overwrites the start date and resolution.
+    #     duration   - [String] Period of time with resolution encoded.
+    #                           If provided, overwrites the start date and resolution.
     #
     # Returns [Hash] of tag stats info
     def get_tag_stats(domain, tag, options = {})

data/lib/mailgun/version.rb

@@ -2,5 +2,5 @@
 
 # It's the version. Yeay!
 module Mailgun
-  VERSION = '1.4.2'
+  VERSION = '1.4.3'
 end

data/lib/railgun/attachment.rb

@@ -30,7 +30,7 @@ module Railgun
       @inline
     end
 
-    def is_original_filename
+    def original_filename?
       @original_filename == @overwritten_filename
     end
 
@@ -38,13 +38,11 @@ module Railgun
       @filename
     end
 
-    def attach_to_message!(mb)
-      nil if mb.nil?
-
+    def attach_to_message!(m_body)
       if inline?
-        mb.add_inline_image self, @filename
+        m_body.add_inline_image self, @filename
       else
-        mb.add_attachment self, @filename
+        m_body.add_attachment self, @filename
       end
     end
   end

data/lib/railgun/mailer.rb

@@ -41,7 +41,7 @@ module Railgun
     end
 
     def deliver!(mail)
-      @mg_domain = set_mg_domain(mail)
+      @mg_domain = mg_domain(mail)
       @mg_client.set_api_key(mail[:api_key].value) if mail[:api_key].present?
       @mg_client.set_subaccount(mail[:subaccount_id].value) if mail[:subaccount_id].present?
 
@@ -66,7 +66,7 @@ module Railgun
     private
 
     # Set @mg_domain from mail[:domain] header if present, then remove it to prevent being sent.
-    def set_mg_domain(mail)
+    def mg_domain(mail)
       return mail[:domain].value if mail[:domain]
 
       domain

data/mailgun.gemspec

@@ -34,7 +34,10 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.13.0'
   spec.add_development_dependency 'rspec-its', '~> 2.0.0'
   spec.add_development_dependency 'rubocop'
-  spec.add_development_dependency 'simplecov', '~> 0.16.1'
+  spec.add_development_dependency 'rubocop-rake'
+  spec.add_development_dependency 'rubocop-rspec'
+  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'simplecov-json'
   spec.add_development_dependency 'vcr', '~> 6.4.0'
   spec.add_development_dependency 'webmock', '~> 3.7'
   spec.add_dependency 'faraday', '~> 2.1'

data/spec/integration/analytics_tags_spec.rb

@@ -44,7 +44,7 @@ describe 'AnalyticsTags', vcr: vcr_opts do
     end
   end
 
-  context '#limits' do
+  describe '#limits' do
     it 'returns limits' do
       response = mg_obj.limits
 

data/spec/integration/domains_spec.rb

@@ -44,7 +44,7 @@ describe 'For the domains endpoint', vcr: vcr_opts do
       end
     end
 
-    context '#update' do
+    describe '#update' do
       let(:api_version) { 'v4' }
 
       it 'updates the domain' do
@@ -52,11 +52,11 @@ describe 'For the domains endpoint', vcr: vcr_opts do
 
         expect(response['domain']['spam_action']).to eq('block')
         expect(response['domain']['web_scheme']).to eq('https')
-        expect(response['domain']['wildcard']).to eq(true)
+        expect(response['domain']['wildcard']).to be(true)
       end
     end
 
-    context '#verify' do
+    describe '#verify' do
       let(:api_version) { 'v4' }
 
       it 'verifies the domain' do
@@ -199,7 +199,7 @@ describe 'For the domains endpoint', vcr: vcr_opts do
         )
 
         expect(result).to include('tracking')
-        expect(result['tracking']['click']['active']).to eq(false)
+        expect(result['tracking']['click']['active']).to be(false)
       end
     end
 
@@ -212,7 +212,7 @@ describe 'For the domains endpoint', vcr: vcr_opts do
           }
         )
 
-        expect(result['click']['active']).to eq(false)
+        expect(result['click']['active']).to be(false)
       end
     end
 
@@ -225,7 +225,7 @@ describe 'For the domains endpoint', vcr: vcr_opts do
           }
         )
 
-        expect(result['open']['active']).to eq(false)
+        expect(result['open']['active']).to be(false)
       end
     end
 
@@ -238,17 +238,11 @@ describe 'For the domains endpoint', vcr: vcr_opts do
           }
         )
 
-        expect(result['unsubscribe']['active']).to eq(false)
+        expect(result['unsubscribe']['active']).to be(false)
       end
     end
   end
 
-  context 'Domain::DKIM_Security methods' do
-    # TODO: add missing:
-    # dkim_rotation
-    # dkim_rotate
-  end
-
   context 'Credentials methods' do
     # TODO: to be moved to the dedicated module
 

data/spec/integration/events_spec.rb

@@ -23,8 +23,6 @@ describe 'For the Events endpoint', vcr: vcr_opts do
   end
 
   it 'can iterate over all events with `each`' do
-    @events.each do |e|
-      expect(e).to have_key('event')
-    end
+    expect(@events).to all(have_key('event'))
   end
 end

data/spec/integration/list_members_spec.rb

@@ -54,7 +54,7 @@ describe 'For the Mailing Lists Members endpoint', order: :defined, vcr: vcr_opt
     expect(result.body['message']).to eq('Mailing list member has been updated')
     expect(result.body['member']['address']).to eq(@ml_member)
     expect(result.body['member']['name']).to eq('Jane Doe Update')
-    expect(result.body['member']['subscribed']).to eq(false)
+    expect(result.body['member']['subscribed']).to be(false)
   end
 
   it 'removes a list member' do

data/spec/integration/logs_spec.rb

@@ -6,7 +6,7 @@ require 'mailgun'
 vcr_opts = { cassette_name: 'logs' }
 
 describe Mailgun::Logs, vcr: vcr_opts do
-  let(:logs) { Mailgun::Logs.new(Mailgun::Client.new(APIKEY, APIHOST, 'v1')) }
+  let(:logs) { described_class.new(Mailgun::Client.new(APIKEY, APIHOST, 'v1')) }
 
   describe '#account_logs' do
     let(:options) do

data/spec/integration/mailgun_spec.rb

@@ -109,12 +109,13 @@ describe 'The method send_message()', vcr: { cassette_name: 'send_message' } do
     result.to_h!
     expect(result.body).to include('message')
     expect(result.body).to include('id')
+    expect(Mailgun::Client.deliveries.size).to eq(1)
   end
 
   it 'fakes message send while in *client* test mode' do
     @mg_obj.enable_test_mode!
 
-    expect(@mg_obj.test_mode?).to eq(true)
+    expect(@mg_obj.test_mode?).to be(true)
 
     data = { from: "joe@#{@domain}",
              to: "bob@#{@domain}",
@@ -182,7 +183,7 @@ Testing some Mailgun awesomness!'
   it 'receives success response code' do
     @mg_obj.enable_test_mode!
 
-    expect(@mg_obj.test_mode?).to eq(true)
+    expect(@mg_obj.test_mode?).to be(true)
 
     data = { from: "joe@#{@domain}",
              to: "bob@#{@domain}",

data/spec/integration/metrics_spec.rb

@@ -6,7 +6,7 @@ require 'mailgun'
 vcr_opts = { cassette_name: 'metrics' }
 
 describe Mailgun::Metrics, vcr: vcr_opts do
-  let(:metrics) { Mailgun::Metrics.new(Mailgun::Client.new(APIKEY, APIHOST, 'v1')) }
+  let(:metrics) { described_class.new(Mailgun::Client.new(APIKEY, APIHOST, 'v1')) }
 
   describe '#account_metrics' do
     let(:options) do
@@ -69,7 +69,10 @@ describe Mailgun::Metrics, vcr: vcr_opts do
                           'display_value' => 'Wed, 27 Nov 2024 13:00:00 +0000'
                         }],
                         'metrics' => {
-                          'accepted_count' => 1, 'delivered_count' => 1, 'opened_rate' => '0.0000', 'clicked_rate' => '0.0000'
+                          'accepted_count' => 1,
+                          'delivered_count' => 1,
+                          'opened_rate' => '0.0000',
+                          'clicked_rate' => '0.0000'
                         }
                       },
                       {
@@ -79,7 +82,10 @@ describe Mailgun::Metrics, vcr: vcr_opts do
                           'display_value' => 'Thu, 28 Nov 2024 15:00:00 +0000'
                         }],
                         'metrics' => {
-                          'accepted_count' => 1, 'delivered_count' => 1, 'opened_rate' => '0.0000', 'clicked_rate' => '0.0000'
+                          'accepted_count' => 1,
+                          'delivered_count' => 1,
+                          'opened_rate' => '0.0000',
+                          'clicked_rate' => '0.0000'
                         }
                       }],
           'aggregates' => {