mailgun-ruby 1.4.1 → 1.4.3

data/spec/integration/domains_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'mailgun'
 
-vcr_opts = { :cassette_name => "domains" }
+vcr_opts = { cassette_name: 'domains' }
 
 describe 'For the domains endpoint', vcr: vcr_opts do
   let(:api_version) { APIVERSION }
@@ -42,7 +44,7 @@ describe 'For the domains endpoint', vcr: vcr_opts do
       end
     end
 
-    context '#update' do
+    describe '#update' do
       let(:api_version) { 'v4' }
 
       it 'updates the domain' do
@@ -50,11 +52,11 @@ describe 'For the domains endpoint', vcr: vcr_opts do
 
         expect(response['domain']['spam_action']).to eq('block')
         expect(response['domain']['web_scheme']).to eq('https')
-        expect(response['domain']['wildcard']).to eq(true)
+        expect(response['domain']['wildcard']).to be(true)
       end
     end
 
-    context '#verify' do
+    describe '#verify' do
       let(:api_version) { 'v4' }
 
       it 'verifies the domain' do
@@ -71,7 +73,6 @@ describe 'For the domains endpoint', vcr: vcr_opts do
     end
   end
 
-
   context 'Domain::Keys methods' do
     describe '#list_domain_keys' do
       let(:api_version) { 'v1' }
@@ -123,7 +124,6 @@ describe 'For the domains endpoint', vcr: vcr_opts do
       let(:api_version) { 'v4' }
 
       it 'activates a domain key' do
-
         result = mg_obj.activate_domain_key(
           domain,
           'mailo1'
@@ -187,7 +187,7 @@ describe 'For the domains endpoint', vcr: vcr_opts do
   end
 
   context 'Domain::Tracking methods' do
-    # TODO add missing:
+    # TODO: add missing:
     # get_domain_tracking_certificate
     # regenerate_domain_tracking_certificate
     # generate_domain_tracking_certificate
@@ -199,7 +199,7 @@ describe 'For the domains endpoint', vcr: vcr_opts do
         )
 
         expect(result).to include('tracking')
-        expect(result['tracking']['click']['active']).to eq(false)
+        expect(result['tracking']['click']['active']).to be(false)
       end
     end
 
@@ -212,7 +212,7 @@ describe 'For the domains endpoint', vcr: vcr_opts do
           }
         )
 
-        expect(result['click']['active']).to eq(false)
+        expect(result['click']['active']).to be(false)
       end
     end
 
@@ -225,7 +225,7 @@ describe 'For the domains endpoint', vcr: vcr_opts do
           }
         )
 
-        expect(result['open']['active']).to eq(false)
+        expect(result['open']['active']).to be(false)
       end
     end
 
@@ -238,17 +238,11 @@ describe 'For the domains endpoint', vcr: vcr_opts do
           }
         )
 
-        expect(result['unsubscribe']['active']).to eq(false)
+        expect(result['unsubscribe']['active']).to be(false)
       end
     end
   end
 
-  context 'Domain::DKIM_Security methods' do
-    # TODO add missing:
-    # dkim_rotation
-    # dkim_rotate
-  end
-
   context 'Credentials methods' do
     # TODO: to be moved to the dedicated module
 
@@ -261,7 +255,7 @@ describe 'For the domains endpoint', vcr: vcr_opts do
           }
         )
 
-        expect(result['message']).to eq("Created 1 credentials pair(s)")
+        expect(result['message']).to eq('Created 1 credentials pair(s)')
       end
     end
 

data/spec/integration/email_validation_spec.rb

@@ -1,16 +1,18 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'mailgun'
 require 'mailgun/address'
 
-vcr_opts = { :cassette_name => "email_validation" }
+vcr_opts = { cassette_name: 'email_validation' }
 
 describe 'For the email validation endpoint', order: :defined, vcr: vcr_opts do
   before(:all) do
     @mg_obj = Mailgun::Address.new
 
-    @valid = ["Alice <alice@example.com>", "bob@example.com"]
-    @invalid = ["example.org"]
+    @valid = ['Alice <alice@example.com>', 'bob@example.com']
+    @invalid = ['example.org']
 
     @all_addrs = @valid + @invalid
   end
@@ -19,54 +21,53 @@ describe 'For the email validation endpoint', order: :defined, vcr: vcr_opts do
     skip 'is parse method removed?'
     res = @mg_obj.parse(@all_addrs)
 
-    expect(res["parsed"]).to eq(@valid)
-    expect(res["unparsable"]).to eq(@invalid)
+    expect(res['parsed']).to eq(@valid)
+    expect(res['unparsable']).to eq(@invalid)
   end
 
   it 'validates alice@mailgun.net with info' do
-    res = @mg_obj.validate("alice@mailgun.net")
+    res = @mg_obj.validate('alice@mailgun.net')
 
     expected = {
-        "address" => "alice@mailgun.net",
-        "did_you_mean" => nil,
-        "is_disposable_address" => false,
-        "is_role_address" => false,
-        "is_valid" => true,
-        "mailbox_verification" => "true",
-        "reason" => nil,
-        "parts" => {
-            "display_name" => nil,
-            "domain" => "mailgun.net",
-            "local_part" => "alice",
-        },
+      'address' => 'alice@mailgun.net',
+      'did_you_mean' => nil,
+      'is_disposable_address' => false,
+      'is_role_address' => false,
+      'is_valid' => true,
+      'mailbox_verification' => 'true',
+      'reason' => nil,
+      'parts' => {
+        'display_name' => nil,
+        'domain' => 'mailgun.net',
+        'local_part' => 'alice'
+      }
     }
     expect(res).to eq(expected)
   end
 
   it 'performs mailbox validation for alice@mailgun.net' do
-    res = @mg_obj.validate("alice@mailgun.net", true)
+    res = @mg_obj.validate('alice@mailgun.net', true)
 
-    expect(res["mailbox_verification"]).to eq("true")
+    expect(res['mailbox_verification']).to eq('true')
   end
 
   it 'fails to validate example.org' do
-    res = @mg_obj.validate("example.org")
+    res = @mg_obj.validate('example.org')
 
     expected = {
-        "address" => "example.org",
-        "did_you_mean" => nil,
-        "is_disposable_address" => false,
-        "is_role_address" => false,
-        "is_valid" => false,
-        "mailbox_verification" => "unknown",
-        #"reason" => "Validation failed for 'example.org', reason: 'malformed address; missing @ sign'",
-        "parts" => {
-            "display_name" => nil,
-            "domain" => nil,
-            "local_part" => nil,
-        },
+      'address' => 'example.org',
+      'did_you_mean' => nil,
+      'is_disposable_address' => false,
+      'is_role_address' => false,
+      'is_valid' => false,
+      'mailbox_verification' => 'unknown',
+      # "reason" => "Validation failed for 'example.org', reason: 'malformed address; missing @ sign'",
+      'parts' => {
+        'display_name' => nil,
+        'domain' => nil,
+        'local_part' => nil
+      }
     }
     expect(res).to eq(expected)
   end
-
 end

data/spec/integration/events_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'mailgun'
 require 'mailgun/events/events'
 
-vcr_opts = { :cassette_name => "events" }
+vcr_opts = { cassette_name: 'events' }
 
 describe 'For the Events endpoint', vcr: vcr_opts do
   before(:all) do
@@ -12,17 +14,15 @@ describe 'For the Events endpoint', vcr: vcr_opts do
   end
 
   it 'can get an event.' do
-    result = @mg_obj.get("#{@domain}/events", {:limit => 1})
+    result = @mg_obj.get("#{@domain}/events", { limit: 1 })
 
     result.to_h!
-    expect(result.body["items"].length).to be_within(1).of(1)
-    expect(result.body["paging"]).to include("next")
-    expect(result.body["paging"]).to include("previous")
+    expect(result.body['items'].length).to be_within(1).of(1)
+    expect(result.body['paging']).to include('next')
+    expect(result.body['paging']).to include('previous')
   end
 
   it 'can iterate over all events with `each`' do
-    @events.each do |e|
-      expect(e).to have_key('event')
-    end
+    expect(@events).to all(have_key('event'))
   end
 end

data/spec/integration/list_members_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'mailgun'
 
-vcr_opts = { :cassette_name => "list_members" }
+vcr_opts = { cassette_name: 'list_members' }
 
 describe 'For the Mailing Lists Members endpoint', order: :defined, vcr: vcr_opts do
   before(:all) do
@@ -10,54 +12,53 @@ describe 'For the Mailing Lists Members endpoint', order: :defined, vcr: vcr_opt
     @ml_address = "integration_test_list@#{@domain}"
     @ml_member = "integration_test_member_member@#{@domain}"
   end
-  
+
   it 'creates a list' do
-    result = @mg_obj.post("lists", {:address => @ml_address,
-                           :name => 'Integration Test List',
-                           :description => 'This list should be deleted automatically.',
-                           :access_level => 'members'})
+    result = @mg_obj.post('lists', { address: @ml_address,
+                                     name: 'Integration Test List',
+                                     description: 'This list should be deleted automatically.',
+                                     access_level: 'members' })
     result.to_h!
-    expect(result.body["message"]).to eq("Mailing list has been created")
-    expect(result.body["list"]["address"]).to eq(@ml_address)
-    expect(result.body["list"]["name"]).to eq('Integration Test List')
+    expect(result.body['message']).to eq('Mailing list has been created')
+    expect(result.body['list']['address']).to eq(@ml_address)
+    expect(result.body['list']['name']).to eq('Integration Test List')
   end
 
   it 'adds a list member' do
     result = @mg_obj.post("lists/#{@ml_address}/members",
-                          {:address => @ml_member,
-                           :name => 'Jane Doe',
-                           :subscribed => true,
-                           :upsert => 'no'})
+                          { address: @ml_member,
+                            name: 'Jane Doe',
+                            subscribed: true,
+                            upsert: 'no' })
 
     result.to_h!
-    expect(result.body["message"]).to eq("Mailing list member has been created")
-    expect(result.body["member"]["address"]).to eq(@ml_member)
-    expect(result.body["member"]["name"]).to eq('Jane Doe')
+    expect(result.body['message']).to eq('Mailing list member has been created')
+    expect(result.body['member']['address']).to eq(@ml_member)
+    expect(result.body['member']['name']).to eq('Jane Doe')
   end
-  
+
   it 'gets a list member.' do
     result = @mg_obj.get("lists/#{@ml_address}/members/#{@ml_member}")
 
     result.to_h!
-    expect(result.body["member"]["address"]).to eq(@ml_member)
-    expect(result.body["member"]["name"]).to eq('Jane Doe')
+    expect(result.body['member']['address']).to eq(@ml_member)
+    expect(result.body['member']['name']).to eq('Jane Doe')
   end
 
   it 'updates a list member.' do
     result = @mg_obj.put("lists/#{@ml_address}/members/#{@ml_member}",
-                         {:name => 'Jane Doe Update',
-                          :subscribed => false})
+                         { name: 'Jane Doe Update',
+                           subscribed: false })
 
     result.to_h!
-    expect(result.body["message"]).to eq("Mailing list member has been updated")
-    expect(result.body["member"]["address"]).to eq(@ml_member)
-    expect(result.body["member"]["name"]).to eq('Jane Doe Update')
-    expect(result.body["member"]["subscribed"]).to eq(false)
+    expect(result.body['message']).to eq('Mailing list member has been updated')
+    expect(result.body['member']['address']).to eq(@ml_member)
+    expect(result.body['member']['name']).to eq('Jane Doe Update')
+    expect(result.body['member']['subscribed']).to be(false)
   end
 
   it 'removes a list member' do
     @mg_obj.delete("lists/#{@ml_address}/members/#{@ml_member}")
     @mg_obj.delete("lists/#{@ml_address}")
   end
-
 end

data/spec/integration/list_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'mailgun'
 
-vcr_opts = { :cassette_name => "mailing_list" }
+vcr_opts = { cassette_name: 'mailing_list' }
 
 describe 'For the Mailing Lists endpoint', vcr: vcr_opts do
   before(:all) do
@@ -11,48 +13,47 @@ describe 'For the Mailing Lists endpoint', vcr: vcr_opts do
   end
 
   it 'creates a list' do
-    result = @mg_obj.post("lists", {:address => @ml_address,
-                                    :name => 'Integration Test List',
-                                    :description => 'This list should be deleted automatically.',
-                                    :access_level => 'members'})
+    result = @mg_obj.post('lists', { address: @ml_address,
+                                     name: 'Integration Test List',
+                                     description: 'This list should be deleted automatically.',
+                                     access_level: 'members' })
 
     result.to_h!
-    expect(result.body["message"]).to eq("Mailing list has been created")
-    expect(result.body["list"]["address"]).to eq(@ml_address)
-    expect(result.body["list"]["name"]).to eq('Integration Test List')
+    expect(result.body['message']).to eq('Mailing list has been created')
+    expect(result.body['list']['address']).to eq(@ml_address)
+    expect(result.body['list']['name']).to eq('Integration Test List')
   end
 
   it 'gets a list.' do
     result = @mg_obj.get("lists/#{@ml_address}")
 
     result.to_h!
-    expect(result.body["list"]["address"]).to eq(@ml_address)
-    expect(result.body["list"]["name"]).to eq('Integration Test List')
+    expect(result.body['list']['address']).to eq(@ml_address)
+    expect(result.body['list']['name']).to eq('Integration Test List')
   end
 
   it 'gets a list of all lists.' do
-    result = @mg_obj.get("lists", {:limit => 50})
+    result = @mg_obj.get('lists', { limit: 50 })
 
     result.to_h!
-    expect(result.body["total_count"]).to be > 0
+    expect(result.body['total_count']).to be > 0
   end
 
   it 'updates a list.' do
     result = @mg_obj.put("lists/#{@ml_address}",
-                         {:address => @ml_address,
-                          :name => 'Integration Test List Update',
-                          :description => 'This list should be deleted automatically.',
-                          :access_level => 'readonly'})
+                         { address: @ml_address,
+                           name: 'Integration Test List Update',
+                           description: 'This list should be deleted automatically.',
+                           access_level: 'readonly' })
 
     result.to_h!
-    expect(result.body["message"]).to eq("Mailing list has been updated")
-    expect(result.body["list"]["address"]).to eq(@ml_address)
-    expect(result.body["list"]["name"]).to eq('Integration Test List Update')
-    expect(result.body["list"]["access_level"]).to eq('readonly')
+    expect(result.body['message']).to eq('Mailing list has been updated')
+    expect(result.body['list']['address']).to eq(@ml_address)
+    expect(result.body['list']['name']).to eq('Integration Test List Update')
+    expect(result.body['list']['access_level']).to eq('readonly')
   end
 
   it 'deletes a list' do
     @mg_obj.delete("lists/#{@ml_address}")
   end
-
 end

data/spec/integration/logs_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'mailgun'
 
 vcr_opts = { cassette_name: 'logs' }
 
 describe Mailgun::Logs, vcr: vcr_opts do
-  let(:logs) { Mailgun::Logs.new(Mailgun::Client.new(APIKEY, APIHOST, 'v1')) }
+  let(:logs) { described_class.new(Mailgun::Client.new(APIKEY, APIHOST, 'v1')) }
 
   describe '#account_logs' do
     let(:options) do
@@ -37,65 +39,65 @@ describe Mailgun::Logs, vcr: vcr_opts do
     it 'responds with account logs' do
       expect(logs.account_logs(options)).to eq(
         {
-          "start" => "Wed, 25 Jun 2025 00:00:00 -0000",
-          "end" => "Wed, 25 Jun 2025 23:00:00 -0000",
-          "items" => [
+          'start' => 'Wed, 25 Jun 2025 00:00:00 -0000',
+          'end' => 'Wed, 25 Jun 2025 23:00:00 -0000',
+          'items' => [
             {
-              "id" => "123",
-              "event" => "accepted",
-              "@timestamp" => "2025-06-25T17:19:51.166Z",
-              "account" => {
-                "id" => "123"
+              'id' => '123',
+              'event' => 'accepted',
+              '@timestamp' => '2025-06-25T17:19:51.166Z',
+              'account' => {
+                'id' => '123'
               },
-              "method" => "HTTP",
-              "originating-ip" => "123.123.12.123",
-              "api-key-id" => "xxx",
-              "domain" => {
-                "name" => "example.mailgun.org"
+              'method' => 'HTTP',
+              'originating-ip' => '123.123.12.123',
+              'api-key-id' => 'xxx',
+              'domain' => {
+                'name' => 'example.mailgun.org'
               },
-              "recipient" => "alex@example.com",
-              "recipient-domain" => "example.com",
-              "envelope" => {
-                "sender" => "example.mailgun.org",
-                "transport" => "smtp",
-                "targets" => "alex@example.com"
+              'recipient' => 'alex@example.com',
+              'recipient-domain' => 'example.com',
+              'envelope' => {
+                'sender' => 'example.mailgun.org',
+                'transport' => 'smtp',
+                'targets' => 'alex@example.com'
               },
-              "storage" => {
-                "region" => "us-east4",
-                "env" => "production",
-                "key" => "xxx",
-                "url" => ["https://storage.api.mailgun.net/v3/domains/example.mailgun.org/messages/123"]
+              'storage' => {
+                'region' => 'us-east4',
+                'env' => 'production',
+                'key' => 'xxx',
+                'url' => ['https://storage.api.mailgun.net/v3/domains/example.mailgun.org/messages/123']
               },
-              "log-level" => "info",
-              "user-variables" => "{}",
-              "message" => {
-                "headers" => {
-                  "to" => "alex@example.com",
-                  "message-id" => "123@example.mailgun.org",
-                  "from" => "bob@sending_domain.com+4",
-                  "subject" => "The Ruby SDK is awesome!"
+              'log-level' => 'info',
+              'user-variables' => '{}',
+              'message' => {
+                'headers' => {
+                  'to' => 'alex@example.com',
+                  'message-id' => '123@example.mailgun.org',
+                  'from' => 'bob@sending_domain.com+4',
+                  'subject' => 'The Ruby SDK is awesome!'
                 },
-                "attachments" => [
+                'attachments' => [
                   {
-                    "filename" => "image.jpg",
-                    "content-type" => "image/jpeg",
-                    "size" => 16712
+                    'filename' => 'image.jpg',
+                    'content-type' => 'image/jpeg',
+                    'size' => 16_712
                   }
                 ],
-                "size" => 23476
+                'size' => 23_476
               },
-              "flags" => {
-                "is-authenticated" => true,
-                "is-system-test" => false,
-                "is-routed" => false,
-                "is-test-mode" => false,
-                "is-delayed-bounce" => false,
-                "is-callback" => false
+              'flags' => {
+                'is-authenticated' => true,
+                'is-system-test' => false,
+                'is-routed' => false,
+                'is-test-mode' => false,
+                'is-delayed-bounce' => false,
+                'is-callback' => false
               }
             }
           ],
-          "pagination" => {},
-          "aggregates" => {}
+          'pagination' => {},
+          'aggregates' => {}
         }
       )
     end

data/spec/integration/mailer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'json'
 require 'logger'
@@ -21,7 +23,7 @@ class IntegrationUnitTestMailer < ActionMailer::Base
   end
 end
 
-vcr_opts = { :cassette_name => 'message_deliver' }
+vcr_opts = { cassette_name: 'message_deliver' }
 
 describe 'Message deliver', vcr: vcr_opts do
   let(:domain) { TESTDOMAIN || 'DOMAIN.TEST' }
@@ -43,7 +45,7 @@ describe 'Message deliver', vcr: vcr_opts do
   end
 end
 
-vcr_opts = { :cassette_name => 'mailer_invalid_domain' }
+vcr_opts = { cassette_name: 'mailer_invalid_domain' }
 
 describe 'Invalid domain', vcr: vcr_opts do
   let(:domain) { 'not-our-doma.in' }
@@ -56,6 +58,8 @@ describe 'Invalid domain', vcr: vcr_opts do
   let(:mail) { IntegrationUnitTestMailer.plain_message('sally@not-our-doma.in', "bob@#{domain}", 'subject', {}) }
 
   it 'raises expected error' do
-    expect { Railgun::Mailer.new(config).deliver!(mail) }.to raise_error Mailgun::Unauthorized, /Invalid Domain or API key/
+    expect do
+      Railgun::Mailer.new(config).deliver!(mail)
+    end.to raise_error Mailgun::Unauthorized, /Invalid Domain or API key/
   end
 end