mailgun-ruby 1.4.1 → 1.4.2

data/spec/integration/templates_spec.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'mailgun'
 
-vcr_opts = { :cassette_name => "templates" }
+vcr_opts = { cassette_name: 'templates' }
 
 describe 'For the templates endpoints', vcr: vcr_opts do
   let(:template_name) { 'test.template' }
-  let(:domain) { "integration-test.domain.invalid" }
+  let(:domain) { 'integration-test.domain.invalid' }
   let(:tag) { 'v2' }
 
   before(:all) do
@@ -21,14 +23,14 @@ describe 'For the templates endpoints', vcr: vcr_opts do
           name: template_name,
           description: 'Test',
           template: '{{fname}} {{lname}}',
-            comment: 'test comment',
-            headers: '{"Subject": "{{subject}}"}',
-            tag: 'V1'
+          comment: 'test comment',
+          headers: '{"Subject": "{{subject}}"}',
+          tag: 'V1'
         }
       )
 
-      expect(result['template']["name"]).to eq('test.template')
-      expect(result['template']["description"]).to eq("Test")
+      expect(result['template']['name']).to eq('test.template')
+      expect(result['template']['description']).to eq('Test')
     end
   end
 
@@ -36,8 +38,8 @@ describe 'For the templates endpoints', vcr: vcr_opts do
     it 'gets the templates info' do
       result = @mg_obj.info(domain, 'test.template')
 
-      expect(result).to include("template")
-      expect(result["template"]["name"]).to eq(template_name)
+      expect(result).to include('template')
+      expect(result['template']['name']).to eq(template_name)
     end
   end
 
@@ -88,7 +90,7 @@ describe 'For the templates endpoints', vcr: vcr_opts do
         }
       )
 
-      expect(result['template']["version"]['tag']).to eq(tag)
+      expect(result['template']['version']['tag']).to eq(tag)
     end
   end
 
@@ -96,7 +98,7 @@ describe 'For the templates endpoints', vcr: vcr_opts do
     it "gets the template's version info" do
       result = @mg_obj.info_version(domain, template_name, tag)
 
-      expect(result["template"]["version"]['tag']).to eq(tag)
+      expect(result['template']['version']['tag']).to eq(tag)
     end
   end
 
@@ -121,7 +123,7 @@ describe 'For the templates endpoints', vcr: vcr_opts do
     it "returns template's versions" do
       result = @mg_obj.template_versions_list(domain, template_name)
 
-      expect(result["template"]["versions"].first).to include('tag')
+      expect(result['template']['versions'].first).to include('tag')
     end
   end
 

data/spec/integration/unsubscribes_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'mailgun'
 
-vcr_opts = { :cassette_name => "unsubscribes" }
+vcr_opts = { cassette_name: 'unsubscribes' }
 
 describe 'For the Unsubscribes endpoint', order: :defined, vcr: vcr_opts do
   before(:all) do
@@ -14,22 +16,22 @@ describe 'For the Unsubscribes endpoint', order: :defined, vcr: vcr_opts do
     result = @mg_obj.post "#{@domain}/unsubscribes", address: @email, tag: '*'
 
     result.to_h!
-    expect(result.body["message"]).to eq("Address has been added to the unsubscribes table")
-    expect(result.body["address"]).to eq(@email)
+    expect(result.body['message']).to eq('Address has been added to the unsubscribes table')
+    expect(result.body['address']).to eq(@email)
   end
 
   it 'get an unsubscribee.' do
     result = @mg_obj.get "#{@domain}/unsubscribes/#{@email}"
 
     result.to_h!
-    expect(result.body["address"]).to eq(@email)
+    expect(result.body['address']).to eq(@email)
   end
 
   it 'gets a list of unsubscribes.' do
     result = @mg_obj.get "#{@domain}/unsubscribes"
 
     result.to_h!
-    expect(result.body["items"].length).to be > 0
+    expect(result.body['items'].length).to be > 0
   end
 
   it 'removes an unsubscribee' do
@@ -37,6 +39,6 @@ describe 'For the Unsubscribes endpoint', order: :defined, vcr: vcr_opts do
 
     result.to_h!
     expect(result.body['address']).to eq(@email)
-    expect(result.body["message"]).to eq("Unsubscribe event has been removed")
+    expect(result.body['message']).to eq('Unsubscribe event has been removed')
   end
 end

data/spec/integration/webhook_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'mailgun'
 
-vcr_opts = { :cassette_name => "webhooks" }
+vcr_opts = { cassette_name: 'webhooks' }
 
 describe 'For the webhooks endpoint', order: :defined, vcr: vcr_opts do
   before(:all) do
@@ -13,42 +15,41 @@ describe 'For the webhooks endpoint', order: :defined, vcr: vcr_opts do
 
   it 'creates a webhook' do
     result = @mg_obj.post("domains/#{@domain}/webhooks", { id: @testhook,
-                                                           url: "http://example.com/mailgun/events/#{@testhook}" } )
+                                                           url: "http://example.com/mailgun/events/#{@testhook}" })
 
     result.to_h!
-    expect(result.body["message"]).to eq("Webhook has been created")
-    expect(result.body["webhook"]["urls"]).to include("http://example.com/mailgun/events/#{@testhook}")
+    expect(result.body['message']).to eq('Webhook has been created')
+    expect(result.body['webhook']['urls']).to include("http://example.com/mailgun/events/#{@testhook}")
   end
 
   it 'gets a webhook.' do
     result = @mg_obj.get("domains/#{@domain}/webhooks/#{@testhook}")
 
     result.to_h!
-    expect(result.body["webhook"]["urls"]).to include("http://example.com/mailgun/events/#{@testhook}")
+    expect(result.body['webhook']['urls']).to include("http://example.com/mailgun/events/#{@testhook}")
   end
 
   it 'gets a list of all webhooks.' do
     result = @mg_obj.get("domains/#{@domain}/webhooks")
 
     result.to_h!
-    expect(result.body["webhooks"]["accepted"]["urls"]).to include("http://example.com/mailgun/events/#{@testhook}")
+    expect(result.body['webhooks']['accepted']['urls']).to include("http://example.com/mailgun/events/#{@testhook}")
   end
 
   it 'updates a webhook.' do
-    result = @mg_obj.put("domains/#{@domain}/webhooks/#{@testhook}", {:id => @testhook,
-                                                                :url => "http://example.com/mailgun/events/#{@testhookup}"})
+    result = @mg_obj.put("domains/#{@domain}/webhooks/#{@testhook}", { id: @testhook,
+                                                                       url: "http://example.com/mailgun/events/#{@testhookup}" })
 
     result.to_h!
-    expect(result.body["message"]).to eq("Webhook has been updated")
-    expect(result.body["webhook"]["urls"]).to include("http://example.com/mailgun/events/#{@testhookup}")
+    expect(result.body['message']).to eq('Webhook has been updated')
+    expect(result.body['webhook']['urls']).to include("http://example.com/mailgun/events/#{@testhookup}")
   end
 
   it 'removes a webhook' do
     result = @mg_obj.delete("domains/#{@domain}/webhooks/#{@testhook}")
 
     result.to_h!
-    expect(result.body['message']).to eq("Webhook has been deleted")
+    expect(result.body['message']).to eq('Webhook has been deleted')
     expect(result.body['webhook']['urls']).to include("http://example.com/mailgun/events/#{@testhookup}")
   end
-
 end

data/spec/spec_helper.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 
 SimpleCov.start do
-  add_filter "/spec/"
+  add_filter '/spec/'
 end
 
 require 'mailgun'
@@ -10,22 +12,20 @@ require 'vcr'
 require 'webmock/rspec'
 require 'rspec/its'
 
-#WebMock.disable_net_connect!(allow_localhost: true)
+# WebMock.disable_net_connect!(allow_localhost: true)
 require_relative 'unit/connection/test_client'
 
-RSpec.configure do |c|
-  c.raise_errors_for_deprecations!
-end
+RSpec.configure(&:raise_errors_for_deprecations!)
 
-APIHOST = "api.mailgun.net"
-APIVERSION = "v3"
+APIHOST = 'api.mailgun.net'
+APIVERSION = 'v3'
 SSL = true
 
 # For integration tests modify .ruby-env.yml
 # use .ruby-env.yml.example for an example
 # alternatively
 # set environment variables as named in .ruby-env.yml.example
-envfile = File.join(File.dirname(__FILE__), '..','.ruby-env.yml')
+envfile = File.join(File.dirname(__FILE__), '..', '.ruby-env.yml')
 envs = File.exist?(envfile) ? YAML.load_file(envfile) : ENV
 APIKEY = envs['MAILGUN_APIKEY']
 PUB_APIKEY = envs['MAILGUN_PUB_APIKEY']

data/spec/unit/connection/test_client.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require 'time'
 require 'json'
 
 module Mailgun
   class UnitClient < Mailgun::Client
-
     attr_reader :options, :block, :body, :code, :response
 
     def initialize(endpoint, &block)
@@ -14,9 +15,10 @@ module Mailgun
     end
 
     def [](endpoint, &new_block)
-      case
-      when block_given? then self.class.new(endpoint, &new_block)
-      when block        then self.class.new(endpoint, &block)
+      if block_given?
+        self.class.new(endpoint, &new_block)
+      elsif block
+        self.class.new(endpoint, &block)
       else
         self.class.new(endpoint)
       end
@@ -26,10 +28,8 @@ module Mailgun
       perform_data_validation(working_domain, data)
       case data
       when Hash
-        if data.has_key?(:message)
-          if data[:message].is_a?(String)
-            data[:message] = convert_string_to_file(data[:message])
-          end
+        if data.key?(:message)
+          data[:message] = convert_string_to_file(data[:message]) if data[:message].is_a?(String)
           post("#{working_domain}/messages.mime", data)
         else
           post("#{working_domain}/messages", data)
@@ -37,80 +37,86 @@ module Mailgun
       when MessageBuilder
         post("#{working_domain}/messages", data.message)
       else
-        raise ParameterError.new("Unknown data type for data parameter.", data)
+        raise ParameterError.new('Unknown data type for data parameter.', data)
       end
     end
 
-    def post(path, data)
-      begin
-        Mailgun::Response.new(response_generator(@endpoint))
-      rescue => e
-        p e
-        raise CommunicationError.new(e), e.response if e.respond_to? :response
-        raise CommunicationError.new(e.message)
-      end
+    def post(_path, _data)
+      Mailgun::Response.new(response_generator(@endpoint))
+    rescue StandardError => e
+      p e
+      raise CommunicationError.new(e), e.response if e.respond_to? :response
+
+      raise CommunicationError, e.message
     end
 
-    def get(path, query_string = nil)
-      begin
-        Mailgun::Response.new(response_generator(@endpoint))
-      rescue => e
-        raise CommunicationError.new(e), e.response
-      end
+    def get(_path, _query_string = nil)
+      Mailgun::Response.new(response_generator(@endpoint))
+    rescue StandardError => e
+      raise CommunicationError.new(e), e.response
     end
 
-    def put(path, data)
-      begin
-        Mailgun::Response.new(response_generator(@endpoint))
-      rescue => e
-        raise CommunicationError.new(e), e.response
-      end
+    def put(_path, _data)
+      Mailgun::Response.new(response_generator(@endpoint))
+    rescue StandardError => e
+      raise CommunicationError.new(e), e.response
     end
 
-    def delete(path)
-      begin
-        Mailgun::Response.new(response_generator(@endpoint))
-      rescue => e
-        raise CommunicationError.new(e), e.response
-      end
+    def delete(_path)
+      Mailgun::Response.new(response_generator(@endpoint))
+    rescue StandardError => e
+      raise CommunicationError.new(e), e.response
     end
 
     private
 
     def perform_data_validation(working_domain, data)
-      fail ParameterError.new('Missing working domain', working_domain) unless working_domain
+      raise ParameterError.new('Missing working domain', working_domain) unless working_domain
       return true unless data.is_a?(Hash) && data.present?
+
       message = data.respond_to?(:message) ? data.message : data
 
-      fail ParameterError.new(
-        'Missing `to` recipient, message should contain at least 1 recipient',
-        working_domain
-      ) if message.fetch('to', []).empty? && message.fetch(:to, []).empty?
-      fail ParameterError.new(
+      if message.fetch('to', []).empty? && message.fetch(:to, []).empty?
+        raise ParameterError.new(
+          'Missing `to` recipient, message should contain at least 1 recipient',
+          working_domain
+        )
+      end
+      return unless message.fetch('from', []).empty? && message.fetch(:from, []).empty?
+
+      raise ParameterError.new(
         'Missing a `from` sender, message should contain at least 1 `from` sender',
         working_domain
-      ) if message.fetch('from', []).empty? && message.fetch(:from, []).empty?
+      )
     end
 
     def response_generator(resource_endpoint)
-      if resource_endpoint == "messages"
+      if resource_endpoint == 'messages'
         t = Time.now
-        id = "<#{t.to_i}.#{rand(99999999)}.5817@example.com>"
-        return Response.from_hash({ body: JSON.generate({"message" => "Queued. Thank you.", "id" => id}) })
+        id = "<#{t.to_i}.#{rand(99_999_999)}.5817@example.com>"
+        return Response.from_hash({ body: JSON.generate({ 'message' => 'Queued. Thank you.', 'id' => id }) })
       end
-      if resource_endpoint == "bounces"
-        return Response.from_hash({ body: JSON.generate({"total_count" => 1, "items" => {"created_at" => "Fri, 21 Oct 2011 11:02:55 GMT", "status" => 550, "address" => "baz@example.com", "error" => "Message was not accepted -- invalid mailbox. Local mailbox baz@example.com is unavailable: user not found"}}) })
+      if resource_endpoint == 'bounces'
+        return Response.from_hash({ body: JSON.generate({ 'total_count' => 1,
+                                                          'items' => { 'created_at' => 'Fri, 21 Oct 2011 11:02:55 GMT', 'status' => 550, 'address' => 'baz@example.com',
+                                                                       'error' => 'Message was not accepted -- invalid mailbox. Local mailbox baz@example.com is unavailable: user not found' } }) })
       end
-      if resource_endpoint == "lists"
-        return Response.from_hash({ body: JSON.generate({"member" => {"vars" => {"age" => 26}, "name" => "Foo Bar", "subscribed" => false, "address" => "bar@example.com"}, "message" => "Mailing list member has been updated"}) })
+      if resource_endpoint == 'lists'
+        return Response.from_hash({ body: JSON.generate({
+                                                          'member' => { 'vars' => { 'age' => 26 }, 'name' => 'Foo Bar', 'subscribed' => false,
+                                                                        'address' => 'bar@example.com' }, 'message' => 'Mailing list member has been updated'
+                                                        }) })
       end
-      if resource_endpoint == "campaigns"
-        return Response.from_hash({ body: JSON.generate({"message" => "Campaign has been deleted", "id" => "ABC123"}) })
-      end
-      if resource_endpoint == "events"
-        return Response.from_hash({ body: JSON.generate({"items" => [], "paging" => {"next"=> "https://api.mailgun.net/v3/thisisatestdomainformailgun.com/events/W3siYiI6ICIyMDE0LTA1LTA3VDAwOjQ1OjUxLjc0MDg5MiswMDowMCIsICJlIjogIjIwMTQtMDUtMDVUMDA6NDU6NTEuNzQwOTgzKzAwOjAwIn0sIHsiYiI6ICIyMDE0LTA1LTA3VDAwOjQ1OjUxLjc0MDg5MiswMDowMCIsICJlIjogIjIwMTQtMDUtMDVUMDA6NDU6NTEuNzQwOTgzKzAwOjAwIn0sIFsiZiJdLCBudWxsLCB7ImFjY291bnQuaWQiOiAiNGU4MjMwZjYxNDc2ZDg2NzEzMDBjNDc2IiwgImRvbWFpbi5uYW1lIjogInRoaXNpc2F0ZXN0ZG9tYWluZm9ybWFpbGd1bi5jb20iLCAic2V2ZXJpdHkiOiAiTk9UIGludGVybmFsIn0sIDEwMCwgbnVsbF0=", "previous"=> "https://api.mailgun.net/v2/thisisatestdomainformailgun.com/events/W3siYiI6ICIyMDE0LTA1LTA3VDAwOjQ1OjUxLjc0MDg5MiswMDowMCIsICJlIjogIjIwMTQtMDUtMDVUMDA6NDU6NTEuNzQwOTgzKzAwOjAwIn0sIHsiYiI6ICIyMDE0LTA1LTA3VDAwOjQ1OjUxLjc0MDg5MiswMDowMCIsICJlIjogIjIwMTQtMDUtMDdUMDA6NDU6NTEuNzQxODkyKzAwOjAwIn0sIFsicCIsICJmIl0sIG51bGwsIHsiYWNjb3VudC5pZCI6ICI0ZTgyMzBmNjE0NzZkODY3MTMwMGM0NzYiLCAiZG9tYWluLm5hbWUiOiAidGhpc2lzYXRlc3Rkb21haW5mb3JtYWlsZ3VuLmNvbSIsICJzZXZlcml0eSI6ICJOT1QgaW50ZXJuYWwifSwgMTAwLCBudWxsXQ=="}}) })
+      if resource_endpoint == 'campaigns'
+        return Response.from_hash({ body: JSON.generate({ 'message' => 'Campaign has been deleted',
+                                                          'id' => 'ABC123' }) })
       end
+      return unless resource_endpoint == 'events'
+
+      Response.from_hash({ body: JSON.generate({ 'items' => [],
+                                                 'paging' => {
+                                                   'next' => 'https://api.mailgun.net/v3/thisisatestdomainformailgun.com/events/W3siYiI6ICIyMDE0LTA1LTA3VDAwOjQ1OjUxLjc0MDg5MiswMDowMCIsICJlIjogIjIwMTQtMDUtMDVUMDA6NDU6NTEuNzQwOTgzKzAwOjAwIn0sIHsiYiI6ICIyMDE0LTA1LTA3VDAwOjQ1OjUxLjc0MDg5MiswMDowMCIsICJlIjogIjIwMTQtMDUtMDVUMDA6NDU6NTEuNzQwOTgzKzAwOjAwIn0sIFsiZiJdLCBudWxsLCB7ImFjY291bnQuaWQiOiAiNGU4MjMwZjYxNDc2ZDg2NzEzMDBjNDc2IiwgImRvbWFpbi5uYW1lIjogInRoaXNpc2F0ZXN0ZG9tYWluZm9ybWFpbGd1bi5jb20iLCAic2V2ZXJpdHkiOiAiTk9UIGludGVybmFsIn0sIDEwMCwgbnVsbF0=', 'previous' => 'https://api.mailgun.net/v2/thisisatestdomainformailgun.com/events/W3siYiI6ICIyMDE0LTA1LTA3VDAwOjQ1OjUxLjc0MDg5MiswMDowMCIsICJlIjogIjIwMTQtMDUtMDVUMDA6NDU6NTEuNzQwOTgzKzAwOjAwIn0sIHsiYiI6ICIyMDE0LTA1LTA3VDAwOjQ1OjUxLjc0MDg5MiswMDowMCIsICJlIjogIjIwMTQtMDUtMDdUMDA6NDU6NTEuNzQxODkyKzAwOjAwIn0sIFsicCIsICJmIl0sIG51bGwsIHsiYWNjb3VudC5pZCI6ICI0ZTgyMzBmNjE0NzZkODY3MTMwMGM0NzYiLCAiZG9tYWluLm5hbWUiOiAidGhpc2lzYXRlc3Rkb21haW5mb3JtYWlsZ3VuLmNvbSIsICJzZXZlcml0eSI6ICJOT1QgaW50ZXJuYWwifSwgMTAwLCBudWxsXQ=='
+                                                 } }) })
     end
   end
-
 end

data/spec/unit/events/events_spec.rb

@@ -1,31 +1,34 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'The method get' do
   it 'should return a proper hash of log data.' do
     @mg_obj = Mailgun::UnitClient.new('events')
-    events = Mailgun::Events.new(@mg_obj, "samples.mailgun.org")
-    result = events.get()
+    events = Mailgun::Events.new(@mg_obj, 'samples.mailgun.org')
+    result = events.get
 
-    expect(result.body).to include("items")
-    expect(result.body).to include("paging")
+    expect(result.body).to include('items')
+    expect(result.body).to include('paging')
   end
 end
 
 describe 'Pagination' do
   it 'should return a proper hash of log data.' do
     @mg_obj = Mailgun::UnitClient.new('events')
-    events = Mailgun::Events.new(@mg_obj, "samples.mailgun.org")
-    result = events.get()
+    events = Mailgun::Events.new(@mg_obj, 'samples.mailgun.org')
+    result = events.get
 
     json = JSON.parse(result.body)
-    expect(json).to include("paging")
-    expect(json["paging"]).to include("next")
-    expect(json["paging"]).to include("previous")
+    expect(json).to include('paging')
+    expect(json['paging']).to include('next')
+    expect(json['paging']).to include('previous')
   end
 
   it 'should calculate proper next-page url' do
-    events = Mailgun::Events.new(@mg_obj, "samples.mailgun.org")
-    output = events.send(:extract_endpoint_from, '/v3/samples.mailgun.org/events/W3siYiI6ICIyMDE3LTA1LTEwVDIwOjA2OjU0LjU3NiswMDowMCIsICJlIjogIjIwMTctMDUtMDhUMjA6MDY6NTQuNTc3KzAwOjAwIn0sIHsiYiI6ICIyMDE3LTA1LTEwVDIwOjA2OjU0LjU3NiswMDowMCIsICJlIjogIjIwMTctMDUtMDhUMjA6MDY6NTQuNTc3KzAwOjAwIn0sIFsiZiJdLCBudWxsLCBbWyJhY2NvdW50LmlkIiwgIjU4MDUyMTg2NzhmYTE2MTNjNzkwYjUwZiJdLCBbImRvbWFpbi5uYW1lIiwgInNhbmRib3gyOTcwMTUyYWYzZDM0NTU5YmZjN2U3MTcwM2E2Y2YyNC5tYWlsZ3VuLm9yZyJdXSwgMTAwLCBudWxsXQ==')
+    events = Mailgun::Events.new(@mg_obj, 'samples.mailgun.org')
+    output = events.send(:extract_endpoint_from,
+                         '/v3/samples.mailgun.org/events/W3siYiI6ICIyMDE3LTA1LTEwVDIwOjA2OjU0LjU3NiswMDowMCIsICJlIjogIjIwMTctMDUtMDhUMjA6MDY6NTQuNTc3KzAwOjAwIn0sIHsiYiI6ICIyMDE3LTA1LTEwVDIwOjA2OjU0LjU3NiswMDowMCIsICJlIjogIjIwMTctMDUtMDhUMjA6MDY6NTQuNTc3KzAwOjAwIn0sIFsiZiJdLCBudWxsLCBbWyJhY2NvdW50LmlkIiwgIjU4MDUyMTg2NzhmYTE2MTNjNzkwYjUwZiJdLCBbImRvbWFpbi5uYW1lIiwgInNhbmRib3gyOTcwMTUyYWYzZDM0NTU5YmZjN2U3MTcwM2E2Y2YyNC5tYWlsZ3VuLm9yZyJdXSwgMTAwLCBudWxsXQ==')
 
     expect(output).to eq 'W3siYiI6ICIyMDE3LTA1LTEwVDIwOjA2OjU0LjU3NiswMDowMCIsICJlIjogIjIwMTctMDUtMDhUMjA6MDY6NTQuNTc3KzAwOjAwIn0sIHsiYiI6ICIyMDE3LTA1LTEwVDIwOjA2OjU0LjU3NiswMDowMCIsICJlIjogIjIwMTctMDUtMDhUMjA6MDY6NTQuNTc3KzAwOjAwIn0sIFsiZiJdLCBudWxsLCBbWyJhY2NvdW50LmlkIiwgIjU4MDUyMTg2NzhmYTE2MTNjNzkwYjUwZiJdLCBbImRvbWFpbi5uYW1lIiwgInNhbmRib3gyOTcwMTUyYWYzZDM0NTU5YmZjN2U3MTcwM2E2Y2YyNC5tYWlsZ3VuLm9yZyJdXSwgMTAwLCBudWxsXQ=='
   end
@@ -34,33 +37,33 @@ end
 describe 'The method next' do
   it 'should return the next series of data.' do
     @mg_obj = Mailgun::UnitClient.new('events')
-    events = Mailgun::Events.new(@mg_obj, "samples.mailgun.org")
-    result = events.next()
+    events = Mailgun::Events.new(@mg_obj, 'samples.mailgun.org')
+    result = events.next
 
-    expect(result.body).to include("items")
-    expect(result.body).to include("paging")
+    expect(result.body).to include('items')
+    expect(result.body).to include('paging')
   end
 end
 
 describe 'The method previous' do
   it 'should return the previous series of data.' do
     @mg_obj = Mailgun::UnitClient.new('events')
-    events = Mailgun::Events.new(@mg_obj, "samples.mailgun.org")
-    result = events.previous()
+    events = Mailgun::Events.new(@mg_obj, 'samples.mailgun.org')
+    result = events.previous
 
-    expect(result.body).to include("items")
-    expect(result.body).to include("paging")
+    expect(result.body).to include('items')
+    expect(result.body).to include('paging')
   end
 end
 
 describe 'The method each' do
   it 'should iterate over all event items.' do
     @mg_obj = Mailgun::UnitClient.new('events')
-    events = Mailgun::Events.new(@mg_obj, "samples.mailgun.org")
+    events = Mailgun::Events.new(@mg_obj, 'samples.mailgun.org')
     # Events from the UnitClient are actually empty.
     count = 0
-    events.each do |e|
-      count = count + 1
+    events.each do |_e|
+      count += 1
     end
 
     # Better than nothing..

data/spec/unit/exceptions/exceptions_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe Mailgun::CommunicationError do
@@ -9,22 +11,21 @@ RSpec.describe Mailgun::CommunicationError do
         end.not_to raise_error
       end
 
-      context "when the Response body has an `Error` property" do
-        it "uses the `Error` property as the API message" do
+      context 'when the Response body has an `Error` property' do
+        it 'uses the `Error` property as the API message' do
           subject = described_class.new('Boom!', { status: 401, body: '{"Error":"unauthorized"}' })
 
-          expect(subject.message).to eq("Boom!: unauthorized")
+          expect(subject.message).to eq('Boom!: unauthorized')
         end
       end
 
-      context "when the Response body has an `error` property" do
-        it "uses the `Error` property as the API message" do
+      context 'when the Response body has an `error` property' do
+        it 'uses the `Error` property as the API message' do
           subject = described_class.new('Boom!', { status: 401, body: '{"error":"not found"}' })
 
-          expect(subject.message).to eq("Boom!: not found")
+          expect(subject.message).to eq('Boom!: not found')
         end
       end
-
     end
   end
 end

data/spec/unit/lists/opt_in_handler_spec.rb

@@ -1,22 +1,24 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'The method generate_hash' do
   before(:each) do
-    @mailing_list = "mylist@example.com"
-    @secret_app_id = "mysupersecretpassword"
-    @recipient_address = "bob@example.com"
-    @precalculated_hash = "eyJoIjoiMmY3ZmY1MzFlOGJmMjA0OWNhMTI3ZmU4ZTQyNjZkOTljYzhkMTdk%0AMiIsInAiOiJleUpzSWpvaWJYbHNhWE4wUUdWNFlXMXdiR1V1WTI5dElpd2lj%0AaUk2SW1KdllrQmxlR0Z0Y0d4bExtTnZcbmJTSjlcbiJ9%0A"
+    @mailing_list = 'mylist@example.com'
+    @secret_app_id = 'mysupersecretpassword'
+    @recipient_address = 'bob@example.com'
+    @precalculated_hash = 'eyJoIjoiMmY3ZmY1MzFlOGJmMjA0OWNhMTI3ZmU4ZTQyNjZkOTljYzhkMTdk%0AMiIsInAiOiJleUpzSWpvaWJYbHNhWE4wUUdWNFlXMXdiR1V1WTI5dElpd2lj%0AaUk2SW1KdllrQmxlR0Z0Y0d4bExtTnZcbmJTSjlcbiJ9%0A'
   end
 
   it 'generates a web safe hash for the recipient wishing to subscribe' do
     my_hash = Mailgun::OptInHandler.generate_hash(@mailing_list, @secret_app_id, @recipient_address)
-    
+
     expect(my_hash).to eq(@precalculated_hash)
   end
 
   it 'generates a web safe hash for the recipient wishing to subscribe' do
     validate_result = Mailgun::OptInHandler.validate_hash(@secret_app_id, @precalculated_hash)
-    
+
     expect(validate_result.length).to eq(2)
     expect(validate_result['recipient_address']).to eq(@recipient_address)
     expect(validate_result['mailing_list']).to eq(@mailing_list)