mailchimp_api_v3 0.2.1 → 0.2.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9b1defa3bc88fd22214ea8fc775fcca81f4b91f9
-  data.tar.gz: bb86a874d5bb6ecadd5fbab3459f8977dc4f7804
+  metadata.gz: 1dab92eb4645ef0146c63e4a18b2dafd1a996c73
+  data.tar.gz: 54b25de985d17c12a96c9968258392217c59ce7e
 SHA512:
-  metadata.gz: e5e166d8894d5cf0992fcbac31a48ab2167d63b90e446adefafd799174b557cab218169818c397b5869827b3d3c67dc21f712595b0a69f673a7b8272d0fa6b30
-  data.tar.gz: 129ffa0e7dda961bbe9a4f838f360fecbc418d173d69a480a326656d7dc206c79beba8772d50c6e7aaa3f9b3d3b88803cb22cc1b4be7ed7ec09d92c7d49355f9
+  metadata.gz: 38015076b51956f2139b0b823b65b3c3565e733e5a6d1334371905a780ebdb1836b7a1c83ff9a68a6daca7a21e59b31e1fdf5e12f700c3b4d61fe4060fcfdce7
+  data.tar.gz: 84e3e2fd2613ec42191cacc779b36bdc99b1f2e1d433ebac772fcc87c7bb73a7010d7942a4a715658ffb5999ab24b80f05feee0bbd9051b1a59b9d63adf1f0b8

data/.rubocop.yml

@@ -3,6 +3,11 @@ AllCops:
   Exclude:
     - 'tmp/**/*'
 
+Metrics/BlockLength:
+  CountComments: false  # count full line comments?
+  Exclude:
+    - '**/*_spec.rb'
+
 StringLiterals:
   EnforcedStyle: single_quotes
   Enabled: true

data/.travis.yml

@@ -0,0 +1,6 @@
+---
+language: ruby
+rvm:
+  - 2.4.0
+script:
+  - rspec

data/Gemfile

@@ -1,3 +1,22 @@
 # frozen_string_literal: true
 source 'https://rubygems.org'
 gemspec
+
+group :development do
+  gem 'bundler'
+  gem 'gem-release'
+  gem 'guard'
+  gem 'guard-rspec'
+  gem 'guard-rubocop'
+end
+
+group :test do
+  gem 'coveralls'
+  gem 'fuubar'
+  gem 'rake' # Workaround for a bug in Rainbow 2.2.1 https://github.com/sickill/rainbow/issues/44
+  gem 'rspec'
+  gem 'rspec_junit_formatter'
+  gem 'simplecov', '~> 0.13'
+  gem 'vcr'
+  gem 'webmock'
+end

data/HISTORY.md

@@ -1,3 +1,7 @@
+### v0.2.13
+    * Refreshed Rubocop and ensured the code is still compliant
+    * Changed copyright to me
+
 ### v0.2.0
     * Updated the dependency on rest-client to 2.0.0 because of the known vulnerabilities in earlier versions
     * The corollary of this is that Ruby versions < 2.0 are no longer supported

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2015, Xenapto
+Copyright (c) 2017 Dominic Sayers
 Some code copyright (c) 2015, The Rocket Science Group, LLC
 All rights reserved.
 

data/README.md

@@ -1,14 +1,17 @@
 ## Mailchimp API v3
-[![Gem Version](https://badge.fury.io/rb/mailchimp_api_v3.svg)](https://rubygems.org/gems/mailchimp_api_v3)
+[![Gem Version 0.2.15](https://badge.fury.io/rb/mailchimp_api_v3.svg)](https://rubygems.org/gems/mailchimp_api_v3)
 [![Gem downloads](https://img.shields.io/gem/dt/mailchimp_api_v3.svg)](https://rubygems.org/gems/mailchimp_api_v3)
-[![Build status](https://img.shields.io/circleci/project/Xenapto/mailchimp_api_v3/develop.svg)](https://circleci.com/gh/Xenapto/mailchimp_api_v3)
-[![Code quality](http://img.shields.io/codeclimate/github/Xenapto/mailchimp_api_v3.svg?style=flat)](https://codeclimate.com/github/Xenapto/mailchimp_api_v3)
-[![Coverage](https://img.shields.io/coveralls/Xenapto/mailchimp_api_v3/develop.svg?style=flat)](https://coveralls.io/r/Xenapto/mailchimp_api_v3?branch=develop)
-[![Dependency Status](https://dependencyci.com/github/Xenapto/mailchimp_api_v3/badge)](https://dependencyci.com/github/Xenapto/mailchimp_api_v3)
-[![Security](https://hakiri.io/github/Xenapto/mailchimp_api_v3/develop.svg)](https://hakiri.io/github/Xenapto/mailchimp_api_v3/develop)
-[![Join the chat at https://gitter.im/Xenapto/mailchimp_api_v3](https://badges.gitter.im/Xenapto/mailchimp_api_v3.svg)](https://gitter.im/Xenapto/mailchimp_api_v3?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+[![Build status](https://img.shields.io/circleci/project/dominicsayers/mailchimp_api_v3/develop.svg)](https://circleci.com/gh/dominicsayers/mailchimp_api_v3)
+[![Code quality](http://img.shields.io/codeclimate/github/dominicsayers/mailchimp_api_v3.svg?style=flat)](https://codeclimate.com/github/dominicsayers/mailchimp_api_v3)
+[![Coverage Status](https://coveralls.io/repos/github/dominicsayers/mailchimp_api_v3/badge.svg?branch=develop)](https://coveralls.io/github/dominicsayers/mailchimp_api_v3?branch=develop)
+[![Dependency Status](https://dependencyci.com/github/dominicsayers/mailchimp_api_v3/badge)](https://dependencyci.com/github/dominicsayers/mailchimp_api_v3)
+[![Security](https://hakiri.io/github/dominicsayers/mailchimp_api_v3/develop.svg)](https://hakiri.io/github/dominicsayers/mailchimp_api_v3/develop)
 
-A simple gem to interact with Mailchimp through the Mailchimp API v3
+A simple gem to interact with Mailchimp through the Mailchimp API v3.
+
+### A note on Gibbon
+
+I wrote this gem when [Gibbon](https://github.com/amro/gibbon) did not support Mailchimp's API v3. I believe it now does, and is a more regularly-maintained gem. You are welcome to use my gem but I don't have a great deal of time to deal with issues or enhance it further.
 
 ### Project status
 
@@ -87,7 +90,7 @@ end
 
 ### Contributing
 
-[![Developer](http://img.shields.io/badge/developer-awesome-brightgreen.svg?style=flat)](http://xenapto.com)
+[![Developer](http://img.shields.io/badge/developer-awesome-brightgreen.svg?style=flat)](https://www.dominicsayers.com)
 
 1.  Fork it
 1.  Create your feature branch (`git checkout -b my-new-feature`)

data/circle.yml

@@ -1,7 +1,14 @@
 ---
 machine:
   ruby:
-    version: 2.3.1
+    version: 2.4.0
+dependencies:
+  pre:
+    - echo "export rvm_ignore_gemsets_flag=1" >> ~/.rvmrc
+    - gem update --system
+    - gem install bundler
+  override:
+    - bundle check --path=vendor/bundle || bundle install --path=vendor/bundle --jobs=4 --retry=3 --full-index
 test:
   override:
     - RAILS_ENV=test bundle exec rspec -r rspec_junit_formatter --format RspecJunitFormatter -o $CIRCLE_TEST_REPORTS/rspec/junit.xml:

data/lib/mailchimp_api_v3/client.rb

@@ -24,10 +24,12 @@ module Mailchimp
     def initialize(api_key = nil, extra_headers = {})
       @api_key = api_key || ENV['MAILCHIMP_API_KEY']
 
-      raise(
-        Mailchimp::Exception::APIKeyError,
-        'detail' => "Invalid API key format: #{@api_key}"
-      ) unless api_key_valid?
+      unless api_key_valid?
+        raise(
+          Mailchimp::Exception::APIKeyError,
+          'detail' => "Invalid API key format: #{@api_key}"
+        )
+      end
 
       @extra_headers = extra_headers
       super self, { 'id' => '3.0' }

data/lib/mailchimp_api_v3/client/remote.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+require 'json'
 require 'yaml'
 require 'restclient'
 
@@ -27,7 +28,7 @@ module Mailchimp
 
       def managed_remote(path, method = :get, options = {}, payload = nil)
         headers_and_params = headers.merge params_from(options)
-        YAML.load(naked_remote("#{url_stub}#{path}", method, headers_and_params, payload) || '')
+        YAML.safe_load(naked_remote("#{url_stub}#{path}", method, headers_and_params, payload) || '')
       rescue *RETRY_EXCEPTIONS => e
         @retries ||= 0
         raise e if (@retries += 1) > 3
@@ -37,16 +38,18 @@ module Mailchimp
       end
 
       def managed_remote_exception(e)
-        data = YAML.load(e.http_body) if e.respond_to? :http_body
+        data = YAML.safe_load(e.http_body) if e.respond_to? :http_body
         exception_class_name = e.class.to_s
 
         if Mailchimp::Exception::MAPPED_EXCEPTIONS.key? exception_class_name
           raise Mailchimp::Exception::MAPPED_EXCEPTIONS[exception_class_name], data
-        elsif exception_class_name == 'RestClient::BadRequest'
-          Mailchimp::Exception.parse_invalid_resource_exception data
-        else
-          raise e
         end
+
+        if exception_class_name == Mailchimp::Exception::BAD_REQUEST
+          return Mailchimp::Exception.parse_invalid_resource_exception data
+        end
+
+        raise e
       end
 
       def naked_remote(url, method, headers_and_params, payload = nil)

data/lib/mailchimp_api_v3/exception.rb

@@ -37,5 +37,7 @@ module Mailchimp
       'RestClient::ResourceNotFound' => NotFound,
       'RestClient::Unauthorized' => APIKeyError
     }.freeze
+
+    BAD_REQUEST = 'RestClient::BadRequest'.freeze
   end
 end

data/lib/mailchimp_api_v3/interest.rb

@@ -5,7 +5,7 @@ module Mailchimp
       Interest = Class.new(Instance)
 
       class Interests < Collection
-        PATH_KEY = DATA_KEY = 'interests'
+        PATH_KEY = DATA_KEY = 'interests'.freeze
         CHILD_CLASS = Interest
       end
     end

data/lib/mailchimp_api_v3/interest_category.rb

@@ -10,9 +10,9 @@ module Mailchimp
     end
 
     class InterestCategories < Collection
-      NAME_FIELD = 'title'
-      PATH_KEY = 'interest-categories'
-      DATA_KEY = 'categories'
+      NAME_FIELD = 'title'.freeze
+      PATH_KEY = 'interest-categories'.freeze
+      DATA_KEY = 'categories'.freeze
       CHILD_CLASS = InterestCategory
     end
   end

data/lib/mailchimp_api_v3/list.rb

@@ -16,7 +16,7 @@ module Mailchimp
   end
 
   class Lists < Collection
-    PATH_KEY = DATA_KEY = 'lists'
+    PATH_KEY = DATA_KEY = 'lists'.freeze
     CHILD_CLASS = List
   end
 end

data/lib/mailchimp_api_v3/member.rb

@@ -57,7 +57,7 @@ module Mailchimp
     end
 
     class Members < Collection
-      PATH_KEY = DATA_KEY = 'members'
+      PATH_KEY = DATA_KEY = 'members'.freeze
       CHILD_CLASS = Member
 
       def create(data)

data/lib/mailchimp_api_v3/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Mailchimp
-  VERSION = '0.2.1'
+  VERSION = '0.2.15'.freeze
 end

data/mailchimp_api_v3.gemspec

@@ -6,11 +6,11 @@ require 'mailchimp_api_v3/version'
 Gem::Specification.new do |spec|
   spec.name = 'mailchimp_api_v3'
   spec.version = Mailchimp::VERSION
-  spec.authors = ['Xenapto']
-  spec.email = ['developers@xenapto.com']
+  spec.authors = ['Dominic Sayers']
+  spec.email = ['dominic@sayers.cc']
   spec.description = 'A simple gem to interact with Mailchimp through their API v3'
   spec.summary = 'Example: mailchimp.lists("My first list").member("ann@example.com")'
-  spec.homepage = 'https://github.com/Xenapto/mailchimp_api_v3'
+  spec.homepage = 'https://github.com/dominicsayers/mailchimp_api_v3'
   spec.license = 'BSD-2-Clause'
 
   spec.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
@@ -19,18 +19,4 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'rest-client', '~> 2' # https://github.com/rest-client/rest-client/issues/369
-
-  spec.add_development_dependency 'bundler', '~> 1'
-  spec.add_development_dependency 'rspec', '~> 3'
-  spec.add_development_dependency 'fuubar', '~> 2'
-  spec.add_development_dependency 'rspec_junit_formatter', '~> 0'
-  spec.add_development_dependency 'simplecov', '~> 0'
-  spec.add_development_dependency 'coveralls', '~> 0'
-  spec.add_development_dependency 'vcr', '~> 3'
-  spec.add_development_dependency 'webmock', '~> 2'
-  spec.add_development_dependency 'listen', '~> 3.0', '< 3.1' # Dependency of guard, 3.1 requires Ruby 2.2+
-  spec.add_development_dependency 'guard', '~> 2'
-  spec.add_development_dependency 'guard-rspec', '~> 4'
-  spec.add_development_dependency 'guard-rubocop', '~> 1'
-  spec.add_development_dependency 'gem-release', '~> 0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mailchimp_api_v3
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.15
 platform: ruby
 authors:
-- Xenapto
+- Dominic Sayers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-04 00:00:00.000000000 Z
+date: 2017-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -24,206 +24,18 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3'
-- !ruby/object:Gem::Dependency
-  name: fuubar
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2'
-- !ruby/object:Gem::Dependency
-  name: rspec_junit_formatter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: coveralls
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: vcr
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2'
-- !ruby/object:Gem::Dependency
-  name: listen
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.1'
-- !ruby/object:Gem::Dependency
-  name: guard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2'
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4'
-- !ruby/object:Gem::Dependency
-  name: guard-rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1'
-- !ruby/object:Gem::Dependency
-  name: gem-release
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
 description: A simple gem to interact with Mailchimp through their API v3
 email:
-- developers@xenapto.com
+- dominic@sayers.cc
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".coveralls.yml"
 - ".gitignore"
 - ".hound.yml"
 - ".rspec"
 - ".rubocop.yml"
+- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Guardfile
@@ -274,7 +86,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/api_key.rb
 - spec/support/vcr_setup.rb
-homepage: https://github.com/Xenapto/mailchimp_api_v3
+homepage: https://github.com/dominicsayers/mailchimp_api_v3
 licenses:
 - BSD-2-Clause
 metadata: {}
@@ -294,7 +106,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.4
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: 'Example: mailchimp.lists("My first list").member("ann@example.com")'

data/.coveralls.yml

@@ -1,4 +0,0 @@
-notify:
-  webhooks:
-    # A list of hook hashes, containing the url field
-    - url: https://coveralls.io/webhook?repo_token=SFdYC8cgEnwclAC8K7dzccQ5e16ZBDlPj