mailchimp_api_v3 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8b131d5f8ea61376b71ae54ad06e55ba4d1b4ad2
-  data.tar.gz: 761823e4d92f3d25340294ad43eb30c0398358e9
+  metadata.gz: c5bd68d37be74e00ba3cc25767c6eb284dacbfb6
+  data.tar.gz: 38fdd51235a7defcdc13a26da6f9a062299cd42b
 SHA512:
-  metadata.gz: 74c51582f8b6c2c12b5909120b92bd2e9341ee9fda650373ad26fcdb5bbc3934caf21d4a0aa58303c91ab30f61043f79c2a8a84fe6b0f4b0bf20ab331cd7028d
-  data.tar.gz: 3e7dec641e3cb9f0b4a8502984af84b79c1dcd4857f08ce3e59679ecc4b698c454c2bed44ce6f3ffefdf9581b6c0be09d52e1c7c2b5fcdbfd1076d8b332b146b
+  metadata.gz: da6e188a8a5664611e1d78f3dc046455818d204bc4979d5243421825d9844a872b625dd7e1f854c24e822baac9514a59d9134d18b181aab6c894ef4c00e9aaf7
+  data.tar.gz: 497263a595bfeef764a482f809a096d4af6d5b5cc4dd0afdd1a6c85cebe7b8d1c2e25d66c219b68bc73322157494e10318f7a47a081e05a5d31d2c0b7962f0d1

data/lib/mailchimp_api_v3.rb

@@ -38,6 +38,6 @@ class String
   end
 
   def convert_to_id
-    OpenSSL::Digest.digest('MD5', self.downcase).unpack('H*').first
+    OpenSSL::Digest.digest('MD5', downcase).unpack('H*').first
   end
 end

data/lib/mailchimp_api_v3/client.rb

@@ -23,7 +23,7 @@ module Mailchimp
     def initialize(api_key = nil, extra_headers = {})
       @api_key = api_key || ENV['MAILCHIMP_API_KEY']
 
-      fail(
+      raise(
         Mailchimp::Exception::APIKeyError,
         'detail' => "Invalid API key format: #{@api_key}"
       ) unless api_key_valid?

data/lib/mailchimp_api_v3/client/remote.rb

@@ -22,7 +22,7 @@ module Mailchimp
 
       private
 
-      RETRY_EXCEPTIONS = [SocketError]
+      RETRY_EXCEPTIONS = [SocketError].freeze
 
       def managed_remote(path, method = :get, options = {}, payload = nil)
         headers_and_params = headers.merge params_from(options)
@@ -40,11 +40,11 @@ module Mailchimp
         exception_class_name = e.class.to_s
 
         if Mailchimp::Exception::MAPPED_EXCEPTIONS.key? exception_class_name
-          fail Mailchimp::Exception::MAPPED_EXCEPTIONS[exception_class_name], data
+          raise Mailchimp::Exception::MAPPED_EXCEPTIONS[exception_class_name], data
         elsif exception_class_name == 'RestClient::BadRequest'
           Mailchimp::Exception.parse_invalid_resource_exception data
         else
-          fail e
+          raise e
         end
       end
 

data/lib/mailchimp_api_v3/exception.rb

@@ -3,13 +3,9 @@ module Mailchimp
     def self.parse_invalid_resource_exception(data)
       detail = data['detail']
 
-      if detail.include? 'already'
-        fail Duplicate, data
-      elsif detail.include? 'can\'t be blank'
-        fail MissingField, data
-      else
-        fail BadRequest, data
-      end
+      raise Duplicate, data if detail.include? 'already'
+      raise MissingField, data if detail.include? 'can\'t be blank'
+      raise BadRequest, data
     end
 
     class DataException < RuntimeError
@@ -19,7 +15,11 @@ module Mailchimp
       end
 
       def method_missing(symbol)
-        @data[symbol.id2name]
+        symbol.is_a?(Symbol) ? @data[symbol.id2name] : super
+      end
+
+      def respond_to_missing?(symbol)
+        symbol.is_a?(Symbol)
       end
     end
 
@@ -35,6 +35,6 @@ module Mailchimp
     MAPPED_EXCEPTIONS = {
       'RestClient::ResourceNotFound' => NotFound,
       'RestClient::Unauthorized' => APIKeyError
-    }
+    }.freeze
   end
 end

data/lib/mailchimp_api_v3/instance.rb

@@ -59,6 +59,11 @@ module Mailchimp
       super
     end
 
+    def respond_to_missing?(symbol)
+      key = symbol.id2name
+      @data.key? key
+    end
+
     def subclass_instance_from(collection_class, id)
       child_path = "#{path}/#{collection_class::PATH_KEY}"
       collection_class::CHILD_CLASS.get @client, child_path, id

data/lib/mailchimp_api_v3/interest.rb

@@ -4,7 +4,7 @@ module Mailchimp
       Interest = Class.new(Instance)
 
       class Interests < Collection
-        PATH_KEY = DATA_KEY = 'interests'
+        PATH_KEY = DATA_KEY = 'interests'.freeze
         CHILD_CLASS = Interest
       end
     end

data/lib/mailchimp_api_v3/interest_category.rb

@@ -9,9 +9,9 @@ module Mailchimp
     end
 
     class InterestCategories < Collection
-      NAME_FIELD = 'title'
-      PATH_KEY = 'interest-categories'
-      DATA_KEY = 'categories'
+      NAME_FIELD = 'title'.freeze
+      PATH_KEY = 'interest-categories'.freeze
+      DATA_KEY = 'categories'.freeze
       CHILD_CLASS = InterestCategory
     end
   end

data/lib/mailchimp_api_v3/list.rb

@@ -15,7 +15,7 @@ module Mailchimp
   end
 
   class Lists < Collection
-    PATH_KEY = DATA_KEY = 'lists'
+    PATH_KEY = DATA_KEY = 'lists'.freeze
     CHILD_CLASS = List
   end
 end

data/lib/mailchimp_api_v3/member.rb

@@ -56,7 +56,7 @@ module Mailchimp
     end
 
     class Members < Collection
-      PATH_KEY = DATA_KEY = 'members'
+      PATH_KEY = DATA_KEY = 'members'.freeze
       CHILD_CLASS = Member
 
       def create(data)

data/lib/mailchimp_api_v3/version.rb

@@ -1,3 +1,3 @@
 module Mailchimp
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'.freeze
 end

data/mailchimp_api_v3.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.description = 'A simple gem to interact with Mailchimp through their API v3'
   spec.summary = 'Example: mailchimp.lists("My first list").member("ann@example.com")'
   spec.homepage = 'https://github.com/Xenapto/mailchimp_api_v3'
-  spec.license = 'BSD'
+  spec.license = 'BSD-2-Clause'
 
   spec.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables = spec.files.grep(%r{^bin\/}) { |f| File.basename(f) }

data/spec/mailchimp_api_v3/member_spec.rb

@@ -40,7 +40,7 @@ describe Mailchimp::List::Member, vcr: { cassette_name: 'member' } do
         }
       }
 
-      expect(member.update data).to have_attributes name: 'Ann Example'
+      expect(member.update(data)).to have_attributes name: 'Ann Example'
     end
   end
 end

data/spec/mailchimp_api_v3/members_spec.rb

@@ -82,12 +82,12 @@ describe Mailchimp::List::Members do
         # Update
         data = { first_name: 'Catherine', email_address: 'cat@sayers.cc', status: 'subscribed' }
         expect { members.create_or_update data }.not_to change { list.members.count }
-        expect(members.create_or_update data).to have_attributes name: 'Catherine Sayers'
+        expect(members.create_or_update(data)).to have_attributes name: 'Catherine Sayers'
 
         # Unless we supply an id or equivalent, we won't end up updating anything
         data = { name: 'Catherine Sayers' }
         expect { members.create_or_update data }.not_to change { list.members.count }
-        expect(members.create_or_update data).to have_attributes name: 'Catherine Sayers'
+        expect(members.create_or_update(data)).to have_attributes name: 'Catherine Sayers'
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mailchimp_api_v3
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Xenapto
@@ -260,7 +260,7 @@ files:
 - spec/support/vcr_setup.rb
 homepage: https://github.com/Xenapto/mailchimp_api_v3
 licenses:
-- BSD
+- BSD-2-Clause
 metadata: {}
 post_install_message: 
 rdoc_options: []