mailboxer 0.11.0 → 0.12.0.rc1

data/spec/models/mailboxer_models_messageable_spec.rb

@@ -1,94 +1,94 @@
 require 'spec_helper'
 
 describe "Mailboxer::Models::Messageable through User" do
-  
+
   before do
     @entity1 = FactoryGirl.create(:user)
     @entity2 = FactoryGirl.create(:user)
   end
-  
+
   it "should have a mailbox" do
     assert @entity1.mailbox
   end
-  
+
   it "should be able to send a message" do
     assert @entity1.send_message(@entity2,"Body","Subject")
   end
-  
+
   it "should be able to reply to sender" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     assert @entity2.reply_to_sender(@receipt,"Reply body")
   end
-  
+
   it "should be able to reply to all" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
-    assert @entity2.reply_to_all(@receipt,"Reply body")    
+    assert @entity2.reply_to_all(@receipt,"Reply body")
   end
-  
-  
-  
-  it "should be able to unread an owned Receipt (mark as unread)" do
+
+
+
+  it "should be able to unread an owned Mailboxer::Receipt (mark as unread)" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @receipt.is_read.should==true
     @entity1.mark_as_unread(@receipt)
     @receipt.is_read.should==false
   end
-  
-  it "should be able to read an owned Receipt (mark as read)" do
+
+  it "should be able to read an owned Mailboxer::Receipt (mark as read)" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @receipt.is_read.should==true
     @entity1.mark_as_unread(@receipt)
     @entity1.mark_as_read(@receipt)
     @receipt.is_read.should==true
   end
-  
-  it "should not be able to unread a not owned Receipt (mark as unread)" do
+
+  it "should not be able to unread a not owned Mailboxer::Receipt (mark as unread)" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @receipt.is_read.should==true
     @entity2.mark_as_unread(@receipt) #Should not change
     @receipt.is_read.should==true
   end
-  
-  it "should not be able to read a not owned Receipt (mark as read)" do
+
+  it "should not be able to read a not owned Mailboxer::Receipt (mark as read)" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @receipt.is_read.should==true
     @entity1.mark_as_unread(@receipt) #From read to unread
     @entity2.mark_as_read(@receipt) #Should not change
     @receipt.is_read.should==false
   end
-  
-  it "should be able to trash an owned Receipt" do
+
+  it "should be able to trash an owned Mailboxer::Receipt" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @receipt.trashed.should==false
     @entity1.trash(@receipt)
     @receipt.trashed.should==true
   end
-  
-  it "should be able to untrash an owned Receipt" do
+
+  it "should be able to untrash an owned Mailboxer::Receipt" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @receipt.trashed.should==false
     @entity1.trash(@receipt)
     @entity1.untrash(@receipt)
     @receipt.trashed.should==false
   end
-  
-  it "should not be able to trash a not owned Receipt" do
+
+  it "should not be able to trash a not owned Mailboxer::Receipt" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @receipt.trashed.should==false
     @entity2.trash(@receipt) #Should not change
     @receipt.trashed.should==false
   end
-  
-  it "should not be able to untrash a not owned Receipt" do
+
+  it "should not be able to untrash a not owned Mailboxer::Receipt" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @receipt.trashed.should==false
     @entity1.trash(@receipt) #From read to unread
     @entity2.untrash(@receipt) #Should not change
     @receipt.trashed.should==true
   end
-  
-  
-  
+
+
+
   it "should be able to unread an owned Message (mark as unread)" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @message = @receipt.message
@@ -96,7 +96,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity1.mark_as_unread(@message)
     @message.receipt_for(@entity1).first.is_read.should==false
   end
-  
+
   it "should be able to read an owned Message (mark as read)" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @message = @receipt.message
@@ -105,7 +105,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity1.mark_as_read(@message)
     @message.receipt_for(@entity1).first.is_read.should==true
   end
-  
+
   it "should not be able to unread a not owned Message (mark as unread)" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @message = @receipt.message
@@ -113,7 +113,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity2.mark_as_unread(@message) #Should not change
     @message.receipt_for(@entity1).first.is_read.should==true
   end
-  
+
   it "should not be able to read a not owned Message (mark as read)" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @message = @receipt.message
@@ -122,7 +122,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity2.mark_as_read(@message) #Should not change
     @message.receipt_for(@entity1).first.is_read.should==false
   end
-  
+
   it "should be able to trash an owned Message" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @message = @receipt.message
@@ -130,7 +130,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity1.trash(@message)
     @message.receipt_for(@entity1).first.trashed.should==true
   end
-  
+
   it "should be able to untrash an owned Message" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @message = @receipt.message
@@ -139,7 +139,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity1.untrash(@message)
     @message.receipt_for(@entity1).first.trashed.should==false
   end
-  
+
   it "should not be able to trash a not owned Message" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @message = @receipt.message
@@ -147,7 +147,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity2.trash(@message) #Should not change
     @message.receipt_for(@entity1).first.trashed.should==false
   end
-  
+
   it "should not be able to untrash a not owned Message" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @message = @receipt.message
@@ -167,7 +167,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity1.mark_as_unread(@notification)
     @notification.receipt_for(@entity1).first.is_read.should==false
   end
-  
+
   it "should be able to read an owned Notification (mark as read)" do
     @receipt = @entity1.notify("Subject","Body")
     @notification = @receipt.notification
@@ -175,7 +175,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity1.mark_as_read(@notification)
     @notification.receipt_for(@entity1).first.is_read.should==true
   end
-  
+
   it "should not be able to unread a not owned Notification (mark as unread)" do
     @receipt = @entity1.notify("Subject","Body")
     @notification = @receipt.notification
@@ -184,7 +184,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity2.mark_as_unread(@notification)
     @notification.receipt_for(@entity1).first.is_read.should==true
   end
-  
+
   it "should not be able to read a not owned Notification (mark as read)" do
     @receipt = @entity1.notify("Subject","Body")
     @notification = @receipt.notification
@@ -192,7 +192,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity2.mark_as_read(@notification)
     @notification.receipt_for(@entity1).first.is_read.should==false
   end
-  
+
   it "should be able to trash an owned Notification" do
     @receipt = @entity1.notify("Subject","Body")
     @notification = @receipt.notification
@@ -200,7 +200,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity1.trash(@notification)
     @notification.receipt_for(@entity1).first.trashed.should==true
   end
-  
+
   it "should be able to untrash an owned Notification" do
     @receipt = @entity1.notify("Subject","Body")
     @notification = @receipt.notification
@@ -209,7 +209,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity1.untrash(@notification)
     @notification.receipt_for(@entity1).first.trashed.should==false
   end
-  
+
   it "should not be able to trash a not owned Notification" do
     @receipt = @entity1.notify("Subject","Body")
     @notification = @receipt.notification
@@ -217,7 +217,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity2.trash(@notification)
     @notification.receipt_for(@entity1).first.trashed.should==false
   end
-  
+
   it "should not be able to untrash a not owned Notification" do
     @receipt = @entity1.notify("Subject","Body")
     @notification = @receipt.notification
@@ -226,9 +226,9 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity2.untrash(@notification)
     @notification.receipt_for(@entity1).first.trashed.should==true
   end
-  
-  
-  
+
+
+
   it "should be able to unread an owned Conversation (mark as unread)" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @conversation = @receipt.conversation
@@ -236,7 +236,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity1.mark_as_unread(@conversation)
     @conversation.receipts_for(@entity1).first.is_read.should==false
   end
-  
+
   it "should be able to read an owned Conversation (mark as read)" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @conversation = @receipt.conversation
@@ -245,7 +245,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity1.mark_as_read(@conversation)
     @conversation.receipts_for(@entity1).first.is_read.should==true
   end
-  
+
   it "should not be able to unread a not owned Conversation (mark as unread)" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @conversation = @receipt.conversation
@@ -253,7 +253,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity2.mark_as_unread(@conversation)
     @conversation.receipts_for(@entity1).first.is_read.should==true
   end
-  
+
   it "should not be able to read a not owned Conversation (mark as read)" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @conversation = @receipt.conversation
@@ -262,7 +262,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity2.mark_as_read(@conversation)
     @conversation.receipts_for(@entity1).first.is_read.should==false
   end
-  
+
   it "should be able to trash an owned Conversation" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @conversation = @receipt.conversation
@@ -270,7 +270,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity1.trash(@conversation)
     @conversation.receipts_for(@entity1).first.trashed.should==true
   end
-  
+
   it "should be able to untrash an owned Conversation" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @conversation = @receipt.conversation
@@ -279,7 +279,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity1.untrash(@conversation)
     @conversation.receipts_for(@entity1).first.trashed.should==false
   end
-  
+
   it "should not be able to trash a not owned Conversation" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @conversation = @receipt.conversation
@@ -287,7 +287,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @entity2.trash(@conversation)
     @conversation.receipts_for(@entity1).first.trashed.should==false
   end
-  
+
   it "should not be able to untrash a not owned Conversation" do
     @receipt = @entity1.send_message(@entity2,"Body","Subject")
     @conversation = @receipt.conversation
@@ -302,7 +302,7 @@ describe "Mailboxer::Models::Messageable through User" do
     @conversation = @receipt.conversation
     @conversation.messages.first.attachment_identifier.should=='testfile.txt'
   end
-  
+
   it "should be the same message time as passed" do
     message_time = 5.days.ago
     receipt = @entity1.send_message(@entity2, "Body", "Subject", nil, nil, message_time)

data/spec/models/message_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Message do
+describe Mailboxer::Message do
   
   before do
     @entity1 = FactoryGirl.create(:user)

data/spec/models/notification_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Message do
+describe Mailboxer::Notification do
 
   before do
     @entity1 = FactoryGirl.create(:user)
@@ -8,6 +8,12 @@ describe Message do
     @entity3 = FactoryGirl.create(:user)
   end
 
+  it { should validate_presence_of :subject }
+  it { should validate_presence_of :body }
+
+  it { should ensure_length_of(:subject).is_at_most(Mailboxer.subject_max_length) }
+  it { should ensure_length_of(:body).is_at_most(Mailboxer.body_max_length) }
+
   it "should notify one user" do
     @entity1.notify("Subject", "Body")
 
@@ -41,9 +47,8 @@ describe Message do
   end
 
   it "should notify several users" do
-    recipients = Set.new [@entity1, @entity2, @entity3]
-    Notification.notify_all(recipients, "Subject", "Body")
-
+    recipients = Set.new [@entity1,@entity2,@entity3]
+    Mailboxer::Notification.notify_all(recipients,"Subject","Body")
     #Check getting ALL receipts
     @entity1.mailbox.receipts.size.should==1
     receipt      = @entity1.mailbox.receipts.first
@@ -78,7 +83,7 @@ describe Message do
   end
 
   it "should notify a single recipient" do
-    Notification.notify_all(@entity1, "Subject", "Body")
+    Mailboxer::Notification.notify_all(@entity1,"Subject","Body")
 
     #Check getting ALL receipts
     @entity1.mailbox.receipts.size.should==1
@@ -93,10 +98,37 @@ describe Message do
     notification.subject.should=="Subject"
     notification.body.should=="Body"
   end
-  
+
+  describe "scopes" do
+    let(:scope_user) { FactoryGirl.create(:user) }
+    let!(:notification) { scope_user.notify("Body", "Subject").notification }
+
+    describe ".unread" do
+      it "finds unread notifications" do
+        unread_notification = scope_user.notify("Body", "Subject").notification
+        notification.mark_as_read(scope_user)
+        Mailboxer::Notification.unread.last.should == unread_notification
+      end
+    end
+
+    describe ".expired" do
+      it "finds expired notifications" do
+        notification.update_attributes(expires: 1.day.ago)
+        scope_user.mailbox.notifications.expired.count.should eq(1)
+      end
+    end
+
+    describe ".unexpired" do
+      it "finds unexpired notifications" do
+        notification.update_attributes(expires: 1.day.from_now)
+        scope_user.mailbox.notifications.unexpired.count.should eq(1)
+      end
+    end
+  end
+
   describe "#expire" do
-    subject { Notification.new }
-    
+    subject { described_class.new }
+
     describe "when the notification is already expired" do
       before do
         subject.stub(:expired? => true)
@@ -124,11 +156,11 @@ describe Message do
         subject.expire
       end
     end
-    
+
   end
-  
+
   describe "#expire!" do
-    subject { Notification.new }
+    subject { described_class.new }
 
     describe "when the notification is already expired" do
       before do
@@ -157,44 +189,44 @@ describe Message do
         subject.expire!
       end
     end
-    
+
   end
 
   describe "#expired?" do
-    subject { Notification.new }
+    subject { described_class.new }
     context "when the expiration date is in the past" do
       before { subject.stub(:expires => Time.now - 1.second) }
       it 'should be expired' do
         subject.expired?.should be_true
       end
     end
-    
+
     context "when the expiration date is now" do
       before {
         time = Time.now
         Time.stub(:now => time)
         subject.stub(:expires => time)
       }
-      
+
       it 'should not be expired' do
         subject.expired?.should be_false
       end
     end
-    
+
     context "when the expiration date is in the future" do
       before { subject.stub(:expires => Time.now + 1.second) }
       it 'should not be expired' do
         subject.expired?.should be_false
       end
     end
-    
+
     context "when the expiration date is not set" do
       before {subject.stub(:expires => nil)}
       it 'should not be expired' do
         subject.expired?.should be_false
       end
     end
-    
+
   end
 
 end