mail_room 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 495c36dd61e6ddd5f5a259594d414942055446ad
-  data.tar.gz: 9bb752935c2713d74d9ffb8c0c8b3a57d39f2a1d
+  metadata.gz: 33a01369a37c3598dfcbf688c6d25b24e3bd12fc
+  data.tar.gz: af420b076c8d8b1fe089e6605c430bb2aca738bc
 SHA512:
-  metadata.gz: d8271126e54103017c167bdbd42138284f863481b9dd3b47bae0e490135d04ad70b5cced5221b1fa64320e8e0e36013c9f6540e426573a0164b394bd28492f86
-  data.tar.gz: a5883a201543fec388de4a86f070592def4a1c22345dbc92f6c0aba149bf862c8179f4532483c256ffd706aba471f392622088d8e6fde186e9bfaf4bdac94325
+  metadata.gz: e5947b83f39dbf76e7336fb577a18c2e88708d66ca8aee0348a076fc0af20f4dbdaace44d48ea5e185217d369d3832ed0086180aa9501ce5ebdb77fc482fd78d
+  data.tar.gz: 13303bc00405170552017e5457c5252ac3e7a34eaafa414bb5d47138f6bae93acd7fd3839fbe01288cf5f146dd8483d48e0b00a5cc91bf96fc0e9bef71fecddd

data/CHANGELOG.md

@@ -1,9 +1,16 @@
+## mail_room 0.4.1 ##
+
+* Fix redis default host/port configuration
+* Mailbox does not attempt delivery without a message
+
+    *Douwe Maan <@DouweM>*
+
 ## mail_room 0.4.0 ##
 
 * Sidekiq delivery method
 * Option to delete messages after delivered
 
-    *Douwe Mann <@DouweM>*
+    *Douwe Maan <@DouweM>*
 
 * -q/--quiet do not raise errors on missing configuration
 * prefetch mail messages before idling

data/lib/mail_room/delivery/sidekiq.rb

@@ -9,10 +9,10 @@ module MailRoom
     class Sidekiq
       Options = Struct.new(:redis_url, :namespace, :queue, :worker) do
         def initialize(mailbox)
-          redis_url = mailbox.delivery_options[:redis_url]
+          redis_url = mailbox.delivery_options[:redis_url] || "redis://localhost:6379"
           namespace = mailbox.delivery_options[:namespace]
-          queue     = mailbox.delivery_options[:queue]  || "default"
-          worker    = mailbox.delivery_options[:worker] || "redis://localhost:6379"
+          queue     = mailbox.delivery_options[:queue] || "default"
+          worker    = mailbox.delivery_options[:worker]
 
           super(redis_url, namespace, queue, worker)
         end

data/lib/mail_room/mailbox.rb

@@ -58,7 +58,10 @@ module MailRoom
     # deliver the imap email message
     # @param message [Net::IMAP::FetchData]
     def deliver(message)
-      delivery_klass.new(parsed_delivery_options).deliver(message.attr['RFC822'])
+      message = message.attr['RFC822']
+      return true unless message
+      
+      delivery_klass.new(parsed_delivery_options).deliver(message)
     end
 
     private

data/lib/mail_room/version.rb

@@ -1,4 +1,4 @@
 module MailRoom
   # Current version of MailRoom gem
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

data/spec/lib/mailbox_spec.rb

@@ -49,5 +49,17 @@ describe MailRoom::Mailbox do
         letter_opener.should have_received(:deliver).with('a message')
       end
     end
+
+    context "without an RFC822 attribute" do
+      it "doesn't deliver the message" do
+        mailbox = MailRoom::Mailbox.new({:delivery_method => 'noop'})
+        noop = stub(:deliver)
+        MailRoom::Delivery::Noop.stubs(:new => noop)
+
+        mailbox.deliver(stub(:attr => {'FLAGS' => [:Seen, :Recent]}))
+
+        noop.should have_received(:deliver).never
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mail_room
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Tony Pitale
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-20 00:00:00.000000000 Z
+date: 2015-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake