mail 2.4.4 → 2.5.5

data/lib/mail/elements/address.rb

@@ -5,7 +5,7 @@ module Mail
     include Mail::Utilities
     
     # Mail::Address handles all email addresses in Mail.  It takes an email address string
-    # and parses it, breaking it down into it's component parts and allowing you to get the
+    # and parses it, breaking it down into its component parts and allowing you to get the
     # address, comments, display name, name, local part, domain part and fully formatted
     # address.
     # 
@@ -21,7 +21,7 @@ module Mail
     #  a.comments     #=> ['My email address']
     #  a.to_s         #=> 'Mikel Lindsaar <mikel@test.lindsaar.net> (My email address)'
     def initialize(value = nil)
-      @output_type = nil
+      @output_type = :decode
       @tree = nil
       @raw_text = value
       case
@@ -40,7 +40,7 @@ module Mail
     end
 
     # Returns a correctly formatted address for the email going out.  If given
-    # an incorrectly formatted address as input, Mail::Address will do it's best
+    # an incorrectly formatted address as input, Mail::Address will do its best
     # to format it correctly.  This includes quoting display names as needed and
     # putting the address in angle brackets etc.
     #
@@ -53,8 +53,10 @@ module Mail
         ''
       when display_name
         [quote_phrase(display_name), "<#{address}>", format_comments].compact.join(" ")
-      else
+      when address
         [address, format_comments].compact.join(" ")
+      else
+        tree.text_value
       end
     end
 
@@ -296,6 +298,12 @@ module Mail
         tree.angle_addr.addr_spec.local_part.text_value
       when tree.respond_to?(:addr_spec) && tree.addr_spec.respond_to?(:local_part)
         tree.addr_spec.local_part.text_value
+      when tree.respond_to?(:angle_addr) && tree.angle_addr.respond_to?(:addr_spec) && tree.angle_addr.addr_spec.respond_to?(:local_dot_atom_text)
+        # Ignore local dot atom text when in angle brackets
+        nil
+      when tree.respond_to?(:addr_spec) && tree.addr_spec.respond_to?(:local_dot_atom_text)
+        # Ignore local dot atom text when in angle brackets
+        nil
       else
         tree && tree.respond_to?(:local_part) ? tree.local_part.text_value : nil
       end
@@ -303,4 +311,4 @@ module Mail
     
  
   end
-end
+end

data/lib/mail/elements/envelope_from_element.rb

@@ -26,8 +26,21 @@ module Mail
       @address
     end
     
-    def to_s(*args)
-      "#{@info}; #{@date_time.to_s(*args)}"
+    # RFC 4155:
+    #   a timestamp indicating the UTC date and time when the message
+    #   was originally received, conformant with the syntax of the
+    #   traditional UNIX 'ctime' output sans timezone (note that the
+    #   use of UTC precludes the need for a timezone indicator);
+    def formatted_date_time
+      if @date_time.respond_to?(:ctime)
+        @date_time.ctime
+      else
+        @date_time.strftime '%a %b %e %T %Y'
+      end
+    end
+
+    def to_s
+      "#{@address} #{formatted_date_time}"
     end
     
   end

data/lib/mail/elements.rb

@@ -1,14 +1,14 @@
 module Mail
-  autoload :Address, 'mail/elements/address'
-  autoload :AddressList, 'mail/elements/address_list'
-  autoload :ContentDispositionElement, 'mail/elements/content_disposition_element'
-  autoload :ContentLocationElement, 'mail/elements/content_location_element'
-  autoload :ContentTransferEncodingElement, 'mail/elements/content_transfer_encoding_element'
-  autoload :ContentTypeElement, 'mail/elements/content_type_element'
-  autoload :DateTimeElement, 'mail/elements/date_time_element'
-  autoload :EnvelopeFromElement, 'mail/elements/envelope_from_element'
-  autoload :MessageIdsElement, 'mail/elements/message_ids_element'
-  autoload :MimeVersionElement, 'mail/elements/mime_version_element'
-  autoload :PhraseList, 'mail/elements/phrase_list'
-  autoload :ReceivedElement, 'mail/elements/received_element'
+  register_autoload :Address, 'mail/elements/address'
+  register_autoload :AddressList, 'mail/elements/address_list'
+  register_autoload :ContentDispositionElement, 'mail/elements/content_disposition_element'
+  register_autoload :ContentLocationElement, 'mail/elements/content_location_element'
+  register_autoload :ContentTransferEncodingElement, 'mail/elements/content_transfer_encoding_element'
+  register_autoload :ContentTypeElement, 'mail/elements/content_type_element'
+  register_autoload :DateTimeElement, 'mail/elements/date_time_element'
+  register_autoload :EnvelopeFromElement, 'mail/elements/envelope_from_element'
+  register_autoload :MessageIdsElement, 'mail/elements/message_ids_element'
+  register_autoload :MimeVersionElement, 'mail/elements/mime_version_element'
+  register_autoload :PhraseList, 'mail/elements/phrase_list'
+  register_autoload :ReceivedElement, 'mail/elements/received_element'
 end

data/lib/mail/encodings/quoted_printable.rb

@@ -12,13 +12,14 @@ module Mail
         EightBit.can_encode? str
       end
 
-      # Decode the string from Quoted-Printable
+      # Decode the string from Quoted-Printable. Cope with hard line breaks
+      # that were incorrectly encoded as hex instead of literal CRLF.
       def self.decode(str)
-        str.unpack("M*").first
+        str.gsub(/(?:=0D=0A|=0D|=0A)\r\n/, "\r\n").unpack("M*").first.to_lf
       end
 
       def self.encode(str)
-        [str].pack("M").gsub(/\n/, "\r\n")
+        [str.to_lf].pack("M").to_crlf
       end
 
       def self.cost(str)

data/lib/mail/encodings.rb

@@ -53,7 +53,7 @@ module Mail
     # Encodes a parameter value using URI Escaping, note the language field 'en' can
     # be set using Mail::Configuration, like so:
     #
-    #  Mail.defaults.do
+    #  Mail.defaults do
     #    param_encode_language 'jp'
     #  end
     #
@@ -114,52 +114,49 @@ module Mail
     # String has to be of the format =?<encoding>?[QB]?<string>?=
     def Encodings.value_decode(str)
       # Optimization: If there's no encoded-words in the string, just return it
-      return str unless str.index("=?")
+      return str unless str =~ /\=\?[^?]+\?[QB]\?[^?]+?\?\=/xmi
 
-      str = str.gsub(/\?=(\s*)=\?/, '?==?') # Remove whitespaces between 'encoded-word's
+      lines = collapse_adjacent_encodings(str)
 
       # Split on white-space boundaries with capture, so we capture the white-space as well
-      str.split(/([ \t])/).map do |text|
-        if text.index('=?') .nil?
-          text
-        else
-          # Join QP encoded-words that are adjacent to avoid decoding partial chars
-          text.gsub!(/\?\=\=\?.+?\?[Qq]\?/m, '') if text =~ /\?==\?/
-
-          # Search for occurences of quoted strings or plain strings
-          text.scan(/(                                  # Group around entire regex to include it in matches
-                       \=\?[^?]+\?([QB])\?[^?]+?\?\=  # Quoted String with subgroup for encoding method
-                       |                                # or
-                       .+?(?=\=\?|$)                    # Plain String
-                     )/xmi).map do |matches|
-            string, method = *matches
-            if    method == 'b' || method == 'B'
-              b_value_decode(string)
-            elsif method == 'q' || method == 'Q'
-              q_value_decode(string)
-            else
-              string
+      lines.map do |line|
+        line.split(/([ \t])/).map do |text|
+          if text.index('=?').nil?
+            text
+          else
+            # Search for occurences of quoted strings or plain strings
+            text.scan(/(                                 # Group around entire regex to include it in matches
+                        \=\?[^?]+\?([QB])\?[^?]+?\?\=    # Quoted String with subgroup for encoding method
+                        |                                # or
+                        .+?(?=\=\?|$)                    # Plain String
+                      )/xmi).map do |matches|
+              string, method = *matches
+              if    method == 'b' || method == 'B'
+                b_value_decode(string)
+              elsif method == 'q' || method == 'Q'
+                q_value_decode(string)
+              else
+                string
+              end
             end
           end
         end
-      end.join("")
+      end.flatten.join("")
     end
 
     # Takes an encoded string of the format =?<encoding>?[QB]?<string>?=
     def Encodings.unquote_and_convert_to(str, to_encoding)
-      original_encoding = split_encoding_from_string( str )
-
-      output = value_decode( str ).to_s
+      output = value_decode( str ).to_s # output is already converted to UTF-8
 
-      if original_encoding.to_s.downcase.gsub("-", "") == to_encoding.to_s.downcase.gsub("-", "")
+      if 'utf8' == to_encoding.to_s.downcase.gsub("-", "")
         output
-      elsif original_encoding && to_encoding
+      elsif to_encoding
         begin
           if RUBY_VERSION >= '1.9'
             output.encode(to_encoding)
           else
             require 'iconv'
-            Iconv.iconv(to_encoding, original_encoding, output).first
+            Iconv.iconv(to_encoding, 'UTF-8', output).first
           end
         rescue Iconv::IllegalSequence, Iconv::InvalidEncoding, Errno::EINVAL
           # the 'from' parameter specifies a charset other than what the text
@@ -178,10 +175,10 @@ module Mail
     def Encodings.address_encode(address, charset = 'utf-8')
       if address.is_a?(Array)
         # loop back through for each element
-        address.map { |a| Encodings.address_encode(a, charset) }.join(", ")
+        address.compact.map { |a| Encodings.address_encode(a, charset) }.join(", ")
       else
         # find any word boundary that is not ascii and encode it
-        encode_non_usascii(address, charset)
+        encode_non_usascii(address, charset) if address
       end
     end
 
@@ -189,15 +186,15 @@ module Mail
       return address if address.ascii_only? or charset.nil?
       us_ascii = %Q{\x00-\x7f}
       # Encode any non usascii strings embedded inside of quotes
-      address.gsub!(/(".*?[^#{us_ascii}].*?")/) { |s| Encodings.b_value_encode(unquote(s), charset) }
+      address = address.gsub(/(".*?[^#{us_ascii}].*?")/) { |s| Encodings.b_value_encode(unquote(s), charset) }
       # Then loop through all remaining items and encode as needed
       tokens = address.split(/\s/)
       map_with_index(tokens) do |word, i|
         if word.ascii_only?
           word
         else
-          previous_non_ascii = tokens[i-1] && !tokens[i-1].ascii_only?
-          if previous_non_ascii
+          previous_non_ascii = i>0 && tokens[i-1] && !tokens[i-1].ascii_only?
+          if previous_non_ascii #why are we adding an extra space here?
             word = " #{word}"
           end
           Encodings.b_value_encode(word, charset)
@@ -270,5 +267,39 @@ module Mail
     def Encodings.find_encoding(str)
       RUBY_VERSION >= '1.9' ? str.encoding : $KCODE
     end
+
+    # Gets the encoding type (Q or B) from the string.
+    def Encodings.split_value_encoding_from_string(str)
+      match = str.match(/\=\?[^?]+?\?([QB])\?(.+)?\?\=/mi)
+      if match
+        match[1]
+      else
+        nil
+      end
+    end
+
+    # When the encoded string consists of multiple lines, lines with the same
+    # encoding (Q or B) can be joined together.
+    #
+    # String has to be of the format =?<encoding>?[QB]?<string>?=
+    def Encodings.collapse_adjacent_encodings(str)
+      lines = str.split(/(\?=)\s*(=\?)/).each_slice(2).map(&:join)
+      results = []
+      previous_encoding = nil
+
+      lines.each do |line|
+        encoding = split_value_encoding_from_string(line)
+
+        if encoding == previous_encoding
+          line = results.pop + line
+          line.gsub!(/\?\=\=\?.+?\?[QqBb]\?/m, '')
+        end
+
+        previous_encoding = encoding
+        results << line
+      end
+
+      results
+    end
   end
 end

data/lib/mail/field.rb

@@ -5,11 +5,11 @@ module Mail
   # Provides a single class to call to create a new structured or unstructured
   # field.  Works out per RFC what field of field it is being given and returns
   # the correct field of class back on new.
-  # 
+  #
   # ===Per RFC 2822
-  #  
+  #
   #  2.2. Header Fields
-  #  
+  #
   #     Header fields are lines composed of a field name, followed by a colon
   #     (":"), followed by a field body, and terminated by CRLF.  A field
   #     name MUST be composed of printable US-ASCII characters (i.e.,
@@ -19,12 +19,12 @@ module Mail
   #     used in header "folding" and  "unfolding" as described in section
   #     2.2.3.  All field bodies MUST conform to the syntax described in
   #     sections 3 and 4 of this standard.
-  #  
+  #
   class Field
-    
+
     include Patterns
     include Comparable
-    
+
     STRUCTURED_FIELDS = %w[ bcc cc content-description content-disposition
                             content-id content-location content-transfer-encoding
                             content-type date from in-reply-to keywords message-id
@@ -34,7 +34,39 @@ module Mail
                             return-path sender to ]
 
     KNOWN_FIELDS = STRUCTURED_FIELDS + ['comments', 'subject']
-    
+
+    FIELDS_MAP = {
+      "to" => ToField,
+      "cc" => CcField,
+      "bcc" => BccField,
+      "message-id" => MessageIdField,
+      "in-reply-to" => InReplyToField,
+      "references" => ReferencesField,
+      "subject" => SubjectField,
+      "comments" => CommentsField,
+      "keywords" => KeywordsField,
+      "date" => DateField,
+      "from" => FromField,
+      "sender" => SenderField,
+      "reply-to" => ReplyToField,
+      "resent-date" => ResentDateField,
+      "resent-from" => ResentFromField,
+      "resent-sender" =>  ResentSenderField,
+      "resent-to" => ResentToField,
+      "resent-cc" => ResentCcField,
+      "resent-bcc" => ResentBccField,
+      "resent-message-id" => ResentMessageIdField,
+      "return-path" => ReturnPathField,
+      "received" => ReceivedField,
+      "mime-version" => MimeVersionField,
+      "content-transfer-encoding" => ContentTransferEncodingField,
+      "content-description" => ContentDescriptionField,
+      "content-disposition" => ContentDispositionField,
+      "content-type" => ContentTypeField,
+      "content-id" => ContentIdField,
+      "content-location" => ContentLocationField,
+    }
+
     # Generic Field Exception
     class FieldError < StandardError
     end
@@ -55,25 +87,25 @@ module Mail
     # Raised when attempting to set a structured field's contents to an invalid syntax
     class SyntaxError < FieldError #:nodoc:
     end
-    
+
     # Accepts a string:
-    # 
+    #
     #  Field.new("field-name: field data")
-    # 
+    #
     # Or name, value pair:
-    # 
+    #
     #  Field.new("field-name", "value")
-    # 
+    #
     # Or a name by itself:
-    # 
+    #
     #  Field.new("field-name")
-    # 
+    #
     # Note, does not want a terminating carriage return.  Returns
     # self appropriately parsed.  If value is not a string, then
     # it will be passed through as is, for example, content-type
-    # field can accept an array with the type and a hash of 
+    # field can accept an array with the type and a hash of
     # parameters:
-    # 
+    #
     #  Field.new('content-type', ['text', 'plain', {:charset => 'UTF-8'}])
     def initialize(name, value = nil, charset = 'utf-8')
       case
@@ -92,47 +124,49 @@ module Mail
     def field=(value)
       @field = value
     end
-    
+
     def field
       @field
     end
-    
+
     def name
       field.name
     end
-    
+
     def value
       field.value
     end
-    
+
     def value=(val)
       create_field(name, val, charset)
     end
-    
+
     def to_s
       field.to_s
     end
-    
+
     def update(name, value)
       create_field(name, value, charset)
     end
-    
+
     def same( other )
       match_to_s(other.name, field.name)
     end
-    
+
     alias_method :==, :same
-    
+
     def <=>( other )
-      self_order = FIELD_ORDER.rindex(self.name.to_s.downcase) || 100
-      other_order = FIELD_ORDER.rindex(other.name.to_s.downcase) || 100
-      self_order <=> other_order
+      self.field_order_id <=> other.field_order_id
+    end
+
+    def field_order_id
+      @field_order_id ||= (FIELD_ORDER_LOOKUP[self.name.to_s.downcase] || 100)
     end
-    
+
     def method_missing(name, *args, &block)
       field.send(name, *args, &block)
     end
-    
+
     FIELD_ORDER = %w[ return-path received
                       resent-date resent-from resent-sender resent-to
                       resent-cc resent-bcc resent-message-id
@@ -141,16 +175,18 @@ module Mail
                       subject comments keywords
                       mime-version content-type content-transfer-encoding
                       content-location content-disposition content-description ]
-    
+
+    FIELD_ORDER_LOOKUP = Hash[FIELD_ORDER.each_with_index.to_a]
+
     private
-    
+
     def split(raw_field)
-      match_data = raw_field.mb_chars.match(/^(#{FIELD_NAME})\s*:\s*(#{FIELD_BODY})?$/)
+      match_data = raw_field.mb_chars.match(FIELD_SPLIT)
       [match_data[1].to_s.mb_chars.strip, match_data[2].to_s.mb_chars.strip]
     rescue
-      STDERR.puts "WARNING: Could not parse (and so ignorning) '#{raw_field}'"
+      STDERR.puts "WARNING: Could not parse (and so ignoring) '#{raw_field}'"
     end
-    
+
     def create_field(name, value, charset)
       begin
         self.field = new_field(name, value, charset)
@@ -162,73 +198,14 @@ module Mail
     end
 
     def new_field(name, value, charset)
-      # Could do this with constantize and make it "as DRY as", but a simple case 
-      # statement is, well, simpler... 
-      case name.to_s.downcase
-      when /^to$/i
-        ToField.new(value, charset)
-      when /^cc$/i
-        CcField.new(value, charset)
-      when /^bcc$/i
-        BccField.new(value, charset)
-      when /^message-id$/i
-        MessageIdField.new(value, charset)
-      when /^in-reply-to$/i
-        InReplyToField.new(value, charset)
-      when /^references$/i
-        ReferencesField.new(value, charset)
-      when /^subject$/i
-        SubjectField.new(value, charset)
-      when /^comments$/i
-        CommentsField.new(value, charset)
-      when /^keywords$/i
-        KeywordsField.new(value, charset)
-      when /^date$/i
-        DateField.new(value, charset)
-      when /^from$/i
-        FromField.new(value, charset)
-      when /^sender$/i
-        SenderField.new(value, charset)
-      when /^reply-to$/i
-        ReplyToField.new(value, charset)
-      when /^resent-date$/i
-        ResentDateField.new(value, charset)
-      when /^resent-from$/i
-        ResentFromField.new(value, charset)
-      when /^resent-sender$/i 
-        ResentSenderField.new(value, charset)
-      when /^resent-to$/i
-        ResentToField.new(value, charset)
-      when /^resent-cc$/i
-        ResentCcField.new(value, charset)
-      when /^resent-bcc$/i
-        ResentBccField.new(value, charset)
-      when /^resent-message-id$/i
-        ResentMessageIdField.new(value, charset)
-      when /^return-path$/i
-        ReturnPathField.new(value, charset)
-      when /^received$/i
-        ReceivedField.new(value, charset)
-      when /^mime-version$/i
-        MimeVersionField.new(value, charset)
-      when /^content-transfer-encoding$/i
-        ContentTransferEncodingField.new(value, charset)
-      when /^content-description$/i
-        ContentDescriptionField.new(value, charset)
-      when /^content-disposition$/i
-        ContentDispositionField.new(value, charset)
-      when /^content-type$/i
-        ContentTypeField.new(value, charset)
-      when /^content-id$/i
-        ContentIdField.new(value, charset)
-      when /^content-location$/i
-        ContentLocationField.new(value, charset)
-      else 
+      lower_case_name = name.to_s.downcase
+      if field_klass = FIELDS_MAP[lower_case_name]
+        field_klass.new(value, charset)
+      else
         OptionalField.new(name, value, charset)
       end
-      
     end
 
   end
-  
+
 end

data/lib/mail/fields/bcc_field.rb

@@ -6,7 +6,7 @@
 # field in the email.
 # 
 # Sending bcc to a mail message will instantiate a Mail::Field object that
-# has a BccField as it's field type.  This includes all Mail::CommonAddress
+# has a BccField as its field type.  This includes all Mail::CommonAddress
 # module instance metods.
 # 
 # Only one Bcc field can appear in a header, though it can have multiple
@@ -16,7 +16,7 @@
 # 
 #  mail = Mail.new
 #  mail.bcc = 'Mikel Lindsaar <mikel@test.lindsaar.net>, ada@test.lindsaar.net'
-#  mail.bcc    #=> ['Mikel Lindsaar <mikel@test.lindsaar.net>', 'ada@test.lindsaar.net']
+#  mail.bcc    #=> ['mikel@test.lindsaar.net', 'ada@test.lindsaar.net']
 #  mail[:bcc]  #=> '#<Mail::Field:0x180e5e8 @field=#<Mail::BccField:0x180e1c4
 #  mail['bcc'] #=> '#<Mail::Field:0x180e5e8 @field=#<Mail::BccField:0x180e1c4
 #  mail['Bcc'] #=> '#<Mail::Field:0x180e5e8 @field=#<Mail::BccField:0x180e1c4

data/lib/mail/fields/cc_field.rb

@@ -6,7 +6,7 @@
 # field in the email.
 # 
 # Sending cc to a mail message will instantiate a Mail::Field object that
-# has a CcField as it's field type.  This includes all Mail::CommonAddress
+# has a CcField as its field type.  This includes all Mail::CommonAddress
 # module instance metods.
 # 
 # Only one Cc field can appear in a header, though it can have multiple
@@ -16,7 +16,7 @@
 # 
 #  mail = Mail.new
 #  mail.cc = 'Mikel Lindsaar <mikel@test.lindsaar.net>, ada@test.lindsaar.net'
-#  mail.cc    #=> ['Mikel Lindsaar <mikel@test.lindsaar.net>', 'ada@test.lindsaar.net']
+#  mail.cc    #=> ['mikel@test.lindsaar.net', 'ada@test.lindsaar.net']
 #  mail[:cc]  #=> '#<Mail::Field:0x180e5e8 @field=#<Mail::CcField:0x180e1c4
 #  mail['cc'] #=> '#<Mail::Field:0x180e5e8 @field=#<Mail::CcField:0x180e1c4
 #  mail['Cc'] #=> '#<Mail::Field:0x180e5e8 @field=#<Mail::CcField:0x180e1c4

data/lib/mail/fields/comments_field.rb

@@ -6,7 +6,7 @@
 # header field in the email.
 # 
 # Sending comments to a mail message will instantiate a Mail::Field object that
-# has a CommentsField as it's field type.
+# has a CommentsField as its field type.
 #  
 # An email header can have as many comments fields as it wants.  There is no upper
 # limit, the comments field is also optional (that is, no comment is needed)

data/lib/mail/fields/common/common_address.rb

@@ -62,7 +62,17 @@ module Mail
   
     # Returns the addresses that are part of groups
     def group_addresses
-      groups.map { |k,v| v.map { |a| a.format } }.flatten
+      decoded_group_addresses
+    end
+
+    # Returns a list of decoded group addresses
+    def decoded_group_addresses
+      groups.map { |k,v| v.map { |a| a.decoded } }.flatten
+    end
+
+    # Returns a list of encoded group addresses
+    def encoded_group_addresses
+      groups.map { |k,v| v.map { |a| a.encoded } }.flatten
     end
 
     # Returns the name of all the groups in a string
@@ -81,15 +91,20 @@ module Mail
       when val.blank?
         parse(encoded)
       else
-        parse((formatted + [val]).join(", "))
+        self.value = [self.value, val].reject {|a| a.blank? }.join(", ")
       end
     end
+
+    def value=(val)
+      super
+      parse(self.value)
+    end
   
     private
   
     def do_encode(field_name)
       return '' if value.blank?
-      address_array = tree.addresses.reject { |a| group_addresses.include?(a.encoded) }.compact.map { |a| a.encoded }
+      address_array = tree.addresses.reject { |a| encoded_group_addresses.include?(a.encoded) }.compact.map { |a| a.encoded }
       address_text  = address_array.join(", \r\n\s")
       group_array = groups.map { |k,v| "#{k}: #{v.map { |a| a.encoded }.join(", \r\n\s")};" }
       group_text  = group_array.join(" \r\n\s")
@@ -99,7 +114,7 @@ module Mail
 
     def do_decode
       return nil if value.blank?
-      address_array = tree.addresses.reject { |a| group_addresses.include?(a.decoded) }.map { |a| a.decoded }
+      address_array = tree.addresses.reject { |a| decoded_group_addresses.include?(a.decoded) }.map { |a| a.decoded }
       address_text  = address_array.join(", ")
       group_array = groups.map { |k,v| "#{k}: #{v.map { |a| a.decoded }.join(", ")};" }
       group_text  = group_array.join(" ")