maid 0.10.0.pre.alpha.2 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8d0fa40b9069dd973a12021c729407e1f98719ea96e8ede17aff4426cd8d9eb
-  data.tar.gz: ed334d76e2cdc9ba723e600a6f371efab241ea24c080e7009425dee9a99d52f4
+  metadata.gz: 386fffc38404ce847ae5650376f84be904056ad5d6acd86cea9311cedade94c1
+  data.tar.gz: 49c5f4a3b21d583d2edd09d73d862c495c2e8d5eb36c510401bc5ff216316c57
 SHA512:
-  metadata.gz: 4be4e2a2771566d670b9b7a5d5966c334e3ca58c7c204dab7182654821b47b6076dc2ceb0e880de1a2e6966f110fee7422d289ffa058c9ba6861287afd2f60be
-  data.tar.gz: 124d6e7f02282b4772b4a849acfad62efdc3277c08ea0696cd32b57672e199104bf314e53b609c47960e026b2073f4aba55d441de5061600fa9f499f9e90ceae
+  metadata.gz: 334f18ddb7a90a62a6b3c6136930c1724e08358ab7fb0dcca7011570b1b93bffa24958a07756c52f303f617aeea8cc02142d4d6163b75cfeaad3b71c32aeb34e
+  data.tar.gz: 397ca948024144b6beaa7f7139df13a66ff84b2240a3ffd8a716d67286334f5e3da6520e25e6d5df2ba8a3e5f8f417ec64fd29e42f4a955ef5fb24471b3a7dc3

data/.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,37 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: "<Short description of the issue>"
+labels: bug
+assignees: ''
+
+---
+
+**👋 Before reporting a bug, please make sure you're running the latest available version of maid (`gem install maid`).**
+
+**👋 If you're using Ruby 2.7+, please make sure you're running maid v0.10.0+ (`gem install maid --pre`)**
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to trigger the issue.
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Logs**
+If applicable, add logs to help explain your problem. You can find the logs at `~/.maid/maid.log`.
+
+**Environment (please complete the information):**
+- Maid version (`maid --version`): `<enter the command's output here>`
+- OS, distribution (Linux), and version: <examples: OSX 12.0.0/Linux Mint 20.3>
+- Ruby version (`ruby --version`): `<enter the command's output here>`
+
+**Minimal `rules.rb` to reproduce the issue:**
+```ruby
+# Rule(s)
+```
+
+**Additional context**
+Add any other context about the problem here.

data/.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: feature
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

data/.github/workflows/release.yml

@@ -38,8 +38,8 @@ jobs:
           token: ${{ secrets.BOT_GH_TOKEN }}
           # Uncomment for pre-releases, see
           # https://github.com/maid/maid/wiki/Release-Process
-          prerelease: true
-          release-as: v0.10.0-alpha.2
+          # prerelease: true
+          # release-as: v0.10.0-alpha.3
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "0.10.0-alpha.2"
+  ".": "0.10.0"
 }

data/.rubocop_todo.yml

@@ -66,7 +66,7 @@ Metrics/MethodLength:
 # Offense count: 4
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 711
+  Max: 753
 
 # Offense count: 2
 # Configuration parameters: AllowedMethods, AllowedPatterns.

data/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## [0.10.0](https://github.com/maid/maid/compare/v0.10.0-alpha.3...v0.10.0) (2023-05-01)
+
+
+### Miscellaneous Chores
+
+* release 0.10.0 ([1f35afd](https://github.com/maid/maid/commit/1f35afd2030bd74a5175ced5cd9766273162dea4))
+
+## [0.10.0-alpha.3](https://github.com/maid/maid/compare/v0.10.0-alpha.2...v0.10.0-alpha.3) (2023-04-04)
+
+
+### Features
+
+* **maid:** improve `#watch` error message ([#287](https://github.com/maid/maid/issues/287)) ([0894cd6](https://github.com/maid/maid/commit/0894cd69665d5d9fe775b6b3df5a247f22f217d6))
+* **tools:** add option to disable clobbering destination for `#move` ([#284](https://github.com/maid/maid/issues/284)) ([979413f](https://github.com/maid/maid/commit/979413fe284b61b43b33ba2169e72ed23043bcca))
+
 ## [0.10.0-alpha.2](https://github.com/maid/maid/compare/v0.10.0-alpha.1...v0.10.0-alpha.2) (2023-03-28)
 
 

data/Rakefile

@@ -2,6 +2,7 @@ require 'bundler'
 require 'rake'
 require 'rspec/core/rake_task'
 require 'yard'
+require 'rake/notes/rake_task'
 
 task default: :spec
 

data/SECURITY.md

@@ -0,0 +1,29 @@
+# Security Policy
+
+## Supported Versions
+
+### Maid gem
+| Version      | Supported          |
+| ------------ | ------------------ |
+| >= 0.10.0    | :heavy_check_mark: |
+|    0.7.0     | :heavy_check_mark: |
+| <  0.7.0     | :x:                |
+
+### Ruby
+| Version      | Supported          |
+| ------------ | ------------------ |
+| >= 3.0       | :heavy_check_mark: |
+|    2.7       | :warning:          |
+| <= 2.6       | :x:                |
+
+> :warning: Ruby 2.7 became EOL on 2023-03-31 and might be dropped in the near
+> future. We strongly recommend using Ruby 3+. 
+
+## Reporting a Vulnerability
+
+To report a vulnerability, please open an issue. We will investigate and
+respond in a timely manner.
+
+If the vulnerability is accepted, we will work on a patch. Bear in mind that
+this is a community effort and we can't commit to specific timeframes other
+than best effort.

data/fixtures/vcr_cassettes/Dependency_expectations/Geocoder/translates_latitude_and_longitude_into_street_addresses.yml

@@ -0,0 +1,42 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://nominatim.openstreetmap.org/reverse?accept-language=en&addressdetails=1&format=json&lat=-33.85608611111111&lon=151.219925
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Fri, 21 Apr 2023 12:28:49 GMT
+      Content-Type:
+      - application/json; charset=UTF-8
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      Keep-Alive:
+      - timeout=20
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Methods:
+      - OPTIONS,GET
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        eyJwbGFjZV9pZCI6Mjk4ODA4MzUxLCJsaWNlbmNlIjoiRGF0YSDCqSBPcGVuU3RyZWV0TWFwIGNvbnRyaWJ1dG9ycywgT0RiTCAxLjAuIGh0dHBzOi8vb3NtLm9yZy9jb3B5cmlnaHQiLCJvc21fdHlwZSI6InJlbGF0aW9uIiwib3NtX2lkIjo5NTk5NzIzLCJsYXQiOiItMzMuODU2Mzc3NjUiLCJsb24iOiIxNTEuMjE1NTcxODMwNzQ1MDYiLCJkaXNwbGF5X25hbWUiOiJOb3J0aGVybiBCb2FyZHdhbGssIFF1YXkgUXVhcnRlciwgU3lkbmV5LCBDb3VuY2lsIG9mIHRoZSBDaXR5IG9mIFN5ZG5leSwgTmV3IFNvdXRoIFdhbGVzLCAyMDAwLCBBdXN0cmFsaWEiLCJhZGRyZXNzIjp7InJvYWQiOiJOb3J0aGVybiBCb2FyZHdhbGsiLCJuZWlnaGJvdXJob29kIjoiUXVheSBRdWFydGVyIiwic3VidXJiIjoiU3lkbmV5IiwiY2l0eSI6IlN5ZG5leSIsIm11bmljaXBhbGl0eSI6IkNvdW5jaWwgb2YgdGhlIENpdHkgb2YgU3lkbmV5Iiwic3RhdGUiOiJOZXcgU291dGggV2FsZXMiLCJJU08zMTY2LTItbHZsNCI6IkFVLU5TVyIsInBvc3Rjb2RlIjoiMjAwMCIsImNvdW50cnkiOiJBdXN0cmFsaWEiLCJjb3VudHJ5X2NvZGUiOiJhdSJ9LCJib3VuZGluZ2JveCI6WyItMzMuODU2Njc0MiIsIi0zMy44NTYxMDk2IiwiMTUxLjIxNDU1NzkiLCIxNTEuMjE1OTA4NCJdfQ==
+  recorded_at: Fri, 21 Apr 2023 12:28:49 GMT
+recorded_with: VCR 6.1.0

data/fixtures/vcr_cassettes/Maid_Tools/_location_city/given_a_JPEG_image/reports_the_known_location.yml

@@ -0,0 +1,42 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://nominatim.openstreetmap.org/reverse?accept-language=en&addressdetails=1&format=json&lat=-33.85608611111111&lon=151.219925
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Fri, 21 Apr 2023 12:29:51 GMT
+      Content-Type:
+      - application/json; charset=UTF-8
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      Keep-Alive:
+      - timeout=20
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Methods:
+      - OPTIONS,GET
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        eyJwbGFjZV9pZCI6Mjk4ODA4MzUxLCJsaWNlbmNlIjoiRGF0YSDCqSBPcGVuU3RyZWV0TWFwIGNvbnRyaWJ1dG9ycywgT0RiTCAxLjAuIGh0dHBzOi8vb3NtLm9yZy9jb3B5cmlnaHQiLCJvc21fdHlwZSI6InJlbGF0aW9uIiwib3NtX2lkIjo5NTk5NzIzLCJsYXQiOiItMzMuODU2Mzc3NjUiLCJsb24iOiIxNTEuMjE1NTcxODMwNzQ1MDYiLCJkaXNwbGF5X25hbWUiOiJOb3J0aGVybiBCb2FyZHdhbGssIFF1YXkgUXVhcnRlciwgU3lkbmV5LCBDb3VuY2lsIG9mIHRoZSBDaXR5IG9mIFN5ZG5leSwgTmV3IFNvdXRoIFdhbGVzLCAyMDAwLCBBdXN0cmFsaWEiLCJhZGRyZXNzIjp7InJvYWQiOiJOb3J0aGVybiBCb2FyZHdhbGsiLCJuZWlnaGJvdXJob29kIjoiUXVheSBRdWFydGVyIiwic3VidXJiIjoiU3lkbmV5IiwiY2l0eSI6IlN5ZG5leSIsIm11bmljaXBhbGl0eSI6IkNvdW5jaWwgb2YgdGhlIENpdHkgb2YgU3lkbmV5Iiwic3RhdGUiOiJOZXcgU291dGggV2FsZXMiLCJJU08zMTY2LTItbHZsNCI6IkFVLU5TVyIsInBvc3Rjb2RlIjoiMjAwMCIsImNvdW50cnkiOiJBdXN0cmFsaWEiLCJjb3VudHJ5X2NvZGUiOiJhdSJ9LCJib3VuZGluZ2JveCI6WyItMzMuODU2Njc0MiIsIi0zMy44NTYxMDk2IiwiMTUxLjIxNDU1NzkiLCIxNTEuMjE1OTA4NCJdfQ==
+  recorded_at: Fri, 21 Apr 2023 12:29:51 GMT
+recorded_with: VCR 6.1.0

data/lib/maid/maid.rb

@@ -88,6 +88,15 @@ class Maid::Maid
   end
 
   def watch(path, options = {}, &block)
+    full_path = File.expand_path(path)
+
+    unless File.directory?(full_path)
+      message = "#{full_path} cannot be a file and it must exist in order to watch it"
+
+      warn(message)
+      raise message
+    end
+
     @watches << ::Maid::Watch.new(self, path, options, &block)
   end
 
@@ -140,7 +149,7 @@ class Maid::Maid
   def default_trash_path
     # TODO: Refactor module declaration so this can be `Platform`
     if Maid::Platform.linux?
-      # See the [FreeDesktop.org Trash specification](http://www.ramendik.ru/docs/trashspec.html)
+      # See the [FreeDesktop.org Trash specification](https://archive.is/cXir4)
       path = "#{XDG['DATA_HOME']}/Trash/files"
     elsif Maid::Platform.osx?
       path = File.expand_path('~/.Trash')

data/lib/maid/tools.rb

@@ -24,33 +24,50 @@ module Maid::Tools
   # For showing deprecation notices
   include Deprecated
 
-  # Move `sources` to a `destination` directory.
+  # Moves `sources` file(s) to a `destination` directory.
   #
   # Movement is only allowed to directories that already exist.  If your
   # intention is to rename, see the `rename` method.
   #
-  # ## Examples
-  #
-  # Single path:
-  #
-  #     move('~/Downloads/foo.zip', '~/Archive/Software/Mac OS X/')
-  #
-  # Multiple paths:
-  #
-  #     move(['~/Downloads/foo.zip', '~/Downloads/bar.zip'], '~/Archive/Software/Mac OS X/')
-  #     move(dir('~/Downloads/*.zip'), '~/Archive/Software/Mac OS X/')
-  def move(sources, destination)
-    expanded_destination = expand(destination)
-
-    if File.directory?(expanded_destination)
+  # @example Single source file
+  #   move('~/Downloads/foo.zip', '~/Archive/Software/Mac OS X/')
+  #
+  # @example Multiple source files
+  #   move(['~/Downloads/foo.zip', '~/Downloads/bar.zip'],
+  #   '~/Archive/Software/Mac OS X/')
+  #   move(dir('~/Downloads/*.zip'), '~/Archive/Software/Mac OS X/')
+  #
+  # @example Overwrite destination file if it already exists
+  #   move('~/Downloads/foo.zip', '~/Archive/Software/Mac OS X/')
+  #   move('~/Downloads/foo.zip', '~/Archive/Software/Mac OS X/', clobber:
+  #   true)
+  #
+  # @example Skip file if it already exists at destination
+  #   move('~/Downloads/foo.zip', '~/Archive/Software/Mac OS X/', clobber:
+  #   false)
+  #
+  # @param sources [String, Array<String>] the paths to the source files to
+  # move
+  # @param destination_dir [String] path of the directory where to move
+  # `sources` to
+  # @param [Hash] kwargs the arguments to modify behaviour
+  # @option kwargs [Boolean] :clobber (true) `true` to overwrite destination
+  # file if it exists, `false` to skip moving file if it exists
+  def move(sources, destination_dir, clobber: true)
+    expanded_destination_dir = expand(destination_dir)
+
+    if File.directory?(expanded_destination_dir)
       expand_all(sources).each do |source|
-        log("move #{sh_escape(source)} #{sh_escape(expanded_destination)}")
-        FileUtils.mv(source, expanded_destination, **@file_options)
+        log("move #{sh_escape(source)} #{sh_escape(expanded_destination_dir)}")
+
+        unless skip_move?(source, expanded_destination_dir, clobber)
+          FileUtils.mv(source, expanded_destination_dir, **@file_options)
+        end
       end
     else
       # Unix `mv` warns about the target not being a directory with multiple sources.  Maid checks the same.
-      warn("skipping move because #{sh_escape(expanded_destination)} is not a" \
-           "directory (use 'mkdir' to create first, or use 'rename')")
+      warn("skipping move because #{sh_escape(expanded_destination_dir)} " \
+           "is not a directory (use 'mkdir' to create first, or use 'rename')")
     end
   end
 
@@ -1006,4 +1023,29 @@ module Maid::Tools
       []
     end
   end
+
+  # Predicate to tell whether the file should be skipped when moving.
+  # @param source_path [String] the path to the source file
+  # @param destination_dir [String] the path to the destination directory
+  # @param clobber [Boolean] `true` to overwrite existing destination file,
+  # `false` otherwise
+  # @return [Boolean] whether to skip the move
+  def skip_move?(source_path, destination_dir, clobber)
+    destination_path = File.join(destination_dir, File.basename(source_path))
+
+    # if the destination file doesn't exist, we can move.
+    return false unless File.exist?(destination_path)
+
+    log("#{destination_path} already exists")
+
+    # figure out whether to overwrite the existing destination file.
+    if clobber
+      log("clobbering enabled, moving #{File.basename(source_path)} anyway")
+
+      return false
+    end
+    log("clobbering disabled, skipping move for #{File.basename(source_path)}")
+
+    true
+  end
 end

data/lib/maid/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Maid
-  VERSION = '0.10.0-alpha.2'
+  VERSION = '0.10.0'
   SUMMARY = 'Be lazy. Let Maid clean up after you, based on rules you define. ' \
             'Think of it as "Hazel for hackers".'
 end

data/maid.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.authors     = ['Benjamin Oakes', 'Coaxial']
   s.email       = ['hello@benjaminoakes.com', 'c+rubygems@64b.it']
-  s.license     = 'GPLv2'
+  s.license     = 'GPL-2.0'
   s.homepage    = 'http://github.com/maid/maid'
   s.summary     = Maid::SUMMARY
   s.description = s.summary
@@ -53,6 +53,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency('guard-rubocop')
   s.add_development_dependency('pry-byebug')
   s.add_development_dependency('rake', '~> 13.0.6')
+  s.add_development_dependency('rake-notes')
   s.add_development_dependency('redcarpet', '~> 3.6.0') # Soft dependency of `yard`
   s.add_development_dependency('rspec', '~> 3.12.0')
   s.add_development_dependency('rubocop')
@@ -60,6 +61,8 @@ Gem::Specification.new do |s|
   s.add_development_dependency('rubocop-rspec')
   s.add_development_dependency('simplecov')
   s.add_development_dependency('timecop', '~> 0.9.6')
+  s.add_development_dependency('vcr', '~> 6.1.0')
+  s.add_development_dependency('webmock', '~> 3.18.1')
   s.add_development_dependency('yard', '>= 0.9.11')
 
   # In Vagrant, polling won't cross over the OS boundary if you develop in the host OS but run your tests in the

data/spec/dependency_spec.rb

@@ -95,7 +95,7 @@ describe 'Dependency expectations' do
     end
   end
 
-  describe Geocoder do
+  describe Geocoder, vcr: { record: :new_episodes } do
     it 'translates latitude and longitude into street addresses' do
       city = Geocoder.search('-33.85608611111111,151.219925').map { |location| location.city }.uniq.compact
       expect(city).to eq(['Sydney'])

data/spec/lib/maid/maid_spec.rb

@@ -1,12 +1,11 @@
 require 'spec_helper'
 
 module Maid
-  describe Maid do
+  describe Maid, fakefs: true do
     let(:logger) { instance_spy('Logger') }
 
     before do
       allow(Logger).to receive(:new).and_return(logger)
-      allow(FileUtils).to receive(:mkdir_p)
     end
 
     describe '.new' do
@@ -33,8 +32,11 @@ module Maid
       end
 
       it 'makes the log directory in case it does not exist' do
-        expect(FileUtils).to receive(:mkdir_p).with('/home/username/log')
+        expect(File.exist?('/home/username/log')).to be false
+
         Maid.new(log_device: '/home/username/log/maid.log')
+
+        expect(File.exist?('/home/username/log')).to be true
       end
 
       it 'takes a logger object during intialization' do
@@ -58,8 +60,9 @@ module Maid
 
           it 'set the trash to the correct default path' do
             trash_path = "#{@home}/.local/share/Trash/files/"
-            expect(FileUtils).to receive(:mkdir_p).with(trash_path).once
+
             maid = Maid.new
+
             expect(maid.trash_path).to eq(trash_path)
           end
         end
@@ -71,7 +74,7 @@ module Maid
 
           it 'sets the trash to the correct default path' do
             trash_path = "#{@home}/.Trash/"
-            expect(FileUtils).to receive(:mkdir_p).with(trash_path).once
+
             maid = Maid.new
             expect(maid.trash_path).to eq(trash_path)
           end
@@ -86,8 +89,9 @@ module Maid
 
       it 'sets the trash to the given path, if provided' do
         trash_path = '/home/username/tmp/my_trash/'
-        expect(FileUtils).to receive(:mkdir_p).with(trash_path).once
+
         maid = Maid.new(trash_path: trash_path)
+
         expect(maid.trash_path).not_to be_nil
         expect(maid.trash_path).to eq(trash_path)
       end
@@ -198,6 +202,7 @@ module Maid
       before do
         allow(Listen).to receive(:to)
         allow(Listen).to receive(:start)
+        FileUtils.mkdir_p('watch_dir')
         @maid = Maid.new
       end
 
@@ -215,6 +220,8 @@ module Maid
       # FIXME: Example is too long, shouldn't need the rubocop::disable
       it 'accepts a hash of options and passes them to Listen' do # rubocop:disable RSpec/ExampleLength
         hash = { some: :options }
+        FileUtils.mkdir_p('some_dir')
+
         @maid.watch('some_dir', hash) do
           rule 'test' do
           end
@@ -232,9 +239,29 @@ module Maid
 
         @maid.watches.last.run
       end
+
+      context('with a non-existent directory') do
+        let(:maid) { Maid.new }
+
+        it 'raises with an intelligible message' do
+          expect { maid.watch('/doesnt_exist/') }.to raise_error(/file.*exist/)
+        end
+
+        it 'logs an intelligible message' do
+          begin
+            maid.watch('/doesnt_exist')
+            # Suppressing the exception is fine, because we just want to test
+            # that the message is logged when it throws and the test above
+            # checks that the exception is raised.
+          rescue StandardError # rubocop:disable Lint/SuppressedException
+          end
+
+          expect(logger).to have_received(:warn).with(/file.*exist/)
+        end
+      end
     end
 
-    describe '#repeat' do
+    describe '#repeat', fake_zoneinfo: true do
       before do
         @maid = Maid.new
       end

data/spec/lib/maid/tools_spec.rb

@@ -73,6 +73,59 @@ module Maid
           @maid.move([@src_file, another_file], @dst_dir)
         end
       end
+
+      context 'when the destination file already exists' do
+        let(:src_file) { '/tmp/src/test_file' }
+        let(:dst_dir) { '/tmp/dest/' }
+        let(:dst_file) { File.join(dst_dir, File.basename(src_file)) }
+        let(:maid) { Maid.new(logger: @logger) }
+
+        before do
+          FileUtils.mkdir_p(File.dirname(src_file))
+          FileUtils.mkdir_p(dst_dir)
+          FileUtils.touch(src_file)
+          FileUtils.touch(dst_file)
+        end
+
+        after do
+          FileUtils.rm_rf([src_file, dst_file])
+        end
+
+        context 'by default' do
+          let!(:original_mtime) { File.stat(dst_file).mtime }
+
+          before do
+            maid.move(src_file, dst_dir)
+          end
+
+          it 'logs an info message' do
+            expect(@logger).to have_received(:info).with(/already/)
+            expect(@logger).to have_received(:info).with(/anyway/)
+            expect(@logger).not_to have_received(:info).with(/skipping/)
+          end
+
+          it 'overwrites destination' do
+            expect(File.stat(dst_file).mtime).not_to eq(original_mtime)
+          end
+        end
+
+        context 'when clobber: false' do
+          let!(:original_mtime) { File.stat(dst_file).mtime }
+
+          before do
+            maid.move(src_file, dst_dir, clobber: false)
+          end
+
+          it 'logs an info message' do
+            expect(@logger).not_to have_received(:info).with(/anyway/)
+            expect(@logger).to have_received(:info).with(/skipping/)
+          end
+
+          it "doesn't overwrite the destination file" do
+            expect(File.stat(dst_file).mtime).to eq(original_mtime)
+          end
+        end
+      end
     end
 
     describe '#rename' do
@@ -670,7 +723,7 @@ module Maid
 
     describe '#location_city' do
       context 'given a JPEG image' do
-        it 'reports the known location' do
+        it 'reports the known location', vcr: { record: :new_episodes } do
           sydney_path = File.join(file_fixtures_path, 'sydney.jpg')
           expect(@maid.location_city(sydney_path)).to eq('Sydney, New South Wales, AU')
         end

data/spec/spec_helper.rb

@@ -16,6 +16,7 @@ require 'rspec'
 require 'timecop'
 require 'fakefs/spec_helpers'
 require 'pry-byebug'
+require 'vcr'
 
 require 'maid'
 
@@ -25,6 +26,39 @@ RSpec.configure do |config|
   end
   config.include(FakeFS::SpecHelpers, fakefs: true)
   config.raise_errors_for_deprecations!
+
+  config.filter_run focus: true
+  config.run_all_when_everything_filtered = true
+
+  # NOTE: If a test fails because ENOENT /usr/share/zoneinfo/Africa/Abidjan,
+  # add `fake_zoneinfo: true` to the describe:
+  # `describe(MyClass, fake_zoneinfo: true do`
+  config.before(:context, fake_zoneinfo: true) do
+    # Rufus needs zoneinfo data to run, but when using FakeFS,
+    # /usr/share/zoneinfo doesn't exist on the FakeFS.
+    # On Linux, we just have to FakeFS::FileSystem.clone the directory and it
+    # just works.
+    # OSX is, of course, special. /usr/share/zoneinfo is a symlink on that
+    # platform, and `.clone` doesn't seem to be following symlinks. Instead, we
+    # have to copy the zoneinfo data to a temporary directory on the live
+    # filesystem, enable the FakeFS, clone that temporary directory, create
+    # /usr/share/zoneinfo onto the FakeFS, and finally copy the files into it.
+    # This way, they're available in the FakeFS where Rufus can find them.
+    include FakeFS::SpecHelpers
+    FakeFS.activate!
+
+    if Maid::Platform.osx?
+      FakeFS.deactivate!
+      FileUtils.mkdir_p('/tmp/')
+      FileUtils.cp_r('/usr/share/zoneinfo/', '/tmp/')
+      FakeFS.activate!
+      FakeFS::FileSystem.clone('/tmp/zoneinfo/')
+      FileUtils.mkdir_p('/usr/share/')
+      FileUtils.cp_r('/tmp/zoneinfo/', '/usr/share/')
+    end
+
+    FakeFS::FileSystem.clone('/usr/share/zoneinfo') if Maid::Platform.linux?
+  end
 end
 
 RSpec::Matchers.define :have_deprecated_method do |expected|
@@ -32,3 +66,10 @@ RSpec::Matchers.define :have_deprecated_method do |expected|
     expect(actual).to receive(:__deprecated_run_action__).with(expected, anything) # rubocop:disable RSpec/MessageSpies
   end
 end
+
+VCR.configure do |config|
+  config.cassette_library_dir = 'fixtures/vcr_cassettes'
+  config.hook_into :webmock
+  # For autogenerating VCR cassettes' names based on the tests' metadata
+  config.configure_rspec_metadata!
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: maid
 version: !ruby/object:Gem::Version
-  version: 0.10.0.pre.alpha.2
+  version: 0.10.0
 platform: ruby
 authors:
 - Benjamin Oakes
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-03-31 00:00:00.000000000 Z
+date: 2023-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deprecated
@@ -295,6 +295,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 13.0.6
+- !ruby/object:Gem::Dependency
+  name: rake-notes
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: redcarpet
   requirement: !ruby/object:Gem::Requirement
@@ -393,6 +407,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.6
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 6.1.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 6.1.0
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.18.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.18.1
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -447,6 +489,8 @@ extra_rdoc_files: []
 files:
 - ".act-env"
 - ".act-secrets.example"
+- ".github/ISSUE_TEMPLATE/bug_report.md"
+- ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".github/workflows/coverage.yml"
 - ".github/workflows/lint.yml"
 - ".github/workflows/release.yml"
@@ -468,8 +512,11 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- SECURITY.md
 - Vagrantfile
 - bin/maid
+- fixtures/vcr_cassettes/Dependency_expectations/Geocoder/translates_latitude_and_longitude_into_street_addresses.yml
+- fixtures/vcr_cassettes/Maid_Tools/_location_city/given_a_JPEG_image/reports_the_known_location.yml
 - lib/maid.rb
 - lib/maid/app.rb
 - lib/maid/downloading.rb
@@ -518,7 +565,7 @@ files:
 - spec/spec_helper.rb
 homepage: http://github.com/maid/maid
 licenses:
-- GPLv2
+- GPL-2.0
 metadata:
   bug_tracker_uri: https://github.com/maid/maid/issues
   changelog_uri: https://github.com/maid/maid/blob/master/CHANGELOG.md
@@ -538,11 +585,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.4.6
 signing_key: 
 specification_version: 4
 summary: Be lazy. Let Maid clean up after you, based on rules you define. Think of