magnum-payload 0.3.1 → 0.3.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: a93c18d82f5039aabc7a14c75291693117f92b6d
+  data.tar.gz: 9f6d4a32fe5b2b047e4f178bf172ff7c056f0c86
+SHA512:
+  metadata.gz: b8f22f02913bb97c4f030ad0da10d95476c01d595aa952c2426ec873fe5aaab786232fa3e48c7fe786b951b0e393a773bd4ef8b6cca028e447f2b956b204c436
+  data.tar.gz: 5ff86b1468c19eae47943c59b52d56f464443e4254237affa3fbd2cb5e13f44bf3ade649b629631b6aac203043e3ba666e74692e504df0be3894cd6c5ab622f9

data/README.md

@@ -38,9 +38,9 @@ Example:
 require 'magnum/payload'
 
 # Shorthand method to parse payload
-Magnum::Payload.parse('github', 'JSON data')    # => Magnum::Payload::Github
-Magnum::Payload.parse('bitbucket', 'JSON data') # => Magnum::Payload::Bitbucket
-Magnum::Payload.parse('gitlab', 'JSON data')    # => Magnum::Payload::Bitbucket
+Magnum::Payload.parse('github', 'JSON')    # => Magnum::Payload::Github
+Magnum::Payload.parse('bitbucket', 'JSON') # => Magnum::Payload::Bitbucket
+Magnum::Payload.parse('gitlab', 'JSON')    # => Magnum::Payload::Gitlab
 
 # Or directly initialize a class
 payload = Magnum::Payload::Github.new('JSON data')
@@ -89,11 +89,20 @@ To execute test suite run:
 rake test
 ```
 
+## Contact
+
+Magnum CI
+
+- [https://magnum-ci.com](https://magnum-ci.com)
+- [https://github.com/magnumci](https://github.com/magnumci)
+- [https://twitter.com/ci_magnum](https://twitter.com/ci_magnum)
+- [support@magnum-ci.com](mailto:support@magnum-ci.com)
+
 ## License
 
 MIT License
 
-Copyright (c) 2013 Magnum CI, Dan Sosedoff <dan.sosedoff@gmail.com>
+Copyright (c) 2013 Magnum CI
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of
 this software and associated documentation files (the "Software"), to deal in

data/lib/magnum/payload/bitbucket.rb

@@ -1,6 +1,10 @@
 module Magnum
   class Payload::Bitbucket < Payload::Base
     def parse!
+      if data.commits.nil? || data.commits.empty?
+        raise Magnum::Payload::PayloadError, "Payload has no commits"
+      end
+
       commit = Hashr.new(data.commits.last)
 
       branch   = commit.branch || commit.branches.first || 'none'

data/lib/magnum/payload/version.rb

@@ -1,5 +1,5 @@
 module Magnum
   module Payload
-    VERSION = '0.3.1'
+    VERSION = '0.3.2'
   end
 end

data/lib/magnum/payload.rb

@@ -2,6 +2,8 @@ require 'magnum/payload/version'
 
 module Magnum
   module Payload
+    SOURCES = %w(custom github gitlab gitslice bitbucket beanstalk)
+
     class ParseError   < StandardError ; end
     class PayloadError < StandardError ; end
 
@@ -14,11 +16,17 @@ module Magnum
     autoload :Beanstalk,     'magnum/payload/beanstalk'
     autoload :MessageParser, 'magnum/payload/message_parser'
 
+    def self.valid_source?(source)
+      SOURCES.include?(source.to_s)
+    end
+
     def self.parse(source, payload)
+      unless valid_source?(source)
+        raise PayloadError, "Invalid payload type: #{source}"
+      end
+
       klass = Magnum::Payload.const_get(source.to_s.capitalize)
       klass.new(payload)
-    rescue NameError
-      raise PayloadError, "Invalid payload type: #{source}"
     end
   end
 end

data/spec/fixtures/bitbucket/git_no_commits.json

@@ -0,0 +1,16 @@
+{
+  "repository": {
+    "website": "http://www.mysite.com/",
+    "fork": false,
+    "name": "repository",
+    "scm": "git",
+    "owner": "username",
+    "absolute_url": "/username/repository/",
+    "slug": "minestore",
+    "is_private": true
+  },
+  "truncated": false,
+  "commits": [],
+  "canon_url": "https://bitbucket.org",
+  "user": "username"
+}

data/spec/payload/bitbucket_spec.rb

@@ -35,6 +35,15 @@ describe Magnum::Payload::Bitbucket do
       it 'sets compare url' do
         payload.compare_url.should eq 'https://bitbucket.org/sosedoff/test1/compare/e15c6013c0f6232153e53b003b97da51d338da3a..f15566c42759198fd32a70963d2509f3f8309586'
       end
+
+      context "that does not have commits" do
+        let(:data) { fixture("bitbucket/git_no_commits.json") }
+
+        it "raises PayloadError exception" do
+          expect { Magnum::Payload::Bitbucket.new(data) }.
+            to raise_error Magnum::Payload::PayloadError, "Payload has no commits"
+        end
+      end
     end
 
     context 'with mercurial payload' do

data/spec/payload_spec.rb

@@ -1,6 +1,21 @@
 require 'spec_helper'
 
 describe Magnum::Payload do
+  describe ".valid_source?" do
+    it "returns true if valid" do
+      expect(Magnum::Payload.valid_source?("github")).to eq true
+      expect(Magnum::Payload.valid_source?("gitlab")).to eq true
+      expect(Magnum::Payload.valid_source?("gitslice")).to eq true
+      expect(Magnum::Payload.valid_source?("bitbucket")).to eq true
+      expect(Magnum::Payload.valid_source?("beanstalk")).to eq true
+      expect(Magnum::Payload.valid_source?("custom")).to eq true
+    end
+
+    it "returns false if not valid" do
+      expect(Magnum::Payload.valid_source?("foobar")).to eq false
+    end
+  end
+
   describe '.parse' do
     it 'returns payload instance for github' do
       payload = Magnum::Payload.parse('github', fixture('github.json'))

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: magnum-payload
 version: !ruby/object:Gem::Version
-  version: 0.3.1
-  prerelease: 
+  version: 0.3.2
 platform: ruby
 authors:
 - Dan Sosedoff
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-24 00:00:00.000000000 Z
+date: 2013-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -46,7 +41,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -54,7 +48,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -62,33 +55,29 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '1.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '1.8'
 - !ruby/object:Gem::Dependency
   name: hashr
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Allows to parse code payloads from Github, Bitbucket and many more
@@ -120,6 +109,7 @@ files:
 - spec/fixtures/beanstalk/hg.json
 - spec/fixtures/beanstalk/svn.json
 - spec/fixtures/bitbucket/git.json
+- spec/fixtures/bitbucket/git_no_commits.json
 - spec/fixtures/bitbucket/hg.json
 - spec/fixtures/github.json
 - spec/fixtures/github/deleted.json
@@ -142,39 +132,33 @@ files:
 homepage: https://github.com/magnumci/magnum-payload
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 3727367032317050001
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 3727367032317050001
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Code payload parser
 test_files:
 - spec/fixtures/beanstalk/git.json
 - spec/fixtures/beanstalk/hg.json
 - spec/fixtures/beanstalk/svn.json
 - spec/fixtures/bitbucket/git.json
+- spec/fixtures/bitbucket/git_no_commits.json
 - spec/fixtures/bitbucket/hg.json
 - spec/fixtures/github.json
 - spec/fixtures/github/deleted.json