maglevcms 3.0.0.beta3 → 3.0.1

data/app/services/maglev/discard_page_draft_service.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module Maglev
+  class DiscardPageDraftService
+    include Injectable
+
+    argument :site
+    argument :page
+
+    def call
+      ActiveRecord::Base.transaction do
+        revert_container_sections!(site)
+        revert_container_sections!(page)
+        revert_page_information!
+      end
+      true
+    end
+
+    private
+
+    def revert_container_sections!(container)
+      store = find_published_store(container)
+
+      raise Maglev::Errors::UnpublishedPage if store.blank?
+
+      container.sections_translations_will_change!
+      container.sections_translations = store.sections_translations
+      container.save!
+
+      # Update updated_at to be before published_at to mark as up-to-date
+      # rubocop:disable Rails/SkipsModelValidations
+      container.update_column(:updated_at, container.published_at) if container.published_at.present?
+      # rubocop:enable Rails/SkipsModelValidations
+    end
+
+    def find_published_store(container)
+      container.sections_content_stores.published.first
+    end
+
+    def revert_page_information!
+      page.apply_published_payload
+      page.save!
+    end
+  end
+end

data/app/services/maglev/fetch_section_screenshot_url.rb

@@ -5,9 +5,13 @@ module Maglev
     include Injectable
 
     dependency :fetch_section_screenshot_path
+    dependency :context
+
     argument :section
 
     def call
+      return nil unless section.local_screenshot?
+
       screenshot_path = fetch_section_screenshot_path.call(section: section) + query_string
       asset_host ? URI.join(asset_host, screenshot_path).to_s : screenshot_path
     end
@@ -15,11 +19,18 @@ module Maglev
     private
 
     def asset_host
-      Rails.application.config.asset_host
+      host = Rails.application.config.asset_host
+      return nil if host.blank?
+
+      host.start_with?('http://', 'https://') ? host : "#{request_protocol}#{host}"
     end
 
     def query_string
       "?#{section.screenshot_timestamp}"
     end
+
+    def request_protocol
+      context.controller.request.protocol
+    end
   end
 end

data/app/services/maglev/has_unpublished_changes.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module Maglev
+  class HasUnpublishedChanges
+    include Injectable
+
+    argument :site
+    argument :page
+    argument :theme
+
+    def call
+      page.need_to_be_published? || site_need_to_be_published?
+    end
+
+    private
+
+    def site_need_to_be_published?
+      !site.published? || site.updated_at.blank? || site.updated_at > site.published_at
+    end
+  end
+end

data/app/services/maglev/publish_service.rb

@@ -9,14 +9,22 @@ module Maglev
 
     def call
       ActiveRecord::Base.transaction do
-        publish_container_sections!(site)
-        publish_container_sections!(page)
+        unsafe_call
       end
       true
     end
 
     private
 
+    def unsafe_call
+      # copy content from the containers (site and page) to the published stores
+      publish_container_sections!(site)
+      publish_container_sections!(page)
+
+      # copy the page information to the page published payload
+      publish_page_information!
+    end
+
     def publish_container_sections!(container)
       store = find_or_build_published_store(container)
       store.sections_translations = container.sections_translations
@@ -29,5 +37,10 @@ module Maglev
     def find_or_build_published_store(container)
       container.sections_content_stores.find_or_initialize_by(container: container, published: true)
     end
+
+    def publish_page_information!
+      page.update_published_payload
+      page.save!
+    end
   end
 end

data/app/views/layouts/maglev/editor/_sidebar.html.erb

@@ -2,6 +2,7 @@
   path: editor_pages_path(maglev_editing_route_context), 
   icon: 'file_copy', 
   active: controller_name == 'pages',
+  label: t('maglev.editor.sidebar_nav.list_pages_tooltip'),
   options: {
     data: { controller: 'prevent-same-path' }
   }
@@ -10,13 +11,15 @@
 <% sidebar.with_link(
   path: editor_sections_path(maglev_editing_route_context), 
   icon: 'stack',
-  active: controller_name == 'sections'
+  active: controller_name == 'sections',
+  label: t('maglev.editor.sidebar_nav.manage_page_sections_tooltip')
 ) %>
 
 <% sidebar.with_link(
   path: edit_editor_style_path(maglev_editing_route_context), 
   icon: 'drop',
   active: controller_name == 'style',
+  label: t('maglev.editor.sidebar_nav.edit_style_tooltip'),
   options: {
     icon_size: '1.25rem',
     data: { controller: 'prevent-same-path' }
@@ -26,6 +29,7 @@
 <% sidebar.with_link(
   path: editor_assets_path, 
   icon: 'image',
+  label: t('maglev.editor.sidebar_nav.open_image_library_tooltip'),
   options: {
     data: { turbo_frame: 'modal' }
   }
@@ -34,6 +38,7 @@
 <% sidebar.with_link(
   path: editor_leave_path, 
   icon: 'logout',
+  label: t('maglev.editor.sidebar_nav.leave_editor_tooltip'),
   options: {
     position: :bottom
   }

data/app/views/layouts/maglev/editor/application.html.erb

@@ -39,6 +39,8 @@
       client:sectionBlock:clicked@window->editor-preview-notification-center#editSectionBlock
       client:section:setting:clicked@window->editor-preview-notification-center#editSection
       client:sectionBlock:setting:clicked@window->editor-preview-notification-center#editSection
+      client:section:setting:hovered@window->editor-preview-notification-center#prefetchEditSectionOrBlock
+      client:sectionBlock:setting:hovered@window->editor-preview-notification-center#prefetchEditSectionOrBlock
     "
   >
     <div id="root">
@@ -57,6 +59,9 @@
       <% end %>      
 
       <%= render 'maglev/editor/sections/toolbar_list' %>
+
+      <%# Inside #root so Turbo morph refreshes the new-section URL; visibility uses editor-preview-empty variant (see tailwind.css.erb). %>
+      <%= render 'maglev/editor/pages/preview_empty_message' %>
     </div>
 
     <%= render 'maglev/editor/pages/preview' %>

data/app/views/layouts/maglev/editor/topbar/_page_info.html.erb

@@ -3,7 +3,7 @@
   paths: {
     edit: edit_editor_page_path(current_maglev_page, maglev_editing_route_context),
     preview: current_maglev_page_urls[:preview],
-    clone: editor_page_clone_path(current_maglev_page, maglev_editing_route_context),
+    clone: clone_editor_page_path(current_maglev_page, maglev_editing_route_context),
     delete: editor_page_path(current_maglev_page, maglev_editing_route_context)
   },
   live_page_url: current_maglev_page_urls[:live],

data/app/views/layouts/maglev/editor/topbar/_publish_button.html.erb

@@ -1,13 +1,35 @@
 <div class="flex items-center h-full px-4">
-  <%= button_to editor_publication_path(maglev_editing_route_context), 
-    method: :post, 
-    class: maglev_button_classes(color: :primary, size: :medium),
-    form_class: 'group/form is-default',
-    disabled: current_maglev_page.published_and_up_to_date?,
-    data: { controller: 'submit-button' } do %>
-    <%= maglev_button_label(
-      t('maglev.editor.header_nav.publish_button.default'),
-      pending: t('maglev.editor.header_nav.publish_button.in_progress'),
-      )%>
+  <%= render Maglev::Uikit::ButtonGroupComponent.new do |button_group| %>
+    <% button_group.with_button do %>
+      <%= button_to editor_publication_path(maglev_editing_route_context), 
+        method: :post, 
+        class: button_group.wrapped_button_classes,
+        form_class: button_group.wrapper_classes(class: 'group/form is-default'),
+        disabled: !unpublished_changes?,
+        data: { 
+          controller: 'submit-button',
+          turbo_confirm: t('maglev.editor.header_nav.publish_button.publish_confirm')
+        } do %>
+        <%= maglev_button_label(t('maglev.editor.header_nav.publish_button.default'), pending: t('maglev.editor.header_nav.publish_button.in_progress'),) %>
+      <% end %>
+    <% end %>  
+
+    <% button_group.with_button do %>
+      <%= render Maglev::Uikit::MenuDropdownComponent.new(
+        icon_name: 'arrow_down', 
+        wrapper_classes: button_group.wrapper_classes,
+        trigger_classes: button_group.wrapped_button_classes(class: 'px-2!') 
+      ) do |dropdown| %>      
+        <% dropdown.with_item_button_to(discard_draft_editor_page_path(current_maglev_page.id, **maglev_editing_route_context), 
+          method: :post, 
+          data: { 
+            turbo_confirm: t('maglev.editor.header_nav.publish_button.discard_draft_confirm')
+          }) do |menu_item| %>
+          <% menu_item.with_icon_content('history') %>
+          <% menu_item.with_label_content(t('maglev.editor.header_nav.publish_button.discard_draft')) %>
+          <% menu_item.with_sub_label_content(l(current_maglev_page.published_at, format: :long)) %>
+        <% end %>        
+      <% end %>
+    <% end if current_maglev_page.discard_draft? %>
   <% end %>
 </div>

data/app/views/maglev/editor/assets/_list.html.erb

@@ -12,7 +12,8 @@
                 height: asset.height,
                 byte_size: asset.byte_size,
               },
-              delete_path: editor_asset_path(asset, **maglev_editing_route_context, **query_params(pagination: true)),
+              # Numeric id: paths ending in .jpg/.png are Turbo "unvisitable", so forms skip hijacking (no confirm).
+              delete_path: editor_asset_path(asset.id, **maglev_editing_route_context, **query_params(pagination: true)),
               picker_attributes: { picker: params[:picker], source: params[:source] }.compact_blank
             ) %>
           <% end %>

data/app/views/maglev/editor/assets/index.html.erb

@@ -25,5 +25,6 @@
       </div>
 
       <%= render 'list', assets: @assets, pagy: @pagy %>
+    </div>
   <% end %>
 <% end %>

data/app/views/maglev/editor/home/index.html.erb

@@ -1 +1 @@
-<p class="text-green-500">Hello world!!!!</p>
+<!-- this is the home page for the editor -->

data/app/views/maglev/editor/links/edit/_email.html.erb

@@ -1,5 +1,5 @@
 <div class="mt-2 grid grid-cols-1 gap-4"> 
   <%= f.hidden_field :link_type, value: 'email' %>
 
-  <%= f.text_field :email %>
+  <%= f.text_field :email, autocomplete: 'off' %>
 </div>

data/app/views/maglev/editor/links/edit/_url.html.erb

@@ -1,7 +1,7 @@
 <div class="mt-2 grid grid-cols-1 gap-4">
   <%= f.hidden_field :link_type, value: 'url' %>
 
-  <%= f.text_field :url_href %>
+  <%= f.text_field :url_href, autocomplete: 'off' %>
 
   <%= f.check_box :open_new_window %>
 </div>

data/app/views/maglev/editor/pages/_list.html.erb

@@ -2,27 +2,31 @@
   <% if @pages.empty? %>
     <p class="text-center mt-8"><%= t('maglev.editor.pages.list.empty') %></p>
   <% else %>
-    <% @pages.each do |page| %>
-      <div class="flex items-center pl-4 pr-2 hover:bg-gray-50 transition-colors duration-200">
-        <%= link_to editor_real_root_path(maglev_editing_route_context(page: page)), class: 'flex items-center text-gray-800 overflow-hidden w-full py-3.5 gap-2', data: { turbo_frame: '_top', **maglev_page_preview_reload_data } do %>
-          <%= maglev_page_icon(page) %>
-          <span class="truncate">
-            <%= page.title.presence || page.default_title %>
-          </span>
+    <%= render Maglev::Uikit::List::ListComponent.new do |component| %>
+      <% @pages.each do |page| %>
+        <%# Omit maglev_page_preview_reload_data: it runs before Turbo visits the row URL and reloads the iframe, then syncPreview loads the new preview again (double fetch). %>
+        <% component.with_item_content(id: page.id, link: { url: editor_real_root_path(maglev_editing_route_context(page: page)), data: { turbo_frame: '_top' } }, options: { variant: :ghost }) do |item| %>
+          <% item.with_icon do %>
+            <%= maglev_page_icon(page) %>
+          <% end %>
+
+          <% item.with_title_content(page.title.presence || page.default_title) %>
+          <% item.with_sub_title_content("/" + page.path) %>
+
+          <% item.with_action do %>
+            <%= render Maglev::Uikit::PageActionsDropdownComponent.new(
+              paths: {
+                edit: edit_editor_page_path(page.id, **query_params(from_list: true), **maglev_editing_route_context),
+                preview: maglev_page_preview_url(page),
+                clone: clone_editor_page_path(page.id, maglev_editing_route_context),
+                delete: editor_page_path(page.id, **query_params, **maglev_editing_route_context)
+              },
+              live_url: maglev_page_live_url(page),
+              without_actions: page.index? ? [:delete] : []
+            ) %>
+          <% end %>
         <% end %>
-        <div class="ml-auto pr-2 relative">
-          <%= render Maglev::Uikit::PageActionsDropdownComponent.new(
-            paths: {
-              edit: edit_editor_page_path(page.id, **query_params(from_list: true), **maglev_editing_route_context),
-              preview: maglev_page_preview_url(page),
-              clone: editor_page_clone_path(page.id, maglev_editing_route_context),
-              delete: editor_page_path(page.id, **query_params, **maglev_editing_route_context)
-            },
-            live_url: maglev_page_live_url(page),
-            without_actions: page.index? ? [:delete] : []
-          ) %>
-        </div>
-      </div>
-    <% end %>
+      <% end %>
+    <% end %>   
   <% end %>
 </div>  

data/app/views/maglev/editor/pages/_preview.html.erb

@@ -1,12 +1,14 @@
 <div 
-  class="absolute top-16 left-16 right-0 bottom-0 overflow-hidden group"
+  class="absolute top-16 left-16 right-0 bottom-0 z-0 overflow-hidden group"
   data-controller="editor-page-preview"
   data-action="
     uikit-device-toggler:change@window->editor-page-preview#changeDevice 
     client:ready@window->editor-page-preview#clientReady
     client:ready@window->editor-preview-notification-center#clientReady
     turbo:load@window->editor-page-preview#detectUrlChange
-    dispatcher:page-preview:reload@window->editor-page-preview#startLoading
+    turbo:render@window->editor-page-preview#detectUrlChange
+    pageshow@window->editor-page-preview#detectUrlChange
+    dispatcher:page-preview:reload@window->editor-page-preview#reload
     dispatcher:page-preview:remove-empty-message@window->editor-page-preview#removeEmptyMessage
   "
 >
@@ -20,8 +22,8 @@
       class="bg-white w-full h-full mx-auto transition-discrete transition-all duration-100 ease-in-out group-data-[device=mobile]/device:w-[375px] group-data-[device=tablet]/device:w-[1024px]" 
       data-editor-page-preview-target="iframe"
       data-editor-preview-notification-center-target="iframe"
-      data-editor-preview-notification-center-primary-color-param="<%= maglev_primary_hex_color %>"
-      data-editor-preview-notification-center-sticky-section-ids-param="<%=current_maglev_sections.select(&:sticky?).map(&:id).to_json %>"
+      data-editor-preview-notification-center-primary-color-value="<%= maglev_primary_hex_color %>"
+      data-editor-preview-notification-center-sticky-section-ids-value="<%= current_maglev_sections.select(&:sticky?).map(&:id).to_json %>"
       data-action="load->editor-preview-notification-center#sendConfig"></iframe>
   </div>
 
@@ -30,6 +32,4 @@
       <%= t('maglev.editor.page_preview.loading') %>
     </p>
   </div>
-
-  <%= render 'maglev/editor/pages/preview_empty_message' %>
 </div>

data/app/views/maglev/editor/pages/_preview_empty_message.html.erb

@@ -1,14 +1,17 @@
-<div class="absolute inset-0 flex-col justify-center items-center hidden group-[.is-empty]:flex bg-gray-50">
-  <h2 class="text-center text-2xl font-bold">
-    <%= t('maglev.editor.page_preview.empty.title') %>
-  </h2>
-  <div class="mt-4 text-gray-600 max-w-md mx-auto leading-9">
-    <% new_section_link = capture do %>
-      <%= link_to new_editor_section_path(**maglev_editing_route_context), class: 'text-editor-primary inline-block relative top-1.5' do %>
-        <%= render Maglev::Uikit::IconComponent.new(name: 'stack', size: '1.5rem') %>
+<%# z-[5]: below PageLayoutComponent (z-10 / z-40), above preview shell (z-0). editor-preview-empty: tailwind.css.erb @custom-variant on [data-controller~="editor-page-preview"].is-empty %>
+<div class="fixed top-16 left-16 right-0 bottom-0 z-[5] bg-gray-50 hidden editor-preview-empty:block">
+  <div class="flex min-h-full flex-col items-center justify-center px-4">
+    <h2 class="text-center text-2xl font-bold">
+      <%= t('maglev.editor.page_preview.empty.title') %>
+    </h2>
+    <div class="mt-4 max-w-md mx-auto leading-9 text-gray-600">
+      <% new_section_link = capture do %>
+        <%= link_to new_editor_section_path(**maglev_editing_route_context), class: 'text-editor-primary inline-block relative top-1.5', data: { turbo_frame: 'modal' } do %>
+          <%= render Maglev::Uikit::IconComponent.new(name: 'stack', size: '1.5rem') %>
+        <% end %>
       <% end %>
-    <% end %>
 
-    <%= t('maglev.editor.page_preview.empty.message', button: new_section_link).html_safe %>    
+      <%= t('maglev.editor.page_preview.empty.message', button: new_section_link).html_safe %>
+    </div>
   </div>
 </div>

data/app/views/maglev/editor/pages/discard_draft/create.turbo_stream.erb

@@ -0,0 +1,16 @@
+<%= turbo_stream.console_log 'Discard page draft' %>
+
+<%= turbo_stream.dispatch_event "page-preview:reload", payload: {}.to_json %>
+
+<%= turbo_stream.update dom_id(current_maglev_page, 'topbar-page-info'), method: 'morph' do %>
+  <%= render 'layouts/maglev/editor/topbar/page_info' %>
+<% end %>
+
+<%= turbo_stream.update dom_id(current_maglev_page, 'topbar-publish-button'), method: 'morph' do %>
+  <%= render 'layouts/maglev/editor/topbar/publish_button' %>
+<% end %>
+
+<%= turbo_stream.refresh %>
+
+<%#= turbo_stream.refresh delayed: true %>
+

data/app/views/maglev/editor/pages/index.html.erb

@@ -18,6 +18,13 @@
   </div>
 
   <% page_layout.with_footer do %>
-    <%= link_to t('maglev.editor.pages.list.new_button'), new_editor_page_path(**maglev_editing_route_context, **query_params), class: maglev_button_classes(size: :big), data: { turbo_frame: '_top' } %>
+    <div>
+      <% if defined?(@pagy) && @pagy.present? %>
+        <div class="pb-2">
+          <%= render Maglev::Uikit::PaginationComponent.new(pagy: @pagy, hidden_if_single_page: false, show_info: false) %>
+        </div>
+      <% end %>
+      <%= link_to t('maglev.editor.pages.list.new_button'), new_editor_page_path(**maglev_editing_route_context, **query_params), class: maglev_button_classes(size: :big), data: { turbo_frame: '_top' } %>
+    </div>
   <% end %>
 <% end %>

data/app/views/maglev/editor/section_blocks/_form.html.erb

@@ -1,15 +1,7 @@
-<%= hidden_field_tag 'lock_version', @section_block.lock_version.presence || 0, data: { editor_section_form_target: 'lockVersion' } %>
-
-<% if @section_block.definition.advanced_settings.blank? %>
-  <%= section_block_form_settings(@section, @section_block) %>
-<% else %>
-  <%= render Maglev::Uikit::TabsComponent.new(container_classes: 'w-full h-full flex flex-col') do |tabs| %>
-    <% tabs.with_tab(label: t('maglev.editor.section_blocks.edit.tabs.main')) do %>
-      <%= section_block_form_settings(@section, @section_block) %>
-    <% end %>
-
-    <% tabs.with_tab(label: t('maglev.editor.section_blocks.edit.tabs.advanced')) do %>
-      <%= section_block_form_settings(@section, @section_block, advanced: true) %>
-    <% end %>
+<% if @section_block.definition.empty? %>
+  <%= render Maglev::Uikit::Well::SimpleWellComponent.new do |well| %>
+    <% well.with_title_content(t('maglev.editor.section_blocks.edit.no_settings')) %>
   <% end %>
+<% else %>
+  <%= section_block_form_settings(@section, @section_block, advanced: defined?(advanced) && advanced) %>
 <% end %>

data/app/views/maglev/editor/section_blocks/_form_with_tabs.html.erb

@@ -0,0 +1,15 @@
+<%= hidden_field_tag 'lock_version', source_lock_version, data: { editor_section_form_target: 'lockVersion' } %>
+
+<% if @section_block.definition.advanced_settings.blank? %>
+  <%= render 'maglev/editor/section_blocks/form' %>
+<% else %>
+  <%= render Maglev::Uikit::TabsComponent.new(container_classes: 'w-full h-full flex flex-col') do |tabs| %>
+    <% tabs.with_tab(label: t('maglev.editor.section_blocks.edit.tabs.main')) do %>
+      <%= render 'maglev/editor/section_blocks/form' %>
+    <% end %>
+
+    <% tabs.with_tab(label: t('maglev.editor.section_blocks.edit.tabs.advanced')) do %>
+      <%= render 'maglev/editor/section_blocks/form', advanced: true %>
+    <% end %>
+  <% end %>
+<% end %>

data/app/views/maglev/editor/section_blocks/_new.html.erb

@@ -6,7 +6,7 @@
     'editor-preview-notification-center-section-id-param': @section.id,
   } do |f| %>
   <%= f.hidden_field :parent_id, value: parent_id if parent_id %>
-  <%= f.hidden_field :lock_version, value: @section.lock_version %>
+  <%= f.hidden_field :lock_version, value: source_lock_version %>
 
   <div class="space-y-4">
     <% blocks.each do |block_definition| %>

data/app/views/maglev/editor/section_blocks/edit.html.erb

@@ -12,7 +12,7 @@
     controller: 'editor-section-form', 
     'editor-section-form-section-id-value': @section.id,
     'editor-section-form-section-block-id-value': @section_block.id,
-    'editor-section-form-section-lock-version-value': @section.lock_version,
+    'editor-section-form-section-lock-version-value': source_lock_version,
     action: %(
       editor-setting:change->editor-section-form#onSettingChange
       editor-section-form:connected@window->editor-preview-notification-center#checkSectionLockVersion
@@ -23,6 +23,6 @@
       dispatcher:section-block-#{@section_block.id}:persisted@window->editor-section-form#onPersist
     )
   } do %>
-    <%= render 'maglev/editor/section_blocks/form' %>
+    <%= render 'maglev/editor/section_blocks/form_with_tabs' %>
   <% end %>
 <% end %>

data/app/views/maglev/editor/section_blocks/index/_list.html.erb

@@ -1,7 +1,7 @@
 <% if @section.blocks.any? %>
   <%= render Maglev::Uikit::List::ListComponent.new(
     sort_form: { 
-      path: sort_editor_section_blocks_path(@section, lock_version: @section.lock_version, **maglev_editing_route_context), 
+      path: sort_editor_section_blocks_path(@section, lock_version: source_lock_version, **maglev_editing_route_context), 
       data: { 
         turbo_frame: '_top',
         action: 'sortable:drag-stopped@window->editor-preview-notification-center#moveSectionBlocks', 
@@ -35,7 +35,7 @@
     <% end %>
   <% end %>
 <% else %>
-  <p class="text-center mt-8 text-gray-800">
+  <p class="text-center mt-8 text-gray-500">
     <%= t('maglev.editor.section_blocks.index.empty') %>
   </p>
 <% end %>

data/app/views/maglev/editor/section_blocks/index/_tree.html.erb

@@ -1,6 +1,6 @@
 <%= render Maglev::Uikit::List::ListComponent.new(
   sort_form: { 
-    path: sort_editor_section_blocks_path(@section, parent_id: parent_id, lock_version: @section.lock_version, **maglev_editing_route_context), 
+    path: sort_editor_section_blocks_path(@section, parent_id: parent_id, lock_version: source_lock_version, **maglev_editing_route_context), 
     data: { turbo_frame: '_top' } 
   },
   sortable_scope: parent_id || 'root',

data/app/views/maglev/editor/section_blocks/update.turbo_stream.erb

@@ -1,4 +1,4 @@
-<%= turbo_stream.dispatch_event "section-block-#{@section_block.id}:persisted", payload: { lockVersion: @section_block.lock_version }.to_json %>
+<%= turbo_stream.dispatch_event "section-block-#{@section_block.id}:persisted", payload: { lockVersion: source_lock_version }.to_json %>
 
 <%= turbo_stream.update 'page-layout-notification', method: 'morph' do %>
   <%= render Maglev::Uikit::BadgeComponent.new(color: :green, icon_name: 'checkbox_circle', disappear_after: 3.seconds).with_content(flash.now[:notice]) %>

data/app/views/maglev/editor/sections/_form.html.erb

@@ -1,21 +1,7 @@
-<%= hidden_field_tag 'lock_version', @section.lock_version.presence || 0, data: { editor_section_form_target: 'lockVersion' } %>
-
-<% if @section.definition.blocks.none? && !@section.definition.advanced_settings.any? %>
-  <%= section_form_settings(@section) %>
-<% else %>
-  <%= render Maglev::Uikit::TabsComponent.new(container_classes: 'w-full h-full flex flex-col') do |tabs| %>
-    <% tabs.with_tab(label: t('maglev.editor.sections.edit.tabs.main')) do %>
-      <%= section_form_settings(@section) %>
-    <% end %>
-
-    <% tabs.with_tab(label: t('maglev.editor.sections.edit.tabs.advanced')) do %>
-      <%= section_form_settings(@section, advanced: true) %>
-    <% end if @section.definition.advanced_settings.any? %>
-
-    <% tabs.with_tab(
-        label: @section.blocks_label, 
-        link: { url: editor_section_blocks_path(@section, maglev_editing_route_context), html_options: { data: { turbo_frame: '_top' } } }
-      ) unless @section.definition.blocks.none?
-    %>
+<% if @section.definition.empty? %>
+  <%= render Maglev::Uikit::Well::SimpleWellComponent.new do |well| %>
+    <% well.with_title_content(t('maglev.editor.sections.edit.no_settings')) %>
   <% end %>
-<% end %>
+<% else %>
+  <%= section_form_settings(@section, advanced: defined?(advanced) && advanced) %>
+<% end %>

data/app/views/maglev/editor/sections/_form_with_tabs.html.erb

@@ -0,0 +1,21 @@
+<%= hidden_field_tag 'lock_version', source_lock_version, data: { editor_section_form_target: 'lockVersion' } %>
+
+<% if @section.definition.blocks.none? && !@section.definition.advanced_settings.any? %>
+  <%= render 'maglev/editor/sections/form' %>
+<% else %>
+  <%= render Maglev::Uikit::TabsComponent.new(container_classes: 'w-full h-full flex flex-col') do |tabs| %>
+    <% tabs.with_tab(label: t('maglev.editor.sections.edit.tabs.main')) do %>
+      <%= render 'maglev/editor/sections/form' %>
+    <% end %>
+
+    <% tabs.with_tab(label: t('maglev.editor.sections.edit.tabs.advanced')) do %>
+      <%= render 'maglev/editor/sections/form', advanced: true %>      
+    <% end if @section.definition.advanced_settings.any? %>
+
+    <% tabs.with_tab(
+        label: @section.blocks_label, 
+        link: { url: editor_section_blocks_path(@section, maglev_editing_route_context), html_options: { data: { turbo_frame: '_top' } } }
+      ) unless @section.definition.blocks.none?
+    %>
+  <% end %>
+<% end %>

data/app/views/maglev/editor/sections/_list.html.erb

@@ -8,7 +8,7 @@
             action: 'sortable:drag-stopped@window->editor-preview-notification-center#moveSection',            
           } 
         }) do |component| %>
-      <% component.with_item_insert_button(link: { url: new_editor_section_path(position: 0, **maglev_editing_route_context), data: { turbo_frame: '_top' } })%>
+      <% component.with_item_insert_button(link: { url: new_editor_section_path(position: 0, **maglev_editing_route_context), data: { turbo_frame: 'modal' } })%>
       
       <% current_maglev_sections.each_with_index do |section, index| %>
         <% component.with_item_content(id: section.id, link: { url: edit_editor_section_path(section.id, maglev_editing_route_context), data: { turbo_frame: '_top' } }) do |item| %>
@@ -39,11 +39,11 @@
           <% end %>
         <% end %>
         
-        <% component.with_item_insert_button(link: { url: new_editor_section_path(position: index + 1, **maglev_editing_route_context), data: { turbo_frame: '_top' } }) %> 
+        <% component.with_item_insert_button(link: { url: new_editor_section_path(position: index + 1, **maglev_editing_route_context), data: { turbo_frame: 'modal' } }) %> 
       <% end %>
     <% end %>
   <% else %>
-    <p class="text-center mt-8 text-gray-800">
+    <p class="text-center mt-8 text-gray-500">
       <%= t('maglev.editor.sections.index.empty') %>
     </p>
   <% end %>