magick-feature-flags 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 046dc5815e415705073eff7b3619c90bfd09a4af59b74d4116a3b2c206d5572e
-  data.tar.gz: 97bd2be3b303a73fa464c87ebbc6456098003601d236072c10e9a483e52c50b2
+  metadata.gz: a34f03026e8631bc2d29c0935cb98e472e7ed387fc4628edc357776423bfc2c5
+  data.tar.gz: d87af21843efb22d5dba60d342f3beb5fd807eb42f1b2948c82ae8dc3d6b67a2
 SHA512:
-  metadata.gz: 85d499e307729dfd4742ec0535f5edde63fb5dc2706ee8b1189dd63f8ed7f9c8c6d7a784d9a7f59e988f394fb92f41acc84c176a9544fb417c892586dd6444f2
-  data.tar.gz: 589515a83297e0d3ce02332afa309741533f1cf91fa556044b9a1f4f63a2d327248eba80c1727baa08ed5ed476db401530ddd21645eab3d7028624f97f6ee204
+  metadata.gz: '0296397245455dbecd448a2dab448b2209579f4c9c39a1e93b424e8f6982fe8a3f498140ac7af5f1127c70fc2cdaa3378194135afe2e55fe9254646a4c761e64'
+  data.tar.gz: 43e1ce6dcf51815f83ccf4440845d415f8d351e6a6038c8f7bcd0a294dfc0def6531a04a118119d66e71a64d7cfcc1607273eda0c181dfdf951c9ee61d4cfae7

data/README.md

@@ -467,6 +467,32 @@ class CheckoutController < ApplicationController
 end
 ```
 
+**Experiments without a user (anonymous visitors):**
+
+For flows where there's no authenticated user yet (e.g., registration, landing pages), use any stable identifier as `user_id` — a session ID or a tracking cookie:
+
+```ruby
+class RegistrationController < ApplicationController
+  def new
+    cookies[:visitor_id] ||= SecureRandom.uuid
+    @variant = Magick.variant(:registration_flow, user_id: cookies[:visitor_id])
+  end
+end
+```
+
+The hashing just needs a consistent string. As long as the same visitor sends the same identifier, they get the same variant every time.
+
+**Safe to call on non-existent experiments:**
+
+```ruby
+Magick.variant(:nonexistent, user_id: 123)  # => nil
+Magick.variant_value(:nonexistent, user_id: 123)  # => nil
+```
+
+**Important — changing weights may shift users:**
+
+You can change variant weights at any time via the Admin UI or code, and changes take effect immediately across all adapters. However, changing weights alters the bucket boundaries, which means some users may be reassigned to a different variant after the update. Magick does not persist individual user-to-variant assignments — assignment is computed on the fly from the hash. If your experiment requires that users never shift variants mid-experiment, you should persist the assignment externally (e.g., store `user_id → variant` in a database table on first exposure).
+
 **How it works:**
 - Variants are assigned using a deterministic MD5 hash of `feature_name + user_id`
 - The same user always gets the same variant across sessions and requests

data/app/controllers/magick/adminui/features_controller.rb

@@ -80,8 +80,11 @@ module Magick
       end
 
       def enable
-        @feature.enable
-        redirect_to magick_admin_ui.features_path, notice: 'Feature enabled'
+        if @feature.enable
+          redirect_to magick_admin_ui.features_path, notice: 'Feature enabled'
+        else
+          redirect_to magick_admin_ui.feature_path(@feature.name), alert: 'Cannot enable feature — its dependencies must be enabled first'
+        end
       end
 
       def disable

data/lib/magick/feature.rb

@@ -516,20 +516,16 @@ module Magick
     end
 
     def enable(user_id: nil)
-      # Check if this feature is a dependency of any disabled features
-      # If a main feature that depends on this feature is disabled, prevent enabling this dependency
-      # Dependencies cannot be enabled until the main feature is enabled
-      dependent_features = find_dependent_features
-      disabled_dependents = dependent_features.select do |dep_feature_name|
-        dep_feature = Magick.features[dep_feature_name.to_s] || Magick[dep_feature_name]
-        # Check if the dependent feature (main feature) is disabled
-        dep_feature && !dep_feature.enabled?
-      end
+      # Check that all of this feature's own dependencies are enabled
+      # e.g. if checkout depends on payments, checkout can't be enabled until payments is
+      deps = @dependencies || []
+      unless deps.empty?
+        disabled_deps = deps.select do |dep_name|
+          dep_feature = Magick.features[dep_name.to_s] || Magick[dep_name]
+          dep_feature && !dep_feature.enabled?
+        end
 
-      unless disabled_dependents.empty?
-        # Return false if any main feature that depends on this feature is disabled
-        # This prevents enabling a dependency when the main feature is disabled
-        return false
+        return false unless disabled_deps.empty?
       end
 
       # Clear all targeting to enable globally
@@ -988,13 +984,12 @@ module Magick
     end
 
     def disable_dependent_features(user_id: nil)
-      # Cascade-disable this feature's own dependencies (downstream sub-features).
-      # e.g. if A depends on B, disabling A also disables B.
-      # But disabling B does NOT cascade up to A.
-      deps = @dependencies || []
-      return if deps.empty?
+      # Cascade-disable features that depend ON this feature.
+      # e.g. if checkout depends on payments, disabling payments also disables checkout.
+      dependents = find_dependent_features
+      return if dependents.empty?
 
-      deps.each do |dep_name|
+      dependents.each do |dep_name|
         dep_feature = Magick.features[dep_name.to_s] || Magick[dep_name]
         next unless dep_feature
 

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '1.3.0'
+  VERSION = '1.3.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Andrew Lobanov