magick-feature-flags 0.9.6 → 0.9.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c89e62bee50614e51b3e844968d557e90217cd48e77bb68ec50c47d48881389b
-  data.tar.gz: d39574add8463bb4a927ea94db047d3418317d966b77f400892f67ed6bf4a31c
+  metadata.gz: a7f546b5a885a633524d3b0c405e296621f00eaeabb7b65339160c5aa0911ead
+  data.tar.gz: 07af571d3fdba904c122c5e8996c58fcaac31d515bd955f57aa640d66373376b
 SHA512:
-  metadata.gz: 133bbce3e15f14c39181eaf2078e0bec80fcc2aa295d85397bcb78f95400637e046dd9749f5c8ed65291f2c2e8b562ac8ced6b3df39dd3d625536a58851cefbb
-  data.tar.gz: 3a8578be1de567da37d0393e07302934176100bed9d9239bad978c757ed65a6f58770cc3a9b6b6fb5d73fd2393007053bc43c32b466b9bd167e97d5e775c6be0
+  metadata.gz: 75608b0d581c01aa0a25a362bb45c6cdcb4e8b3ee0316663d1ec6e521b9af3099192d1e2a38fcc13ead9adb256c1fda09934fef749323fc7e94cbaa7daac7c3f
+  data.tar.gz: ca5643cbd9bdeffeb8c8e1116b4631c6bedde59c2bd050936a77b6bdece35fc67955608ecccba41a7eaaffe59da769a0b74c59f9cb57372fbd07b281c188b397

data/README.md

@@ -82,7 +82,12 @@ Magick.configure do
   async_updates enabled: true
 
   # Enable services
-  performance_metrics enabled: true
+  performance_metrics(
+    enabled: true,
+    redis_tracking: true,  # Auto-enabled if Redis is configured
+    batch_size: 100,       # Flush after 100 updates
+    flush_interval: 60     # Or flush every 60 seconds
+  )
   audit_log enabled: true
   versioning enabled: true
   warn_on_deprecated enabled: true
@@ -295,7 +300,16 @@ variant = feature.get_variant
 ```ruby
 feature = Magick[:advanced_feature]
 feature.add_dependency(:base_feature)
-# advanced_feature will only be enabled if base_feature is also enabled
+# advanced_feature can be enabled independently
+# However, base_feature (dependency) cannot be enabled if advanced_feature (main feature) is disabled
+# This ensures dependencies are only enabled when their parent features are enabled
+
+# Example:
+Magick[:advanced_feature].disable  # => true
+Magick[:base_feature].enable        # => false (cannot enable dependency when main feature is disabled)
+
+Magick[:advanced_feature].enable   # => true
+Magick[:base_feature].enable        # => true (now can enable dependency)
 ```
 
 #### Export/Import
@@ -322,16 +336,55 @@ Magick.versioning.rollback(:my_feature, version: 2)
 #### Performance Metrics
 
 ```ruby
-# Get average duration for feature checks
-avg_duration = Magick.performance_metrics.average_duration(feature_name: :my_feature)
+# Get comprehensive stats for a feature
+Magick.feature_stats(:my_feature)
+# => {
+#   usage_count: 1250,
+#   average_duration: 0.032,
+#   average_duration_by_operation: {
+#     enabled: 0.032,
+#     value: 0.0,
+#     get_value: 0.0
+#   }
+# }
+
+# Get just the usage count
+Magick.feature_usage_count(:my_feature)
+# => 1250
+
+# Get average duration (optionally filtered by operation)
+Magick.feature_average_duration(:my_feature)
+Magick.feature_average_duration(:my_feature, operation: 'enabled?')
 
 # Get most used features
-most_used = Magick.performance_metrics.most_used_features(limit: 10)
+Magick.most_used_features(limit: 10)
+# => {
+#   "my_feature" => 1250,
+#   "another_feature" => 890,
+#   ...
+# }
+
+# Direct access to performance metrics (for advanced usage)
+Magick.performance_metrics.average_duration(feature_name: :my_feature)
+Magick.performance_metrics.usage_count(:my_feature)
+Magick.performance_metrics.most_used_features(limit: 10)
+```
+
+**Configuration:**
 
-# Get usage count
-count = Magick.performance_metrics.usage_count(:my_feature)
+```ruby
+Magick.configure do
+  performance_metrics(
+    enabled: true,
+    redis_tracking: true,  # Auto-enabled if Redis is configured
+    batch_size: 100,       # Flush after 100 updates
+    flush_interval: 60     # Or flush every 60 seconds
+  )
+end
 ```
 
+**Note:** When `redis_tracking: true` is set, usage counts are persisted to Redis and aggregated across all processes, giving you total usage statistics.
+
 #### Audit Logging
 
 ```ruby
@@ -351,7 +404,10 @@ Magick uses a dual-adapter strategy:
 1. **Memory Adapter**: Fast, in-memory storage with TTL support
 2. **Redis Adapter**: Persistent storage for distributed systems (optional)
 
-The registry automatically falls back from memory to Redis if a feature isn't found in memory. When features are updated, both adapters are updated simultaneously.
+The registry automatically falls back from memory to Redis if a feature isn't found in memory. When features are updated:
+- Both adapters are updated simultaneously
+- Cache invalidation messages are published via Redis Pub/Sub to notify other processes
+- Targeting updates trigger immediate cache invalidation to ensure consistency
 
 #### Memory-Only Mode
 

data/lib/magick/adapters/registry.rb

@@ -92,6 +92,11 @@ module Magick
         publish_cache_invalidation(feature_name)
       end
 
+      # Check if Redis adapter is available
+      def redis_available?
+        !redis_adapter.nil?
+      end
+
       private
 
       attr_reader :memory_adapter, :redis_adapter, :circuit_breaker

data/lib/magick/config.rb

@@ -48,12 +48,16 @@ module Magick
       return unless enabled
 
       @performance_metrics = PerformanceMetrics.new(batch_size: batch_size, flush_interval: flush_interval)
-      # Enable Redis tracking if Redis adapter is configured (or explicitly set)
-      if redis_tracking.nil?
-        # Auto-enable if Redis adapter exists
-        redis_tracking = !@redis_url.nil? || configure_redis_adapter != nil
+      # Store redis_tracking preference for later application
+      @performance_metrics_redis_tracking = redis_tracking
+      # Enable Redis tracking if explicitly set to true, otherwise defer to apply! method
+      if redis_tracking == true
+        @performance_metrics.enable_redis_tracking(enable: true)
+      elsif redis_tracking == false
+        @performance_metrics.enable_redis_tracking(enable: false)
       end
-      @performance_metrics.enable_redis_tracking(enable: redis_tracking) if @performance_metrics
+      # If nil, will be auto-determined in apply! method
+      @performance_metrics
     end
 
     def audit_log(enabled: true, adapter: nil)
@@ -90,15 +94,23 @@ module Magick
     def apply!
       # Apply configuration to Magick module
       Magick.adapter_registry = adapter_registry if adapter_registry
-      Magick.performance_metrics = performance_metrics if performance_metrics
+
+      # Apply performance metrics (preserve redis_tracking setting)
+      if performance_metrics
+        Magick.performance_metrics = performance_metrics
+        # Re-apply redis_tracking setting after assignment (in case object was replaced)
+        if defined?(@performance_metrics_redis_tracking) && !@performance_metrics_redis_tracking.nil?
+          Magick.performance_metrics.enable_redis_tracking(enable: @performance_metrics_redis_tracking)
+        # Otherwise, auto-enable if Redis adapter is configured
+        # Check Magick.adapter_registry (after it's been set) instead of local instance variable
+        elsif Magick.adapter_registry.is_a?(Adapters::Registry) && Magick.adapter_registry.redis_available?
+          Magick.performance_metrics.enable_redis_tracking(enable: true)
+        end
+      end
+
       Magick.audit_log = audit_log if audit_log
       Magick.versioning = versioning if versioning
       Magick.warn_on_deprecated = warn_on_deprecated
-
-      # Enable Redis tracking for performance metrics if Redis adapter is configured
-      if Magick.performance_metrics && adapter_registry.is_a?(Adapters::Registry) && adapter_registry.redis_adapter
-        Magick.performance_metrics.enable_redis_tracking(enable: true)
-      end
     end
 
     private

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.9.6'
+  VERSION = '0.9.8'
 end

data/lib/magick.rb

@@ -128,6 +128,46 @@ module Magick
       @versioning ||= Versioning.new(adapter_registry || default_adapter_registry)
     end
 
+    # Manually enable Redis tracking for performance metrics
+    # Useful if Redis adapter becomes available after initial configuration
+    def enable_redis_tracking(enable: true)
+      return unless performance_metrics
+
+      performance_metrics.enable_redis_tracking(enable: enable)
+    end
+
+    # Get total usage count for a feature (combines memory and Redis counts)
+    def feature_stats(feature_name)
+      return {} unless performance_metrics
+
+      {
+        usage_count: performance_metrics.usage_count(feature_name),
+        average_duration: performance_metrics.average_duration(feature_name: feature_name),
+        average_duration_by_operation: {
+          enabled: performance_metrics.average_duration(feature_name: feature_name, operation: 'enabled?'),
+          value: performance_metrics.average_duration(feature_name: feature_name, operation: 'value'),
+          get_value: performance_metrics.average_duration(feature_name: feature_name, operation: 'get_value')
+        }
+      }
+    end
+
+    # Get usage count for a feature
+    def feature_usage_count(feature_name)
+      performance_metrics&.usage_count(feature_name) || 0
+    end
+
+    # Get average duration for a feature (optionally filtered by operation)
+    def feature_average_duration(feature_name, operation: nil)
+      return 0.0 unless performance_metrics
+
+      performance_metrics.average_duration(feature_name: feature_name, operation: operation)
+    end
+
+    # Get most used features
+    def most_used_features(limit: 10)
+      performance_metrics&.most_used_features(limit: limit) || {}
+    end
+
     def reset!
       @features = {}
       @adapter_registry = nil

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.9.6
+  version: 0.9.8
 platform: ruby
 authors:
 - Andrew Lobanov