magick-feature-flags 0.9.5 → 0.9.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: db6e3bc7c41ca6efc8b8d1e0c3a37bb12ee979f012bb76482b7e45e65b89d2c9
-  data.tar.gz: fb85c3f115744839d1fcc909e4bb495c3182bddd70977f4a6db525efe4d67e81
+  metadata.gz: 015b9568cac92b03d1776240c7236cb395d15189eb496e03ac803979fef2d77d
+  data.tar.gz: 3219b3349bb202775c883d7b977ca0dd8d64846625a524abbe858c6d51d9db43
 SHA512:
-  metadata.gz: 895c93c5620618068c67643a1d5d989e385dd8c311714cf7af1e0b910a1b32f79739c55f3b7a8f987e73ea58dc7795b381fa2590dcd5bc73a0f4767578cbdb87
-  data.tar.gz: 677a4ec77be3a13ed1c18ddd37c7609aff6c151dfff0be9a975d40742bb26b6adc86ed9e9c10e57490d665e3e3ec0fc685e36c7f272d16a4688a2829faa26419
+  metadata.gz: d93760f46cd383bc5b97f032a992fe4e0fc6e567d50985ab2544475805ffbb4545b105c8033a7aafb5a48149c1169ab7f87e6e70da58bcbfd2554a1935608bb3
+  data.tar.gz: 19424a6172af8421a2041a4259f5474a4cffa7cf62cd03582b23f479374b7ca3a9aa56ca57f69e7facae4e372662d70abf80384456247d801ffd6eee141acd56

data/README.md

@@ -82,7 +82,12 @@ Magick.configure do
   async_updates enabled: true
 
   # Enable services
-  performance_metrics enabled: true
+  performance_metrics(
+    enabled: true,
+    redis_tracking: true,  # Auto-enabled if Redis is configured
+    batch_size: 100,       # Flush after 100 updates
+    flush_interval: 60     # Or flush every 60 seconds
+  )
   audit_log enabled: true
   versioning enabled: true
   warn_on_deprecated enabled: true
@@ -295,7 +300,16 @@ variant = feature.get_variant
 ```ruby
 feature = Magick[:advanced_feature]
 feature.add_dependency(:base_feature)
-# advanced_feature will only be enabled if base_feature is also enabled
+# advanced_feature can be enabled independently
+# However, base_feature (dependency) cannot be enabled if advanced_feature (main feature) is disabled
+# This ensures dependencies are only enabled when their parent features are enabled
+
+# Example:
+Magick[:advanced_feature].disable  # => true
+Magick[:base_feature].enable        # => false (cannot enable dependency when main feature is disabled)
+
+Magick[:advanced_feature].enable   # => true
+Magick[:base_feature].enable        # => true (now can enable dependency)
 ```
 
 #### Export/Import
@@ -322,16 +336,55 @@ Magick.versioning.rollback(:my_feature, version: 2)
 #### Performance Metrics
 
 ```ruby
-# Get average duration for feature checks
-avg_duration = Magick.performance_metrics.average_duration(feature_name: :my_feature)
+# Get comprehensive stats for a feature
+Magick.feature_stats(:my_feature)
+# => {
+#   usage_count: 1250,
+#   average_duration: 0.032,
+#   average_duration_by_operation: {
+#     enabled: 0.032,
+#     value: 0.0,
+#     get_value: 0.0
+#   }
+# }
+
+# Get just the usage count
+Magick.feature_usage_count(:my_feature)
+# => 1250
+
+# Get average duration (optionally filtered by operation)
+Magick.feature_average_duration(:my_feature)
+Magick.feature_average_duration(:my_feature, operation: 'enabled?')
 
 # Get most used features
-most_used = Magick.performance_metrics.most_used_features(limit: 10)
+Magick.most_used_features(limit: 10)
+# => {
+#   "my_feature" => 1250,
+#   "another_feature" => 890,
+#   ...
+# }
+
+# Direct access to performance metrics (for advanced usage)
+Magick.performance_metrics.average_duration(feature_name: :my_feature)
+Magick.performance_metrics.usage_count(:my_feature)
+Magick.performance_metrics.most_used_features(limit: 10)
+```
+
+**Configuration:**
 
-# Get usage count
-count = Magick.performance_metrics.usage_count(:my_feature)
+```ruby
+Magick.configure do
+  performance_metrics(
+    enabled: true,
+    redis_tracking: true,  # Auto-enabled if Redis is configured
+    batch_size: 100,       # Flush after 100 updates
+    flush_interval: 60     # Or flush every 60 seconds
+  )
+end
 ```
 
+**Note:** When `redis_tracking: true` is set, usage counts are persisted to Redis and aggregated across all processes, giving you total usage statistics.
+
 #### Audit Logging
 
 ```ruby
@@ -351,7 +404,10 @@ Magick uses a dual-adapter strategy:
 1. **Memory Adapter**: Fast, in-memory storage with TTL support
 2. **Redis Adapter**: Persistent storage for distributed systems (optional)
 
-The registry automatically falls back from memory to Redis if a feature isn't found in memory. When features are updated, both adapters are updated simultaneously.
+The registry automatically falls back from memory to Redis if a feature isn't found in memory. When features are updated:
+- Both adapters are updated simultaneously
+- Cache invalidation messages are published via Redis Pub/Sub to notify other processes
+- Targeting updates trigger immediate cache invalidation to ensure consistency
 
 #### Memory-Only Mode
 

data/lib/magick/adapters/registry.rb

@@ -86,6 +86,12 @@ module Magick
         (memory_features + redis_features).uniq
       end
 
+      # Explicitly trigger cache invalidation for a feature
+      # This is useful for targeting updates that need immediate cache invalidation
+      def invalidate_cache(feature_name)
+        publish_cache_invalidation(feature_name)
+      end
+
       private
 
       attr_reader :memory_adapter, :redis_adapter, :circuit_breaker

data/lib/magick/config.rb

@@ -48,12 +48,15 @@ module Magick
       return unless enabled
 
       @performance_metrics = PerformanceMetrics.new(batch_size: batch_size, flush_interval: flush_interval)
-      # Enable Redis tracking if Redis adapter is configured (or explicitly set)
-      if redis_tracking.nil?
-        # Auto-enable if Redis adapter exists
-        redis_tracking = !@redis_url.nil? || configure_redis_adapter != nil
+      # Store redis_tracking preference for later application
+      @performance_metrics_redis_tracking = redis_tracking
+      # Enable Redis tracking if explicitly set to true, otherwise defer to apply! method
+      if redis_tracking == true
+        @performance_metrics.enable_redis_tracking(enable: true)
+      elsif redis_tracking == false
+        @performance_metrics.enable_redis_tracking(enable: false)
       end
-      @performance_metrics.enable_redis_tracking(enable: redis_tracking) if @performance_metrics
+      # If nil, will be auto-determined in apply! method
     end
 
     def audit_log(enabled: true, adapter: nil)
@@ -95,9 +98,15 @@ module Magick
       Magick.versioning = versioning if versioning
       Magick.warn_on_deprecated = warn_on_deprecated
 
-      # Enable Redis tracking for performance metrics if Redis adapter is configured
-      if Magick.performance_metrics && adapter_registry.is_a?(Adapters::Registry) && adapter_registry.redis_adapter
-        Magick.performance_metrics.enable_redis_tracking(enable: true)
+      # Enable Redis tracking for performance metrics
+      if Magick.performance_metrics
+        # If redis_tracking was explicitly set, use that value
+        if defined?(@performance_metrics_redis_tracking) && !@performance_metrics_redis_tracking.nil?
+          Magick.performance_metrics.enable_redis_tracking(enable: @performance_metrics_redis_tracking)
+        # Otherwise, auto-enable if Redis adapter is configured
+        elsif adapter_registry.is_a?(Adapters::Registry) && adapter_registry.redis_adapter
+          Magick.performance_metrics.enable_redis_tracking(enable: true)
+        end
       end
     end
 

data/lib/magick/feature.rb

@@ -74,7 +74,7 @@ module Magick
       return false if status == :inactive
       return false if status == :deprecated && !context[:allow_deprecated]
 
-      # Note: We don't check dependencies here because:
+      # NOTE: We don't check dependencies here because:
       # - Main features can be enabled independently
       # - Dependencies are only prevented from being enabled if the main feature is disabled
       # - The dependency check is handled in the enable() method, not in enabled?()
@@ -463,6 +463,7 @@ module Magick
     def delete
       adapter_registry.delete(name)
       @stored_value = nil
+      @stored_value_initialized = false # Reset initialization flag so get_value returns default_value
       @targeting = {}
       # Also remove from Magick.features if registered
       Magick.features.delete(name.to_s)
@@ -822,11 +823,20 @@ module Magick
     end
 
     def save_targeting
+      # Save targeting to adapter (this triggers cache invalidation via Pub/Sub)
       adapter_registry.set(name, 'targeting', targeting)
+
       # Update the feature in Magick.features if it's registered
       return unless Magick.features.key?(name)
 
       Magick.features[name].instance_variable_set(:@targeting, targeting.dup)
+
+      # Explicitly trigger cache invalidation for targeting updates
+      # Targeting changes affect enabled? checks, so we need immediate cache invalidation
+      # even if async updates are enabled
+      return unless adapter_registry.respond_to?(:invalidate_cache)
+
+      adapter_registry.invalidate_cache(name)
     end
 
     def default_for_type

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.9.5'
+  VERSION = '0.9.7'
 end

data/lib/magick.rb

@@ -128,6 +128,38 @@ module Magick
       @versioning ||= Versioning.new(adapter_registry || default_adapter_registry)
     end
 
+    # Get total usage count for a feature (combines memory and Redis counts)
+    def feature_stats(feature_name)
+      return {} unless performance_metrics
+
+      {
+        usage_count: performance_metrics.usage_count(feature_name),
+        average_duration: performance_metrics.average_duration(feature_name: feature_name),
+        average_duration_by_operation: {
+          enabled: performance_metrics.average_duration(feature_name: feature_name, operation: 'enabled?'),
+          value: performance_metrics.average_duration(feature_name: feature_name, operation: 'value'),
+          get_value: performance_metrics.average_duration(feature_name: feature_name, operation: 'get_value')
+        }
+      }
+    end
+
+    # Get usage count for a feature
+    def feature_usage_count(feature_name)
+      performance_metrics&.usage_count(feature_name) || 0
+    end
+
+    # Get average duration for a feature (optionally filtered by operation)
+    def feature_average_duration(feature_name, operation: nil)
+      return 0.0 unless performance_metrics
+
+      performance_metrics.average_duration(feature_name: feature_name, operation: operation)
+    end
+
+    # Get most used features
+    def most_used_features(limit: 10)
+      performance_metrics&.most_used_features(limit: limit) || {}
+    end
+
     def reset!
       @features = {}
       @adapter_registry = nil

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.9.5
+  version: 0.9.7
 platform: ruby
 authors:
 - Andrew Lobanov