magick-feature-flags 0.9.27 → 0.9.29

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2d9899b591d5ec1be511af30b937a34c676afae3b82cb79bfdc902aadadf9064
-  data.tar.gz: 2a0bdd7d7edac034d652a709dafa7e46d24f2674f0e2335bd50fc44755ab0238
+  metadata.gz: f1083faa87c666482ed4ad7d0497e8ffcd7971f735ec1060d211f56e2ebbb756
+  data.tar.gz: 444ef7774e1f944f39f133ef8f6b37a94915574c54ec9b562e3623d5b1ab4d08
 SHA512:
-  metadata.gz: 401bfd7caa17aca83411668f7ac024a734131dbd130f24628ee5ef0f34f6b45ac06ca118c0aa903d53ee09f045f081e272bcd09f21820e9c07c16edbdc9f81c3
-  data.tar.gz: '08ad203ed9b79dcb39c5e6e6a79fa497332e52bd84482c629275ce43e38d77894ad31b2b0480feb4a27975a4317f16172182c60e73a5169888bf3ae716b6f140'
+  metadata.gz: bd0f4cc40177fcf796461f84e4ff4b63fd569b5828d0ebc8c2d3c8130b4938db02f747e223858267e96c0ebd471d46e6e437efb97f8f073e888f05cdab737876
+  data.tar.gz: 8cd773acbaf174f5e96c9eed9f3103f241936ac61941cb533ab335df4d60bfc7fe13dab0e639b344715c4d0a358eb0c245ce4f038a54f67942acbb15fad9d338

data/lib/magick/adapters/registry.rb

@@ -15,6 +15,8 @@ module Magick
         @primary = primary || :memory # :memory, :redis, or :active_record
         @subscriber_thread = nil
         @subscriber = nil
+        @last_reload_times = {} # Track last reload time per feature for debouncing
+        @reload_mutex = Mutex.new
         # Only start Pub/Sub subscriber if Redis is available
         # In memory-only mode, each process has isolated cache (no cross-process invalidation)
         start_cache_invalidation_subscriber if redis_adapter
@@ -187,6 +189,21 @@ module Magick
             on.message do |_channel, feature_name|
               feature_name_str = feature_name.to_s
 
+              # Debounce: only reload if we haven't reloaded this feature in the last 100ms
+              # This prevents duplicate reloads from multiple invalidation messages
+              should_reload = @reload_mutex.synchronize do
+                last_reload = @last_reload_times[feature_name_str]
+                now = Time.now.to_f
+                if last_reload.nil? || (now - last_reload) > 0.1 # 100ms debounce
+                  @last_reload_times[feature_name_str] = now
+                  true
+                else
+                  false
+                end
+              end
+
+              next unless should_reload
+
               # Invalidate memory cache for this feature
               memory_adapter.delete(feature_name_str) if memory_adapter
 
@@ -196,7 +213,7 @@ module Magick
                 feature = Magick.features[feature_name_str]
                 if feature.respond_to?(:reload)
                   feature.reload
-                  # Log for debugging (only in development)
+                  # Log for debugging (only in development, and only once per debounce period)
                   if defined?(Rails) && Rails.env.development?
                     Rails.logger.debug "Magick: Reloaded feature '#{feature_name_str}' after cache invalidation"
                   end

data/lib/magick/admin_ui/engine.rb

@@ -16,6 +16,11 @@ module Magick
 
       engine_name 'magick_admin_ui'
 
+      # Ensure the engine doesn't interfere with Warden/Devise middleware
+      # Rails engines by default inherit middleware from the main app, which is what we want
+      # We don't add any custom middleware that could interfere with Warden/Devise
+      # The engine should work alongside existing authentication middleware without modification
+
       # Rails engines automatically detect app/views and app/controllers directories
       # With isolate_namespace, views should be at:
       # app/views/magick/adminui/[controller]/[action].html.erb

data/lib/magick/feature.rb

@@ -563,6 +563,7 @@ module Magick
 
     def save_targeting
       # Save targeting to adapter (this updates memory synchronously, then Redis/AR)
+      # The set method already publishes cache invalidation to other processes via Pub/Sub
       adapter_registry.set(name, 'targeting', targeting)
 
       # Update the feature in Magick.features if it's registered
@@ -575,14 +576,10 @@ module Magick
       # Update local targeting empty cache for performance
       @_targeting_empty = targeting.empty?
 
-      # Explicitly publish cache invalidation to other processes via Pub/Sub
-      # This ensures other Rails app instances/consoles invalidate their cache and reload
-      # Note: We don't invalidate local cache here because we just updated it above
-      # The set method publishes cache invalidation, but we also publish here to ensure
-      # it happens even if Redis update fails or is async
-      if adapter_registry.respond_to?(:publish_cache_invalidation)
-        adapter_registry.publish_cache_invalidation(name)
-      end
+      # Note: We don't need to explicitly publish cache invalidation here because:
+      # 1. adapter_registry.set already publishes cache invalidation (synchronously for async Redis updates)
+      # 2. Publishing twice causes duplicate reloads in other processes
+      # 3. The set method handles both sync and async Redis updates correctly
     end
 
     private

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.9.27'
+  VERSION = '0.9.29'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.9.27
+  version: 0.9.29
 platform: ruby
 authors:
 - Andrew Lobanov