magick-feature-flags 0.9.22 → 0.9.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 42699b3af1d542ac14b10f2b82ea4156da27b68e3e2a07e715cd528f0e3f936b
-  data.tar.gz: 0c5235c6cb220201ed0443d1a4633009325d410620d8d28ecbb836cac01bdc25
+  metadata.gz: 0cae8aed5b88784ad2c7b2635b377cd17270044eea05e4f47a18bd3a209c9e3f
+  data.tar.gz: f2c69d41bd7a26010f25eee8e0088d660e90fdeb976de961192dcbc52c781c3d
 SHA512:
-  metadata.gz: 10fb678c4aeaf5a17f721341e01ec937bf9a14042e4a90fa0bcc1aba13c5e91272aba144fa05913a020660ffd602ccf7481d216e92364338c7e4a111794e0896
-  data.tar.gz: '079e2d11d6ab0339929f965c1eb05fc934ea88522f26e268df324c366ad28268f87131233fe0f2315a5494328ae5fa18790e8e512fa550372852c3c1d61c3faf'
+  metadata.gz: 7a184080f97332ecac03e71f3ae72791ed3a01389a05f84dfdab7d6588dca2a0e8da7c5c5f78b9dc7fee05c09ddbdb302bd8cc97e8a6af0b276e621a01331640
+  data.tar.gz: c51c09f333e04b46e980c8c6ff67d434611208d716757b53850d625630a48c73c6f4c961f091909ade1fd33d0170f0128111fefb1d1a181f9a012e77be2be1ab

data/lib/magick/performance_metrics.rb

@@ -40,23 +40,43 @@ module Magick
       @_rails_events_enabled = defined?(Magick::Rails::Events) && Magick::Rails::Events.rails8?
       @_adapter_available = nil # Will be cached on first check
       @_redis_available = nil # Will be cached on first check
+
+      # Async recording queue for non-blocking metrics
+      @async_queue = Queue.new
+      @async_thread = nil
+      @async_enabled = true # Enable async by default for performance
+      start_async_processor
     end
 
     # Public accessor for redis_enabled
     attr_reader :redis_enabled
 
     def record(feature_name, operation, duration, success: true)
-      # Fast path: minimize work in mutex
-      feature_name_str = feature_name.to_s
+      # Fast path: push to async queue (non-blocking, zero overhead in hot path)
+      # Queue#<< is thread-safe and lock-free - extremely fast!
+      return unless @async_enabled
+
+      # Push to async queue - this is lock-free and extremely fast
+      # Use non-blocking push (will raise if queue is full, but our queue is unbounded)
+      begin
+        @async_queue << [feature_name.to_s, operation.to_s, duration, success]
+      rescue ThreadError, ClosedQueueError
+        # Queue is closed or thread died, disable async
+        @async_enabled = false
+      end
+
+      nil
+    end
 
+    # Internal: Process metrics from async queue (runs in background thread)
+    def process_async_record(feature_name_str, operation_str, duration, success)
       # Minimize mutex lock time - only update counters
       pending_count = nil
       total_pending = nil
       @mutex.synchronize do
         # Only create Metric object if we're keeping metrics in memory
-        # Most of the time we just need counters, not full metric objects
         if @metrics.length < 1000
-          metric = Metric.new(feature_name_str, operation, duration, success: success)
+          metric = Metric.new(feature_name_str, operation_str, duration, success: success)
           @metrics << metric
         end
         @usage_count[feature_name_str] += 1
@@ -69,14 +89,48 @@ module Magick
 
       # Rails 8+ event for usage tracking (cached check)
       if @_rails_events_enabled
-        Magick::Rails::Events.usage_tracked(feature_name, operation: operation, duration: duration, success: success)
+        Magick::Rails::Events.usage_tracked(feature_name_str, operation: operation_str, duration: duration,
+                                                              success: success)
       end
 
-      # Batch flush check - only if we're close to batch size (avoid expensive checks)
-      # Check pending count first before doing expensive adapter checks
+      # Batch flush check - only if we're close to batch size
       flush_to_redis_if_needed if pending_count >= @batch_size || total_pending >= @batch_size
+    end
 
-      nil # Don't return metric object to avoid allocation overhead
+    # Start background thread to process async metrics
+    def start_async_processor
+      return if @async_thread&.alive?
+
+      @async_thread = Thread.new do
+        last_flush_check = Time.now
+        loop do
+          # Wait for metrics with timeout to allow periodic flush checks
+          # Queue#pop with timeout returns nil on timeout, raises on closed queue
+          begin
+            data = @async_queue.pop(timeout: 1.0)
+          rescue ThreadError => e
+            # Queue closed or thread interrupted
+            break if e.message.include?('queue closed')
+
+            raise
+          end
+
+          if data
+            feature_name_str, operation_str, duration, success = data
+            process_async_record(feature_name_str, operation_str, duration, success)
+            last_flush_check = Time.now
+          elsif Time.now - last_flush_check >= 1.0
+            # Timeout - check if we need to flush based on time (every second)
+            flush_to_redis_if_needed
+            last_flush_check = Time.now
+          end
+        rescue StandardError => e
+          # Log error but continue processing
+          warn "Magick: Error in async metrics processor: #{e.message}" if defined?(Rails) && Rails.env.development?
+          sleep 0.1 # Brief pause on error
+        end
+      end
+      @async_thread.abort_on_exception = false
     end
 
     def flush_to_redis_if_needed
@@ -326,5 +380,13 @@ module Magick
         @flushed_counts.clear
       end
     end
+
+    # Stop async processor (for cleanup)
+    def stop_async_processor
+      @async_enabled = false
+      @async_queue.close if @async_queue.respond_to?(:close)
+      @async_thread&.kill
+      @async_thread = nil
+    end
   end
 end

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.9.22'
+  VERSION = '0.9.23'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.9.22
+  version: 0.9.23
 platform: ruby
 authors:
 - Andrew Lobanov