magick-feature-flags 0.9.21 → 0.9.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 467ad50ad54569fd4ac8562da75e37672716b980cfdfb03da79b2f29950fd4c9
-  data.tar.gz: 0b89ad165e8aad8fb2074821025bd7e50ef2568cc46f5b750bfc4c91c6e11658
+  metadata.gz: 0cae8aed5b88784ad2c7b2635b377cd17270044eea05e4f47a18bd3a209c9e3f
+  data.tar.gz: f2c69d41bd7a26010f25eee8e0088d660e90fdeb976de961192dcbc52c781c3d
 SHA512:
-  metadata.gz: 7b3fa0a75bd127f269ecafcddfbe6dcba8d45a247d6b47d83085a097f58de6b74c570eb0655fd4a97c78d8335ff1916a57b3eb2b891143d6a2cc585acc5ff87c
-  data.tar.gz: 79cf7083e34daab0c569e9e05d6e0b123167692f2b206b67ae53321ddabe722861e701346dd5cac80c6b1898be75140ed52fd93470b9a19ccf8113ebf6d91a16
+  metadata.gz: 7a184080f97332ecac03e71f3ae72791ed3a01389a05f84dfdab7d6588dca2a0e8da7c5c5f78b9dc7fee05c09ddbdb302bd8cc97e8a6af0b276e621a01331640
+  data.tar.gz: c51c09f333e04b46e980c8c6ff67d434611208d716757b53850d625630a48c73c6f4c961f091909ade1fd33d0170f0128111fefb1d1a181f9a012e77be2be1ab

data/lib/magick/feature.rb

@@ -52,11 +52,12 @@ module Magick
       return check_enabled(context) unless perf_metrics_enabled
 
       # Performance metrics enabled: measure and record
+      # Use inline timing to avoid function call overhead
       start_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       result = check_enabled(context)
       duration = (Process.clock_gettime(Process::CLOCK_MONOTONIC) - start_time) * 1000 # milliseconds
 
-      # Record metrics (only if enabled)
+      # Record metrics (fast path - minimal overhead)
       perf_metrics.record(name, 'enabled?', duration, success: true)
 
       # Rails 8+ events (only in development or when explicitly enabled)

data/lib/magick/performance_metrics.rb

@@ -36,44 +36,113 @@ module Magick
       # If redis_enabled is explicitly set, use it; otherwise default to false
       # It will be enabled later via enable_redis_tracking if Redis adapter is available
       @redis_enabled = redis_enabled.nil? ? false : redis_enabled
+      # Cache expensive checks for performance
+      @_rails_events_enabled = defined?(Magick::Rails::Events) && Magick::Rails::Events.rails8?
+      @_adapter_available = nil # Will be cached on first check
+      @_redis_available = nil # Will be cached on first check
+
+      # Async recording queue for non-blocking metrics
+      @async_queue = Queue.new
+      @async_thread = nil
+      @async_enabled = true # Enable async by default for performance
+      start_async_processor
     end
 
     # Public accessor for redis_enabled
     attr_reader :redis_enabled
 
     def record(feature_name, operation, duration, success: true)
-      feature_name_str = feature_name.to_s
-      metric = Metric.new(feature_name_str, operation, duration, success: success)
+      # Fast path: push to async queue (non-blocking, zero overhead in hot path)
+      # Queue#<< is thread-safe and lock-free - extremely fast!
+      return unless @async_enabled
+
+      # Push to async queue - this is lock-free and extremely fast
+      # Use non-blocking push (will raise if queue is full, but our queue is unbounded)
+      begin
+        @async_queue << [feature_name.to_s, operation.to_s, duration, success]
+      rescue ThreadError, ClosedQueueError
+        # Queue is closed or thread died, disable async
+        @async_enabled = false
+      end
+
+      nil
+    end
 
+    # Internal: Process metrics from async queue (runs in background thread)
+    def process_async_record(feature_name_str, operation_str, duration, success)
+      # Minimize mutex lock time - only update counters
+      pending_count = nil
+      total_pending = nil
       @mutex.synchronize do
-        @metrics << metric
+        # Only create Metric object if we're keeping metrics in memory
+        if @metrics.length < 1000
+          metric = Metric.new(feature_name_str, operation_str, duration, success: success)
+          @metrics << metric
+        end
         @usage_count[feature_name_str] += 1
         @pending_updates[feature_name_str] += 1
+        pending_count = @pending_updates[feature_name_str]
+        total_pending = @pending_updates.values.sum
         # Keep only last 1000 metrics (as a safety limit)
-        # Note: Metrics are removed from memory after flushing to Redis to reduce memory usage
         @metrics.shift if @metrics.length > 1000
       end
 
-      # Rails 8+ event for usage tracking
-      if defined?(Magick::Rails::Events) && Magick::Rails::Events.rails8?
-        Magick::Rails::Events.usage_tracked(feature_name, operation: operation, duration: duration, success: success)
+      # Rails 8+ event for usage tracking (cached check)
+      if @_rails_events_enabled
+        Magick::Rails::Events.usage_tracked(feature_name_str, operation: operation_str, duration: duration,
+                                                              success: success)
       end
 
-      # Batch flush to Redis if needed
-      flush_to_redis_if_needed
+      # Batch flush check - only if we're close to batch size
+      flush_to_redis_if_needed if pending_count >= @batch_size || total_pending >= @batch_size
+    end
+
+    # Start background thread to process async metrics
+    def start_async_processor
+      return if @async_thread&.alive?
+
+      @async_thread = Thread.new do
+        last_flush_check = Time.now
+        loop do
+          # Wait for metrics with timeout to allow periodic flush checks
+          # Queue#pop with timeout returns nil on timeout, raises on closed queue
+          begin
+            data = @async_queue.pop(timeout: 1.0)
+          rescue ThreadError => e
+            # Queue closed or thread interrupted
+            break if e.message.include?('queue closed')
+
+            raise
+          end
 
-      metric
+          if data
+            feature_name_str, operation_str, duration, success = data
+            process_async_record(feature_name_str, operation_str, duration, success)
+            last_flush_check = Time.now
+          elsif Time.now - last_flush_check >= 1.0
+            # Timeout - check if we need to flush based on time (every second)
+            flush_to_redis_if_needed
+            last_flush_check = Time.now
+          end
+        rescue StandardError => e
+          # Log error but continue processing
+          warn "Magick: Error in async metrics processor: #{e.message}" if defined?(Rails) && Rails.env.development?
+          sleep 0.1 # Brief pause on error
+        end
+      end
+      @async_thread.abort_on_exception = false
     end
 
     def flush_to_redis_if_needed
-      # Always try to flush if Redis adapter is available, even if @redis_enabled is false
-      # This ensures stats are collected even if redis_enabled wasn't set correctly
-      adapter = Magick.adapter_registry || Magick.default_adapter_registry
-      return unless adapter # No adapter at all, skip
-
-      redis_available = adapter.is_a?(Magick::Adapters::Registry) && adapter.redis_available?
+      # Cache adapter availability check (expensive)
+      if @_adapter_available.nil?
+        adapter = Magick.adapter_registry || Magick.default_adapter_registry
+        @_adapter_available = adapter
+        @_redis_available = adapter.is_a?(Magick::Adapters::Registry) && adapter.redis_available? if adapter
+      end
 
-      return unless redis_available || @redis_enabled
+      return unless @_adapter_available
+      return unless @_redis_available || @redis_enabled
       return if @pending_updates.empty?
 
       should_flush = false
@@ -311,5 +380,13 @@ module Magick
         @flushed_counts.clear
       end
     end
+
+    # Stop async processor (for cleanup)
+    def stop_async_processor
+      @async_enabled = false
+      @async_queue.close if @async_queue.respond_to?(:close)
+      @async_thread&.kill
+      @async_thread = nil
+    end
   end
 end

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.9.21'
+  VERSION = '0.9.23'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.9.21
+  version: 0.9.23
 platform: ruby
 authors:
 - Andrew Lobanov