magick-feature-flags 0.9.21 → 0.9.22

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 467ad50ad54569fd4ac8562da75e37672716b980cfdfb03da79b2f29950fd4c9
-  data.tar.gz: 0b89ad165e8aad8fb2074821025bd7e50ef2568cc46f5b750bfc4c91c6e11658
+  metadata.gz: 42699b3af1d542ac14b10f2b82ea4156da27b68e3e2a07e715cd528f0e3f936b
+  data.tar.gz: 0c5235c6cb220201ed0443d1a4633009325d410620d8d28ecbb836cac01bdc25
 SHA512:
-  metadata.gz: 7b3fa0a75bd127f269ecafcddfbe6dcba8d45a247d6b47d83085a097f58de6b74c570eb0655fd4a97c78d8335ff1916a57b3eb2b891143d6a2cc585acc5ff87c
-  data.tar.gz: 79cf7083e34daab0c569e9e05d6e0b123167692f2b206b67ae53321ddabe722861e701346dd5cac80c6b1898be75140ed52fd93470b9a19ccf8113ebf6d91a16
+  metadata.gz: 10fb678c4aeaf5a17f721341e01ec937bf9a14042e4a90fa0bcc1aba13c5e91272aba144fa05913a020660ffd602ccf7481d216e92364338c7e4a111794e0896
+  data.tar.gz: '079e2d11d6ab0339929f965c1eb05fc934ea88522f26e268df324c366ad28268f87131233fe0f2315a5494328ae5fa18790e8e512fa550372852c3c1d61c3faf'

data/lib/magick/feature.rb

@@ -52,11 +52,12 @@ module Magick
       return check_enabled(context) unless perf_metrics_enabled
 
       # Performance metrics enabled: measure and record
+      # Use inline timing to avoid function call overhead
       start_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       result = check_enabled(context)
       duration = (Process.clock_gettime(Process::CLOCK_MONOTONIC) - start_time) * 1000 # milliseconds
 
-      # Record metrics (only if enabled)
+      # Record metrics (fast path - minimal overhead)
       perf_metrics.record(name, 'enabled?', duration, success: true)
 
       # Rails 8+ events (only in development or when explicitly enabled)

data/lib/magick/performance_metrics.rb

@@ -36,44 +36,59 @@ module Magick
       # If redis_enabled is explicitly set, use it; otherwise default to false
       # It will be enabled later via enable_redis_tracking if Redis adapter is available
       @redis_enabled = redis_enabled.nil? ? false : redis_enabled
+      # Cache expensive checks for performance
+      @_rails_events_enabled = defined?(Magick::Rails::Events) && Magick::Rails::Events.rails8?
+      @_adapter_available = nil # Will be cached on first check
+      @_redis_available = nil # Will be cached on first check
     end
 
     # Public accessor for redis_enabled
     attr_reader :redis_enabled
 
     def record(feature_name, operation, duration, success: true)
+      # Fast path: minimize work in mutex
       feature_name_str = feature_name.to_s
-      metric = Metric.new(feature_name_str, operation, duration, success: success)
 
+      # Minimize mutex lock time - only update counters
+      pending_count = nil
+      total_pending = nil
       @mutex.synchronize do
-        @metrics << metric
+        # Only create Metric object if we're keeping metrics in memory
+        # Most of the time we just need counters, not full metric objects
+        if @metrics.length < 1000
+          metric = Metric.new(feature_name_str, operation, duration, success: success)
+          @metrics << metric
+        end
         @usage_count[feature_name_str] += 1
         @pending_updates[feature_name_str] += 1
+        pending_count = @pending_updates[feature_name_str]
+        total_pending = @pending_updates.values.sum
         # Keep only last 1000 metrics (as a safety limit)
-        # Note: Metrics are removed from memory after flushing to Redis to reduce memory usage
         @metrics.shift if @metrics.length > 1000
       end
 
-      # Rails 8+ event for usage tracking
-      if defined?(Magick::Rails::Events) && Magick::Rails::Events.rails8?
+      # Rails 8+ event for usage tracking (cached check)
+      if @_rails_events_enabled
         Magick::Rails::Events.usage_tracked(feature_name, operation: operation, duration: duration, success: success)
       end
 
-      # Batch flush to Redis if needed
-      flush_to_redis_if_needed
+      # Batch flush check - only if we're close to batch size (avoid expensive checks)
+      # Check pending count first before doing expensive adapter checks
+      flush_to_redis_if_needed if pending_count >= @batch_size || total_pending >= @batch_size
 
-      metric
+      nil # Don't return metric object to avoid allocation overhead
     end
 
     def flush_to_redis_if_needed
-      # Always try to flush if Redis adapter is available, even if @redis_enabled is false
-      # This ensures stats are collected even if redis_enabled wasn't set correctly
-      adapter = Magick.adapter_registry || Magick.default_adapter_registry
-      return unless adapter # No adapter at all, skip
-
-      redis_available = adapter.is_a?(Magick::Adapters::Registry) && adapter.redis_available?
+      # Cache adapter availability check (expensive)
+      if @_adapter_available.nil?
+        adapter = Magick.adapter_registry || Magick.default_adapter_registry
+        @_adapter_available = adapter
+        @_redis_available = adapter.is_a?(Magick::Adapters::Registry) && adapter.redis_available? if adapter
+      end
 
-      return unless redis_available || @redis_enabled
+      return unless @_adapter_available
+      return unless @_redis_available || @redis_enabled
       return if @pending_updates.empty?
 
       should_flush = false

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.9.21'
+  VERSION = '0.9.22'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.9.21
+  version: 0.9.22
 platform: ruby
 authors:
 - Andrew Lobanov