magick-feature-flags 0.9.20 → 0.9.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e4f9379b630e9db00b28614f347d523edb33d63c842d6b5c9fd747be02f1d75d
-  data.tar.gz: ffa32ee13faa08781c68870813c15ea7b3dcc15fe65f8c1f2618952251fe870c
+  metadata.gz: 467ad50ad54569fd4ac8562da75e37672716b980cfdfb03da79b2f29950fd4c9
+  data.tar.gz: 0b89ad165e8aad8fb2074821025bd7e50ef2568cc46f5b750bfc4c91c6e11658
 SHA512:
-  metadata.gz: 0f2651c1f8528b4eb385f82a629c7891e0a78ec4a796b574baa8228a2bfcaddf88ee6855af45f9fba9c12b4d7d475e1d8aa6ba6b1002706a1247a8ef81b540e4
-  data.tar.gz: 418cc8c6909969581b147df052c72ffc9635a86b07726f69f0c6085bef3bbb804515d34a3d6ca782f8b4c03d4127722a5547a483ca2d0cddfc56f3bef4e6e864
+  metadata.gz: 7b3fa0a75bd127f269ecafcddfbe6dcba8d45a247d6b47d83085a097f58de6b74c570eb0655fd4a97c78d8335ff1916a57b3eb2b891143d6a2cc585acc5ff87c
+  data.tar.gz: 79cf7083e34daab0c569e9e05d6e0b123167692f2b206b67ae53321ddabe722861e701346dd5cac80c6b1898be75140ed52fd93470b9a19ccf8113ebf6d91a16

data/lib/magick/feature.rb

@@ -33,15 +33,54 @@ module Magick
       # Update targeting empty cache after loading
       @_targeting_empty = @targeting.empty?
       # Cache performance metrics availability (check once, not on every call)
-      @_perf_metrics_enabled = Magick.performance_metrics != nil
+      # Only enable if performance_metrics exists AND is actually being used
+      @_perf_metrics_enabled = !Magick.performance_metrics.nil?
       # Save description and display_name to adapter if they were provided and not already in adapter
       save_metadata_if_new
     end
 
     def enabled?(context = {})
-      # Fastest path: check enabled status directly (no overhead)
-      check_enabled(context)
+      # Check performance metrics dynamically (in case enabled after feature creation)
+      # But cache the check result for performance
+      perf_metrics = Magick.performance_metrics
+      perf_metrics_enabled = !perf_metrics.nil?
+
+      # Update cached flag if it changed
+      @_perf_metrics_enabled = perf_metrics_enabled if @_perf_metrics_enabled != perf_metrics_enabled
+
+      # Fast path: if performance metrics disabled, skip all overhead
+      return check_enabled(context) unless perf_metrics_enabled
+
+      # Performance metrics enabled: measure and record
+      start_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+      result = check_enabled(context)
+      duration = (Process.clock_gettime(Process::CLOCK_MONOTONIC) - start_time) * 1000 # milliseconds
+
+      # Record metrics (only if enabled)
+      perf_metrics.record(name, 'enabled?', duration, success: true)
+
+      # Rails 8+ events (only in development or when explicitly enabled)
+      if @_rails_events_enabled
+        if result
+          Magick::Rails::Events.feature_enabled(name, context: context)
+        else
+          Magick::Rails::Events.feature_disabled(name, context: context)
+        end
+      end
+
+      # Warn if deprecated (only if enabled)
+      if status == :deprecated && result && !context[:allow_deprecated] && Magick.warn_on_deprecated
+        warn "DEPRECATED: Feature '#{name}' is deprecated and will be removed."
+        Magick::Rails::Events.deprecated_warning(name) if @_rails_events_enabled
+      end
+
+      result
     rescue StandardError => e
+      # Record error metrics if enabled
+      if perf_metrics_enabled && perf_metrics
+        duration = defined?(start_time) && start_time ? (Process.clock_gettime(Process::CLOCK_MONOTONIC) - start_time) * 1000 : 0.0
+        perf_metrics.record(name, 'enabled?', duration, success: false)
+      end
       # Return false on any error (fail-safe)
       warn "Magick: Error checking feature '#{name}': #{e.message}" if defined?(Rails) && Rails.env.development?
       false
@@ -452,6 +491,10 @@ module Magick
     # Reload feature state from adapter (useful when feature is changed externally)
     def reload
       load_from_adapter
+      # Update targeting empty cache
+      @_targeting_empty = @targeting.empty?
+      # Update performance metrics flag (in case it was enabled after feature creation)
+      @_perf_metrics_enabled = !Magick.performance_metrics.nil?
       # Update registered feature instance if it exists
       if Magick.features.key?(name)
         registered = Magick.features[name]
@@ -461,6 +504,8 @@ module Magick
         registered.instance_variable_set(:@description, @description)
         registered.instance_variable_set(:@display_name, @display_name)
         registered.instance_variable_set(:@targeting, @targeting.dup)
+        registered.instance_variable_set(:@_targeting_empty, @_targeting_empty)
+        registered.instance_variable_set(:@_perf_metrics_enabled, @_perf_metrics_enabled)
       end
       true
     end

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.9.20'
+  VERSION = '0.9.21'
 end

data/lib/magick.rb

@@ -38,6 +38,12 @@ module Magick
       if value && adapter_registry.is_a?(Adapters::Registry) && adapter_registry.redis_available?
         value.enable_redis_tracking(enable: true)
       end
+      # Update all existing features to enable performance metrics tracking
+      if value
+        features.each_value do |feature|
+          feature.instance_variable_set(:@_perf_metrics_enabled, true)
+        end
+      end
       value
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.9.20
+  version: 0.9.21
 platform: ruby
 authors:
 - Andrew Lobanov