magick-feature-flags 0.9.19 → 0.9.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a9bd8f59c8729764a5a1b9876b20bca16dce2670ed477ee64109eda02219f98
-  data.tar.gz: 566826dcca95d42a34fd5f95581e5dfd1c3d074a3260def10fda5bb3a68c5ce0
+  metadata.gz: 467ad50ad54569fd4ac8562da75e37672716b980cfdfb03da79b2f29950fd4c9
+  data.tar.gz: 0b89ad165e8aad8fb2074821025bd7e50ef2568cc46f5b750bfc4c91c6e11658
 SHA512:
-  metadata.gz: 0b37fb6089b687c08b31aad74d24f43c90d65134c9e68e0de2d521a6357f64d0f3778b8aafe60aca9f912f4610d73a42e4e6a2f96f156f66a8c5d154affa8d91
-  data.tar.gz: 267b78151d2017069f1a3e4836ed0016bbdc524ee9fb2d7ea15ec8148df9359604f9acf9dca886aa073fb289309c5f4f90ce39754d8da80d95794606b0a05087
+  metadata.gz: 7b3fa0a75bd127f269ecafcddfbe6dcba8d45a247d6b47d83085a097f58de6b74c570eb0655fd4a97c78d8335ff1916a57b3eb2b891143d6a2cc585acc5ff87c
+  data.tar.gz: 79cf7083e34daab0c569e9e05d6e0b123167692f2b206b67ae53321ddabe722861e701346dd5cac80c6b1898be75140ed52fd93470b9a19ccf8113ebf6d91a16

data/lib/magick/adapters/memory.rb

@@ -11,12 +11,16 @@ module Magick
       end
 
       def get(feature_name, key)
+        # Fast path: avoid mutex if possible (use string keys directly)
+        feature_name_str = feature_name.is_a?(String) ? feature_name : feature_name.to_s
+        key_str = key.is_a?(String) ? key : key.to_s
+
         mutex.synchronize do
           cleanup_expired
-          feature_data = store[feature_name.to_s]
+          feature_data = store[feature_name_str]
           return nil unless feature_data
 
-          value = feature_data[key.to_s]
+          value = feature_data[key_str]
           deserialize_value(value)
         end
       end

data/lib/magick/feature.rb

@@ -25,29 +25,39 @@ module Magick
       # Performance optimizations: cache expensive checks
       @_targeting_empty = true # Will be updated after load_from_adapter
       @_rails_events_enabled = false # Cache Rails events availability (only enable in dev)
+      @_perf_metrics_enabled = false # Cache performance metrics (disabled by default for speed)
 
       validate_type!
       validate_default_value!
       load_from_adapter
       # Update targeting empty cache after loading
       @_targeting_empty = @targeting.empty?
+      # Cache performance metrics availability (check once, not on every call)
+      # Only enable if performance_metrics exists AND is actually being used
+      @_perf_metrics_enabled = !Magick.performance_metrics.nil?
       # Save description and display_name to adapter if they were provided and not already in adapter
       save_metadata_if_new
     end
 
     def enabled?(context = {})
-      # Performance metrics: measure before the check (only if enabled)
+      # Check performance metrics dynamically (in case enabled after feature creation)
+      # But cache the check result for performance
       perf_metrics = Magick.performance_metrics
-      start_time = perf_metrics ? Process.clock_gettime(Process::CLOCK_MONOTONIC) : nil
+      perf_metrics_enabled = !perf_metrics.nil?
 
-      # Fast path: check enabled status
+      # Update cached flag if it changed
+      @_perf_metrics_enabled = perf_metrics_enabled if @_perf_metrics_enabled != perf_metrics_enabled
+
+      # Fast path: if performance metrics disabled, skip all overhead
+      return check_enabled(context) unless perf_metrics_enabled
+
+      # Performance metrics enabled: measure and record
+      start_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
       result = check_enabled(context)
+      duration = (Process.clock_gettime(Process::CLOCK_MONOTONIC) - start_time) * 1000 # milliseconds
 
-      # Record metrics if enabled (after the check to minimize overhead)
-      if perf_metrics
-        duration = (Process.clock_gettime(Process::CLOCK_MONOTONIC) - start_time) * 1000 # milliseconds
-        perf_metrics.record(name, 'enabled?', duration, success: true)
-      end
+      # Record metrics (only if enabled)
+      perf_metrics.record(name, 'enabled?', duration, success: true)
 
       # Rails 8+ events (only in development or when explicitly enabled)
       if @_rails_events_enabled
@@ -66,8 +76,9 @@ module Magick
 
       result
     rescue StandardError => e
-      if perf_metrics
-        duration = start_time ? (Process.clock_gettime(Process::CLOCK_MONOTONIC) - start_time) * 1000 : 0.0
+      # Record error metrics if enabled
+      if perf_metrics_enabled && perf_metrics
+        duration = defined?(start_time) && start_time ? (Process.clock_gettime(Process::CLOCK_MONOTONIC) - start_time) * 1000 : 0.0
         perf_metrics.record(name, 'enabled?', duration, success: false)
       end
       # Return false on any error (fail-safe)
@@ -480,6 +491,10 @@ module Magick
     # Reload feature state from adapter (useful when feature is changed externally)
     def reload
       load_from_adapter
+      # Update targeting empty cache
+      @_targeting_empty = @targeting.empty?
+      # Update performance metrics flag (in case it was enabled after feature creation)
+      @_perf_metrics_enabled = !Magick.performance_metrics.nil?
       # Update registered feature instance if it exists
       if Magick.features.key?(name)
         registered = Magick.features[name]
@@ -489,6 +504,8 @@ module Magick
         registered.instance_variable_set(:@description, @description)
         registered.instance_variable_set(:@display_name, @display_name)
         registered.instance_variable_set(:@targeting, @targeting.dup)
+        registered.instance_variable_set(:@_targeting_empty, @_targeting_empty)
+        registered.instance_variable_set(:@_perf_metrics_enabled, @_perf_metrics_enabled)
       end
       true
     end

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.9.19'
+  VERSION = '0.9.21'
 end

data/lib/magick.rb

@@ -38,6 +38,12 @@ module Magick
       if value && adapter_registry.is_a?(Adapters::Registry) && adapter_registry.redis_available?
         value.enable_redis_tracking(enable: true)
       end
+      # Update all existing features to enable performance metrics tracking
+      if value
+        features.each_value do |feature|
+          feature.instance_variable_set(:@_perf_metrics_enabled, true)
+        end
+      end
       value
     end
 
@@ -103,7 +109,9 @@ module Magick
     end
 
     def enabled?(feature_name, context = {})
-      feature = features[feature_name.to_s] || self[feature_name]
+      # Fast path: use string key directly (avoid repeated to_s conversion)
+      feature_name_str = feature_name.to_s
+      feature = features[feature_name_str] || self[feature_name]
       feature.enabled?(context)
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.9.19
+  version: 0.9.21
 platform: ruby
 authors:
 - Andrew Lobanov