magick-feature-flags 0.9.18 → 0.9.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7df3e59dc8f0736e18fb93603f53038f48b5302769c42cc37ab87f2afcba0307
-  data.tar.gz: e0235e0c7518860061b7b67a27aee9c1be88346c8292733aae0a2c794c2288d7
+  metadata.gz: 3a9bd8f59c8729764a5a1b9876b20bca16dce2670ed477ee64109eda02219f98
+  data.tar.gz: 566826dcca95d42a34fd5f95581e5dfd1c3d074a3260def10fda5bb3a68c5ce0
 SHA512:
-  metadata.gz: 0a76c637a3cd96cebd6fa91be4f10df8e1174713fabb82c4cdb8df1cecd2d4c6c6ea46e00949cc485e6c0a3d46a9180c718204361a2630c8a71a069a0c6f6bbd
-  data.tar.gz: f0682f004002eab91412ee9d948e69f3f84de41238ab2d5ca3f06abec1abf2616c86063a66198f8a596f32d8dc2cf545c9db0b62961e6dc98a4d97a39b01e5cc
+  metadata.gz: 0b37fb6089b687c08b31aad74d24f43c90d65134c9e68e0de2d521a6357f64d0f3778b8aafe60aca9f912f4610d73a42e4e6a2f96f156f66a8c5d154affa8d91
+  data.tar.gz: 267b78151d2017069f1a3e4836ed0016bbdc524ee9fb2d7ea15ec8148df9359604f9acf9dca886aa073fb289309c5f4f90ce39754d8da80d95794606b0a05087

data/lib/magick/feature.rb

@@ -22,26 +22,35 @@ module Magick
       @dependencies = options[:dependencies] ? Array(options[:dependencies]) : []
       @stored_value_initialized = false # Track if @stored_value has been explicitly set
 
+      # Performance optimizations: cache expensive checks
+      @_targeting_empty = true # Will be updated after load_from_adapter
+      @_rails_events_enabled = false # Cache Rails events availability (only enable in dev)
+
       validate_type!
       validate_default_value!
       load_from_adapter
+      # Update targeting empty cache after loading
+      @_targeting_empty = @targeting.empty?
       # Save description and display_name to adapter if they were provided and not already in adapter
       save_metadata_if_new
     end
 
     def enabled?(context = {})
-      # Track usage if metrics available
-      start_time = Time.now if Magick.performance_metrics
+      # Performance metrics: measure before the check (only if enabled)
+      perf_metrics = Magick.performance_metrics
+      start_time = perf_metrics ? Process.clock_gettime(Process::CLOCK_MONOTONIC) : nil
 
+      # Fast path: check enabled status
       result = check_enabled(context)
 
-      if Magick.performance_metrics
-        duration = (Time.now - start_time) * 1000 # milliseconds
-        Magick.performance_metrics.record(name, 'enabled?', duration, success: true)
+      # Record metrics if enabled (after the check to minimize overhead)
+      if perf_metrics
+        duration = (Process.clock_gettime(Process::CLOCK_MONOTONIC) - start_time) * 1000 # milliseconds
+        perf_metrics.record(name, 'enabled?', duration, success: true)
       end
 
-      # Rails 8+ events for enabled/disabled
-      if defined?(Magick::Rails::Events) && Magick::Rails::Events.rails8?
+      # Rails 8+ events (only in development or when explicitly enabled)
+      if @_rails_events_enabled
         if result
           Magick::Rails::Events.feature_enabled(name, context: context)
         else
@@ -49,21 +58,17 @@ module Magick
         end
       end
 
-      # Warn if deprecated
-      if status == :deprecated && result && !context[:allow_deprecated]
-        warn "DEPRECATED: Feature '#{name}' is deprecated and will be removed." if Magick.warn_on_deprecated
-
-        # Rails 8+ event for deprecation warning
-        if defined?(Magick::Rails::Events) && Magick::Rails::Events.rails8?
-          Magick::Rails::Events.deprecated_warning(name)
-        end
+      # Warn if deprecated (only if enabled)
+      if status == :deprecated && result && !context[:allow_deprecated] && Magick.warn_on_deprecated
+        warn "DEPRECATED: Feature '#{name}' is deprecated and will be removed."
+        Magick::Rails::Events.deprecated_warning(name) if @_rails_events_enabled
       end
 
       result
     rescue StandardError => e
-      if Magick.performance_metrics
-        duration = (Time.now - start_time) * 1000
-        Magick.performance_metrics.record(name, 'enabled?', duration, success: false)
+      if perf_metrics
+        duration = start_time ? (Process.clock_gettime(Process::CLOCK_MONOTONIC) - start_time) * 1000 : 0.0
+        perf_metrics.record(name, 'enabled?', duration, success: false)
       end
       # Return false on any error (fail-safe)
       warn "Magick: Error checking feature '#{name}': #{e.message}" if defined?(Rails) && Rails.env.development?
@@ -71,28 +76,28 @@ module Magick
     end
 
     def check_enabled(context = {})
+      # Fast path: check status first
       return false if status == :inactive
       return false if status == :deprecated && !context[:allow_deprecated]
 
-      # NOTE: We don't check dependencies here because:
-      # - Main features can be enabled independently
-      # - Dependencies are only prevented from being enabled if the main feature is disabled
-      # - The dependency check is handled in the enable() method, not in enabled?()
-
-      # Check date/time range targeting
-      return false if targeting[:date_range] && !date_range_active?(targeting[:date_range])
+      # Fast path: skip targeting checks if targeting is empty (most common case)
+      unless @_targeting_empty
+        # Check date/time range targeting
+        return false if targeting[:date_range] && !date_range_active?(targeting[:date_range])
 
-      # Check IP address targeting
-      return false if targeting[:ip_address] && context[:ip_address] && !ip_address_matches?(context[:ip_address])
+        # Check IP address targeting
+        return false if targeting[:ip_address] && context[:ip_address] && !ip_address_matches?(context[:ip_address])
 
-      # Check custom attributes
-      return false if targeting[:custom_attributes] && !custom_attributes_match?(context, targeting[:custom_attributes])
+        # Check custom attributes
+        return false if targeting[:custom_attributes] && !custom_attributes_match?(context,
+                                                                                   targeting[:custom_attributes])
 
-      # Check complex conditions
-      if targeting[:complex_conditions] && !complex_conditions_match?(context, targeting[:complex_conditions])
-        return false
+        # Check complex conditions
+        return false if targeting[:complex_conditions] && !complex_conditions_match?(context,
+                                                                                     targeting[:complex_conditions])
       end
 
+      # Get value and check based on type
       value = get_value(context)
       case type
       when :boolean
@@ -131,19 +136,21 @@ module Magick
     end
 
     def get_value(context = {})
-      # Check targeting rules first
-      targeting_result = check_targeting(context)
-      return targeting_result unless targeting_result.nil?
+      # Fast path: check targeting rules first (only if targeting exists)
+      unless @_targeting_empty
+        targeting_result = check_targeting(context)
+        return targeting_result unless targeting_result.nil?
+      end
 
-      # Use instance variable if it has been set (check using defined? to handle nil vs uninitialized)
-      # We use a special check: if @stored_value was explicitly set (even to false), use it
-      # We track this by checking if @stored_value_initialized flag is set
-      return @stored_value if defined?(@stored_value_initialized) && @stored_value_initialized
+      # Fast path: use cached value if initialized (avoid adapter calls)
+      return @stored_value if @stored_value_initialized
 
       # Load from adapter if instance variable hasn't been initialized
       loaded_value = load_value_from_adapter
       if loaded_value.nil?
-        # Value not found in adapter, use default
+        # Value not found in adapter, use default and cache it
+        @stored_value = default_value
+        @stored_value_initialized = true
         default_value
       else
         # Value found in adapter, use it and mark as initialized
@@ -827,9 +834,14 @@ module Magick
       adapter_registry.set(name, 'targeting', targeting)
 
       # Update the feature in Magick.features if it's registered
-      return unless Magick.features.key?(name)
+      if Magick.features.key?(name)
+        Magick.features[name].instance_variable_set(:@targeting, targeting.dup)
+        # Update targeting empty cache for performance
+        Magick.features[name].instance_variable_set(:@_targeting_empty, targeting.empty?)
+      end
 
-      Magick.features[name].instance_variable_set(:@targeting, targeting.dup)
+      # Update local targeting empty cache for performance
+      @_targeting_empty = targeting.empty?
 
       # Explicitly trigger cache invalidation for targeting updates
       # Targeting changes affect enabled? checks, so we need immediate cache invalidation

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.9.18'
+  VERSION = '0.9.19'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.9.18
+  version: 0.9.19
 platform: ruby
 authors:
 - Andrew Lobanov