magick-feature-flags 0.8.6 → 0.8.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 92b5a4b913e87e53dc5c98b88d86ebaa7ea2d2bdf8434da373846f1c11a77d1f
-  data.tar.gz: 39cd2f51130d3bbd1ecc15760d5352c93b5fb2e06622ed1426f366443d157e8f
+  metadata.gz: 876436714b054435d68ac40f18eab6597165640e5f4ab2cb666474f7b03cb92f
+  data.tar.gz: 1cb04e84837d1faf72fa9566fe852ce484d20035b763b9cec4896ec1cb24b62e
 SHA512:
-  metadata.gz: 2786314abef311c89157aa037b7275dbea5ab5748d27795191b211dab1200fa6ee26473ade2fba66fc4569f831e49e5fcbae46d162a364434b5fe711e90beb50
-  data.tar.gz: a4bc99cd3aac2c007d845ffe92092ef0c64c30cc3d690283834fe44bd294d32bb155813bffe1dfa6deea9bc62019aac26fbbce16fa6974c676f5668315fced54
+  metadata.gz: b541dbee500ab1e93969791326ca2f02ab7b4bd9595f5a903ec954018166cf5de9f26cde857325e2698fdcfe311533e31f3eb201027594e4a66007246a14248a
+  data.tar.gz: 701320125c33d03df6238e010ee9ce274f59fc56d4b423ebb6ffec131b2edda19fb1214dc532b875259f63848e4cbfa61ddbbf9b1354b6384fa139cd17c06840

data/lib/magick/feature.rb

@@ -126,8 +126,11 @@ module Magick
       targeting_result = check_targeting(context)
       return targeting_result unless targeting_result.nil?
 
-      # Fall back to stored value or default
-      stored_value || default_value
+      # Use instance variable if set, otherwise load from adapter
+      # This ensures we use the most recent value set via set_value/disable/enable
+      value = @stored_value
+      value = load_value_from_adapter if value.nil?
+      value || default_value
     end
 
     def enable_for_user(user_id)
@@ -325,7 +328,11 @@ module Magick
       @stored_value = value
 
       # Update registered feature instance if it exists
-      Magick.features[name].instance_variable_set(:@stored_value, value) if Magick.features.key?(name)
+      if Magick.features.key?(name)
+        registered = Magick.features[name]
+        registered.instance_variable_set(:@stored_value, value)
+        registered.instance_variable_set(:@targeting, @targeting.dup) if @targeting
+      end
 
       changes = { value: { from: old_value, to: value } }
 
@@ -386,6 +393,12 @@ module Magick
         raise InvalidFeatureValueError, "Cannot disable feature of type #{type}"
       end
 
+      # Ensure registered feature instance also has targeting cleared
+      if Magick.features.key?(name)
+        registered = Magick.features[name]
+        registered.instance_variable_set(:@targeting, {})
+      end
+
       # Cascade disable: disable all features that depend on this one
       disable_dependent_features(user_id: user_id)
 
@@ -485,9 +498,9 @@ module Magick
       if @description && !adapter_registry.get(name, 'description')
         adapter_registry.set(name, 'description', @description)
       end
-      if @display_name && !adapter_registry.get(name, 'display_name')
-        adapter_registry.set(name, 'display_name', @display_name)
-      end
+      return unless @display_name && !adapter_registry.get(name, 'display_name')
+
+      adapter_registry.set(name, 'display_name', @display_name)
     end
 
     def load_value_from_adapter
@@ -720,9 +733,7 @@ module Magick
       dependent_features = []
       Magick.features.each do |_name, feature|
         feature_deps = feature.instance_variable_get(:@dependencies) || []
-        if feature_deps.include?(name.to_s) || feature_deps.include?(name.to_sym)
-          dependent_features << feature.name
-        end
+        dependent_features << feature.name if feature_deps.include?(name.to_s) || feature_deps.include?(name.to_sym)
       end
       dependent_features
     end

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.8.6'
+  VERSION = '0.8.8'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.8.6
+  version: 0.8.8
 platform: ruby
 authors:
 - Andrew Lobanov