magick-feature-flags 0.8.6 → 0.8.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 92b5a4b913e87e53dc5c98b88d86ebaa7ea2d2bdf8434da373846f1c11a77d1f
-  data.tar.gz: 39cd2f51130d3bbd1ecc15760d5352c93b5fb2e06622ed1426f366443d157e8f
+  metadata.gz: 2ab8236f8c928279337c89be2c15f6ff413c6f33f3bbd2d2489eb9344d93b546
+  data.tar.gz: 14bc44e42dc9429441b504c81fe0b076f947c0638d2e55a590a0743bf75822e8
 SHA512:
-  metadata.gz: 2786314abef311c89157aa037b7275dbea5ab5748d27795191b211dab1200fa6ee26473ade2fba66fc4569f831e49e5fcbae46d162a364434b5fe711e90beb50
-  data.tar.gz: a4bc99cd3aac2c007d845ffe92092ef0c64c30cc3d690283834fe44bd294d32bb155813bffe1dfa6deea9bc62019aac26fbbce16fa6974c676f5668315fced54
+  metadata.gz: e346d563053b3adb3acc9fed5bcd8b085b064be393a6cc1303435ff592a69f7987261baf9383f82ca5a46667f89de0c0dcecc5d01708fc972616ecd042dc54cc
+  data.tar.gz: 8ad9c0b56690511dc1709721248875a474e0ab521dd8d98ce63e80aedbec8e4993eb88be099b01cac82ad41096aba4eae2b40a06bd6840fd15d805f102282585

data/lib/magick/feature.rb

@@ -325,7 +325,11 @@ module Magick
       @stored_value = value
 
       # Update registered feature instance if it exists
-      Magick.features[name].instance_variable_set(:@stored_value, value) if Magick.features.key?(name)
+      if Magick.features.key?(name)
+        registered = Magick.features[name]
+        registered.instance_variable_set(:@stored_value, value)
+        registered.instance_variable_set(:@targeting, @targeting.dup) if @targeting
+      end
 
       changes = { value: { from: old_value, to: value } }
 
@@ -386,6 +390,12 @@ module Magick
         raise InvalidFeatureValueError, "Cannot disable feature of type #{type}"
       end
 
+      # Ensure registered feature instance also has targeting cleared
+      if Magick.features.key?(name)
+        registered = Magick.features[name]
+        registered.instance_variable_set(:@targeting, {})
+      end
+
       # Cascade disable: disable all features that depend on this one
       disable_dependent_features(user_id: user_id)
 
@@ -485,9 +495,9 @@ module Magick
       if @description && !adapter_registry.get(name, 'description')
         adapter_registry.set(name, 'description', @description)
       end
-      if @display_name && !adapter_registry.get(name, 'display_name')
-        adapter_registry.set(name, 'display_name', @display_name)
-      end
+      return unless @display_name && !adapter_registry.get(name, 'display_name')
+
+      adapter_registry.set(name, 'display_name', @display_name)
     end
 
     def load_value_from_adapter
@@ -720,9 +730,7 @@ module Magick
       dependent_features = []
       Magick.features.each do |_name, feature|
         feature_deps = feature.instance_variable_get(:@dependencies) || []
-        if feature_deps.include?(name.to_s) || feature_deps.include?(name.to_sym)
-          dependent_features << feature.name
-        end
+        dependent_features << feature.name if feature_deps.include?(name.to_s) || feature_deps.include?(name.to_sym)
       end
       dependent_features
     end

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.8.6'
+  VERSION = '0.8.7'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.8.6
+  version: 0.8.7
 platform: ruby
 authors:
 - Andrew Lobanov