magick-feature-flags 0.8.5 → 0.8.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a62d079b6f68d6c2b207fe51bf1698fd7b79eca4e9eecd509b614f4a33ee78f2
-  data.tar.gz: 7b01eafa0b42fa5555cfa7356bc299a3bb5170a8065714707e68c0d13a8e16a6
+  metadata.gz: 2ab8236f8c928279337c89be2c15f6ff413c6f33f3bbd2d2489eb9344d93b546
+  data.tar.gz: 14bc44e42dc9429441b504c81fe0b076f947c0638d2e55a590a0743bf75822e8
 SHA512:
-  metadata.gz: e93c25f079be5541256bd3c89389a8370edb0c8cd2789e85c2010d9e6f6e8e20b9bb0ca74e87a7c22c4bfb471a53d88cde64ea1570cc06f2439746ee07a0e621
-  data.tar.gz: 9297dcd89a4bcfb487f1fe550960f1d1984a7a5ac631c80cb0f417a9792dbeffa7b1832b2d02fd0f07408ff9ba8e539f0c1127a6677415f9e81c62957ffd34cd
+  metadata.gz: e346d563053b3adb3acc9fed5bcd8b085b064be393a6cc1303435ff592a69f7987261baf9383f82ca5a46667f89de0c0dcecc5d01708fc972616ecd042dc54cc
+  data.tar.gz: 8ad9c0b56690511dc1709721248875a474e0ab521dd8d98ce63e80aedbec8e4993eb88be099b01cac82ad41096aba4eae2b40a06bd6840fd15d805f102282585

data/lib/magick/feature.rb

@@ -325,7 +325,11 @@ module Magick
       @stored_value = value
 
       # Update registered feature instance if it exists
-      Magick.features[name].instance_variable_set(:@stored_value, value) if Magick.features.key?(name)
+      if Magick.features.key?(name)
+        registered = Magick.features[name]
+        registered.instance_variable_set(:@stored_value, value)
+        registered.instance_variable_set(:@targeting, @targeting.dup) if @targeting
+      end
 
       changes = { value: { from: old_value, to: value } }
 
@@ -386,6 +390,12 @@ module Magick
         raise InvalidFeatureValueError, "Cannot disable feature of type #{type}"
       end
 
+      # Ensure registered feature instance also has targeting cleared
+      if Magick.features.key?(name)
+        registered = Magick.features[name]
+        registered.instance_variable_set(:@targeting, {})
+      end
+
       # Cascade disable: disable all features that depend on this one
       disable_dependent_features(user_id: user_id)
 
@@ -485,9 +495,9 @@ module Magick
       if @description && !adapter_registry.get(name, 'description')
         adapter_registry.set(name, 'description', @description)
       end
-      if @display_name && !adapter_registry.get(name, 'display_name')
-        adapter_registry.set(name, 'display_name', @display_name)
-      end
+      return unless @display_name && !adapter_registry.get(name, 'display_name')
+
+      adapter_registry.set(name, 'display_name', @display_name)
     end
 
     def load_value_from_adapter
@@ -689,14 +699,28 @@ module Magick
       # Find all features that depend on this feature
       dependent_features = find_dependent_features
 
-      # Disable each dependent feature
+      # Disable each dependent feature by setting value directly (avoid recursion)
       dependent_features.each do |dep_feature_name|
         dep_feature = Magick.features[dep_feature_name.to_s] || Magick[dep_feature_name]
         next unless dep_feature
 
-        # Only disable if it's currently enabled (to avoid unnecessary operations)
-        if dep_feature.enabled?
-          dep_feature.disable(user_id: user_id)
+        # Set value directly to avoid recursive disable calls
+        # Clear targeting and set value to false/empty/0 based on type
+        dep_feature.instance_variable_set(:@targeting, {})
+        dep_feature.save_targeting
+
+        case dep_feature.type
+        when :boolean
+          dep_feature.set_value(false, user_id: user_id)
+        when :string
+          dep_feature.set_value('', user_id: user_id)
+        when :number
+          dep_feature.set_value(0, user_id: user_id)
+        end
+
+        # Rails 8+ event
+        if defined?(Magick::Rails::Events) && Magick::Rails::Events.rails8?
+          Magick::Rails::Events.feature_disabled_globally(dep_feature_name, user_id: user_id)
         end
       end
     end
@@ -706,9 +730,7 @@ module Magick
       dependent_features = []
       Magick.features.each do |_name, feature|
         feature_deps = feature.instance_variable_get(:@dependencies) || []
-        if feature_deps.include?(name.to_s) || feature_deps.include?(name.to_sym)
-          dependent_features << feature.name
-        end
+        dependent_features << feature.name if feature_deps.include?(name.to_s) || feature_deps.include?(name.to_sym)
       end
       dependent_features
     end

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.8.5'
+  VERSION = '0.8.7'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.8.5
+  version: 0.8.7
 platform: ruby
 authors:
 - Andrew Lobanov