magick-feature-flags 0.8.3 → 0.8.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 407bbf89a969b1589e0b769323f1a763d5c369084dd5d5118939a99884d0ab9b
-  data.tar.gz: 291b19cb1f6ce75088e137fad9c822c65c1e5f75bf0d7c6c0c42ef2017d350ef
+  metadata.gz: 92b5a4b913e87e53dc5c98b88d86ebaa7ea2d2bdf8434da373846f1c11a77d1f
+  data.tar.gz: 39cd2f51130d3bbd1ecc15760d5352c93b5fb2e06622ed1426f366443d157e8f
 SHA512:
-  metadata.gz: 7d92b8f1177df7033fdc281d5c3e57949a769e935c73b6341dff61eb2004719bc0bbb0ecbfc90b82304d767dfd96ca3566222c246fe99780e5cc212413b390ff
-  data.tar.gz: 9f28aaa757a173ba43c91dd5703cda04663f7d9257c245e481474f36cf2aedbd2c68fb054e961e621b17f0a587f09ce69e63181e23f6821a4bfab8bb59645d00
+  metadata.gz: 2786314abef311c89157aa037b7275dbea5ab5748d27795191b211dab1200fa6ee26473ade2fba66fc4569f831e49e5fcbae46d162a364434b5fe711e90beb50
+  data.tar.gz: a4bc99cd3aac2c007d845ffe92092ef0c64c30cc3d690283834fe44bd294d32bb155813bffe1dfa6deea9bc62019aac26fbbce16fa6974c676f5668315fced54

data/lib/magick/feature.rb

@@ -24,6 +24,8 @@ module Magick
       validate_type!
       validate_default_value!
       load_from_adapter
+      # Save description and display_name to adapter if they were provided and not already in adapter
+      save_metadata_if_new
     end
 
     def enabled?(context = {})
@@ -420,6 +422,7 @@ module Magick
         registered = Magick.features[name]
         registered.instance_variable_set(:@stored_value, @stored_value)
         registered.instance_variable_set(:@status, @status)
+        registered.instance_variable_set(:@description, @description)
         registered.instance_variable_set(:@display_name, @display_name)
         registered.instance_variable_set(:@targeting, @targeting.dup)
       end
@@ -455,8 +458,15 @@ module Magick
       @stored_value = load_value_from_adapter
       status_value = adapter_registry.get(name, 'status')
       @status = status_value ? status_value.to_sym : status
+
+      # Load description from adapter (override initial value if present in adapter)
+      description_value = adapter_registry.get(name, 'description')
+      @description = description_value if description_value
+
+      # Load display_name from adapter (override initial value if present in adapter)
       display_name_value = adapter_registry.get(name, 'display_name')
       @display_name = display_name_value if display_name_value
+
       targeting_value = adapter_registry.get(name, 'targeting')
       if targeting_value.is_a?(Hash)
         # Normalize keys to symbols and handle nested structures
@@ -469,6 +479,17 @@ module Magick
       end
     end
 
+    def save_metadata_if_new
+      # Save description and display_name to adapter if they were provided in options
+      # but don't exist in adapter yet (to avoid overwriting existing values)
+      if @description && !adapter_registry.get(name, 'description')
+        adapter_registry.set(name, 'description', @description)
+      end
+      if @display_name && !adapter_registry.get(name, 'display_name')
+        adapter_registry.set(name, 'display_name', @display_name)
+      end
+    end
+
     def load_value_from_adapter
       value = adapter_registry.get(name, 'value')
       return nil if value.nil?
@@ -668,14 +689,28 @@ module Magick
       # Find all features that depend on this feature
       dependent_features = find_dependent_features
 
-      # Disable each dependent feature
+      # Disable each dependent feature by setting value directly (avoid recursion)
       dependent_features.each do |dep_feature_name|
         dep_feature = Magick.features[dep_feature_name.to_s] || Magick[dep_feature_name]
         next unless dep_feature
 
-        # Only disable if it's currently enabled (to avoid unnecessary operations)
-        if dep_feature.enabled?
-          dep_feature.disable(user_id: user_id)
+        # Set value directly to avoid recursive disable calls
+        # Clear targeting and set value to false/empty/0 based on type
+        dep_feature.instance_variable_set(:@targeting, {})
+        dep_feature.save_targeting
+
+        case dep_feature.type
+        when :boolean
+          dep_feature.set_value(false, user_id: user_id)
+        when :string
+          dep_feature.set_value('', user_id: user_id)
+        when :number
+          dep_feature.set_value(0, user_id: user_id)
+        end
+
+        # Rails 8+ event
+        if defined?(Magick::Rails::Events) && Magick::Rails::Events.rails8?
+          Magick::Rails::Events.feature_disabled_globally(dep_feature_name, user_id: user_id)
         end
       end
     end

data/lib/magick/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Magick
-  VERSION = '0.8.3'
+  VERSION = '0.8.6'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: magick-feature-flags
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 0.8.6
 platform: ruby
 authors:
 - Andrew Lobanov