magic_pipe 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: a3eadd291f2aa10633773f3cd5bf74a032300941
-  data.tar.gz: 3f78a0d8475045c972cdbcb20b39331e2290cd8d
+SHA256:
+  metadata.gz: 1e62bd485afca6636d7eaf6f1012626e56ab2487bc5a14c0907b16ee1b31719d
+  data.tar.gz: 52f3fd7a732204f997db9d9f94287ad5f6874ae652a98cd030a0ffba2653afd6
 SHA512:
-  metadata.gz: fcb5e475d09bb7cdea135a7850a70f0d5168015a77f5a60153bfddf66c110a00ccf25051a2c4a4e770183265f4e232f39d321c645321936510b425be9fa6955b
-  data.tar.gz: bfb8dc0ac117ca58a78af84c94869e1e017206ff573980b94e544075a81b6d5cd1a9c4360d0936f6998fdae3baa4148b30ba0400a12e07e1e476d905b351b2ca
+  metadata.gz: e010cb398432c0bd5282bdce573aeb4208a8001c01a69e63028f5b0dbe72bbf2b058c530c470d9ca91a33b13fcd8306467725a2826227bedcbc5aa61b4a28437
+  data.tar.gz: 1322dbfd131696b6a80497e1701354943d2e497cab23842cad51d108afc2f380c3854dc537940dec20bbd6983457be47e5f0831b3f06571dd6cce7e25e4afcdb

data/.travis.yml

@@ -1,9 +1,9 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.4.3
-  - 2.3.6
-  - 2.2.9
+  - 2.5.3
+  - 2.4.5
+  - 2.3.8
 script:
   - bundle exec rspec
 notifications:

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # MagicPipe Changelog
 
+## v0.4.0
+
+Bug fix: Ensure that the `Https` transport raises an exception when the HTTP POST request fails.
+
 ## v0.3.0
 
 * Allow to set the `basic_auth` config as a proc which gets the topic name passed. (thanks @Crunch09, https://github.com/tompave/magic_pipe/pull/1)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    magic_pipe (0.3.0)
+    magic_pipe (0.4.0)
 
 GEM
   remote: https://rubygems.org/
@@ -25,9 +25,9 @@ GEM
     diff-lcs (1.3)
     ethon (0.11.0)
       ffi (>= 1.3.0)
-    faraday (0.14.0)
+    faraday (0.15.3)
       multipart-post (>= 1.2, < 3)
-    ffi (1.9.18)
+    ffi (1.9.25)
     hashdiff (0.3.7)
     jmespath (1.3.1)
     method_source (0.9.0)
@@ -89,4 +89,4 @@ DEPENDENCIES
   webmock (~> 3.3)
 
 BUNDLED WITH
-   1.16.1
+   1.16.4

data/lib/magic_pipe/errors.rb

@@ -11,4 +11,16 @@ module MagicPipe
     end
     attr_reader :message
   end
+
+  module Transports
+    class SubmitFailedError < MagicPipe::Error
+      def initialize(transport_klass)
+        @message = "#{transport_klass} couldn't submit message"
+      end
+      attr_reader :message
+    end
+
+    class NotImplementedError < SubmitFailedError
+    end
+  end
 end

data/lib/magic_pipe/senders/async.rb

@@ -27,7 +27,7 @@ module MagicPipe
           )
 
           payload = codec.new(envelope).encode
-          client.transport.submit(payload, metadata)
+          client.transport.submit!(payload, metadata)
 
           track_success(client.metrics, topic)
         rescue => e

data/lib/magic_pipe/senders/sync.rb

@@ -10,7 +10,7 @@ module MagicPipe
         metadata = build_metadata
         envelope = build_message(metadata)
         payload = @codec.new(envelope).encode
-        @transport.submit(payload, metadata)
+        @transport.submit!(payload, metadata)
         track_success(@metrics, @topic)
       rescue => e
         track_failure(@metrics, @topic)

data/lib/magic_pipe/transports/base.rb

@@ -9,8 +9,8 @@ module MagicPipe
 
       attr_reader :metrics, :logger
 
-      def submit(payload, metadata)
-        raise NotImplementedError
+      def submit!(payload, metadata)
+        raise MagicPipe::Transports::NotImplementedError
       end
     end
   end

data/lib/magic_pipe/transports/debug.rb

@@ -6,7 +6,7 @@ module MagicPipe
       def initialize(*)
       end
 
-      def submit(payload, metadata)
+      def submit!(payload, metadata)
         $magic_pipe_out = {
           payload: payload,
           metadata: metadata

data/lib/magic_pipe/transports/https.rb

@@ -20,10 +20,10 @@ module MagicPipe
       # TODO: should this raise an error on failure?
       # So that it can be retried?
       #
-      def submit(payload, metadata)
+      def submit!(payload, metadata)
         username, password = basic_auth(metadata[:topic])
         @conn.basic_auth(username, password || "x")
-        @conn.post do |r|
+        resp = @conn.post do |r|
           path = dynamic_path(metadata[:topic])
           r.url(path) if path
 
@@ -32,6 +32,10 @@ module MagicPipe
           r.headers["X-MagicPipe-Topic"] = metadata[:topic]
           r.headers["X-MagicPipe-Producer"] = metadata[:producer]
         end
+
+        unless resp.success?
+          raise SubmitFailedError, self.class
+        end
       end
 
 

data/lib/magic_pipe/transports/log.rb

@@ -7,7 +7,7 @@ module MagicPipe
         super(config, metrics)
       end
 
-      def submit(payload, _metadata)
+      def submit!(payload, _metadata)
         @logger.info "[Trasport#submit]: ↩️\n#{payload}\n"
       end
     end

data/lib/magic_pipe/transports/multi.rb

@@ -9,10 +9,10 @@ module MagicPipe
       end
 
 
-      def submit(payload, metadata)
+      def submit!(payload, metadata)
         @transports.map do |transport|
           begin
-            transport.submit(payload, metadata)
+            transport.submit!(payload, metadata)
           rescue => e
             log_error(e, transport)
           end

data/lib/magic_pipe/transports/sqs.rb

@@ -15,7 +15,10 @@ module MagicPipe
       end
 
 
-      def submit(payload, metadata)
+      # The AWS SQS client will raise an error if it can't
+      # submit the message.
+      #
+      def submit!(payload, metadata)
         send_message(payload, metadata)
       end
 

data/lib/magic_pipe/version.rb

@@ -1,3 +1,3 @@
 module MagicPipe
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: magic_pipe
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Tommaso Pavese
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-24 00:00:00.000000000 Z
+date: 2018-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -248,7 +248,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: A Magic Pipe to send data in arbitrary formats to configurable backends,