magellan-publisher 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d38adff420cc28de137ce67afb59bd8109e0a3d9
-  data.tar.gz: edf2f4bd089b5c5ca8507ffaa022130a37685782
+  metadata.gz: 8009042b4cf90b3a91fd1063b3fd7f558eba3b87
+  data.tar.gz: 40ba2d7b358fb62dc7fe365698214469cbd609ab
 SHA512:
-  metadata.gz: eecfefcf1d081102103ff4d317ae41f71c6b7c7bb2d969494de5b7ef78b7a17481d5da196e5786f11de4bf9b9333076d19cd744e92839bda198cfeb32b02ce2f
-  data.tar.gz: c12bceffff43b22e316c5398e70548ef0a0dedd8bfe1e8e67cd3cde468fc37fe571be19e637b6c14bbf8addc4f65a42862d67257f183239c4b3f23faf5d3d9db
+  metadata.gz: c250a3822a1beb4232a224d5b8a0e8ec1ca9ecef23e56567515cd4b6abd4aa1285867ecfba9cafa6468bf75dbdb5166c1be92d294e0d2ba8b090d61ab765356f
+  data.tar.gz: 3208a67faed86c583004da0caf663790e6b1c6e5ca171770887d52cf04841874c9d10d7c62c5c9c62587bde34f04ecfaf598310d9668372fb09e38b7e275db75

data/lib/magellan/publisher/version.rb

@@ -1,5 +1,5 @@
 module Magellan
   class Publisher
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/lib/magellan/publisher.rb

@@ -2,8 +2,10 @@
 
 module Magellan
   class Publisher
+    class MessageTooLong < StandardError; end
+
     def initialize(host: nil, port: nil, vhost: nil, user: nil, pass: nil, timeout: nil)
-      # RabbitMQへの接続設定を作成
+      # connection settings for AMQP
       connection_settings = {
         host:    load_env_as_default(host,    ['MAGELLAN_PUBLISH_AMQP_ADDR'],    :string),
         port:    load_env_as_default(port,    ['MAGELLAN_PUBLISH_AMQP_PORT'],    :integer),
@@ -19,10 +21,14 @@ module Magellan
 
       exchange_name  = ENV["MAGELLAN_PUBLISH_EXCHANGE"] || "magellan_publish"
 
-      # no_declareを設定しない場合、Exchangeに対してdeclareを実行してしまい、
-      # Acess Contorolにひっかかりエラーとなります
-      # exchangeはmagellan-conductorによって作成済みの想定です
+      # here :no_declare options should be true to get rid of Access Control Error.
       @exchange = @channel.exchange(exchange_name, no_declare: true)
+
+      # publish message size limit
+      @message_size_limit = load_env_as_default(nil, ["MAGELLAN_PUBLISH_MESSAGE_SIZE_LIMIT"], :integer) || (256 * 1024 * 1024)
+      # message size limit should be treated equally with MQTT message.
+      # substruct MQTT's topic length + packet identifier size (4 bytes)
+      @message_size_limit -= 4
     end
 
     def convert_topic(mqtt_topic)
@@ -31,6 +37,9 @@ module Magellan
     private :convert_topic
 
     def publish(topic, body)
+      if topic.bytesize + body.bytesize > @message_size_limit
+        raise MessageTooLong, "publishing topic(#{topic.bytesize} bytes) and payload(#{body.bytesize}) exceed message size limitation#{@message_size_limit}."
+      end
       @exchange.publish(body, routing_key: convert_topic(topic))
     end
 

data/spec/magellan/publisher_spec.rb

@@ -16,22 +16,45 @@ describe Magellan::Publisher do
       @bunny    = BunnyMock.new
       channel = @bunny.create_channel
       @exchange = @bunny.exchange('test_exchange', type: :direct, durable: false, auto_delete: false)
-      expect(@exchange).to receive(:publish).with(@payload, routing_key: @rabbitmq_topic)
 
       allow(Bunny  ).to receive(:new).and_return(@bunny)
       allow(@bunny  ).to receive(:create_channel).and_return(channel)
       allow(channel).to receive(:exchange).with('test_exchange', no_declare: true).and_return(@exchange)
 
       ENV["MAGELLAN_PUBLISH_EXCHANGE"] = "test_exchange"
-      @publisher = Magellan::Publisher.new(host: "127.0.0.1",
-                                           port: 5672,
-                                           vhost: "/customer1.sample_project",
-                                           user: "customer1.sample_project",
-                                           pass: "pasw1")
     end
 
-    it do
-      @publisher.publish(@topic, @payload)
+    context "normally" do
+      before do
+        expect(@exchange).to receive(:publish).with(@payload, routing_key: @rabbitmq_topic)
+        @publisher = Magellan::Publisher.new(host: "127.0.0.1",
+                                             port: 5672,
+                                             vhost: "/customer1.sample_project",
+                                             user: "customer1.sample_project",
+                                             pass: "pasw1")
+      end
+
+      it do
+        @publisher.publish(@topic, @payload)
+      end
+    end
+
+    context "message size limit exceed" do
+      before do
+        ENV["MAGELLAN_PUBLISH_MESSAGE_SIZE_LIMIT"] = (@topic.size + @payload.size + 1).to_s
+        @publisher = Magellan::Publisher.new(host: "127.0.0.1",
+                                             port: 5672,
+                                             vhost: "/customer1.sample_project",
+                                             user: "customer1.sample_project",
+                                             pass: "pasw1")
+      end
+      after do
+        ENV["MAGELLAN_PUBLISH_MESSAGE_SIZE_LIMIT"] = nil
+      end
+
+      it do
+        expect { @publisher.publish(@topic, @payload) }.to raise_error(Magellan::Publisher::MessageTooLong)
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: magellan-publisher
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Tomoyuki Chikanaga
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-11 00:00:00.000000000 Z
+date: 2015-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bunny
@@ -117,7 +117,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: ''