maestrano-connector-rails 1.3.5 → 1.4.0

data/spec/models/sub_entity_base_spec.rb

@@ -14,10 +14,10 @@ describe Maestrano::Connector::Rails::SubEntityBase do
 
     describe 'external_entity_name' do
       context 'when entity is external' do
-        before(:each) {
+        before(:each) do
           allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(true)
           allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
-        }
+        end
 
         it 'returns the entity_name' do
           expect(subject.external_entity_name).to eql('Name')
@@ -25,19 +25,19 @@ describe Maestrano::Connector::Rails::SubEntityBase do
       end
 
       context 'when entity is not external' do
-        before {
+        before do
           allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(false)
-        }
+        end
         it { expect{ subject.external_entity_name }.to raise_error('Forbidden call: cannot call external_entity_name for a connec entity') }
       end
     end
 
     describe 'connec_entity_name' do
       context 'when entity is not external' do
-        before(:each) {
+        before(:each) do
           allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(false)
           allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
-        }
+        end
 
         it 'returns the entity_name' do
           expect(subject.connec_entity_name).to eql('Name')
@@ -45,19 +45,19 @@ describe Maestrano::Connector::Rails::SubEntityBase do
       end
 
       context 'when entity is external' do
-        before {
+        before do
           allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(true)
-        }
+        end
         it { expect{ subject.connec_entity_name }.to raise_error('Forbidden call: cannot call connec_entity_name for an external entity') }
       end
     end
 
     describe 'names_hash' do
       let(:bool) { true }
-      before {
+      before do
         allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(bool)
         allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
-      }
+      end
 
       context 'when external' do
         it { expect(subject.names_hash).to eql({external_entity: 'name'}) }
@@ -79,25 +79,25 @@ describe Maestrano::Connector::Rails::SubEntityBase do
     subject { Maestrano::Connector::Rails::SubEntityBase.new(organization, connec_client, external_client, opts) }
 
     describe 'map_to' do
-      before {
+      before do
         class AMapper
           extend HashMapper
         end
         allow(subject.class).to receive(:mapper_classes).and_return('Name' => AMapper)
-      }
+      end
 
       describe 'failure' do
         it { expect{ subject.map_to('Not an entity', {}) }.to raise_error(RuntimeError) }
       end
 
       context 'when external' do
-        before {
+        before do
           allow(subject.class).to receive(:external?).and_return(true)
           allow(subject.class).to receive(:id_from_external_entity_hash).and_return('this id')
-        }
+        end
 
         it 'calls the mapper denormalize' do
-          expect(AMapper).to receive(:denormalize).and_return({})
+          expect(AMapper).to receive(:denormalize).with({}, subject.instance_values).and_return({})
           subject.map_to('Name', {})
         end
 
@@ -108,6 +108,12 @@ describe Maestrano::Connector::Rails::SubEntityBase do
           subject.map_to('Name', {})
         end
 
+        it 'calls the creation_mapper_classes that delegates to the mapper_classes denormalize when passed true as a third argument' do
+          expect(subject.class).to receive(:creation_mapper_classes).and_call_original
+          expect(AMapper).to receive(:denormalize).with({}, subject.instance_values).and_return({})
+          subject.map_to('Name', {}, true)
+        end
+
         context 'when no refs' do
           it 'calls for reference folding' do
             allow(subject.class).to receive(:references).and_return({})
@@ -117,10 +123,10 @@ describe Maestrano::Connector::Rails::SubEntityBase do
         end
 
         context 'when connec_matching_fields' do
-          before {
+          before do
             expect(AMapper).to receive(:denormalize).and_return({opts: {a: 2}})
             allow(subject.class).to receive(:connec_matching_fields).and_return('matching_fields')
-          }
+          end
 
           it 'adds the matching_fields in the entity opts' do
             expect(subject.map_to('Name', {})).to eql({id: [Maestrano::Connector::Rails::ConnecHelper.id_hash('this id', organization)], opts: {a: 2, matching_fields: 'matching_fields'}}.with_indifferent_access)
@@ -129,15 +135,21 @@ describe Maestrano::Connector::Rails::SubEntityBase do
       end
 
       context 'when not external' do
-        before {
+        before do
           allow(subject.class).to receive(:external?).and_return(false)
-        }
+        end
 
         it 'calls the mapper normalize' do
-          expect(AMapper).to receive(:normalize).and_return({})
+          expect(AMapper).to receive(:normalize).with({}, subject.instance_values).and_return({})
           subject.map_to('Name', {})
         end
+
+        it 'calls the creation_mapper_classes that delegates to the mapper_classes normalize when passed true as a third argument' do
+          expect(subject.class).to receive(:creation_mapper_classes).and_call_original
+          expect(AMapper).to receive(:normalize).with({}, subject.instance_values).and_return({})
+          subject.map_to('Name', {}, true)
+        end
       end
     end
   end
-end
+end

metadata

@@ -1,14 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: maestrano-connector-rails
 version: !ruby/object:Gem::Version
-  version: 1.3.5
+  version: 1.4.0
 platform: ruby
 authors:
+- Maestrano
 - Pierre Berard
+- Marco Bagnasco
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-19 00:00:00.000000000 Z
+date: 2016-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -44,14 +46,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.2.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.2.2
 - !ruby/object:Gem::Dependency
   name: haml-rails
   requirement: !ruby/object:Gem::Requirement
@@ -362,7 +364,7 @@ dependencies:
         version: '0'
 description: Maestrano is the next generation marketplace for SME applications. See
   https://maestrano.com for details.
-email: pierre.berard@maestrano.com
+email: developers@maestrano.com
 executables:
 - rails
 extensions: []