maestrano-connector-rails 1.2.3 → 1.3.0

data/spec/integration/complex_id_references_spec.rb

@@ -0,0 +1,248 @@
+require 'spec_helper'
+
+describe 'complex id references' do
+
+  class Entities::IdPayment < Maestrano::Connector::Rails::ComplexEntity
+    def self.connec_entities_names
+      %w(IdPayment)
+    end
+    def self.external_entities_names
+      %w(IdBill)
+    end
+    def connec_model_to_external_model(connec_hash_of_entities)
+      {'IdPayment' => {'IdBill' => connec_hash_of_entities['IdPayment']}}
+    end
+    def external_model_to_connec_model(external_hash_of_entities)
+      {'IdBill' => {'IdPayment' => external_hash_of_entities['IdBill']}}
+    end
+  end
+
+  module Entities::SubEntities
+  end
+  class Entities::SubEntities::IdPayment < Maestrano::Connector::Rails::SubEntityBase
+    def self.external?
+      false
+    end
+    def self.entity_name
+      'IdPayment'
+    end
+    def self.mapper_classes
+      {
+        'IdBill' => ::IdPaymentMapper
+      }
+    end
+    def self.object_name_from_connec_entity_hash(entity)
+      entity['title']
+    end
+    def self.references
+      {'IdBill' => {record_references: %w(organization_id), id_references: %w(lines/id)}}
+    end
+    def self.id_from_external_entity_hash(entity)
+      entity['ID']
+    end
+  end
+
+  class Entities::SubEntities::IdBill < Maestrano::Connector::Rails::SubEntityBase
+    def self.external?
+      true
+    end
+    def self.entity_name
+      'IdBill'
+    end
+    def self.mapper_classes
+      {'IdPayment' => ::IdPaymentMapper}
+    end
+    def self.id_from_external_entity_hash(entity)
+      entity['ID']
+    end
+    def self.references
+      {'IdPayment' => {record_references: %w(organization_id), id_references: %w(lines/id)}}
+    end
+  end
+
+  class IdLineMapper
+    extend HashMapper
+    map from('id'), to('ID')
+    map from('amount'), to('Price')
+  end
+
+  class IdPaymentMapper
+    extend HashMapper
+    map from('title'), to('Title')
+    map from('organization_id'), to('AccountId')
+    map from('lines'), to('Line'), using: IdLineMapper
+  end
+
+  let(:provider) { 'provider' }
+  let(:oauth_uid) { 'oauth uid' }
+  let!(:organization) { create(:organization, oauth_provider: provider, oauth_uid: oauth_uid) }
+  let(:connec_client) { Maestrano::Connector::Rails::ConnecHelper.get_client(organization) }
+  let(:external_client) { Object.new }
+  let(:connec_payment_id) { '1205c5e0-e18e-0133-890f-07d4de9f9781' }
+  let(:connec_line_id1) { '3405c5e0-e18e-0133-890f-07d4de9f9781' }
+  let(:connec_line_id2) { '4505c5e0-e18e-0133-890f-07d4de9f9781' }
+  let(:ext_payment_id) { 'ext payment id' }
+  let(:ext_org_id) { 'ext org id' }
+  let(:ext_line_id1) { 'ext line id1' }
+  let(:ext_line_id2) { 'ext line id2' }
+
+  let(:payment_title) { 'This is a payment' }
+
+  before {
+    allow(Maestrano::Connector::Rails::External).to receive(:entities_list).and_return(%w(id_payment))
+
+    allow(connec_client).to receive(:get).and_return(ActionDispatch::Response.new(200, {}, {idpayments: [connec_payment]}.to_json, {}))
+    allow(connec_client).to receive(:batch).and_return(ActionDispatch::Response.new(200, {}, {results: [{status: 200, body: {payments: {}}}]}.to_json, {}))
+
+    allow_any_instance_of(Entities::SubEntities::IdBill).to receive(:get_external_entities).and_return([])
+  }
+
+  subject { Maestrano::Connector::Rails::SynchronizationJob.new.sync_entity('id_payment', organization, connec_client, external_client, organization.last_synchronization_date, {}) }
+
+  describe 'a creation from connec' do
+    before {
+      allow_any_instance_of(Entities::SubEntities::IdPayment).to receive(:create_external_entity).and_return(entity_received_after_creation)
+    }
+
+    let(:connec_payment) {
+      {
+        'id' => [
+          {
+            'realm' => 'org-fg4a',
+            'provider' => 'connec',
+            'id' => connec_payment_id
+          }
+        ],
+        'title' => payment_title,
+        'organization_id' => [
+          {
+            'realm' => 'org-fg4a',
+            'provider' => 'connec',
+            'id' => '2305c5e0-e18e-0133-890f-07d4de9f9781'
+          },
+          {
+            'realm' => oauth_uid,
+            'provider' => provider,
+            'id' => ext_org_id
+          }
+        ],
+        'lines' => lines
+      }
+    }
+
+    let(:lines) {
+      [
+        {
+          'id' => [
+            {
+              'realm' => 'org-fg4a',
+              'provider' => 'connec',
+              'id' => connec_line_id1
+            }
+          ],
+          'amount' => 123
+        },
+        {
+          'id' => [
+            {
+              'realm' => 'org-fg4a',
+              'provider' => 'connec',
+              'id' => connec_line_id2
+            }
+          ],
+          'amount' => 456
+        }
+      ]
+    }
+
+    let(:entity_received_after_creation) {
+      {
+        'ID' => ext_payment_id,
+        'Title' => payment_title,
+        'AccountId' => ext_org_id,
+        'Line' => [
+          {
+            'ID' => ext_line_id1,
+            'Price' => 123
+          },
+          {
+            'ID' => ext_line_id2,
+            'Price' => 456
+          }
+        ]
+      }
+    }
+
+    let(:batch_params) {
+      {
+        :sequential=>true,
+        :ops=> [
+          {
+            :method=>"put",
+            :url=>"/api/v2/#{organization.uid}/idpayments/#{connec_payment_id}",
+            :params=>
+            {
+              :idpayments=>{
+                'id' => [
+                  {
+                    'id' => ext_payment_id,
+                    'provider' =>provider,
+                    'realm' =>oauth_uid
+                  }
+                ],
+                'lines' => [
+                  {
+                    'id' => [
+                      {
+                        'realm' => 'org-fg4a',
+                        'provider' => 'connec',
+                        'id' => connec_line_id1
+                      },
+                      {
+                        'realm' => oauth_uid,
+                        'provider' => provider,
+                        'id' => ext_line_id1
+                      }
+                    ]
+                  },
+                  {
+                    'id' => [
+                      {
+                        'realm' => 'org-fg4a',
+                        'provider' => 'connec',
+                        'id' => connec_line_id2
+                      },
+                      {
+                        'realm' => oauth_uid,
+                        'provider' => provider,
+                        'id' => ext_line_id2
+                      }
+                    ]
+                  }
+                ]
+              }
+            }
+          }
+        ]
+      }
+    }
+
+    it 'handles the idmap correctly' do
+      expect{
+        subject
+      }.to change{ Maestrano::Connector::Rails::IdMap.count }.by(1)
+      idmap = Maestrano::Connector::Rails::IdMap.last
+      expect(idmap.name).to eql(payment_title)
+      expect(idmap.connec_entity).to eql('idpayment')
+      expect(idmap.external_entity).to eql('idbill')
+      expect(idmap.message).to be_nil
+      expect(idmap.external_id).to eql(ext_payment_id)
+      expect(idmap.connec_id).to eql(connec_payment_id)
+    end
+
+    it 'send the external id to connec' do
+      expect(connec_client).to receive(:batch).with(batch_params)
+      subject
+    end
+  end
+end

data/spec/integration/complex_naming_spec.rb

@@ -0,0 +1,191 @@
+require 'spec_helper'
+
+describe 'complex entity subentities naming conflict' do
+
+  class Entities::NamePayment < Maestrano::Connector::Rails::ComplexEntity
+    def self.connec_entities_names
+      {Payment: 'NamePayment'}
+    end
+    def self.external_entities_names
+      {Payment: 'ExtPayment'}
+    end
+    def connec_model_to_external_model(connec_hash_of_entities)
+      {'Payment' => {'Payment' => connec_hash_of_entities['Payment']}}
+    end
+    def external_model_to_connec_model(external_hash_of_entities)
+      {'Payment' => {'Payment' => external_hash_of_entities['Payment']}}
+    end
+  end
+
+  module Entities::SubEntities
+  end
+  class Entities::SubEntities::NamePayment < Maestrano::Connector::Rails::SubEntityBase
+    def self.external?
+      false
+    end
+    def self.entity_name
+      'Payment'
+    end
+    def self.mapper_classes
+      {
+        'Payment' => ::PaymentMapper
+      }
+    end
+    def self.object_name_from_connec_entity_hash(entity)
+      entity['title']
+    end
+    def self.references
+      {'Payment' => {record_references: %w(organization_id), id_references: %w(lines/id)}}
+    end
+    def self.id_from_external_entity_hash(entity)
+      entity['ID']
+    end
+  end
+
+  class Entities::SubEntities::ExtPayment < Maestrano::Connector::Rails::SubEntityBase
+    def self.external?
+      true
+    end
+    def self.entity_name
+      'Payment'
+    end
+    def self.mapper_classes
+      {'Payment' => ::PaymentMapper}
+    end
+    def self.id_from_external_entity_hash(entity)
+      entity['ID']
+    end
+    def self.references
+      {'Payment' => {record_references: %w(organization_id), id_references: %w(lines/id)}}
+    end
+  end
+
+  class LineMapper
+    extend HashMapper
+    map from('id'), to('ID')
+    map from('amount'), to('Price')
+  end
+
+  class PaymentMapper
+    extend HashMapper
+    map from('title'), to('Title')
+    map from('organization_id'), to('AccountId')
+    map from('lines'), to('Line'), using: LineMapper
+  end
+
+  let(:provider) { 'provider' }
+  let(:oauth_uid) { 'oauth uid' }
+  let!(:organization) { create(:organization, oauth_provider: provider, oauth_uid: oauth_uid) }
+  let(:connec_client) { Maestrano::Connector::Rails::ConnecHelper.get_client(organization) }
+  let(:external_client) { Object.new }
+  let(:connec_payment_id) { '1205c5e0-e18e-0133-890f-07d4de9f9781' }
+  let(:connec_line_id1) { '3405c5e0-e18e-0133-890f-07d4de9f9781' }
+  let(:ext_payment_id) { 'ext payment id' }
+  let(:ext_org_id) { 'ext org id' }
+  let(:ext_line_id1) { 'ext line id1' }
+  let(:payment_title) { 'This is a payment' }
+
+  before {
+    allow(Maestrano::Connector::Rails::External).to receive(:entities_list).and_return(%w(name_payment))
+  }
+
+  subject { Maestrano::Connector::Rails::SynchronizationJob.new.sync_entity('name_payment', organization, connec_client, external_client, organization.last_synchronization_date, {}) }
+
+  describe 'fetching entities from external' do
+    before {
+      allow_any_instance_of(Entities::SubEntities::NamePayment).to receive(:get_connec_entities).and_return([])
+    }
+
+    it 'does a fetch with the right name' do
+      expect_any_instance_of(Entities::SubEntities::ExtPayment).to receive(:get_external_entities).with('Payment', organization.last_synchronization_date).and_return([])
+      subject
+    end
+  end
+
+  describe 'sending entities to external' do
+    before {
+      allow(connec_client).to receive(:get).and_return(ActionDispatch::Response.new(200, {}, {payments: [connec_payment]}.to_json, {}))
+      allow(connec_client).to receive(:batch).and_return(ActionDispatch::Response.new(200, {}, {results: [{status: 200, body: {payments: {}}}]}.to_json, {}))
+
+      allow_any_instance_of(Entities::SubEntities::ExtPayment).to receive(:get_external_entities).and_return([])
+    }
+
+    let(:connec_payment) {
+      {
+        'id' => [
+          {
+            'realm' => 'org-fg4a',
+            'provider' => 'connec',
+            'id' => connec_payment_id
+          }
+        ],
+        'title' => payment_title,
+        'organization_id' => [
+          {
+            'realm' => 'org-fg4a',
+            'provider' => 'connec',
+            'id' => '2305c5e0-e18e-0133-890f-07d4de9f9781'
+          },
+          {
+            'realm' => oauth_uid,
+            'provider' => provider,
+            'id' => ext_org_id
+          }
+        ],
+        'lines' => lines
+      }
+    }
+
+    let(:lines) {
+      [
+        {
+          'id' => [
+            {
+              'realm' => 'org-fg4a',
+              'provider' => 'connec',
+              'id' => connec_line_id1
+            }
+          ],
+          'amount' => 123
+        }
+      ]
+    }
+
+    let(:mapped_payment) {
+      {
+        "Title"=>"This is a payment",
+        "AccountId"=>"ext org id",
+        "Line"=>[{"Price"=>123}]}
+    }
+
+    before {
+      allow_any_instance_of(Entities::SubEntities::NamePayment).to receive(:create_external_entity).and_return({'ID' => ext_payment_id})
+    }
+
+    it 'handles the idmap correctly' do
+      expect{
+        subject
+      }.to change{ Maestrano::Connector::Rails::IdMap.count }.by(1)
+      idmap = Maestrano::Connector::Rails::IdMap.last
+      expect(idmap.name).to eql(payment_title)
+      expect(idmap.connec_entity).to eql('payment')
+      expect(idmap.external_entity).to eql('payment')
+      expect(idmap.message).to be_nil
+      expect(idmap.external_id).to eql(ext_payment_id)
+      expect(idmap.connec_id).to eql(connec_payment_id)
+    end
+
+    it 'handles the mapping correctly' do
+      payment_idmap = Entities::SubEntities::NamePayment.create_idmap(organization_id: organization.id, external_id: ext_payment_id, connec_entity: 'payment')
+      allow(Maestrano::Connector::Rails::IdMap).to receive(:create).and_return(payment_idmap)
+      expect_any_instance_of(Entities::NamePayment).to receive(:push_entities_to_external).with({'Payment' => {'Payment' => [{entity: mapped_payment.with_indifferent_access, idmap: payment_idmap, id_refs_only_connec_entity: {'lines' => lines.map { |l| l.delete('amount'); l }}}]}})
+      subject
+    end
+
+    it 'handles the sending with the correct names' do
+      expect_any_instance_of(Entities::SubEntities::NamePayment).to receive(:create_external_entity).once.with(mapped_payment, 'Payment').and_return({})
+      expect(connec_client).to receive(:batch).once.and_return(ActionDispatch::Response.new(201, {}, {results: []}.to_json, {}))
+      subject
+    end
+  end
+end

data/spec/integration/{integration_complex_spec.rb → complex_spec.rb}

@@ -10,16 +10,16 @@ describe 'complex entities workflow' do
     end
     def connec_model_to_external_model(connec_hash_of_entities)
       organizations = connec_hash_of_entities['CompOrganization']
-      modeled_connec_entities = {'CompOrganization' => { 'CompSupplier' => [], 'CompCustomer' => [] }}
+      modelled_connec_entities = {'CompOrganization' => { 'CompSupplier' => [], 'CompCustomer' => [] }}
 
       organizations.each do |organization|
         if organization['is_supplier']
-          modeled_connec_entities['CompOrganization']['CompSupplier'] << organization
+          modelled_connec_entities['CompOrganization']['CompSupplier'] << organization
         else
-          modeled_connec_entities['CompOrganization']['CompCustomer'] << organization
+          modelled_connec_entities['CompOrganization']['CompCustomer'] << organization
         end
       end
-      return modeled_connec_entities
+      return modelled_connec_entities
     end
     def external_model_to_connec_model(external_hash_of_entities)
       return {'CompCustomer' => {'CompOrganization' => external_hash_of_entities['CompCustomer']}, 'CompSupplier' => {'CompOrganization' => external_hash_of_entities['CompSupplier']}}
@@ -228,7 +228,7 @@ describe 'complex entities workflow' do
 
   it 'handles the idmap correctly' do
     allow(connec_client).to receive(:batch).and_return(ActionDispatch::Response.new(201, {}, {results: []}.to_json, {}))
-    allow_any_instance_of(Entities::SubEntities::CompOrganization).to receive(:create_external_entity).and_return(connec_org1_ext_id)
+    allow_any_instance_of(Entities::SubEntities::CompOrganization).to receive(:create_external_entity).and_return({'id' => connec_org1_ext_id})
     allow_any_instance_of(Entities::SubEntities::CompOrganization).to receive(:update_external_entity).and_return(nil)
     expect{
       subject
@@ -267,14 +267,14 @@ describe 'complex entities workflow' do
     org1_idmap = Entities::SubEntities::CompOrganization.create_idmap(organization_id: organization.id, external_id: connec_org1_ext_id, external_entity: 'compsupplier')
     org2_idmap = Entities::SubEntities::CompOrganization.create_idmap(organization_id: organization.id, external_id: connec_org2_ext_id, external_entity: 'compcustomer')
     allow(Maestrano::Connector::Rails::IdMap).to receive(:create).and_return(org1_idmap, org2_idmap, cust_idmap)
-    expect_any_instance_of(Entities::CustomerAndSupplier).to receive(:push_entities_to_external).with({'CompOrganization' => {'CompSupplier' => [{entity: mapped_connec_org1, idmap: org1_idmap}], 'CompCustomer' => [{entity: mapped_connec_org2, idmap: org2_idmap}]}})
-    expect_any_instance_of(Entities::CustomerAndSupplier).to receive(:push_entities_to_connec).with({'CompCustomer' => {'CompOrganization' => [{entity: mapped_ext_customer, idmap: cust_idmap}]}, 'CompSupplier' => {'CompOrganization' => [{entity: mapped_ext_supplier, idmap: supplier_idmap}]}})
+    expect_any_instance_of(Entities::CustomerAndSupplier).to receive(:push_entities_to_external).with({'CompOrganization' => {'CompSupplier' => [{entity: mapped_connec_org1.with_indifferent_access, idmap: org1_idmap, id_refs_only_connec_entity: {}}], 'CompCustomer' => [{entity: mapped_connec_org2.with_indifferent_access, idmap: org2_idmap, id_refs_only_connec_entity: {}}]}})
+    expect_any_instance_of(Entities::CustomerAndSupplier).to receive(:push_entities_to_connec).with({'CompCustomer' => {'CompOrganization' => [{entity: mapped_ext_customer.with_indifferent_access, idmap: cust_idmap}]}, 'CompSupplier' => {'CompOrganization' => [{entity: mapped_ext_supplier.with_indifferent_access, idmap: supplier_idmap}]}})
     subject
   end
 
   it 'sends two objects to connec, two objects to external and send back one id to connec' do
-    expect_any_instance_of(Entities::SubEntities::CompOrganization).to receive(:create_external_entity).once
-    expect_any_instance_of(Entities::SubEntities::CompOrganization).to receive(:update_external_entity).once
+    expect_any_instance_of(Entities::SubEntities::CompOrganization).to receive(:create_external_entity).once.with(mapped_connec_org1, 'CompSupplier').and_return({})
+    expect_any_instance_of(Entities::SubEntities::CompOrganization).to receive(:update_external_entity).once.with(mapped_connec_org2, connec_org2_ext_id, 'CompCustomer')
     expect(connec_client).to receive(:batch).exactly(3).times.and_return(ActionDispatch::Response.new(201, {}, {results: []}.to_json, {}), ActionDispatch::Response.new(200, {}, {results: []}.to_json, {}))
     subject
   end