maestrano-connector-rails 0.2.20 → 0.3.0

data/spec/models/entity_spec.rb

@@ -8,35 +8,6 @@ describe Maestrano::Connector::Rails::Entity do
     describe 'entities_list' do
       it { expect(subject.entities_list).to eql(%w(entity1 entity2))}
     end
-  end
-
-  describe 'instance methods' do
-    subject { Maestrano::Connector::Rails::Entity.new }
-
-    describe 'Mapper methods' do
-      before(:each) {
-        class AMapper
-          extend HashMapper
-          def self.set_organization(organization_id)
-          end
-        end
-        allow(subject).to receive(:mapper_class).and_return(AMapper)
-      }
-
-      describe 'map_to_external' do
-        it 'calls the setter normalize' do
-          expect(AMapper).to receive(:normalize).with({})
-          subject.map_to_external({}, nil)
-        end
-      end
-
-      describe 'map_to_connec' do
-        it 'calls the setter denormalize' do
-          expect(AMapper).to receive(:denormalize).with({})
-          subject.map_to_connec({}, nil)
-        end
-      end
-    end
 
     # IdMap methods
     describe 'idmaps mehtods' do
@@ -61,7 +32,7 @@ describe Maestrano::Connector::Rails::Entity do
         before {
           allow(subject).to receive(:object_name_from_external_entity_hash).and_return('name_e')
           allow(subject).to receive(:object_name_from_connec_entity_hash).and_return('name_c')
-          allow(subject).to receive(:get_id_from_external_entity_hash).and_return('id')
+          allow(subject).to receive(:id_from_external_entity_hash).and_return('id')
         }
 
         it {
@@ -73,37 +44,118 @@ describe Maestrano::Connector::Rails::Entity do
           subject.create_idmap_from_external_entity({}, organization)
         }
       end
-
     end
 
-    # Connec! methods
-    describe 'connec_methods' do
-      let(:organization) { create(:organization) }
-      let(:client) { Maestrano::Connec::Client.new(organization.uid) }
-      let(:connec_name) { 'Person' }
-      let(:external_name) { 'external_name' }
-      let(:sync) { create(:synchronization) }
+    describe 'normalized_connec_entity_name' do
       before {
         allow(subject).to receive(:connec_entity_name).and_return(connec_name)
       }
+      context 'for a singleton resource' do
+        before {
+          allow(subject).to receive(:singleton?).and_return(true)
+        }
 
-      describe 'normalized_connec_entity_name' do
-        context 'for a singleton resource' do
-          before {
-            allow(subject).to receive(:singleton?).and_return(true)
-          }
-
+        context 'for a simple name' do
+          let(:connec_name) { 'Person' }
           it { expect(subject.normalized_connec_entity_name).to eql('person') }
         end
 
-        context 'for a non singleton resource' do
-          before {
-            allow(subject).to receive(:singleton?).and_return(false)
-          }
+        context 'for a complex name' do
+          let(:connec_name) { 'Credit Note' }
+          it { expect(subject.normalized_connec_entity_name).to eql('credit_note') }
+        end
+      end
+
+      context 'for a non singleton resource' do
+        before {
+          allow(subject).to receive(:singleton?).and_return(false)
+        }
 
+        context 'for a simple name' do
+          let(:connec_name) { 'Person' }
           it { expect(subject.normalized_connec_entity_name).to eql('people') }
         end
+
+        context 'for a complex name' do
+          let(:connec_name) { 'Credit Note' }
+          it { expect(subject.normalized_connec_entity_name).to eql('credit_notes') }
+        end
       end
+    end
+
+    describe 'id_from_external_entity_hash' do
+      it { expect{ subject.id_from_external_entity_hash(nil) }.to raise_error('Not implemented') }
+    end
+
+    describe 'last_update_date_from_external_entity_hash' do
+      it { expect{ subject.last_update_date_from_external_entity_hash(nil) }.to raise_error('Not implemented') }
+    end
+
+    # Entity specific methods
+    describe 'singleton?' do
+      it 'is false by default' do
+        expect(subject.singleton?).to be false
+      end
+    end
+
+    describe 'connec_entity_name' do
+      it { expect{ subject.connec_entity_name }.to raise_error('Not implemented') }
+    end
+
+    describe 'external_entity_name' do
+      it { expect{ subject.external_entity_name }.to raise_error('Not implemented') }
+    end
+
+    describe 'mapper_class' do
+      it { expect{ subject.mapper_class }.to raise_error('Not implemented') }
+    end
+
+    describe 'object_name_from_connec_entity_hash' do
+      it { expect{ subject.object_name_from_connec_entity_hash({}) }.to raise_error('Not implemented') }
+    end
+
+    describe 'object_name_from_external_entity_hash' do
+      it { expect{ subject.object_name_from_external_entity_hash({}) }.to raise_error('Not implemented') }
+    end
+  end
+
+  describe 'instance methods' do
+    subject { Maestrano::Connector::Rails::Entity.new }
+
+    describe 'Mapper methods' do
+      before(:each) {
+        class AMapper
+          extend HashMapper
+        end
+        allow(subject.class).to receive(:mapper_class).and_return(AMapper)
+      }
+
+      describe 'map_to_external' do
+        it 'calls the mapper normalize' do
+          expect(AMapper).to receive(:normalize).with({})
+          subject.map_to_external({}, nil)
+        end
+      end
+
+      describe 'map_to_connec' do
+        it 'calls the mapper denormalize' do
+          expect(AMapper).to receive(:denormalize).with({})
+          subject.map_to_connec({}, nil)
+        end
+      end
+    end
+
+    # Connec! methods
+    describe 'connec_methods' do
+      let(:organization) { create(:organization) }
+      let(:client) { Maestrano::Connec::Client.new(organization.uid) }
+      let(:connec_name) { 'Person' }
+      let(:external_name) { 'external_name' }
+      let(:sync) { create(:synchronization) }
+      before {
+        allow(subject.class).to receive(:connec_entity_name).and_return(connec_name)
+        allow(subject.class).to receive(:external_entity_name).and_return(external_name)
+      }
 
       describe 'get_connec_entities' do
 
@@ -111,7 +163,7 @@ describe Maestrano::Connector::Rails::Entity do
           context 'for a singleton resource' do
             before {
               allow(client).to receive(:get).and_return(ActionDispatch::Response.new(200, {}, {person: []}.to_json, {}))
-              allow(subject).to receive(:singleton?).and_return(true)
+              allow(subject.class).to receive(:singleton?).and_return(true)
             }
 
             it 'calls get with a singularize url' do
@@ -188,7 +240,7 @@ describe Maestrano::Connector::Rails::Entity do
       describe 'push_entities_to_connec_to' do
         let(:organization) { create(:organization) }
         let(:idmap1) { create(:idmap, organization: organization) }
-        let(:idmap2) { create(:idmap, organization: organization, connec_id: nil, connec_entity: nil, last_push_to_connec: nil) }
+        let(:idmap2) { create(:idmap, organization: organization, connec_id: nil, last_push_to_connec: nil) }
         let(:entity1) { {name: 'John'} }
         let(:entity2) { {name: 'Jane'} }
         let(:entity_with_idmap1) { {entity: entity1, idmap: idmap1} }
@@ -210,9 +262,14 @@ describe Maestrano::Connector::Rails::Entity do
           expect(idmap1.last_push_to_connec).to_not eql(old_push_date)
           idmap2.reload
           expect(idmap2.connec_id).to eql(id)
-          expect(idmap2.connec_entity).to eql(connec_name.downcase)
           expect(idmap2.last_push_to_connec).to_not be_nil
         end
+
+        it 'stores an errr if any in the idmap' do
+          subject.push_entities_to_connec_to(client, entities_with_idmaps, '', organization)
+          idmap1.reload
+          expect(idmap1.message).to_not be nil
+        end
       end
 
       describe 'create_connec_entity' do
@@ -251,11 +308,11 @@ describe Maestrano::Connector::Rails::Entity do
         let(:id) { '765e-zer4' }
         let(:mapped_entity) { {'first_name' => 'John'} }
         before {
-          allow(subject).to receive(:connec_entity_name).and_return(connec_name)
-          allow(subject).to receive(:external_entity_name).and_return(external_name)
+          allow(subject.class).to receive(:connec_entity_name).and_return(connec_name)
+          allow(subject.class).to receive(:external_entity_name).and_return(external_name)
           allow(subject).to receive(:map_to_external).and_return(mapped_entity)
-          allow(subject).to receive(:object_name_from_connec_entity_hash).and_return('name')
-          allow(subject).to receive(:object_name_from_external_entity_hash).and_return('name')
+          allow(subject.class).to receive(:object_name_from_connec_entity_hash).and_return('name')
+          allow(subject.class).to receive(:object_name_from_external_entity_hash).and_return('name')
         }
 
         context 'when entity has an idmap' do
@@ -292,7 +349,7 @@ describe Maestrano::Connector::Rails::Entity do
         context 'when entity has no idmap' do
           let(:entity) { {'id' => id, 'name' => 'John', 'updated_at' => 5.hour.ago } }
           before {
-            allow(subject).to receive(:object_name_from_connec_entity_hash).and_return('human readable stuff')
+            allow(subject.class).to receive(:object_name_from_connec_entity_hash).and_return('human readable stuff')
           }
 
           it { expect{ subject.map_to_external_with_idmap(entity, organization) }.to change{Maestrano::Connector::Rails::IdMap.count}.by(1) }
@@ -329,7 +386,7 @@ describe Maestrano::Connector::Rails::Entity do
 
       describe 'push_entities_to_external' do
         it 'calls push_entities_to_external_to' do
-          allow(subject).to receive(:external_entity_name).and_return(external_name)
+          allow(subject.class).to receive(:external_entity_name).and_return(external_name)
           expect(subject).to receive(:push_entities_to_external_to).with(nil, entities_with_idmaps, external_name, organization)
           subject.push_entities_to_external(nil, entities_with_idmaps, organization)
         end
@@ -337,7 +394,7 @@ describe Maestrano::Connector::Rails::Entity do
 
       describe 'push_entities_to_external_to' do
         it 'calls push_entity_to_external for each entity' do
-          allow(subject).to receive(:connec_entity_name).and_return(connec_name)
+          allow(subject.class).to receive(:connec_entity_name).and_return(connec_name)
           expect(subject).to receive(:push_entity_to_external).twice
           subject.push_entities_to_external_to(nil, entities_with_idmaps, external_name, organization)
         end
@@ -370,7 +427,6 @@ describe Maestrano::Connector::Rails::Entity do
             subject.push_entity_to_external(nil, entity_with_idmap2, external_name, organization)
             idmap2.reload
             expect(idmap2.external_id).to eql('999111')
-            expect(idmap2.external_entity).to eql(external_name)
             expect(idmap2.last_push_to_external).to_not be_nil
           end
         end
@@ -387,14 +443,6 @@ describe Maestrano::Connector::Rails::Entity do
 
         it { expect{ subject.update_external_entity(nil, nil, nil, nil, organization) }.to raise_error('Not implemented') }
       end
-
-      describe 'get_id_from_external_entity_hash' do
-        it { expect{ subject.get_id_from_external_entity_hash(nil) }.to raise_error('Not implemented') }
-      end
-
-      describe 'get_last_update_date_from_external_entity_hash' do
-        it { expect{ subject.get_last_update_date_from_external_entity_hash(nil) }.to raise_error('Not implemented') }
-      end
     end
 
 
@@ -406,19 +454,19 @@ describe Maestrano::Connector::Rails::Entity do
       let(:id) { '56882' }
       let(:date) { 2.hour.ago }
       before {
-        allow(subject).to receive(:get_id_from_external_entity_hash).and_return(id)
-        allow(subject).to receive(:get_last_update_date_from_external_entity_hash).and_return(date)
-        allow(subject).to receive(:external_entity_name).and_return(external_name)
-        allow(subject).to receive(:connec_entity_name).and_return(connec_name)
+        allow(subject.class).to receive(:id_from_external_entity_hash).and_return(id)
+        allow(subject.class).to receive(:last_update_date_from_external_entity_hash).and_return(date)
+        allow(subject.class).to receive(:external_entity_name).and_return(external_name)
+        allow(subject.class).to receive(:connec_entity_name).and_return(connec_name)
       }
 
       context 'for a singleton method' do
         before {
-          allow(subject).to receive(:singleton?).and_return(true)
+          allow(subject.class).to receive(:singleton?).and_return(true)
           allow(subject).to receive(:map_to_connec).and_return({map: 'connec'})
           allow(subject).to receive(:map_to_external).and_return({map: 'external'})
-          allow(subject).to receive(:object_name_from_connec_entity_hash).and_return('connec human name')
-          allow(subject).to receive(:object_name_from_external_entity_hash).and_return('external human name')
+          allow(subject.class).to receive(:object_name_from_connec_entity_hash).and_return('connec human name')
+          allow(subject.class).to receive(:object_name_from_external_entity_hash).and_return('external human name')
         }
 
         it { expect(subject.consolidate_and_map_data([], [], organization)).to eql({connec_entities: [], external_entities: []}) }
@@ -490,7 +538,7 @@ describe Maestrano::Connector::Rails::Entity do
 
           before {
             allow(subject).to receive(:map_to_connec).and_return(mapped_entity)
-            allow(subject).to receive(:object_name_from_external_entity_hash).and_return(human_name)
+            allow(subject.class).to receive(:object_name_from_external_entity_hash).and_return(human_name)
           }
 
           context 'when entity has no idmap' do
@@ -587,34 +635,6 @@ describe Maestrano::Connector::Rails::Entity do
 
       end
     end
-
-
-    # Entity specific methods
-    describe 'singleton?' do
-      it 'is false by default' do
-        expect(subject.singleton?).to be false
-      end
-    end
-
-    describe 'connec_entity_name' do
-      it { expect{ subject.connec_entity_name }.to raise_error('Not implemented') }
-    end
-
-    describe 'external_entity_name' do
-      it { expect{ subject.external_entity_name }.to raise_error('Not implemented') }
-    end
-
-    describe 'mapper_class' do
-      it { expect{ subject.mapper_class }.to raise_error('Not implemented') }
-    end
-
-    describe 'object_name_from_connec_entity_hash' do
-      it { expect{ subject.object_name_from_connec_entity_hash({}) }.to raise_error('Not implemented') }
-    end
-
-    describe 'object_name_from_external_entity_hash' do
-      it { expect{ subject.object_name_from_external_entity_hash({}) }.to raise_error('Not implemented') }
-    end
   end
 
 end

data/spec/models/sub_entity_base_spec.rb

@@ -1,116 +1,122 @@
 require 'spec_helper'
 
 describe Maestrano::Connector::Rails::SubEntityBase do
-  subject { Maestrano::Connector::Rails::SubEntityBase.new }
+  describe 'class methods' do
+    subject { Maestrano::Connector::Rails::SubEntityBase }
 
-  describe 'external?' do
-    it { expect{ subject.external? }.to raise_error('Not implemented') }
-  end
+    describe 'external?' do
+      it { expect{ subject.external? }.to raise_error('Not implemented') }
+    end
 
-  describe 'entity_name' do
-    it { expect{ subject.entity_name }.to raise_error('Not implemented') }
-  end
+    describe 'entity_name' do
+      it { expect{ subject.entity_name }.to raise_error('Not implemented') }
+    end
 
-  describe 'map_to' do
-    it { expect{ subject.map_to('name', {}, nil) }.to raise_error('Not implemented') }
-  end
+    describe 'external_entity_name' do
+      context 'when entity is external' do
+        before(:each) {
+          allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(true)
+          allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
+        }
 
-  describe 'external_entity_name' do
-    context 'when entity is external' do
-      before(:each) {
-        allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(true)
-        allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
-      }
+        it 'returns the entity_name' do
+          expect(subject.external_entity_name).to eql('Name')
+        end
+      end
 
-      it 'returns the entity_name' do
-        expect(subject.external_entity_name).to eql('Name')
+      context 'when entity is not external' do
+        before {
+          allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(false)
+        }
+        it { expect{ subject.external_entity_name }.to raise_error('Forbidden call: cannot call external_entity_name for a connec entity') }
       end
     end
 
-    context 'when entity is not external' do
-      before {
-        allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(false)
-      }
-      it { expect{ subject.external_entity_name }.to raise_error('Forbidden call: cannot call external_entity_name for a connec entity') }
-    end
-  end
+    describe 'connec_entity_name' do
+      context 'when entity is not external' do
+        before(:each) {
+          allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(false)
+          allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
+        }
 
-  describe 'connec_entity_name' do
-    context 'when entity is not external' do
-      before(:each) {
-        allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(false)
-        allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
-      }
+        it 'returns the entity_name' do
+          expect(subject.connec_entity_name).to eql('Name')
+        end
+      end
 
-      it 'returns the entity_name' do
-        expect(subject.connec_entity_name).to eql('Name')
+      context 'when entity is external' do
+        before {
+          allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(true)
+        }
+        it { expect{ subject.connec_entity_name }.to raise_error('Forbidden call: cannot call connec_entity_name for an external entity') }
       end
     end
 
-    context 'when entity is external' do
+    describe 'names_hash' do
+      let(:bool) { true }
       before {
-        allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(true)
+        allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(bool)
+        allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
       }
-      it { expect{ subject.connec_entity_name }.to raise_error('Forbidden call: cannot call connec_entity_name for an external entity') }
+
+      context 'when external' do
+        it { expect(subject.names_hash).to eql({external_entity: 'name'}) }
+      end
+      context 'when not external' do
+        let(:bool) { false }
+        it { expect(subject.names_hash).to eql({connec_entity: 'name'}) }
+      end
     end
-  end
 
-  describe 'names_hash' do
-    let(:bool) { true }
-    before {
-      allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(bool)
-      allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
-    }
+    describe 'create_idmap_from_external_entity' do
+      let(:organization) { create(:organization) }
+      let(:bool) { true }
+      before {
+        allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(bool)
+        allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
+        allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:id_from_external_entity_hash).and_return('id')
+        allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:object_name_from_external_entity_hash).and_return('object name')
+      }
 
-    context 'when external' do
-      it { expect(subject.names_hash).to eql({external_entity: 'name'}) }
-    end
-    context 'when not external' do
-      let(:bool) { false }
-      it { expect(subject.names_hash).to eql({connec_entity: 'name'}) }
+      context 'when external' do
+        it {
+          expect(Maestrano::Connector::Rails::IdMap).to receive(:create).with({:external_entity=>"name", :external_id=>"id", :name=>"object name", :connec_entity=>"lala", :organization_id=>1})
+          subject.create_idmap_from_external_entity({}, 'lala', organization)
+        }
+      end
+      context 'when not external' do
+        let(:bool) { false }
+        it { expect{ subject.create_idmap_from_external_entity({}, '', organization) }.to raise_error('Forbidden call: cannot call create_idmap_from_external_entity for a connec entity') }
+      end
     end
-  end
 
-  describe 'create_idmap_from_external_entity' do
-    let(:organization) { create(:organization) }
-    let(:bool) { true }
-    before {
-      allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(bool)
-      allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
-      allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:get_id_from_external_entity_hash).and_return('id')
-      allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:object_name_from_external_entity_hash).and_return('object name')
-    }
-
-    context 'when external' do
-      it {
-        expect(Maestrano::Connector::Rails::IdMap).to receive(:create).with({:external_entity=>"name", :external_id=>"id", :name=>"object name", :connec_entity=>"lala", :organization_id=>1})
-        subject.create_idmap_from_external_entity({}, 'lala', organization)
+    describe 'create_idmap_from_connec_entity' do
+      let(:organization) { create(:organization) }
+      let(:bool) { true }
+      before {
+        allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(bool)
+        allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
+        allow(Maestrano::Connector::Rails::SubEntityBase).to receive(:object_name_from_connec_entity_hash).and_return('object name')
       }
-    end
-    context 'when not external' do
-      let(:bool) { false }
-      it { expect{ subject.create_idmap_from_external_entity({}, '', organization) }.to raise_error('Forbidden call: cannot call create_idmap_from_external_entity for a connec entity') }
+
+      context 'when external' do
+        it { expect{ subject.create_idmap_from_connec_entity({}, '', organization) }.to raise_error('Forbidden call: cannot call create_idmap_from_connec_entity for an external entity') }
+      end
+      context 'when not external' do
+        let(:bool) { false }
+        it {
+          expect(Maestrano::Connector::Rails::IdMap).to receive(:create).with({:connec_entity=>"name", :connec_id=>"lili", :name=>"object name", :external_entity=>"lala", :organization_id=>1})
+          subject.create_idmap_from_connec_entity({'id' => 'lili'}, 'lala', organization)
+        }
+      end
     end
   end
 
-  describe 'create_idmap_from_connec_entity' do
-    let(:organization) { create(:organization) }
-    let(:bool) { true }
-    before {
-      allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:external?).and_return(bool)
-      allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:entity_name).and_return('Name')
-      allow_any_instance_of(Maestrano::Connector::Rails::SubEntityBase).to receive(:object_name_from_connec_entity_hash).and_return('object name')
-    }
-
-    context 'when external' do
-      it { expect{ subject.create_idmap_from_connec_entity({}, '', organization) }.to raise_error('Forbidden call: cannot call create_idmap_from_connec_entity for an external entity') }
-    end
-    context 'when not external' do
-      let(:bool) { false }
-      it {
-        expect(Maestrano::Connector::Rails::IdMap).to receive(:create).with({:connec_entity=>"name", :connec_id=>"lili", :name=>"object name", :external_entity=>"lala", :organization_id=>1})
-        subject.create_idmap_from_connec_entity({'id' => 'lili'}, 'lala', organization)
-      }
+  describe 'instance methods' do
+    subject { Maestrano::Connector::Rails::SubEntityBase.new }
+
+    describe 'map_to' do
+      it { expect{ subject.map_to('name', {}, nil) }.to raise_error('Not implemented') }
     end
   end
 end