madvertise-logging 0.5.0 → 0.6.0

data/lib/madvertise/logging/improved_logger.rb

@@ -132,9 +132,12 @@ module Madvertise
       #
       # @param [Exception, String] exc  The exception to log. If exc is a
       #   String no backtrace will be generated.
-      def exception(exc)
-        exc = "EXCEPTION: #{exc.message}: #{clean_trace(exc.backtrace)}" if exc.is_a?(::Exception)
-        add(:fatal, exc, true)
+      # @param [String] prefix  Additional message to log.
+      def exception(exc, prefix=nil)
+        msg = "EXCEPTION"
+        msg << ": #{prefix}" if prefix
+        msg << ": #{exc.message}: #{clean_trace(exc.backtrace)}" if exc.is_a?(::Exception)
+        fatal(msg)
       end
 
       # Save the current token and associate it with obj#object_id.
@@ -188,11 +191,10 @@ module Madvertise
         [ File.basename(file), num ].join(':')
       end
 
-      def add(severity, message, skip_caller = false)
+      def add(severity, message)
         severity = self.class.severities[severity]
-        message = "#{called_from}: #{message}" unless skip_caller
+        message = "#{called_from}: #{message}"
         message = "[#{@token}] #{message}" if @token
-
         logger.add(severity) { message }
         return nil
       end
@@ -279,6 +281,7 @@ module Madvertise
         end
       end
 
+      # @private
       module IOCompat
         def close_read
           nil

data/lib/madvertise/logging/version.rb

@@ -1,6 +1,6 @@
 module Madvertise
   module Logging
     # @private
-    VERSION = "0.5.0"
+    VERSION = "0.6.0"
   end
 end

data/spec/improved_logger_spec.rb

@@ -71,7 +71,6 @@ describe ImprovedLogger do
 
   it "should log fatal level messages" do
     @logger.fatal("Fatal test")
-
     @logfile.should have_received_message(/\[FATAL\].*Fatal test/)
   end
 
@@ -117,6 +116,19 @@ describe ImprovedLogger do
     @logfile.should_not have_received_message("EXCEPTION:")
   end
 
+  it "should log additional info on exceptions" do
+    fake_trace = [
+                  "/home/jdoe/app/libexec/app.rb:1:in `foo'",
+                  "/usr/lib/ruby/gems/1.8/gems/madvertise-logging-0.1.0/lib/madvertise/logging/improved_logger.rb:42: in `info'"
+                 ]
+
+    e = RuntimeError.new('Test error')
+    e.set_backtrace(fake_trace)
+
+    @logger.exception(e, "app failed to foo")
+    @logfile.should have_received_message("app failed to foo")
+  end
+
   it "should support silencing" do
     @logger.silence do |logger|
       logger.info "This should never be logged"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: madvertise-logging
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-22 00:00:00.000000000 Z
+date: 2012-09-11 00:00:00.000000000 Z
 dependencies: []
 description: Advanced logging classes with buffer backend, transactions, multi logger,
   etc
@@ -55,7 +55,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3990327644738544266
+      hash: -1250046391813060871
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -64,7 +64,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3990327644738544266
+      hash: -1250046391813060871
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.17