madmin 2.3.1 → 2.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a1057d4a94a2fe018140855f9f53eadef48dc9c74f64465e886e05ea36e95ba4
-  data.tar.gz: f67554da6c25a3f04a011375144dfd8b6ef4fc1e7dfd36fe0a724c97cbe7f568
+  metadata.gz: 2862cda2a9f7f8cc5313b205404c21bc4bd2e3a9aa780dfe6ba708ef0db51c34
+  data.tar.gz: a6dd1ac4898938c31ab694c61ca9c7ac379510b3ab00cc9830d8df43d651aff5
 SHA512:
-  metadata.gz: 215a864a11540a1e532e47159ad04c286e04163e86d9ba240ec19f0c13dc1d604d3af153a2dc39abbf8e6449cf40ca020f987f0d76fbd92b1ef97211e8cb62db
-  data.tar.gz: 8e54f95302d99d7d52a7ff37eecc5e01f8d8d90ce60d8c0925ef0cf7503df530d1b6e47b89eb067e7c4d34ee4e7aaee78cd764502c5c0c1e5f26c92004fd66b0
+  metadata.gz: 8958ec3db4a60cd9df3484a9eb864f6b273ef646ae5a631f13cc16f0d7870147998193552de77c4cef6aad57bf3d97db8bd3f18fa213304f35b430f5d60ac8c7
+  data.tar.gz: d0eb3ec050476cdd04beec7d6ec2cb3a5a1a10d47dbab182b19236b2d8d3a0b90bebdbda04a0e8f5f875a2b695379095a3681470178669a9bc23ccdcb1e55a22

data/README.md

@@ -131,6 +131,7 @@ For example, we can use a select for the genre attribute and specify the collect
 class BookResource < Madmin::Resource
   attribute :genre, :select, collection: ["Fiction", "Mystery", "Thriller"]
 end
+```
 
 ## Custom Fields
 

data/app/views/madmin/application/index.html.erb

@@ -39,7 +39,7 @@
           <% next if attribute.field.nil? %>
           <% next unless attribute.field.visible?(action_name) %>
 
-          <th><%= sortable attribute.name, attribute.name.to_s.titleize %></th>
+          <th><%= sortable attribute.name, attribute.field.label %></th>
         <% end %>
         <th></th>
       </tr>

data/app/views/madmin/application/show.html.erb

@@ -25,7 +25,7 @@
 
       <tr>
         <th class="label">
-          <%= attribute.field.options.label || attribute.name.to_s.titleize %>
+          <%= attribute.field.label %>
         </th>
 
         <td>

data/lib/madmin/field.rb

@@ -29,6 +29,10 @@ module Madmin
       attribute_name
     end
 
+    def label
+      options[:label].presence || attribute_name.to_s.titleize
+    end
+
     # Used for checking visibility of attribute on an view
     def visible?(action)
       action = action.to_sym

data/lib/madmin/resource.rb

@@ -54,15 +54,16 @@ module Madmin
         config = ActiveSupport::OrderedOptions.new.merge(options)
         yield config if block_given?
 
-        # Form is an alias for new & edit
-        if config.has_key?(:form)
-          config.new = config[:form]
-          config.edit = config[:form]
-        end
+        # Form is an alias for new & edit but shouldn't override their values if explicitly set (true/false)
+        config.new = config[:form] if config[:new].nil?
+        config.edit = config[:form] if config[:edit].nil?
 
         # New/create and edit/update need to match
-        config.create = config[:create] if config.has_key?(:new)
-        config.update = config[:update] if config.has_key?(:edit)
+        config.create = config.new
+        config.update = config.edit
+
+        # Remove any nil values to use the defaults
+        config.compact!
 
         attributes[name] = Attribute.new(
           name: name,
@@ -84,7 +85,7 @@ module Madmin
         namespace = model.module_parents.detect do |n|
           n.respond_to?(:use_relative_model_naming?) && n.use_relative_model_naming?
         end
-        @route_namespace = (namespace ? namespace.name.singularize.underscore.to_sym : nil)
+        @route_namespace = (namespace ? namespace.name.underscore.to_sym : nil)
       end
 
       def index_path(options = {})

data/lib/madmin/version.rb

@@ -1,3 +1,3 @@
 module Madmin
-  VERSION = "2.3.1"
+  VERSION = "2.3.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: madmin
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 2.3.3
 platform: ruby
 authors:
 - Chris Oliver
@@ -285,7 +285,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.2
+rubygems_version: 4.0.12
 specification_version: 4
 summary: A modern admin for Ruby on Rails apps
 test_files: []