mad_cart 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 450e045c29572b5f75ffe9e6e21a9a608d6773f9
-  data.tar.gz: ff7b972a1438efa3421e8399b7bcdcfcadfde030
+  metadata.gz: 4b414baa5cd556c5664acb0daf217ee9e41d9489
+  data.tar.gz: 1e64b3d30bb94d163532c25cfcc11d8773effc7f
 SHA512:
-  metadata.gz: a0ec1b9b0b0882efadbd8b9c405875f16dbd98b9a28f28869f2f0d374e72dd49d7644f9135e33438919c905b2d7a52d3ed54775443850244c9c279d434b3b748
-  data.tar.gz: d5f0ddc64d5a44ad69df71720d2f769ada23ee57eae6b0b6b801c85bd561c7e622ec024220cec417ffefb7dd2abb60d995f9a1f559d461b7b0d06d2369879665
+  metadata.gz: 2341f979b1f6f50db08f1077574a521c40e877087431d130eb552c6b0098ed35f08598b2c81b1bcbd2a05b23d6ddf7eb3dfa473bb1d2518d8f53095c6645cb16
+  data.tar.gz: c8491b179797a5e7fc17aa4e3427353a0a38235e7f79f3bdf6c9aad615a2157d907ade75330528db96f1fc522f51cb8dd346cfb47fc93343c2b75ab1e63781f4

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+rvm:
+  - 2.3.5
+cache:
+  - bundler
+script:
+  - bundle exec rspec spec

data/lib/mad_cart/store/base.rb

@@ -65,6 +65,8 @@ module MadCart
         case response.status
         when 401
           raise InvalidCredentials
+        when 404
+          raise InvalidStore
         when 500
           raise ServerError
         end

data/lib/mad_cart/version.rb

@@ -1,3 +1,3 @@
 module MadCart
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

data/spec/lib/configuration_spec.rb

@@ -8,9 +8,8 @@ describe "configuration" do
   end
 
   describe "stores" do
-
     it "does not require store to be added if credentials are passed to constructor" do
-      lambda{ MadCart::Store::BigCommerce.new({:api_key => 'a_fake_key', :store_url => '/path/to/store', :username => 'bob'}) }.should_not raise_error
+      expect { MadCart::Store::BigCommerce.new({:api_key => 'a_fake_key', :store_url => '/path/to/store', :username => 'bob'}) }.not_to raise_error
     end
 
     it "allows config values to be set for a store" do
@@ -19,24 +18,23 @@ describe "configuration" do
         config.add_store :big_commerce, config_data
       end
 
-      MadCart.config.big_commerce.should == config_data
+      expect(MadCart.config.big_commerce).to eql(config_data)
     end
 
     it "gives returns nil if there's no config" do
-      MadCart.config.missing_store.should be_nil
+      expect(MadCart.config.missing_store).to be_nil
     end
-
   end
 
   describe "models" do
     it "allows custom attribute names to be set" do
-      lambda {
+      expect {
         MadCart.configure do |config|
           config.attribute_map :products, {"name" => "title"}
         end
-      }.should_not raise_error
+      }.not_to raise_error
 
-      MadCart.config.attribute_maps["products"].should == {"name" => "title"}
+      expect(MadCart.config.attribute_maps["products"]).to eql({"name" => "title"})
     end
 
     it "allows additional attributes to be included in models" do
@@ -44,9 +42,7 @@ describe "configuration" do
         config.include_attributes :products => [:external_id, :url]
       end
 
-      MadCart.config.included_attributes[:products].should == [:external_id, :url]
+      expect(MadCart.config.included_attributes[:products]).to eql([:external_id, :url])
     end
-
   end
-
 end

data/spec/lib/mad_cart_spec.rb

@@ -1,25 +1,25 @@
 require "spec_helper"
 
 describe MadCart do
-  
+
   it "allows configuration" do
     MadCart.configure do |config|
-      config.should be_a(MadCart::Configuration)
-      config.should be_a(Singleton)
+      expect(config).to be_a(MadCart::Configuration)
+      expect(config).to be_a(Singleton)
     end
   end
-  
+
   it "provides config values" do
-    MadCart.config.should be_a(MadCart::Configuration::Data)
+    expect(MadCart.config).to be_a(MadCart::Configuration::Data)
   end
-  
+
   it "complains when the #config getter is used to set config values" do
-    lambda do
+    expect {
       MadCart.config {|config| config.add_store :big_commerce }
-    end.should raise_error(ArgumentError, "MadCart.config does not support blocks. Use MadCart.configure to set config values.")
+    }.to raise_error(ArgumentError, "MadCart.config does not support blocks. Use MadCart.configure to set config values.")
   end
-  
+
   it "complains if #configure is used incorrectly" do
-    lambda { MadCart.configure }.should raise_error(ArgumentError, "MadCart.configure requires a block argument.")
-  end  
-end
+    expect { MadCart.configure }.to raise_error(ArgumentError, "MadCart.configure requires a block argument.")
+  end
+end

data/spec/lib/model/base_spec.rb

@@ -1,6 +1,7 @@
 require "spec_helper"
 
 describe MadCart::Store::Base do
+
   before(:each) do
     clear_config
     Object.send(:remove_const, :MyModel) if Object.const_defined?(:MyModel)
@@ -15,35 +16,34 @@ describe MadCart::Store::Base do
       MadCart.configure do |config|
         config.include_attributes :my_models => [:external_id, :url]
       end
-      
+
       o = MyModel.new(:name => 'whiskey', :description => 'tasty', :external_id => 2, :url => 'path/to/whiskey', :discarded => 'property')
-      o.attributes.should == {"name" => 'whiskey', "description" => 'tasty', "external_id" => 2, "url" => 'path/to/whiskey'}
+      expect(o.attributes).to eql({"name" => 'whiskey', "description" => 'tasty', "external_id" => 2, "url" => 'path/to/whiskey'})
     end
-    
+
     it "includes mapped attributes" do
       MadCart.configure do |config|
         config.attribute_map :my_models, :old_name => :new_name
       end
-      
+
       o = MyModel.new(:name => 'whiskey', :description => 'tasty', :discarded => 'property', :old_name => 'is included')
-      o.attributes.should == {"name" => 'whiskey', "description" => 'tasty', "new_name" => 'is included'}
+      expect(o.attributes).to eql({"name" => 'whiskey', "description" => 'tasty', "new_name" => 'is included'})
     end
-    
+
     it "allows two sources to map to the same model" do
       MadCart.configure do |config|
         config.include_attributes :my_models => [:external_id]
         config.attribute_map :my_models, :id => :external_id
       end
-      
+
       source_a = {:name => 'whiskey', :description => 'tasty', :discarded => 'property', :id => 'has been renamed'}
       source_b = {:name => 'whiskey', :description => 'tasty', :discarded => 'property', :external_id => 'is included'}
-      
+
       model_a = MyModel.new(source_a)
-      model_a.attributes.should == {"name" => 'whiskey', "description" => 'tasty', "external_id" => 'has been renamed'}
-      
+      expect(model_a.attributes).to eql({"name" => 'whiskey', "description" => 'tasty', "external_id" => 'has been renamed'})
+
       model_b = MyModel.new(source_b)
-      model_b.attributes.should == {"name" => 'whiskey', "description" => 'tasty', "external_id" => 'is included'}
+      expect(model_b.attributes).to eql({"name" => 'whiskey', "description" => 'tasty', "external_id" => 'is included'})
     end
   end
-
 end

data/spec/lib/model/customer_spec.rb

@@ -10,7 +10,7 @@ describe MadCart::Model::Customer do
     attrs = {"first_name" => 'Bob', "last_name" => 'Sagat', "email" => 'bob@sagat.com'}
     c = MadCart::Model::Customer.new(attrs)
 
-    c.attributes.should eql(attrs)
+    expect(c.attributes).to eql(attrs)
   end
 
   it "allows attributes to be overwritten" do
@@ -20,17 +20,16 @@ describe MadCart::Model::Customer do
 
     c = MadCart::Model::Customer.new(:first_name => 'Bob', :last_name => 'Sagat', :email => 'bob@sagat.com')
 
-    c.attributes.should eql({"name" => 'Bob', "last_name" => 'Sagat', "email" => 'bob@sagat.com'})
+    expect(c.attributes).to eql({"name" => 'Bob', "last_name" => 'Sagat', "email" => 'bob@sagat.com'})
   end
 
   it "exposes all additional attributes provided by the api" do
     c = MadCart::Model::Customer.new("first_name" => 'Bob', "last_name" => 'Sagat', "email" => 'bob@sagat.com', "with" => 'some', "additional" => 'fields' )
 
-    c.additional_attributes.should eql({"with" => 'some', "additional" => 'fields'})
+    expect(c.additional_attributes).to eql({"with" => 'some', "additional" => 'fields'})
   end
 
   describe "validation" do
-
     before(:each) do
       @args = {:first_name => 'first_name',
                :last_name => 'last_name',
@@ -40,19 +39,17 @@ describe MadCart::Model::Customer do
 
     it "requires first_name" do
       @args.delete(:first_name)
-      lambda{ MadCart::Model::Customer.new(@args)  }.should raise_error(ArgumentError)
+      expect { MadCart::Model::Customer.new(@args) }.to raise_error(ArgumentError)
     end
 
     it "requires last_name" do
       @args.delete(:last_name)
-      lambda{ MadCart::Model::Customer.new(@args)  }.should raise_error(ArgumentError)
+      expect { MadCart::Model::Customer.new(@args)  }.to raise_error(ArgumentError)
     end
 
     it "requires email" do
       @args.delete(:email)
-      lambda{ MadCart::Model::Customer.new(@args)  }.should raise_error(ArgumentError)
+      expect { MadCart::Model::Customer.new(@args)  }.to raise_error(ArgumentError)
     end
-
   end
-
 end

data/spec/lib/model/product_spec.rb

@@ -15,7 +15,7 @@ describe MadCart::Model::Product do
 
     c = MadCart::Model::Product.new(default_attrs.merge(extra_attrs))
 
-    c.attributes.should eql(default_attrs)
+    expect(c.attributes).to eql(default_attrs)
   end
 
   it "allows attribute names to be overwritten" do
@@ -29,7 +29,7 @@ describe MadCart::Model::Product do
 
     c = MadCart::Model::Product.new(attrs.merge(:name => "product name", :square_image_url => 'path/to/square/image'))
 
-    c.attributes.should eql(attrs.merge("title" => "product name",
+    expect(c.attributes).to eql(attrs.merge("title" => "product name",
                                         "thumbnail" => 'path/to/square/image'))
   end
 
@@ -39,11 +39,10 @@ describe MadCart::Model::Product do
 
     c = MadCart::Model::Product.new(attrs.merge(:with => 'some', :additional => 'fields'))
 
-    c.additional_attributes.should eql({"with" => 'some', "additional" => 'fields'})
+    expect(c.additional_attributes).to eql({"with" => 'some', "additional" => 'fields'})
   end
 
   describe "validation" do
-
     before(:each) do
       @args = {:name => 'name',
                :external_id => 'external_id',
@@ -58,17 +57,17 @@ describe MadCart::Model::Product do
 
     it "requires name" do
       @args.delete(:name)
-      lambda{ MadCart::Model::Product.new(@args)  }.should raise_error(ArgumentError)
+      expect { MadCart::Model::Product.new(@args) }.to raise_error(ArgumentError)
     end
 
     it "requires description" do
       @args.delete(:description)
-      lambda{ MadCart::Model::Product.new(@args)  }.should raise_error(ArgumentError)
+      expect { MadCart::Model::Product.new(@args) }.to raise_error(ArgumentError)
     end
 
     it "requires image_url" do
       @args.delete(:image_url)
-      lambda{ MadCart::Model::Product.new(@args)  }.should raise_error(ArgumentError)
+      expect { MadCart::Model::Product.new(@args) }.to raise_error(ArgumentError)
     end
   end
 end

data/spec/lib/store/base_spec.rb

@@ -9,7 +9,7 @@ describe MadCart::Store::Base do
 
   describe "connection" do
     it "adds a create_connection_with method" do
-      MyStore.should respond_to(:create_connection_with)
+      expect(MyStore).to respond_to(:create_connection_with)
     end
 
     it "accepts a method reference" do
@@ -21,7 +21,7 @@ describe MadCart::Store::Base do
         end
       end
 
-      MyStore.new.connection.should == TestResult
+      expect(MyStore.new.connection).to eql(TestResult)
     end
 
     it "accepts a proc" do
@@ -29,7 +29,7 @@ describe MadCart::Store::Base do
         create_connection_with Proc.new {|args| TestResult }
       end
 
-      MyStore.new.connection.should == TestResult
+      expect(MyStore.new.connection).to eql(TestResult)
     end
 
     it "raises an error if any required connection arguments are not present" do
@@ -37,7 +37,9 @@ describe MadCart::Store::Base do
         create_connection_with Proc.new { }, :requires => [:api_key, :username]
       end
 
-      lambda { MyStore.new(:api_key => 'key').connection }.should raise_error(ArgumentError, "Missing connection arguments: username")
+      expect {
+        MyStore.new(:api_key => 'key').connection
+      }.to raise_error(ArgumentError, "Missing connection arguments: username")
     end
 
     it "retrieves configured connection arguments" do
@@ -49,7 +51,7 @@ describe MadCart::Store::Base do
         config.add_store :my_store, {:several => 'of', :args => 'yes?'}
       end
 
-      lambda { MyStore.new().connection }.should_not raise_error
+      expect { MyStore.new().connection }.not_to raise_error
     end
 
     it "retrieves a combination of configured and initialised connection arguments" do
@@ -61,13 +63,13 @@ describe MadCart::Store::Base do
         config.add_store :my_store, {:several => 'only'}
       end
 
-      lambda { MyStore.new(:args => 'too').connection }.should_not raise_error
+      expect { MyStore.new(:args => 'too').connection }.not_to raise_error
     end
   end
 
   describe "fetch" do
     it "adds a fetch method" do
-      MyStore.should respond_to(:fetch)
+      expect(MyStore).to respond_to(:fetch)
     end
 
     it "accepts a method reference" do
@@ -80,8 +82,8 @@ describe MadCart::Store::Base do
       end
 
       result = double(MadCart::Model::Product)
-      MadCart::Model::Product.should_receive(:new).with({:some => 'attrs'}).and_return(result)
-      MyStore.new.products.should == [result]
+      expect(MadCart::Model::Product).to receive(:new).with({:some => 'attrs'}).and_return(result)
+      expect(MyStore.new.products).to eql([result])
     end
 
     it "accepts a proc" do
@@ -90,8 +92,8 @@ describe MadCart::Store::Base do
       end
 
       result = double(MadCart::Model::Product)
-      MadCart::Model::Product.should_receive(:new).twice.with({:some => 'attrs'}).and_return(result)
-      MyStore.new.products.should == [result, result]
+      expect(MadCart::Model::Product).to receive(:new).twice.with({:some => 'attrs'}).and_return(result)
+      expect(MyStore.new.products).to eql([result, result])
     end
 
     it "converts hashes into instances of the mad cart model" do
@@ -102,7 +104,7 @@ describe MadCart::Store::Base do
         fetch :products, :with => Proc.new { [attrs, attrs] }
       end
 
-      MyStore.new.products.each{|p| p.should be_a(MadCart::Model::Product) }
+      MyStore.new.products.each { |p| expect(p).to be_a(MadCart::Model::Product) }
     end
 
     it "returns instances of the mad cart model if the fetch method returns them" do
@@ -113,7 +115,7 @@ describe MadCart::Store::Base do
         fetch :products, :with => Proc.new { [MadCart::Model::Product.new(attrs), MadCart::Model::Product.new(attrs)] }
       end
 
-      MyStore.new.products.each{|p| p.should be_a(MadCart::Model::Product) }
+      MyStore.new.products.each { |p| expect(p).to be_a(MadCart::Model::Product) }
     end
 
     it "returns instances of the mad cart model if the format method returns them" do
@@ -125,7 +127,7 @@ describe MadCart::Store::Base do
         format :products, :with => Proc.new {|p| MadCart::Model::Product.new(p) }
       end
 
-      MyStore.new.products.each{|p| p.should be_a(MadCart::Model::Product) }
+      MyStore.new.products.each { |p| expect(p).to be_a(MadCart::Model::Product) }
     end
 
     it "can be configured to retrieve additional attributes" do
@@ -141,7 +143,7 @@ describe MadCart::Store::Base do
 
   describe "format" do
     it "adds a format method" do
-      MyStore.should respond_to(:format)
+      expect(MyStore).to respond_to(:format)
     end
 
     it "accepts a method reference" do
@@ -155,8 +157,8 @@ describe MadCart::Store::Base do
       end
 
       store = MyStore.new
-      store.should_receive(:format_method).with(:one => 1).and_return(double(MadCart::Model::Product))
-      store.stub(:ensure_model_format)
+      expect(store).to receive(:format_method).with(:one => 1).and_return(double(MadCart::Model::Product))
+      allow(store).to receive(:ensure_model_format)
       store.products
     end
 
@@ -167,7 +169,7 @@ describe MadCart::Store::Base do
       end
 
       store = MyStore.new
-      store.should_receive(:ensure_model_format).with(:products, ["1"])
+      expect(store).to receive(:ensure_model_format).with(:products, ["1"])
       store.products
     end
   end
@@ -183,7 +185,7 @@ describe MadCart::Store::Base do
       end
 
       o = MyStore.new
-      lambda { o.connection }.should raise_error(MadCart::Store::SetupError,
+      expect { o.connection }.to raise_error(MadCart::Store::SetupError,
           "It appears MyStore has overrided the default MadCart::Base initialize method. " +
           "That's fine, but please store any required connection arguments as @init_args " +
           "for the #connection method to use later. Remember to call #after_initialize " +
@@ -193,7 +195,7 @@ describe MadCart::Store::Base do
 
   describe "after_initialize" do
     it "adds an after_initialize method" do
-      MyStore.should respond_to(:after_initialize)
+      expect(MyStore).to respond_to(:after_initialize)
     end
 
     it "accepts a method reference" do
@@ -210,7 +212,7 @@ describe MadCart::Store::Base do
         end
       end
 
-      MyStore.new(:connection => TestResult).connection.should == TestResult
+      expect(MyStore.new(:connection => TestResult).connection).to eql(TestResult)
     end
 
     it "accepts a proc" do
@@ -223,7 +225,7 @@ describe MadCart::Store::Base do
         end
       end
 
-      TestResult.should_receive(:new)
+      expect(TestResult).to receive(:new)
 
       MyStore.new(:connection => TestResult)
     end

data/spec/lib/store/big_commerce_spec.rb

@@ -11,85 +11,74 @@ describe MadCart::Store::BigCommerce do
   }
 
   describe "store" do
-
     it "expects to be instantiated with an api key, username and store url" do
-      lambda { MadCart::Store::BigCommerce.new(:username => 'test', :store_url => 'test').connection }.should raise_error(ArgumentError)
-      lambda { MadCart::Store::BigCommerce.new(:api_key => 'test', :username => 'test', :store_url => 'test').connection }.should_not raise_error
+      expect {
+        MadCart::Store::BigCommerce.new(:username => 'test', :store_url => 'test').connection
+      }.to raise_error(ArgumentError)
+      expect {
+        MadCart::Store::BigCommerce.new(:api_key => 'test', :username => 'test', :store_url => 'test').connection
+      }.not_to raise_error
     end
 
     it "authenticates via basic auth" do
-      connection = Faraday.new
-      Faraday.stub(:new).and_yield(connection)
-
-      connection.should_receive(:basic_auth).with('username', 'api_key')
-
-      MadCart::Store::BigCommerce.new(:api_key => 'api_key', :username => 'username', :store_url => 'url').connection
+      connection = MadCart::Store::BigCommerce.new(:api_key => 'api_key', :username => 'username', :store_url => 'url').connection
+      expect(connection.headers['Authorization']).not_to be_nil
     end
-
   end
 
   describe "products" do
-
     context "retrieval" do
-
       it "returns products" do
         VCR.use_cassette('big_commerce_products') do
           products = subject.products(limit: 10)
-          products.size.should == 10
+          expect(products.size).to eql(10)
 
           first_product = products.first
-          first_product.should be_a(MadCart::Model::Product)
-          first_product.name.should_not be_nil
-          first_product.description.should_not be_nil
-          first_product.image_url.should_not be_nil
+          expect(first_product).to be_a(MadCart::Model::Product)
+          expect(first_product.name).not_to be_nil
+          expect(first_product.description).not_to be_nil
+          expect(first_product.image_url).not_to be_nil
         end
       end
 
       it "returns an empty array when there are no products" do
         VCR.use_cassette('big_commerce_no_records') do
-          subject.products.should == []
+          expect(subject.products).to eql([])
         end
       end
 
-
       it "returns an empty array when there are no images for any products" do
         VCR.use_cassette('big_commerce_products_no_images') do
-          subject.products.should == []
+          expect(subject.products).to eql([])
         end
       end
-
     end
 
     context "count" do
-
       it "returns how many products there are" do
         VCR.use_cassette('big_commerce_products_count') do
-          subject.products_count.should == 45
+          expect(subject.products_count).to eql(45)
         end
       end
-
     end
-
   end
 
   describe "customers" do
     context "retrieval" do
-
       it "returns all customers" do
         VCR.use_cassette('big_commerce_customers') do
           customers = subject.customers
 
-          customers.size.should be > 0
-          customers.first.should be_a(MadCart::Model::Customer)
+          expect(customers.size).to be > 0
+          expect(customers.first).to be_a(MadCart::Model::Customer)
         end
       end
 
       it "returns an empty array whern there are no customers" do
         VCR.use_cassette('big_commerce_no_records') do
-          subject.customers.should eql([])
+          expect(subject.customers).to eql([])
         end
       end
-
     end
   end
 
@@ -97,17 +86,16 @@ describe MadCart::Store::BigCommerce do
     context "retrieval" do
       it "returns the store" do
         VCR.use_cassette('big_commerce_store') do
-          subject.store.should_not be_nil
+          expect(subject.store).not_to be_nil
         end
       end
     end
   end
 
   describe "validating credentials" do
-
     it "succeeds if it can get time.json from big commerce" do
       VCR.use_cassette('big_commerce_time') do
-        subject.should be_valid
+        expect(subject).to be_valid
       end
     end
 
@@ -119,7 +107,7 @@ describe MadCart::Store::BigCommerce do
           :username => 'support@madmimi.com'
         )
 
-        api.should_not be_valid
+        expect(api).not_to be_valid
       end
     end
 
@@ -131,16 +119,15 @@ describe MadCart::Store::BigCommerce do
           :username => 'support@madmimi.com'
         )
 
-        api.should_not be_valid
+        expect(api).not_to be_valid
       end
     end
 
     it "fails if it cannot parse the response from the big commerce server" do
       VCR.use_cassette('big_commerce_time') do
-        subject.connection.stub(:get) { raise Faraday::ParsingError, "" }
-        subject.should_not be_valid
+        allow(subject.connection).to receive(:get).and_raise(Faraday::ParsingError.new(""))
+        expect(subject).not_to be_valid
       end
     end
   end
-
 end

data/spec/lib/store/etsy_spec.rb

@@ -5,7 +5,6 @@ describe MadCart::Store::Etsy do
   before(:each) { clear_config }
 
   describe "retrieving products" do
-
     context "the store doesn't exist" do
       let(:invalid_store_name) { 'MadeUpStore' }
       let(:store) { MadCart::Store::Etsy.new(:store_name => invalid_store_name, :api_key => '4j3amz573gly866229iixzri') }
@@ -18,7 +17,6 @@ describe MadCart::Store::Etsy do
     end
 
     context "the store does exist" do
-
       before(:each) do
         MadCart.configure do |config|
           config.add_store :etsy, {:api_key => '4j3amz573gly866229iixzri'}
@@ -29,16 +27,15 @@ describe MadCart::Store::Etsy do
         VCR.use_cassette('etsy_store_listings') do
           api = MadCart::Store::Etsy.new(:store_name => 'FabBeads')
           products = api.products(:includes => "MainImage")
-          products.size.should == 25 # the etsy product limit
+          expect(products.size).to eql(25) # the etsy product limit
 
           first_product = products.first
 
-          first_product.should be_a(MadCart::Model::Product)
-          first_product.name.should_not be_nil
-          first_product.description.should_not be_nil
-          first_product.image_url.should_not be_nil
-          puts first_product.image_url
-          first_product.additional_attributes['price'].should == BigDecimal.new('2.5')
+          expect(first_product).to be_a(MadCart::Model::Product)
+          expect(first_product.name).not_to be_nil
+          expect(first_product.description).not_to be_nil
+          expect(first_product.image_url).not_to be_nil
+          expect(first_product.additional_attributes['price']).to eql(BigDecimal.new('2.5'))
         end
       end
 
@@ -47,26 +44,25 @@ describe MadCart::Store::Etsy do
           VCR.use_cassette('etsy_store_listings_new_format_image') do
             api = MadCart::Store::Etsy.new(:store_name => 'TheBeadsofDreams')
             products = api.products(:includes => "MainImage")
-            products.size.should == 25 # the etsy product limit
+            expect(products.size).to eql(25) # the etsy product limit
 
             first_product = products.first
 
-            first_product.should be_a(MadCart::Model::Product)
-            first_product.name.should_not be_nil
-            first_product.description.should_not be_nil
-            first_product.image_url.should_not be_nil
-            first_product.additional_attributes['price'].should == BigDecimal.new('2.2')
+            expect(first_product).to be_a(MadCart::Model::Product)
+            expect(first_product.name).not_to be_nil
+            expect(first_product.description).not_to be_nil
+            expect(first_product.image_url).not_to be_nil
+            expect(first_product.additional_attributes['price']).to eql(BigDecimal.new('2.2'))
           end
         end
       end
 
       context "pagination" do
-
         it "defaults to page one" do
           VCR.use_cassette('etsy_store_listings') do
             api = MadCart::Store::Etsy.new(:store_name => 'FabBeads')
 
-            api.connection.should_receive(:listings).with(:active, {:page => 1}).and_return([])
+            expect(api.connection).to receive(:listings).with(:active, {:page => 1}).and_return([])
             api.products
           end
         end
@@ -75,37 +71,31 @@ describe MadCart::Store::Etsy do
           VCR.use_cassette('etsy_store_listings') do
             api = MadCart::Store::Etsy.new(:store_name => 'FabBeads')
 
-            api.connection.should_receive(:listings).with(:active, {:page => 2}).and_return([]) # Trusting the Etsy gem, not testing that it works
+            expect(api.connection).to receive(:listings).with(:active, {:page => 2}).and_return([]) # Trusting the Etsy gem, not testing that it works
             api.products(:page => 2)
           end
         end
-
       end
 
       context "validating credentials" do
-
         it "succeeds if it can get a connection object" do
           VCR.use_cassette('etsy_store_listings') do
             api = MadCart::Store::Etsy.new(:store_name => 'FabBeads')
 
-            api.should be_valid
+            expect(api).to be_valid
           end
         end
 
         it "fails if it cannot get a connection object" do
           VCR.use_cassette('etsy_store_listings') do
             api = MadCart::Store::Etsy.new(:store_name => 'FabBeads')
-            api.stub(:create_connection).and_return(nil)
+            allow(api).to receive(:create_connection).and_return(nil)
 
-            api.should_not be_valid
+            expect(api).not_to be_valid
           end
         end
-
       end
-
     end
-
   end
-
 end
 

data/spec/lib/store/o_auth_big_commerce_spec.rb

@@ -30,7 +30,7 @@ describe MadCart::Store::OAuthBigCommerce do
     context "retrieval" do
       it "returns the store" do
         VCR.use_cassette('o_auth_big_commerce_store') do
-          subject.store.should_not be_nil
+          expect(subject.store).not_to be_nil
         end
       end
     end

data/spec/lib/store/spree_spec.rb

@@ -22,32 +22,28 @@ describe MadCart::Store::Spree do
   }
 
   describe "store" do
-
     it "expects to be instantiated with an api key and store url" do
-      lambda { MadCart::Store::Spree.new(:store_url => 'test').connection }.should raise_error(ArgumentError)
-      lambda { MadCart::Store::Spree.new(:api_key => 'test', :store_url => 'test').connection }.should_not raise_error
+      expect { MadCart::Store::Spree.new(:store_url => 'test').connection }.to raise_error(ArgumentError)
+      expect { MadCart::Store::Spree.new(:api_key => 'test', :store_url => 'test').connection }.not_to raise_error
     end
-
   end
 
   describe "products" do
-
     context "retrieval" do
-
       context "basic spree installation" do
         it "returns all products" do
           VCR.use_cassette(spree_cassette, :record => :new_episodes) do
             api = MadCart::Store::Spree.new(valid_credentials)
 
-            api.products.size.should == 58
+            expect(api.products.size).to eql(58)
 
             first_product = api.products.first
 
-            first_product.should be_a(MadCart::Model::Product)
-            first_product.name.should_not be_nil
-            first_product.description.should_not be_nil
-            first_product.image_url.should_not be_nil
-            first_product.additional_attributes['price'].should_not be_nil
+            expect(first_product).to be_a(MadCart::Model::Product)
+            expect(first_product.name).not_to be_nil
+            expect(first_product.description).not_to be_nil
+            expect(first_product.image_url).not_to be_nil
+            expect(first_product.additional_attributes['price']).not_to be_nil
           end
         end
       end
@@ -57,15 +53,15 @@ describe MadCart::Store::Spree do
           VCR.use_cassette(spree_alternative_cassette, :record => :new_episodes) do
             api = MadCart::Store::Spree.new(valid_alternative_credentials)
 
-            api.products.size.should == 148
+            expect(api.products.size).to eql(148)
 
             first_product = api.products.first
 
-            first_product.should be_a(MadCart::Model::Product)
-            first_product.name.should_not be_nil
-            first_product.description.should_not be_nil
-            first_product.image_url.should_not be_nil
-            first_product.additional_attributes['price'].should_not be_nil
+            expect(first_product).to be_a(MadCart::Model::Product)
+            expect(first_product.name).not_to be_nil
+            expect(first_product.description).not_to be_nil
+            expect(first_product.image_url).not_to be_nil
+            expect(first_product.additional_attributes['price']).not_to be_nil
           end
         end
       end
@@ -73,7 +69,7 @@ describe MadCart::Store::Spree do
       it "returns an empty array when there are no products" do
         VCR.use_cassette(spree_no_records_cassette) do
           api = MadCart::Store::Spree.new(valid_credentials)
-          api.products.should == []
+          expect(api.products).to eql([])
         end
       end
 
@@ -84,7 +80,7 @@ describe MadCart::Store::Spree do
       it "returns how many products there are" do
         VCR.use_cassette(spree_cassette, :record => :new_episodes) do
           api = MadCart::Store::Spree.new(valid_credentials)
-          api.products_count.should == 58
+          expect(api.products_count).to eql(58)
         end
       end
 
@@ -99,8 +95,8 @@ describe MadCart::Store::Spree do
         VCR.use_cassette(spree_cassette, :record => :new_episodes) do
           api = MadCart::Store::Spree.new(valid_credentials)
 
-          api.customers.size.should be > 0
-          api.customers.first.should be_a(MadCart::Model::Customer)
+          expect(api.customers.size).to be > 0
+          expect(api.customers.first).to be_a(MadCart::Model::Customer)
         end
       end
 
@@ -108,19 +104,18 @@ describe MadCart::Store::Spree do
         VCR.use_cassette(spree_no_records_cassette) do
           api = MadCart::Store::Spree.new(valid_credentials)
 
-          api.customers.should eql([])
+          expect(api.customers).to eql([])
         end
       end
 
     end
 
     describe "validating credentials" do
-
       it "succeeds if it can get orders.json from Spree" do
         VCR.use_cassette(spree_cassette, :record => :new_episodes) do
           api = MadCart::Store::Spree.new(valid_credentials)
 
-          api.should be_valid
+          expect(api).to be_valid
         end
       end
 
@@ -131,11 +126,9 @@ describe MadCart::Store::Spree do
             :store_url => valid_credentials[:store_url]
           )
 
-          api.should_not be_valid
+          expect(api).not_to be_valid
         end
       end
-
     end
   end
-
 end

data/spec/spec_helper.rb

@@ -14,7 +14,6 @@ require 'vcr'
 require 'webmock/rspec'
 
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mad_cart
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Marc Heiligers
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-01 00:00:00.000000000 Z
+date: 2017-12-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -203,6 +203,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt