macmillan-utils 1.0.39 → 1.0.40

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 342d3f41a7778b3ea802b26a9f307f7a866291ce
-  data.tar.gz: b5f073466080b7af195b081f479146a6f7fb9c4d
+  metadata.gz: 035e98cbc71c2bebdd28ae144cbcd2f67d4b4271
+  data.tar.gz: 74d77b9604b18e7e0587c5b369197d9cb9273fc0
 SHA512:
-  metadata.gz: 192d5d9564ec74e1f896b410745effe764e11d919410482ede6770be1d0be77d6325944fcc4aaa427cd14b2bc7451dc1d4506d620d02b55f67c4e0a82c109de4
-  data.tar.gz: cb28995106f7da3fd9d4e18d7ac02bd2f61f53489c56f4adbfd87e3154d6bfb6a23eee0957480547cd8c87fcd06d7c696df9b872483334d99c85d9b8cf4236c8
+  metadata.gz: c2787195fab5f2524f0d886f488580ea2f0b791d0f01e9f96fe2d4429d793d89be50003e97200c86c2a694c21553aef4b2498698e3d47ce16239fa0e4fb313ec
+  data.tar.gz: b06b8e063a31ca8044e10fc8e9ab12b15e53011da44b4307dca0388185f93eb12adb8d6ebdae17200fa6569de7f5f642ff520189166d7686ceb4eafbea95bc0b

data/lib/macmillan/utils/logger/formatter.rb

@@ -35,7 +35,7 @@ module Macmillan
         def msg2str(msg)
           case msg
           when ::String
-            msg
+            "#{msg}\n"
           when ::Exception
             "#{msg.message} (#{msg.class})\n" << (msg.backtrace || []).join("\n")
           else

data/lib/macmillan/utils/middleware/uuid.rb

@@ -1,3 +1,5 @@
+require 'securerandom'
+
 module Macmillan
   module Utils
     module Middleware

data/spec/lib/macmillan/utils/logger/formatter_spec.rb

@@ -17,22 +17,27 @@ describe Macmillan::Utils::Logger::Formatter do
     it 'is called by the logger object' do
       expect(target).to receive(:write).once
       expect(subject).to receive(:call).once
-      logger.info 'this is a test'
+      logger.info('this is a test')
     end
 
     context 'when a prefix is set' do
-      let(:prefix) { 'WEEEE' }
+      let(:prefix)       { 'WEEEE' }
+      let(:level_prefix) { '[ INFO]:' }
+      let(:suffix)       { "\n" }
 
-      it 'is put in front of the log message' do
-        expect(target).to receive(:write).with("#{prefix} [ INFO]: #{msg}").once
-        logger.info msg
+      it 'appears in front of the log message, and the expected suffix applies' do
+        expect(target).to receive(:write).with("#{prefix} #{level_prefix} #{msg}#{suffix}").once
+        logger.info(msg)
       end
     end
 
     context 'when the log message is a string' do
-      it 'returns the string' do
-        expect(target).to receive(:write).with("[ INFO]: #{msg}").once
-        logger.info msg
+      let(:level_prefix) { '[ INFO]:' }
+      let(:suffix)       { "\n" }
+
+      it 'returns the string prefixed and suffixed appropriately' do
+        expect(target).to receive(:write).with("#{level_prefix} #{msg}#{suffix}").once
+        logger.info(msg)
       end
     end
 
@@ -41,7 +46,7 @@ describe Macmillan::Utils::Logger::Formatter do
         ex = StandardError.new('qwerty')
         allow(ex).to receive(:backtrace).and_return(%w(foo bar baz quux))
         expect(target).to receive(:write).with("[ INFO]: qwerty (StandardError)\nfoo\nbar\nbaz\nquux").once
-        logger.info ex
+        logger.info(ex)
       end
     end
 
@@ -49,8 +54,7 @@ describe Macmillan::Utils::Logger::Formatter do
       it 'retuns object.inspect' do
         ex = []
         expect(ex).to receive(:inspect).once
-
-        logger.info ex
+        logger.info(ex)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: macmillan-utils
 version: !ruby/object:Gem::Version
-  version: 1.0.39
+  version: 1.0.40
 platform: ruby
 authors:
 - Springer Nature
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-20 00:00:00.000000000 Z
+date: 2017-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler