m-spec 0.1.6 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6420629e2b27b246efaca92e6ad572603eaaf05bfaf716b0d386cadebafab8f9
-  data.tar.gz: 33e8d052ef1d6513a06e9048ac12ce95c51b1597c3ef7246b4d360619b304cab
+  metadata.gz: 40b2437fce4d14eb4337f07a9d3f9ee43a9f6dc27591c19c4efadf53d05d83f3
+  data.tar.gz: 973c37628137445b7fbb1d0645bd657bfa6c6da14ee57426307f4bf0f0dfe3ae
 SHA512:
-  metadata.gz: f9484c58fa989d6dea4c2a94abed38d2d769b04c663c3206588961d41858f3ae1c2afda4cfac94b515c9364191131b96913d335d1379765f8af495ec6da9ddba
-  data.tar.gz: 21ba3b262a018015878cac2b140acbde0e46ad6e916cb17de44e1a25ea4861d49478d67cd05050d354c96ac180647110b3a9937e452c86319cc3098c5ab24255
+  metadata.gz: 1b69cdb674edf1cfc47ffb60c50d6fc6996f3ee49a60211f7941bc697f896514e9c3f62ef8fe77a346371fb2d1c61a830c0b8d792c9fd7bbb4716116efa09da7
+  data.tar.gz: c12a16300c6fcbb25ac84e5ade3d05ba57f2f830899b78ecbdc2e4ea62b62c80be6c99746130f116b15244a5575613b879444cb4050d21b1da8ca6e98583cebc

data/.rubocop.yml

@@ -0,0 +1,12 @@
+#    _____               ____ ____        __     _         __
+#   / ___/ _____ ____ _ / __// __/____   / /    (_)____   / /_
+#   \__ \ / ___// __ `// /_ / /_ / __ \ / /    / // __ \ / __/
+#  ___/ // /__ / /_/ // __// __// /_/ // /___ / // / / // /_
+# /____/ \___/ \__,_//_/  /_/ 1 \____//_____//_//_/ /_/ \__/
+#
+# The linter file that doesn't lead junior developers to bad habits.
+# https://github.com/makersacademy/scaffolint
+#
+# Configure Rubocop to use the config file in the Scaffolint GitHub repo
+inherit_from:
+  - https://raw.githubusercontent.com/makersacademy/scaffolint/v1.1.0/.rubocop.yml

data/Gemfile

@@ -1,6 +1,6 @@
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in mspec.gemspec
 gemspec

data/README.md

@@ -1,6 +1,6 @@
 # Mspec
 
-The lightest-weight spec framework in ruby. Built for learning at [Makers](https://makers.tech). You have one matcher, the comparison matcher, and test setup and teardown is your responsibility. For additional features, you must extend the gem.
+The lightest-weight spec framework in ruby. Built for learning at [Makers](https://makers.tech). You have two matchers, an equality matcher and an output matcher, and test setup and teardown is your responsibility. For additional features, you must extend the gem.
 
 ## Installation
 
@@ -18,6 +18,14 @@ Or install it yourself as:
 
     $ gem install m-spec
 
+## Setup
+
+Initialize m-spec with a `.m-spec` and a `.rubocop.yml` file
+```sh
+m-spec --init
+```
+
+
 ## Usage
 
 We care about isolating unit tests, so there's a very simple mocking library.
@@ -43,19 +51,38 @@ describe 'The Animal' do
   end
 end
 
-describe 'stubbing' do
-  it 'we can mock too!' do
+describe 'test doubles' do
+  it 'can be stubbed' do
     mock = test_double
     allow(mock).to receive(:speak) { 'Hello!' }
     expect(mock.speak).to eq 'Hello!'
   end
+  it 'can have optional names' do
+    mock = test_double('a name')
+    allow(mock).to receive(:speak) { 'Hello!' }
+    expect(mock.speak).to eq 'Hello!'
+  end
+
+  it 'can be sent messages with any args' do
+    mock = test_double('a name')
+    allow(mock).to receive(:speak) { 'Hello!' }
+    expect(mock.speak('example arg')).to eq 'Hello!'
+  end
+end
+
+describe 'testing output' do
+  it 'captures strings' do
+    expect { puts('hello') }.to output("hello\n")
+  end
 end
 ```
 
-To run your specs, pass the spec file directly as an argument. You have to run individual spec files.
+To run your specs, pass the spec file directly as an argument. You have to run individual spec files, or create a file that requires your specs.
 
 ```sh
 $ m-spec ./spec/animal_spec.rb
+# or
+$ m-spec ./spec_runner.rb
 ```
 
 ```
@@ -67,12 +94,28 @@ The Animal
     # /path/to/directory/spec/animal_spec.rb:11:in `block (2 levels) in <top (required)>'
 stubbing
   we can mock too!
+
+Inspecting 3 files
+...
+
+3 files inspected, no offenses detected
 ```
 
 It's got simple one-level indentation, simple colour coding for test passes and failures, and simple failure messages with expected and actual values and the failing spec file path and line number.
 
 Remember - you'll have to manage yourself: test setup and teardown, keeping test code dry, each test running in isolation, and loading source code properly.
 
+## Rubocop
+
+M-spec comes with rubocop by default, using this [set of rules](https://github.com/makersacademy/scaffolint). To configure your test suite to disable rubocop or to only run rubcop, add an optional configuration file named `.m-spec` to your project root where you run your specs from. You don't need the configuration file - by default your specs will run first, followed by rubocop.
+
+You can add either of two options
+- `--no-rubocop` which will ignore running rubocop
+- `--only-rubocop` which will ignore running your tests
+
+See [rubocop documentation](https://docs.rubocop.org/rubocop/index.html) for more info - you might be interested in reading about rubocop's autocorrect command.
+
+
 ## Extending
 
 After checking out the repo

data/exe/m-spec

@@ -1,5 +1,50 @@
 #!/usr/bin/env ruby
 require 'm-spec'
 
-spec_file = ARGV[0]
-require spec_file
+def run_rubocop!
+  # needs default
+  if File.exist?('.rubocop.yml')
+    puts "\n---Readability Tests---\n\n"
+    system("bundle exec rubocop")
+  else
+    puts "ERROR: No '.rubocop.yml' found, please create one at your project \
+root or re-initialize m-spec with `m-spec --init`"
+  end
+end
+
+def run_specs!
+  spec_file = ARGV[0]
+  Mspec::Specs.new(spec_file).run!
+end
+
+if ARGV[0] == '--init'
+  contents = File.read("#{ENV['GEM_HOME']}/gems/m-spec-#{Mspec::VERSION}/.rubocop.yml")
+  File.open('.rubocop.yml', 'w') do |file|
+    file.write(contents)
+  end
+  puts 'created: .rubocop.yml'
+
+  contents =
+"# This has been auto-generated. Feel free to delete these comments.\
+\n#\n# Try adding options below: '--no-rubocop' or '--only-rubocop' \
+without the quotes."
+  File.open('.m-spec', 'w') do |file|
+    file.write(contents)
+  end
+  puts 'created: .m-spec'
+elsif File.exist?('./.m-spec')
+  File.open('./.m-spec', 'r') do |file|
+    options = file.read.split
+    if options.include?('--only-rubocop')
+      run_rubocop!
+    elsif options.include?('--no-rubocop')
+      run_specs!
+    else
+      run_specs!
+      run_rubocop!
+    end
+  end
+else
+  run_specs!
+  run_rubocop!
+end

data/lib/m-spec.rb

@@ -5,6 +5,8 @@ require "m-spec/version"
 require "m-spec/core/expect"
 require "m-spec/core/spec_error"
 require "m-spec/core/spec_result"
+require "m-spec/core/spec_example"
+require "m-spec/core/specs"
 require "m-spec/core/matchers/equal"
 require "m-spec/core/matchers/output"
 require "m-spec/core/helpers/readable"

data/lib/m-spec/core/helpers/readable.rb

@@ -9,21 +9,22 @@ def describe(str)
   yield
 end
 
-def it(str)
-  spec_result = yield
-  if spec_result.success?
+def it(str, specs = Mspec::Specs.instance)
+  spec_example = Mspec::SpecExample.new(str, yield)
+  specs.add(spec_example)
+  if spec_example.success?
     puts "  \e[#{COLOUR_CODES[:green]}m#{str}\e[0m"
   else
-    puts "  \e[#{COLOUR_CODES[:red]}m#{str}\e[0m"
-    spec_result.failure_message.each do |line|
+    puts "  \e[#{COLOUR_CODES[:red]}m#{str}\n\e[0m"
+    spec_example.failure_message.each do |line|
       puts "    \e[#{COLOUR_CODES[:red]}m#{line}\e[0m"
     end
-    puts "    \e[#{COLOUR_CODES[:light_blue]}m# #{spec_result.trace}\e[0m"
+    puts "\n    \e[#{COLOUR_CODES[:light_blue]}m# #{spec_example.trace}\e[0m"
   end
 end
 
-def expect(obj=nil, &block)
-  if obj
+def expect(obj = nil, &block)
+  if !obj.nil?
     Mspec::Expect.new(obj)
   else
     Mspec::Expect.new(block)

data/lib/m-spec/core/matchers/output.rb

@@ -20,7 +20,7 @@ module Mspec
 
       private
 
-      def mock_output(output=StringIO.new, &block)
+      def mock_output(output = StringIO.new, &block)
         $stdout = output
         block.call
         $stdout = STDOUT

data/lib/m-spec/core/spec_example.rb

@@ -0,0 +1,26 @@
+module Mspec
+  class SpecExample
+    attr_reader :description, :result
+
+    def initialize(description, result)
+      @description = description
+      @result = result
+    end
+
+    def success?
+      @result.success?
+    end
+
+    def failure?
+      !success?
+    end
+
+    def failure_message
+      @result.failure_message
+    end
+
+    def trace
+      @result.trace
+    end
+  end
+end

data/lib/m-spec/core/spec_result.rb

@@ -12,8 +12,8 @@ module Mspec
 
     def failure_message
       [
-        "Expected: #{@expected_result.value.inspect}",
-        "Got: #{test_code_result.inspect}",
+        "Expected: ".rjust(10) + "#{@expected_result.value.inspect}",
+        "Got: ".rjust(10) + "#{test_code_result.inspect}",
       ]
     end
 

data/lib/m-spec/core/specs.rb

@@ -0,0 +1,35 @@
+module Mspec
+  class Specs
+    attr_reader :data
+
+    def initialize(file)
+      @file = file
+      @data = []
+      @@instance = self
+    end
+
+    def run!
+      require(@file)
+      summary
+    end
+
+    def add(spec)
+      @data << spec
+    end
+
+    def self.instance
+      @@instance
+    end
+
+    def summary
+      puts "\n---Summary---\n\n"
+      puts "#{@data.length} examples found"
+      failures = @data.select(&:failure?)
+
+      puts "#{failures.length} failures"
+      failures.each_with_index do |spec, index|
+        puts "     \e[#{COLOUR_CODES[:red]}m#{index+1}. #{spec.trace}\e[0m"
+      end
+    end
+  end
+end

data/lib/m-spec/mocks/allow.rb

@@ -6,7 +6,7 @@ module Mspec
       end
 
       def to(stub)
-        @obj.define_singleton_method(stub.name) { stub.return_value }
+        @obj.define_singleton_method(stub.name) { |*| stub.return_value }
       end
     end
   end

data/lib/m-spec/version.rb

@@ -1,3 +1,3 @@
 module Mspec
-  VERSION = "0.1.6"
+  VERSION = "0.2.2"
 end

data/m-spec.gemspec

@@ -22,6 +22,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
+  spec.add_dependency "rubocop", "~> 0.79.0"
+
   spec.add_development_dependency "bundler", "~> 2.1"
   spec.add_development_dependency "rake", ">= 12.3.3"
 end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: m-spec
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.2.2
 platform: ruby
 authors:
 - Edward Withers
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-29 00:00:00.000000000 Z
+date: 2020-08-17 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.79.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.79.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -48,6 +62,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -62,7 +77,9 @@ files:
 - lib/m-spec/core/matchers/equal.rb
 - lib/m-spec/core/matchers/output.rb
 - lib/m-spec/core/spec_error.rb
+- lib/m-spec/core/spec_example.rb
 - lib/m-spec/core/spec_result.rb
+- lib/m-spec/core/specs.rb
 - lib/m-spec/mocks/allow.rb
 - lib/m-spec/mocks/helpers/readable.rb
 - lib/m-spec/mocks/mock.rb