lyrics_finder 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 24d30590b3b2ea3bca2df02b6f094d6765b567c8
-  data.tar.gz: 9958bc037c98e13ae04be1c389f94b537cbde463
+  metadata.gz: 9e959892dc2ad4be082f5e0e5825fae580c9f29e
+  data.tar.gz: db0dda2962c066efc636568399ff2d192582df66
 SHA512:
-  metadata.gz: 56c43572f530c4beffc7420eb077e008abfd6eb46e30cb185e845da7d763089a30e44e7d3f455efa3783105f5f64cd11101101dd683fe03bff947ba934a46b54
-  data.tar.gz: 9931a17d85fba8980ef222de6d1ed8cc53a2339e389015875b681153d4ecbfc42a31aaf89cc48c259cc813e3cd858fd4272f8e89a6e20dd847ff1bf95dbe14db
+  metadata.gz: 7c7a7e8961e6a25b8ee20af60f6911c3e53dc1d581adb893d626ac3cb8c0d2c222aa3ea42350e3522b3fb9e911e193ca34ecd9dad80bdb8302f0d48fcb841412
+  data.tar.gz: 82c7b89bb4ec654935c4bf659daefcf5d88d3aa73f07d63380bd17beaa1d173f62c6cfba36dc25dc516556116e6d24ed15ca3d054f13122d2aef32e9aa9d74f3

data/README.md

@@ -46,6 +46,12 @@ You can choose among the following:
 - AZLyrics (`:azlyrics`)
 - LyricsMania (`:lyrics_mania`)
 
+You can see the websites you are using as lyrics providers with:
+
+```ruby
+  Finder.selected_providers
+```
+
 ## Example
 
 In your ruby apps:

data/lib/lyrics_finder/providers.rb

@@ -4,6 +4,18 @@ module Lyrics
   module Providers
     include Contracts
 
+    def self.providers_list
+      [:lyrics_wikia, :lyrics_mania, :song_lyrics, :azlyrics]
+    end
+
+    def self.filter_providers(providers)
+      valid_providers = []
+      providers.each do |provider|
+        valid_providers << provider if providers_list.include?(provider)
+      end
+      valid_providers.any? ? valid_providers : providers_list
+    end
+
     Contract Symbol => Module
     def self.build_klass(provider)
       klass = "Lyrics::Providers::" + provider.to_s.camelize

data/lib/lyrics_finder/version.rb

@@ -1,3 +1,3 @@
 module LyricsFinder
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/lib/lyrics_finder.rb

@@ -3,23 +3,18 @@ require_relative 'lyrics_finder/dependencies'
 module Lyrics
   class Finder
     include Contracts
-    PROVIDERS_LIST = [:lyrics_wikia, :lyrics_mania, :song_lyrics, :azlyrics]
 
     def initialize(*args)
-      @providers = filter_providers(args)
+      @providers = Providers.filter_providers(args)
     end
 
     def selected_providers
       @providers
     end
 
+    Contract String, String => Or[Array, nil]
     def search(author, title)
-      song = Song.new(author, title)
-      perform_search(song)
-    end
-
-    Contract Lyrics::Song => Or[Array, nil]
-    def perform_search(song)
+      song = set_song(author, title)
       song_lyric = catch(:song_lyric) {
         @providers.each do |provider|
           klass = Providers.build_klass(provider)
@@ -34,12 +29,9 @@ module Lyrics
 
     private
 
-    def filter_providers(providers)
-      valid_providers = []
-      providers.each do |provider|
-        valid_providers << provider if PROVIDERS_LIST.include?(provider)
-      end
-      valid_providers.any? ? valid_providers : PROVIDERS_LIST
+    Contract String, String => Lyrics::Song
+    def set_song(author, title)
+      Song.new(author, title)
     end
 
     def perform_request(url)

data/spec/lyrics_finder/lyrics_finder_spec.rb

@@ -4,7 +4,7 @@ describe Lyrics::Finder do
       let(:finder) { Lyrics::Finder.new }
 
       it 'sets @providers to default PROVIDERS_LIST' do
-        expect(finder.selected_providers).to eq Lyrics::Finder::PROVIDERS_LIST
+        expect(finder.selected_providers).to eq Lyrics::Providers.providers_list
       end
     end
 
@@ -21,7 +21,7 @@ describe Lyrics::Finder do
         let(:finder) { Lyrics::Finder.new(:bad_songs, :invalid_songs) }
         
         it 'sets @providers to default PROVIDERS_LIST' do
-          expect(finder.selected_providers).to eq Lyrics::Finder::PROVIDERS_LIST
+          expect(finder.selected_providers).to eq Lyrics::Providers.providers_list
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lyrics_finder
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Daniel Romero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-30 00:00:00.000000000 Z
+date: 2014-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler