lydia 0.1.3 → 0.1.4

data/spec/delegator_spec.rb

@@ -6,26 +6,22 @@ extend Lydia::Delegator
 
 describe 'Delegator' do
   include Rack::Test::Methods
-  
+
   class TestDelegator
     extend Lydia::Delegator
-    
+
     get '/hello' do
       'Hello world!'
     end
   end
-  
+
   def app
     Lydia::Application.new
   end
-  
-  it 'Delegator initialize correctly' do
-    expect(1).to eq(1)
-  end
-  
+
   it 'Delegates to Application' do
     get '/hello'
     expect(last_response.status).to eq(200)
     expect(last_response.body).to eq('Hello world!')
   end
-end
+end

data/spec/filters_spec.rb

@@ -2,50 +2,49 @@ require 'spec_helper'
 require 'rack/test'
 require 'lydia/application'
 
-describe "Filters" do
+describe 'Filters' do
   include Rack::Test::Methods
 
-  class TestFilters < Lydia::Application        
-
+  class TestFilters < Lydia::Application
     before do
       @filter = 'before'
     end
-    
+
     after do
       @filter = 'after'
     end
-    
+
     get '/filter' do
       @filter
     end
-    
+
     redirect '/redirect', to: '/redirected'
-    
+
     get '/redirected' do
       'redirected'
     end
-    
+
     namespace '/namespace' do
       before do
         @filter_nested = 'before'
       end
-    
+
       after do
         @filter_nested = 'after'
       end
-      
+
       redirect '/redirect', to: '/redirected'
-      
+
       get '/redirected' do
         'redirected in namespace'
       end
-      
+
       get '/filter' do
         "#{@filter} #{@filter_nested}"
       end
     end
   end
-  
+
   def app
     TestFilters.new
   end
@@ -64,10 +63,10 @@ describe "Filters" do
         get '/namespace/filter'
         expect(last_response.status).to eq(200)
         expect(last_response.body).to eq('before before')
-      end    
+      end
     end
   end
-  
+
   context 'Redirect' do
     context 'Root' do
       it 'redirects' do
@@ -76,7 +75,7 @@ describe "Filters" do
         expect(last_response.body).to eq('redirected')
       end
     end
-    
+
     context 'Namespace' do
       it 'redirects' do
         get '/namespace/redirect'
@@ -85,5 +84,4 @@ describe "Filters" do
       end
     end
   end
-
-end
+end

data/spec/helpers_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 require 'rack/test'
 require 'lydia/application'
 
-describe "Helpers" do
+describe 'Helpers' do
   include Rack::Test::Methods
 
   class TestHelpers < Lydia::Application
@@ -10,24 +10,24 @@ describe "Helpers" do
       content_type 'application/json'
       'body'
     end
-    
+
     get '/redirect' do
       redirect '/new_url'
-    end  
-    
+    end
+
     get '/params' do
       params['key']
     end
-    
+
     get '/file' do
       send_file('test.png')
     end
   end
-  
+
   def app
     TestHelpers.new
   end
-  
+
   it 'responds to content_type' do
     get '/content_type'
     expect(last_response.status).to eq(200)
@@ -39,17 +39,17 @@ describe "Helpers" do
     get '/redirect'
     expect(last_response.status).to eq(302)
     expect(last_response.body).to eq('/new_url')
-  end       
-  
+  end
+
   it 'responds to params' do
-    get '/params', {key: 'value'}
+    get '/params', key: 'value'
     expect(last_response.status).to eq(200)
     expect(last_response.body).to eq('value')
   end
-  
+
   it 'sends a file' do
-    expect {
+    expect do
       get '/file'
-    }.to raise_error(NotImplementedError)
+    end.to raise_error(NotImplementedError)
   end
-end
+end

data/spec/middleware_spec.rb

@@ -4,7 +4,7 @@ require 'erb'
 require 'json'
 require 'lydia/application'
 
-describe "Middleware" do
+describe 'Middleware' do
   include Rack::Test::Methods
 
   class UpcaseMiddleware
@@ -13,24 +13,24 @@ describe "Middleware" do
     end
 
     def call(env)
-      status, headers, body  = @app.call(env)
-      upcased_body = body.map { |chunk| chunk.upcase }
+      status, headers, body = @app.call(env)
+      upcased_body = body.map(&:upcase)
       [status, headers, upcased_body]
     end
-  end  
-  
+  end
+
   class TestMiddleware < Lydia::Application
     use UpcaseMiddleware
-    
+
     get '/hello' do
       'Hello world!'
     end
   end
-  
+
   def app
     TestMiddleware.new
   end
-  
+
   context 'Middleware stack' do
     it 'is correctly handled' do
       get '/hello'
@@ -38,4 +38,4 @@ describe "Middleware" do
       expect(last_response.body).to eq('HELLO WORLD!')
     end
   end
-end
+end

data/spec/response_spec.rb

@@ -2,27 +2,27 @@ require 'spec_helper'
 require 'lydia/response'
 
 describe 'Response' do
-  let (:response) { Lydia::Response.new }
-  
-  context 'initialization' do    
+  let(:response) { Lydia::Response.new }
+
+  context 'initialization' do
     it 'is created' do
-      expect(response).to_not be_nil
+      expect(response).not_to be_nil
     end
-    
+
     it 'contains default content type' do
       expect(response.headers).to include('Content-Type' => 'text/html')
     end
   end
-  
+
   context 'build' do
     it 'responds to build' do
       expect(response).to respond_to(:build)
     end
-    
+
     it 'builds using a string (body)' do
       body = 'Hello world!'
       result = response.build(body)
-      expect(result).to_not be_nil
+      expect(result).not_to be_nil
       expect(result).to be_an(Array)
       expect(result[0]).to eq(200)
       expect(result[1]).to include('Content-Type' => 'text/html')
@@ -30,35 +30,35 @@ describe 'Response' do
       expect(result[2]).to be_an(Array)
       expect(result[2][0]).to eq(body)
     end
-    
+
     it 'builds using a fixnum (status)' do
       status = 204
       result = response.build(status)
-      expect(result).to_not be_nil
+      expect(result).not_to be_nil
       expect(result).to be_an(Array)
       expect(result[0]).to eq(204)
-      expect(result[1]).to_not include('Content-Type')
-      expect(result[1]).to_not include('Content-Length')
+      expect(result[1]).not_to include('Content-Type')
+      expect(result[1]).not_to include('Content-Length')
       expect(result[2]).to be_an(Array)
       expect(result[2][0]).to be_nil
     end
-    
+
     it 'builds using a hash (body)' do
-      body = {hello: 'world'}
+      body = { hello: 'world' }
       result = response.build(body)
-      expect(result).to_not be_nil
+      expect(result).not_to be_nil
       expect(result).to be_an(Array)
       expect(result[0]).to eq(200)
       expect(result[1]).to include('Content-Type' => 'application/json')
       expect(result[1]).to include('Content-Length' => body.to_json.length.to_s)
       expect(result[2]).to be_an(Array)
       expect(result[2][0]).to eq(body.to_json)
-    end    
-    
+    end
+
     it 'builds using an array of two (body is array)' do
       body = [201, ['Body']]
       result = response.build(body)
-      expect(result).to_not be_nil
+      expect(result).not_to be_nil
       expect(result).to be_an(Array)
       expect(result[0]).to eq(201)
       expect(result[1]).to include('Content-Type' => 'text/html')
@@ -66,23 +66,23 @@ describe 'Response' do
       expect(result[2]).to be_an(Array)
       expect(result[2][0]).to eq(body[1][0])
     end
-    
-    it 'builds using an array of two (body is noy an array)' do
+
+    it 'builds using an array of two (body is not an array)' do
       body = [201, 'Body']
       result = response.build(body)
-      expect(result).to_not be_nil
+      expect(result).not_to be_nil
       expect(result).to be_an(Array)
       expect(result[0]).to eq(201)
       expect(result[1]).to include('Content-Type' => 'text/html')
       expect(result[1]).to include('Content-Length' => body[1].length.to_s)
       expect(result[2]).to be_an(Array)
       expect(result[2][0]).to eq(body[1])
-    end    
-    
+    end
+
     it 'builds using an array of three' do
-      body = [201, {'Authentication' => '12345'}, 'Body']
+      body = [201, { 'Authentication' => '12345' }, 'Body']
       result = response.build(body)
-      expect(result).to_not be_nil
+      expect(result).not_to be_nil
       expect(result).to be_an(Array)
       expect(result[0]).to eq(201)
       expect(result[1]).to include('Content-Type' => 'text/html')
@@ -90,39 +90,37 @@ describe 'Response' do
       expect(result[1]).to include('Authentication' => '12345')
       expect(result[2]).to be_an(Array)
       expect(result[2][0]).to eq(body[2])
-    end   
-    
+    end
+
     class Stream
       def each
-        10.times { |i| yield "#{i}" }
+        10.times { |i| yield i.to_s }
       end
     end
 
     context 'Stream' do
-      
       it 'builds a valid stream object' do
         stream = ''
-        Stream.new.each{ |i| stream += i }
+        Stream.new.each { |i| stream += i }
         expect(stream).to eq('0123456789')
       end
-    
+
       it 'builds using an object that responds to :each' do
         result = response.build(Stream.new)
-        expect(result).to_not be_nil
+        expect(result).not_to be_nil
         expect(result).to be_an(Array)
         expect(result[0]).to eq(200)
         expect(result[1]).to include('Content-Type' => 'text/html')
         expect(result[1]).to include('Content-Length')
         expect(result[2]).to be_an(Array)
-        expect(result[2][0]).to_not be_nil
+        expect(result[2][0]).not_to be_nil
       end
-    
     end
-    
+
     it 'returns ArgumentError if object is not allowed' do
-      expect {
+      expect do
         response.build(nil)
-      }.to raise_error(ArgumentError)
+      end.to raise_error(ArgumentError)
     end
   end
-end
+end

data/spec/router_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 require 'rack/test'
 require 'lydia/router'
 
-describe "Router" do
+describe 'Router' do
   include Rack::Test::Methods
 
   class TestRouter < Lydia::Router
@@ -15,16 +15,16 @@ describe "Router" do
     end
 
     get '/500' do
-      raise StandardError.new('Error!')
+      raise StandardError, 'Error!'
     end
 
-    head '/request' do get_response('head'); end
-    get '/request' do get_response('get'); end
-    patch '/request' do get_response('patch'); end
-    put '/request' do get_response('put'); end
-    post '/request' do get_response('post'); end
-    delete '/request' do get_response('delete'); end
-    options '/request' do get_response('options'); end
+    head('/request') { get_response('head') }
+    get('/request') { get_response('get') }
+    patch('/request') { get_response('patch') }
+    put('/request') { get_response('put') }
+    post('/request') { get_response('post') }
+    delete('/request') { get_response('delete') }
+    options('/request') { get_response('options') }
 
     namespace '/namespace' do
       get '/hello' do
@@ -89,7 +89,7 @@ describe "Router" do
     end
 
     def get_response(body, status = 200)
-      [status, { 'Content-Type' => 'text/html', 'Content-Length'=> body.length.to_s }, [body]]
+      [status, { 'Content-Type' => 'text/html', 'Content-Length' => body.length.to_s }, [body]]
     end
   end
 
@@ -115,11 +115,12 @@ describe "Router" do
   end
 
   context 'Response' do
-    it "returns a valid response" do
+    it 'returns a valid response' do
       get '/'
-      expect(last_response).to_not be_nil
+      expect(last_response).not_to be_nil
       expect(last_response.status).to eq(200)
-      expect(last_response.headers.to_hash).to eq({'Content-Type' => 'text/html', 'Content-Length' => '21'})
+      expect(last_response.headers.to_hash).to eq('Content-Type' => 'text/html',
+                                                  'Content-Length' => '21')
       expect(last_response.body).to eq('<H1>Hello world!</H1>')
     end
   end
@@ -169,7 +170,6 @@ describe "Router" do
   end
 
   context 'Routing' do
-
     context 'Namespace' do
       it 'GET /namespace/hello' do
         get '/namespace/hello'
@@ -248,13 +248,13 @@ describe "Router" do
       it 'GET /index.json' do
         get '/index.json'
         expect(last_response.status).to eq(200)
-        expect(last_response.body).to eq('json')        
+        expect(last_response.body).to eq('json')
       end
     end
 
     context 'Query string params' do
       it 'GET /querystring_params' do
-        get '/querystring_params', { name: 'bob' }
+        get '/querystring_params', name: 'bob'
         expect(last_response.status).to eq(200)
         expect(last_response.body).to eq('bob')
       end
@@ -262,12 +262,12 @@ describe "Router" do
 
     context 'Route not valid' do
       it 'returns ArgumentError' do
-        expect {
+        expect do
           class WrongRoute < Lydia::Router
             get Object do
             end
           end
-        }.to raise_error(ArgumentError)
+        end.to raise_error(ArgumentError)
       end
     end
   end
@@ -308,5 +308,4 @@ describe "Router" do
       expect(last_response.status).to eq(200)
     end
   end
-
 end