lx_data_validation 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e194bf49037ed8424cf3dcf33f3fabf5cb52760
-  data.tar.gz: 0647669d8cf15cb8f21e1c817c149ce4925f4225
+  metadata.gz: d375db47b73f839c7657154f711f7b91f008af0f
+  data.tar.gz: 2bc442e90cc560b35a4e8b6489da9c0fa035443a
 SHA512:
-  metadata.gz: b165e44eea570728fb66fd5156eaf4136857ca877d6515279e90543dc70135935b55782231bd37cdab2c67b2da82453ac576cc3d791302d2f0974717e39e88e2
-  data.tar.gz: 7671e8e28c54168f2a659b661f118a4900be3b4208049b7af391d94453ee776e7542eb7825a7d2157c91e874c5688fccd7e1a994c2ceb30154ada490ab8389ae
+  metadata.gz: d5114d8ee2f53f3c4f6a8b986703326b704fb72c89d972f59006d9464242479c2141558e5a935039dfda67bc77f13202d7739e5ed2605f6a6727fd11b9eb2905
+  data.tar.gz: 57de47bcd55eff91184b7d00e6c5a9ae13ba3d9dd8a21cb880308af353a160d7cfba0e723f0059f9ddbf0292c076fddc489630470127934bbb7fd872eb32a155

data/lib/data_validation/comparison/comparison_base.rb

@@ -52,7 +52,7 @@ module DataValidation
             end
 
 
-            unless (team_value.is_a?(String) && team_value.include?(item[i])) ||
+            unless (team_value.is_a?(String) && team_value.include?(item[i].strip)) ||
               (team_value.is_a?(Float) && team_value == item[i].to_f) ||
               (team_value.is_a?(Integer) && team_value == item[i].to_i)
 
@@ -68,9 +68,9 @@ module DataValidation
       def compare_conf_standings(api_data, data_access)
         puts 'Start to compare conf ranking tables'
         conf_standing_data = data_access.conf_standing_data
+
         conf_standing_data.each do |standing|
           full_conf = ''
-          # puts standing.to_s
           standing.each_with_index do |record, i|
             if i == 0
               state = record[0]

data/lib/data_validation/comparison/ranking_table_mw_poll_comparison.rb

@@ -9,7 +9,7 @@ module DataValidation
       end
 
       def field_array
-        ['rank', 'teamName', %w|record wins|, %w|record losses|, %w|record ties|, 'pollPoint', 'pollFirst', 'lastWeek']
+        ['rank', 'teamName', %w|record wins|, %w|record losses|, %w|record ties|, 'pollPoint', 'pollFirst']
       end
 
       def empty_field

data/lib/data_validation/comparison/ranking_table_mw_pr_comparison.rb

@@ -32,10 +32,8 @@ module DataValidation
         ## compare first table
         web_data.each_with_index do |item, index|
           team = api_data['results']['results']['teams'][index]
-
           i = 0
           field_array.each do |filed_name|
-
             if filed_name.is_a? String
               team_value = team[filed_name]
             elsif filed_name.is_a? Array

data/lib/data_validation/data_access.rb

@@ -27,7 +27,15 @@ module DataValidation
       index = 0
       doc.search('div.cs1 div.cs1').text.lines.map do |line|
         if /^\s*(?<rank>\d+)\s+(?<rest>.*)/ =~ line
-          data_array = ([rank] << team_names[index]) + rest.split(' ')
+          data_array = ([rank] << team_names[index])
+          rest_parts = rest.split(' ')
+          rest_parts.each do |item|
+            if item.match /^\d+-/ # win-loss-tie value
+              data_array += item.split('-')
+            else
+              data_array << item
+            end
+          end
           index += 1
           data_array
         end
@@ -59,25 +67,21 @@ module DataValidation
       conf_standing_record = []
       lines = doc.search('div.laxcs1, div.laxcss').text.lines
 
-      conf_data_index = 0
       lines.each_with_index do |line, index|
-        if line.match /^\s[A-Z]/
+        if /^\s(?<conf_full_name>[A-Z].*)Conference/ =~ line || /^\s(?<conf_full_name>[A-Z].*)Overall/ =~ line
           if conf_standing_record.length > 0 ## it's a new conf standing table
             @conf_standing_data << conf_standing_record
             conf_standing_record = []
           end
 
-          conf = conf_data[conf_data_index]
-
-          if conf.nil?
+          conf = get_conf(conf_full_name, conf_data)
+          if conf.nil? ## last standing table has no record, the response of "getConferences" api will not include this conference
             puts 'No independent conf data'
             @conf_standing_data << conf_standing_record
             break
           end
 
           conf_standing_record << [conf['state'], conf['teamClass'], conf['conference']]
-
-          conf_data_index += 1
         elsif /^\s*\d+\s+/.match line
           conf_standing_record << line.split(' ')
         end
@@ -88,7 +92,10 @@ module DataValidation
       end
     end
 
-
+    def get_conf(conf_full_name, conf_data)
+      selected = conf_data.select { |conf| conf_full_name.include?("#{conf['state']}") && conf_full_name.include?("#{conf['teamClass']}") && conf_full_name.include?("#{conf['conference']}")}
+      selected.first if selected && selected.size > 0
+    end
 
     def get_response_from_mobile_api
       HTTParty.post(api_url, headers: {'Content-Type' => 'application/json'}, body: api_body)

data/lib/data_validation/version.rb

@@ -1,3 +1,3 @@
 module DataValidation
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lx_data_validation
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Roger Tong
@@ -93,7 +93,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.6.7
 signing_key: 
 specification_version: 4
 summary: Data validation for LaxPower