lutaml 0.10.13 → 0.10.15

data/lib/lutaml/uml_repository/static_site/serializers/package_tree_builder.rb

@@ -25,30 +25,26 @@ module Lutaml
             if root_packages.size == 1
               build_tree_node(root_packages.first)
             else
-              Models::SpaPackageTreeNode.new(
-                id: "root",
-                name: "Model",
-                path: "",
-                class_count: 0,
-                children: root_packages.map { |pkg| build_tree_node(pkg) },
-              )
+              build_virtual_root(root_packages)
             end
           end
 
           private
 
+          def build_virtual_root(root_packages)
+            Models::SpaPackageTreeNode.new(
+              id: "root",
+              name: "Model",
+              path: "",
+              class_count: 0,
+              children: root_packages.map { |pkg| build_tree_node(pkg) },
+            )
+          end
+
           def build_tree_node(package)
             pkg_id = @id_generator.package_id(package)
-
-            sorted_children = (package.packages || []).sort_by do |p|
-              p.name || ""
-            end
-            sorted_classes = (package.classes || [])
-              .reject { |c| c.name.nil? || c.name.empty? }
-              .sort_by(&:name)
-
-            child_nodes = sorted_children.map { |child| build_tree_node(child) }
-
+            child_nodes = build_child_nodes(package)
+            sorted_classes = filter_valid_classes(package.classes || [])
             total_class_count = sorted_classes.size + child_nodes.sum(&:class_count)
 
             Models::SpaPackageTreeNode.new(
@@ -57,17 +53,35 @@ module Lutaml
               path: package_path_for(package),
               stereotypes: normalize_stereotypes(package.stereotype),
               class_count: total_class_count,
-              classes: sorted_classes.map do |c|
-                Models::SpaTreeClassRef.new(
-                  id: @id_generator.class_id(c),
-                  name: c.name,
-                  stereotypes: normalize_stereotypes(c.stereotype),
-                )
-              end,
+              classes: build_class_refs(sorted_classes),
               children: child_nodes,
             )
           end
 
+          def build_child_nodes(package)
+            sort_by_name(package.packages || []).map do |child|
+              build_tree_node(child)
+            end
+          end
+
+          def sort_by_name(items)
+            items.sort_by { |p| p.name || "" }
+          end
+
+          def filter_valid_classes(classes)
+            classes.reject { |c| c.name.nil? || c.name.empty? }.sort_by(&:name)
+          end
+
+          def build_class_refs(classes)
+            classes.map do |c|
+              Models::SpaTreeClassRef.new(
+                id: @id_generator.class_id(c),
+                name: c.name,
+                stereotypes: normalize_stereotypes(c.stereotype),
+              )
+            end
+          end
+
           def package_path_for(package)
             return package.name unless package.namespace
             return package.name unless package.namespace.is_a?(Lutaml::Uml::Package)

data/lib/lutaml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Lutaml
-  VERSION = "0.10.13"
+  VERSION = "0.10.15"
 end

data/lib/lutaml/xmi/liquid_drops/klass_drop.rb

@@ -4,7 +4,7 @@ module Lutaml
   module Xmi
     module LiquidDrops
       class KlassDrop < Liquid::Drop
-        def initialize(model, guidance = nil, options = {}) # rubocop:disable Lint/MissingSuper,Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/MethodLength,Metrics/PerceivedComplexity
+        def initialize(model, guidance = nil, options = {}) # rubocop:disable Lint/MissingSuper
           @model = model
           @guidance = guidance
           @options = options
@@ -12,23 +12,8 @@ module Lutaml
           @xmi_root_model = options[:xmi_root_model]
           @id_name_mapping = options[:id_name_mapping]
 
-          if @xmi_root_model
-            @clients_dependencies = @lookup.select_dependencies_by_supplier(@model.xmi_id)
-            @suppliers_dependencies = @lookup.select_dependencies_by_client(@model.xmi_id)
-
-            matched_element = @lookup.find_matched_element(@model.xmi_id)
-            @inheritance_ids = matched_element&.links&.map do |link|
-              link.generalization.select do |gen|
-                gen.end == @model.xmi_id
-              end.map(&:id)
-            end&.flatten&.compact || []
-          end
-
-          if guidance
-            @klass_guidance = guidance["classes"].find do |klass|
-              klass["name"] == name || klass["name"] == absolute_path
-            end
-          end
+          init_xmi_dependencies if @xmi_root_model
+          init_guidance(guidance) if guidance
         end
 
         def xmi_id
@@ -53,6 +38,37 @@ module Lutaml
           absolute_path_arr.reverse.join("::")
         end
 
+        private
+
+        def init_xmi_dependencies
+          @clients_dependencies = @lookup.select_dependencies_by_supplier(@model.xmi_id)
+          @suppliers_dependencies = @lookup.select_dependencies_by_client(@model.xmi_id)
+
+          matched_element = @lookup.find_matched_element(@model.xmi_id)
+          @inheritance_ids = extract_inheritance_ids(matched_element)
+        end
+
+        def init_guidance(guidance)
+          @klass_guidance = guidance["classes"].find do |klass|
+            klass["name"] == name || klass["name"] == absolute_path
+          end
+        end
+
+        def extract_inheritance_ids(matched_element)
+          return [] unless matched_element
+
+          links = matched_element.links
+          return [] unless links
+
+          links.flat_map do |link|
+            link.generalization
+              .select { |gen| gen.end == @model.xmi_id }
+              .map(&:id)
+          end.compact
+        end
+
+        public
+
         def package
           nested_pkg = @lookup.find_packaged_element_by_id(@model.xmi_id)
           return unless nested_pkg

data/lib/lutaml/xmi/parsers/xmi_connector.rb

@@ -131,26 +131,32 @@ module Lutaml
         # @param connector_type [String]
         # @return [Array<Hash, String>]
         # @note xpath %(//connector[@xmi:idref="#{link_id}"]/#{connector_type})
-        def fetch_assoc_connector(link_id, connector_type) # rubocop:disable Metrics/AbcSize,Metrics/MethodLength,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
+        def fetch_assoc_connector(link_id, connector_type)
           connector = fetch_connector(link_id)
           return [nil, nil] unless connector
 
           assoc_connector = connector.public_send(connector_type.to_sym)
+          return [nil, nil] unless assoc_connector
 
-          if assoc_connector
-            assoc_connector_type = assoc_connector.type
-            if assoc_connector_type&.multiplicity
-              cardinality = assoc_connector_type.multiplicity.split("..")
-              cardinality.unshift("1") if cardinality.length == 1
-              min, max = cardinality
-            end
-
-            assoc_connector_role = assoc_connector.role
-            attribute_name = assoc_connector.model.name if assoc_connector_role
-            cardinality = cardinality_min_max_value(min, max)
+          cardinality = extract_cardinality(assoc_connector)
+          attribute_name = extract_attribute_name(assoc_connector)
+          [cardinality, attribute_name]
+        end
+
+        def extract_cardinality(assoc_connector)
+          assoc_connector_type = assoc_connector.type
+          min = nil
+          max = nil
+          if assoc_connector_type&.multiplicity
+            cardinality = assoc_connector_type.multiplicity.split("..")
+            cardinality.unshift("1") if cardinality.length == 1
+            min, max = cardinality
           end
+          cardinality_min_max_value(min, max)
+        end
 
-          [cardinality, attribute_name]
+        def extract_attribute_name(assoc_connector)
+          assoc_connector.role ? assoc_connector.model.name : nil
         end
 
         # @param owner_xmi_id [String]
@@ -202,16 +208,22 @@ module Lutaml
         # Lazy-built hash index for O(1) connector lookups
         # @return [Hash] Mapping of [direction, idref] => connector
         def connector_lookup
-          @connector_lookup ||= begin
-            lookup = {}
-            connectors = @xmi_root_model.extension&.connectors&.connector || []
-            connectors.each do |con|
-              %i[source target].each do |dir|
-                idref = con.public_send(dir)&.idref
-                lookup[[dir, idref]] = con if idref
-              end
-            end
-            lookup
+          @connector_lookup ||= build_connector_lookup
+        end
+
+        def build_connector_lookup
+          lookup = {}
+          connectors = @xmi_root_model.extension&.connectors&.connector || []
+          connectors.each do |con|
+            index_connector_directions(con, lookup)
+          end
+          lookup
+        end
+
+        def index_connector_directions(con, lookup)
+          %i[source target].each do |dir|
+            idref = con.public_send(dir)&.idref
+            lookup[[dir, idref]] = con if idref
           end
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lutaml
 version: !ruby/object:Gem::Version
-  version: 0.10.13
+  version: 0.10.15
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-05-12 00:00:00.000000000 Z
+date: 2026-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: expressir
@@ -321,15 +321,8 @@ files:
 - Makefile
 - README.adoc
 - Rakefile
-- TODO.cleanups/01-resolve-production-todos.md
-- TODO.cleanups/02-reduce-metrics-offenses.md
-- TODO.cleanups/03-reduce-rspec-multiple-expectations.md
-- TODO.cleanups/04-reduce-rspec-example-length.md
 - TODO.cleanups/05-replace-marshal-load.md
 - TODO.cleanups/06-replace-eval-in-tests.md
-- TODO.cleanups/07-fix-lint-offenses.md
-- TODO.cleanups/08-reduce-memoized-helpers-and-nesting.md
-- TODO.cleanups/09-reduce-verified-doubles-and-rspec-style.md
 - TODO.cleanups/10-split-large-files.md
 - bin/console
 - bin/folder_yaml2lutaml.sh

data/TODO.cleanups/01-resolve-production-todos.md

@@ -1,65 +0,0 @@
-# 01 — Resolve 7 production TODOs
-
-## Problem
-
-Seven `TODO`/`FIXME` comments in `lib/` represent incomplete features, missing validation, or known tech debt. They risk silent data loss or incorrect behavior.
-
-## Items
-
-### 1. `lib/lutaml/qea/factory/diagram_transformer.rb:28`
-```ruby
-# TODO: Fix diagram_type assignment -
-# lutaml-model compatibility issue
-# diagram.diagram_type = ea_diagram.diagram_type
-```
-**Impact**: Diagram type is silently dropped during QEA→UML transformation. The `diagram_type` attribute exists on `Lutaml::Uml::Diagram` but is never populated from QEA.
-**Fix**: Investigate lutaml-model compatibility (likely a type mismatch or missing attribute). Either fix the assignment or document why it's intentionally omitted.
-
-### 2. `lib/lutaml/qea/factory/package_transformer.rb:32`
-```ruby
-# TODO: Fix tagged_values assignment - temporarily commented out
-# pkg.tagged_values = load_tagged_values(ea_package.ea_guid)
-```
-**Impact**: Tagged values (metadata/annotations) are silently dropped from packages during QEA→UML transformation. This causes XMI/QEA equivalence mismatches.
-**Fix**: Check if `load_tagged_values` returns correct type. Likely needs the same serialization pattern used in class_transformer.
-
-### 3. `lib/lutaml/formatter/graphviz.rb:56`
-```ruby
-# TODO: set rankdir
-# @graph['rankdir'] = 'BT'
-```
-**Impact**: Graph direction can't be configured. The value is commented out.
-**Fix**: Either expose as configurable option or remove dead code.
-
-### 4. `lib/lutaml/uml/node/class_node.rb:19`
-```ruby
-@modifier = value.to_s # TODO: Validate?
-```
-**Impact**: No validation on modifier values — invalid strings accepted silently.
-**Fix**: Add enum validation for known modifiers (`public`, `private`, `protected`, etc.) or remove the TODO if validation isn't needed.
-
-### 5. `lib/lutaml/uml/node/attribute.rb:27`
-```ruby
-@access = value.to_s # TODO: Validate?
-```
-**Impact**: Same as #4 but for access modifiers on attributes.
-**Fix**: Same as #4 — validate or remove TODO.
-
-### 6. `lib/lutaml/uml/node/class_node.rb:24`
-```ruby
-type = member.to_a[0][0] # TODO: This is dumb
-```
-**Impact**: Fragile parsing of member data structure. The `TODO: This is dumb` indicates the developer knew it was wrong but shipped it.
-**Fix**: Replace with structured member parsing using named access.
-
-### 7. `lib/lutaml/uml/has_members.rb:8`
-```ruby
-# TODO: move to Parslet::Transform
-```
-**Impact**: Member type logic is in the model instead of the parser layer.
-**Fix**: Evaluate whether moving to Parslet::Transform is still desirable. If not, remove the TODO.
-
-## Verification
-
-- `grep -rn "TODO\|FIXME" lib/ --include="*.rb"` should return 0 results (or only intentional ones)
-- Full test suite passes: `bundle exec rspec`

data/TODO.cleanups/02-reduce-metrics-offenses.md

@@ -1,37 +0,0 @@
-# 02 — Reduce Metrics/AbcSize and method complexity (212 + 130 + 11 + 11 + 8 offenses)
-
-## Problem
-
-5 Metrics cops account for **372 offenses** across production code. The worst offenders are large methods that do too much, making them hard to test, debug, and maintain.
-
-## Top targets by file
-
-| File | AbcSize | MethodLength | Cyclomatic | Perceived | Lines |
-|------|---------|-------------|------------|-----------|-------|
-| `lib/lutaml/xmi/parsers/xmi_base.rb` | Yes | — | Yes | Yes | 1047 |
-| `lib/lutaml/converter/xmi_to_uml.rb` | Yes | — | Yes | Yes | 474 |
-| `lib/lutaml/uml_repository/index_builder.rb` | Yes | — | Yes | Yes | 480 |
-| `lib/lutaml/qea/database.rb` | Yes | — | Yes | Yes | 477 |
-| `lib/lutaml/uml_repository/queries/class_query.rb` | Yes | — | Yes | Yes | 151 |
-| `lib/lutaml/uml_repository/queries/inheritance_query.rb` | Yes | — | Yes | Yes | — |
-| `lib/lutaml/model_transformations/parsers/base_parser.rb` | Yes | — | — | — | — |
-| `lib/lutaml/qea/factory/enum_transformer.rb` | — | — | Yes | Yes | — |
-| `lib/lutaml/uml_repository/queries/search_query.rb` | — | — | Yes | — | — |
-| `lib/lutaml/cli/tree_view_formatter.rb` | — | — | Yes | — | — |
-
-## Approach
-
-Extract helper methods from god methods. Common patterns:
-
-1. **xmi_base.rb** — The 1047-line file has massive parsing methods. Extract per-element-type parsing into separate methods (already partially done).
-2. **converter/xmi_to_uml.rb** — The `build_*` methods handle too many concerns. Extract mapping logic per element type.
-3. **index_builder.rb** — The single-pass `build_all` is better than before but individual index builders can be further split.
-4. **database.rb** — The `build_lookup_indexes` method builds all indexes at once; split into per-index methods.
-
-**Do NOT**: Increase Max thresholds in `.rubocop_todo.yml`. Instead, refactor to reduce actual complexity.
-
-## Verification
-
-- `bundle exec rubocop --only Metrics` shows reduced offense counts
-- `bundle exec rspec` passes
-- No functional changes — pure refactoring

data/TODO.cleanups/03-reduce-rspec-multiple-expectations.md

@@ -1,54 +0,0 @@
-# 03 — Reduce RSpec/MultipleExpectations (946 offenses)
-
-## Problem
-
-946 test examples have more than 1 expectation. This is the single largest rubocop offense. It makes tests brittle (failures stop at the first failed expectation, masking other issues) and harder to understand what's being verified.
-
-## Approach
-
-Split multi-expectation examples into focused single-expectation examples:
-
-```ruby
-# BEFORE:
-it "validates the widget" do
-  expect(widget.name).to eq("Test")
-  expect(widget.size).to eq(10)
-  expect(widget.active).to be true
-end
-
-# AFTER:
-it { expect(widget.name).to eq("Test") }
-it { expect(widget.size).to eq(10) }
-it { expect(widget.active).to be true }
-```
-
-For cases where multiple expectations are genuinely related (e.g., checking a hash structure), use compound matchers:
-
-```ruby
-expect(result).to include("name" => "Test", "size" => 10, "active" => true)
-```
-
-Or aggregate failures with `aggregate_failures` when the expectations are about the same concern:
-
-```ruby
-it "has correct address fields" do
-  aggregate_failures do
-    expect(address.street).to eq("Main St")
-    expect(address.city).to eq("London")
-  end
-end
-```
-
-## Priority files (highest offense density)
-
-Run `bundle exec rubocop --only RSpec/MultipleExpectations` to see the full list. Focus on:
-1. `spec/lutaml/qea/verification/comprehensive_equivalence_spec.rb`
-2. `spec/lutaml/qea/verification/equivalence_integration_spec.rb`
-3. `spec/lutaml/cli/` command specs
-4. `spec/lutaml/uml_repository/` specs
-
-## Verification
-
-- `bundle exec rubocop --only RSpec/MultipleExpectations` shows reduced count
-- `bundle exec rspec` passes
-- Reduce Max from 26 toward 5 (default)

data/TODO.cleanups/04-reduce-rspec-example-length.md

@@ -1,45 +0,0 @@
-# 04 — Reduce RSpec/ExampleLength (657 offenses)
-
-## Problem
-
-657 test examples exceed the default 5-line limit (current Max: 108). Long examples are hard to read, hide intent, and often combine setup + action + multiple assertions.
-
-## Approach
-
-Common patterns to fix:
-
-1. **Extract test data into `let`/`let!`** — Move setup out of `it` blocks:
-```ruby
-# BEFORE:
-it "parses correctly" do
-  result = described_class.parse(fixture_content)
-  expect(result.name).to eq("Test")
-end
-
-# AFTER:
-let(:result) { described_class.parse(fixture_content) }
-it { expect(result.name).to eq("Test") }
-```
-
-2. **Extract shared setup into `before` blocks** — If multiple examples repeat the same setup.
-
-3. **Use subject with one-liner syntax** — Where the subject is the tested value:
-```ruby
-subject { described_class.new(attrs) }
-it { is_expected.to be_valid }
-```
-
-4. **Extract helper methods** — Complex assertions that span many lines can become custom matchers or helper methods in `spec/support/`.
-
-## Priority
-
-Focus on the longest examples first — run `bundle exec rubocop --only RSpec/ExampleLength` and sort by severity. Files with the worst examples:
-- `spec/lutaml/qea/` verification and factory specs
-- `spec/lutaml/uml_repository/` static site specs
-- `spec/lutaml/cli/` command specs
-
-## Verification
-
-- `bundle exec rubocop --only RSpec/ExampleLength` shows reduced count
-- Reduce Max from 108 toward 10
-- `bundle exec rspec` passes

data/TODO.cleanups/07-fix-lint-offenses.md

@@ -1,74 +0,0 @@
-# 07 — Fix Lint offenses (15 + 8 + 4 + 3 + 4 + 1 + 1 = 36 offenses)
-
-## Problem
-
-Lint cops catch real bugs and code quality issues. 36 offenses across 7 Lint cops.
-
-## Items
-
-### 1. Lint/DuplicateBranch (8 offenses)
-Identical code in different `case`/`if` branches — likely copy-paste bugs or missing differentiation.
-```
-lib/lutaml/cli/element_identifier.rb
-lib/lutaml/cli/uml/verify_command.rb
-lib/lutaml/qea/factory/base_transformer.rb
-lib/lutaml/qea/models/ea_datatype.rb
-lib/lutaml/qea/validation/validation_engine.rb
-lib/lutaml/uml_repository/queries/package_query.rb
-lib/lutaml/uml_repository/static_site/configuration.rb
-lib/lutaml/uml_repository/static_site/search_index_builder.rb
-```
-**Fix**: Merge duplicate branches or differentiate them if they should do different things.
-
-### 2. Lint/IneffectiveAccessModifier (4 offenses)
-`private`/`protected` used inside a `class << self` block — doesn't actually restrict access.
-```
-lib/lutaml/uml_repository/repository_enhanced.rb
-```
-**Fix**: Move methods outside the singleton class or use `private_class_method`.
-
-### 3. Lint/ConstantDefinitionInBlock (15 offenses)
-Constants defined inside `it`/`before` blocks leak and can cause test pollution.
-```
-spec/lutaml/model_transformations/format_registry_spec.rb
-spec/lutaml/model_transformations/parsers/base_parser_spec.rb
-spec/lutaml/model_transformations/transformation_engine_spec.rb
-spec/lutaml/model_transformations_spec.rb
-spec/lutaml/uml_repository/presenters/presenter_factory_spec.rb
-```
-**Fix**: Extract to top-level constants, use `stub_const`, or define in a shared context.
-
-### 4. Lint/EmptyConditionalBody (3 offenses)
-`if`/`unless` with empty body — likely incomplete logic.
-```
-spec/integration/qea_xmi_equivalency_spec.rb
-spec/lutaml/qea/verification/equivalence_integration_spec.rb
-```
-**Fix**: Add the missing body or refactor to use a guard clause.
-
-### 5. Lint/EmptyBlock (4 offenses)
-Empty blocks passed to methods — likely stub placeholders.
-```
-spec/lutaml/qea/integration/tagged_values_integration_spec.rb
-spec/lutaml/qea/services/database_loader_spec.rb
-spec/lutaml/uml_repository/package_exporter_spec.rb
-spec/lutaml/uml_repository/repository_spec.rb
-```
-**Fix**: Remove empty blocks or add `{ }` style comment if intentional.
-
-### 6. Lint/BinaryOperatorWithIdenticalOperands (1 offense)
-```ruby
-# spec/lutaml/qea/lookup_tables_spec.rb
-```
-**Fix**: Likely a test typo — check if both operands should be the same.
-
-### 7. Lint/MissingSuper (1 offense)
-```ruby
-# lib/lutaml/uml_repository/lazy_repository.rb
-```
-**Fix**: Add `super` call or document why it's intentionally omitted.
-
-## Verification
-
-- `bundle exec rubocop --only Lint` shows 0 offenses
-- `bundle exec rspec` passes

data/TODO.cleanups/08-reduce-memoized-helpers-and-nesting.md

@@ -1,43 +0,0 @@
-# 08 — Reduce RSpec/MultipleMemoizedHelpers (130) and RSpec/NestedGroups (29)
-
-## Problem
-
-130 examples exceed memoized helper limits (Max: 11) and 29 examples have excessive nesting (Max: 5). Both indicate test organization issues.
-
-## RSpec/MultipleMemoizedHelpers (130)
-
-Too many `let`, `let!`, `subject` declarations make test setup hard to follow. Each helper adds cognitive load.
-
-### Approach
-1. **Group-related helpers into factory methods** — Instead of 10 separate `let` declarations, use one factory:
-```ruby
-# Instead of:
-let(:name) { "Test" }
-let(:age) { 30 }
-let(:address) { Address.new(city: "London") }
-let(:person) { Person.new(name: name, age: age, address: address) }
-
-# Use:
-let(:person) { build(:person) }  # via FactoryBot or test factory
-```
-
-2. **Use `subject!` instead of separate `let` + action** — Combine setup and action.
-
-3. **Extract shared contexts** — Move common setup into `shared_context` blocks.
-
-### Priority files
-These are the worst offenders — check with `bundle exec rubocop --only RSpec/MultipleMemoizedHelpers`.
-
-## RSpec/NestedGroups (29)
-
-Deeply nested `describe`/`context` blocks (5+ levels) make tests hard to scan.
-
-### Approach
-1. **Flatten by using more descriptive top-level descriptions** — Instead of 3 levels of nesting, use a single `describe` with a descriptive name.
-2. **Extract nested contexts into separate `describe` blocks** — Move `context "when X"` / `context "and Y"` into `context "when X and Y"`.
-3. **Use shared examples** — Repeated nested structures can become shared examples.
-
-## Verification
-
-- `bundle exec rubocop --only RSpec/MultipleMemoizedHelpers,RSpec/NestedGroups` shows reduced counts
-- `bundle exec rspec` passes

data/TODO.cleanups/09-reduce-verified-doubles-and-rspec-style.md

@@ -1,57 +0,0 @@
-# 09 — Reduce RSpec/VerifiedDoubles (212) and other RSpec style offenses
-
-## Problem
-
-212 test doubles don't verify their methods exist against real classes. Other RSpec style issues total ~130 additional offenses.
-
-## RSpec/VerifiedDoubles (212 offenses)
-
-Currently disabled entirely (`Enabled: false`). Every mock/stub in the test suite uses unverified doubles:
-
-```ruby
-# CURRENT (unverified):
-let(:database) { instance_double("Database") }
-allow(database).to receive(:find_object).with(1).and_return(obj)
-
-# SHOULD BE (verified):
-let(:database) { instance_double(Lutaml::Qea::Database) }
-# Now rubocop verifies `find_object` is a real method
-```
-
-### Approach
-1. Re-enable the cop in `.rubocop_todo.yml` but with a high initial Max
-2. Fix in batches per directory:
-   - `spec/lutaml/qea/` (highest density)
-   - `spec/lutaml/uml_repository/`
-   - `spec/lutaml/cli/`
-   - rest
-3. Replace `double(...)` with `instance_double(RealClass, ...)` or `class_double(RealClass, ...)`
-4. Remove any stubbed methods that don't exist on the real class (they were wrong)
-
-### Risk
-Fixing verified doubles may expose test/implementation drift where tests mock methods that no longer exist. This is valuable — it means the tests were providing false confidence.
-
-## Other RSpec style offenses to fix in same pass
-
-| Cop | Count | Fix |
-|-----|-------|-----|
-| RSpec/ContextWording | 25 | Prefix with "when"/"with"/"without" |
-| RSpec/ExpectOutput | 90 | Use `expect { }.to output().to_stdout` |
-| RSpec/InstanceVariable | 48 | Replace `@var` with `let` (except `before(:all)` blocks) |
-| RSpec/RepeatedExample | 16 | Remove or differentiate duplicate test cases |
-| RSpec/LeakyConstantDeclaration | 15 | Use `stub_const` instead of defining constants in tests |
-| RSpec/MessageSpies | 11 | Use `have_received` instead of `receive` with `allow` |
-| RSpec/UnspecifiedException | 6 | Specify exception class in `expect { }.to raise_error(SomeError)` |
-| RSpec/SpecFilePathFormat | 6 | Rename spec files to match their described class |
-| RSpec/IndexedLet | 5 | Rename `thing1`, `thing2` to descriptive names |
-| RSpec/RepeatedExampleGroupDescription | 2 | Rename duplicate describe/context descriptions |
-| RSpec/ExpectActual | 7 | Move expectations out of `let`/`subject` |
-| RSpec/NoExpectationExample | 2 | Add expectations or use `pending` |
-| RSpec/ExpectInLet | 1 | Move expectation out of `let` |
-| RSpec/LeakyLocalVariable | 1 | Use `let` instead of local assignment |
-| RSpec/BeforeAfterAll | 1 | Evaluate if `before(:all)` can be `before(:each)` |
-
-## Verification
-
-- `bundle exec rubocop --only RSpec` shows significantly reduced count
-- `bundle exec rspec` passes