lutaml-model 0.8.143 → 0.8.145

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27c27a6e43a54c69e89e08cdeb8f749992155bc6ea072d5ccb1ba9867de9fc92
-  data.tar.gz: aab282e0b42b4a811529b58ab6b2dd5e8ab40287498802683c5283cfc6b55bdc
+  metadata.gz: 1d4a991baea8734712513f2d1ffb0025d0a5867f174a40b32bee58b1be5017c5
+  data.tar.gz: f1713d5b0ef5024da66ee23f8251604da86fd3f8d7035e7f64118bf080ea9128
 SHA512:
-  metadata.gz: 5b6b43e0792d190536c648d6eebf21d7021e1a4f5c84f687f02394ee98b02dc255fd628c9cf07c130dab442a6f19eada2afaab7f1f7172806cb03cbff38ff836
-  data.tar.gz: 492f737e7ebddc49e140e454a78a01b4c240ef463de21cd0a0040b4b9048657125642eb7a9f2211a5842fe9311a9dfd627506209acbd9b17656fc6f27c4d4ad5
+  metadata.gz: db827973c88ea9fe1779a0105d18ef1d0f93868fa4a59147a029c504005ec5f5e50378a7f90c490097e24d20c62fb33531a8fe277fb7620ed3cd17debdd2adaf
+  data.tar.gz: 90045bda2ce6c2605ca3708527c44ad7811cacb6cb8d4f72d83f3a875a3a043a84503dc48f24f716d94f5e92e367d6a4bfb2fa556982d14db65125623d885252

data/lib/lutaml/model/serialize/initialization.rb

@@ -184,12 +184,16 @@ module Lutaml
           end
         end
 
-        private
-
         # Replace a shared structure with a class-owned copy. The copy
         # becomes the snapshot for every existing subclass, which is what
         # keeps post-fork mutations invisible to them (the eager-copy
         # semantics).
+        #
+        # Public on purpose: code that mutates `mappings`, `attributes`,
+        # `choices` or `registers` outside the DSL — sibling classes pruning
+        # inherited elements (relaton's Item-header prunes) or importing
+        # models — must fork the structure first, or the mutation lands on
+        # the object shared with the superclass and every sibling class.
         def lutaml_cow_fork!(structure)
           return if lutaml_cow_status(structure) == 1
 
@@ -220,8 +224,6 @@ module Lutaml
           lutaml_cow_set_status!(structure, 1)
         end
 
-        public
-
         # Return the mapping object a format DSL may mutate. Forking
         # the mappings structure copies every entry, so the object
         # returned here is this class's own.

data/lib/lutaml/model/serialize/value_mapping.rb

@@ -67,6 +67,21 @@ module Lutaml
           klass = Object.const_get(klass_name)
 
           propagated = options.slice(*Lutaml::Model::Attribute::CHILD_PROPAGATION_KEYS)
+
+          # A map entry that resolves to the deserializing class itself
+          # (a subclass inheriting its base's map, or an apply_mappings
+          # override delegating back to super for its own concrete class)
+          # must fall through to this class's real deserialization:
+          # re-dispatching apply_mappings would resolve the same entry
+          # again and never make progress.
+          if klass == model
+            transformer = Lutaml::Model::Config.transformer_for(format)
+            return transformer.data_to_model(
+              self, doc, format,
+              propagated.merge(register: instance.lutaml_register)
+            )
+          end
+
           klass.apply_mappings(doc, format,
                                propagated.merge(register: instance.lutaml_register))
         end

data/lib/lutaml/model/version.rb

@@ -2,6 +2,6 @@
 
 module Lutaml
   module Model
-    VERSION = "0.8.143"
+    VERSION = "0.8.145"
   end
 end

data/spec/lutaml/model/cow_fork_public_spec.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+# Copy-on-write inheritance shares a subclass's structures with its
+# superclass until the class's own DSL forks them. External mutators — a
+# library pruning an inherited attribute on one subclass (relaton's
+# Item-header prunes) — need a supported way to claim ownership first, or
+# the mutation erases the attribute for every sibling class.
+RSpec.describe "Lutaml::Model::Serializable#lutaml_cow_fork!" do
+  let(:parent_class) do
+    Class.new(Lutaml::Model::Serializable) do
+      attribute :id, :string
+      attribute :shared, :string
+
+      xml do
+        root "parent"
+        map_attribute "id", to: :id
+        map_element "shared", to: :shared
+      end
+    end
+  end
+
+  let(:child_class) do
+    Class.new(parent_class)
+  end
+
+  it "is callable from outside the DSL" do
+    expect(child_class).to respond_to(:lutaml_cow_fork!)
+  end
+
+  it "gives the class a private copy without touching the superclass" do
+    parent_attributes = parent_class.class_attributes
+    child_class.lutaml_cow_fork!(:attributes)
+
+    expect(child_class.class_attributes).not_to equal(parent_attributes)
+    expect(parent_class.class_attributes).to equal(parent_attributes)
+  end
+
+  it "keeps post-fork mutations private to the forking class" do
+    child_class.lutaml_cow_fork!(:attributes)
+    child_class.lutaml_cow_fork!(:mappings)
+    child_class.class_attributes.delete(:id)
+    xml_attrs = child_class.mappings[:xml].instance_variable_get(:@attributes)
+    xml_attrs.delete("id")
+
+    expect(parent_class.class_attributes).to be_key(:id)
+    expect(parent_class.mappings[:xml]
+      .instance_variable_get(:@attributes)).to be_key("id")
+    expect(child_class.class_attributes).not_to be_key(:id)
+  end
+
+  it "does not fork an already-owned structure into a new object" do
+    child_class.lutaml_cow_fork!(:attributes)
+    owned = child_class.class_attributes
+    child_class.lutaml_cow_fork!(:attributes)
+
+    expect(child_class.class_attributes).to equal(owned)
+  end
+end

data/spec/lutaml/model/polymorphic_spec.rb

@@ -125,6 +125,21 @@ module PolymorphicSpec
         }
       end
     end
+
+    # A polymorphic map whose entry resolves to the class carrying it
+    # (e.g. a subclass inheriting its base's map, or an apply_mappings
+    # override delegating back to super for its own concrete class).
+    class SelfResolving < Lutaml::Model::Serializable
+      attribute :_type, :string
+      attribute :name, :string
+
+      key_value do
+        map "_type", to: :_type, polymorphic_map: {
+          "self_resolving" => "PolymorphicSpec::Base::SelfResolving",
+        }
+        map "name", to: :name
+      end
+    end
   end
 
   module Child
@@ -546,4 +561,17 @@ RSpec.describe "Polymorphic" do
       end
     end
   end
+
+  # A polymorphic map that resolves a document to the very class that is
+  # deserializing it must fall through to the model's own
+  # deserialization, not re-dispatch apply_mappings forever.
+  context "when the polymorphic map resolves to the deserializing class" do
+    it "deserializes without recursing" do
+      model = PolymorphicSpec::Base::SelfResolving.apply_mappings(
+        { "_type" => "self_resolving", "name" => "x" }, :hash
+      )
+      expect(model).to be_a(PolymorphicSpec::Base::SelfResolving)
+      expect(model.name).to eq("x")
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lutaml-model
 version: !ruby/object:Gem::Version
-  version: 0.8.143
+  version: 0.8.145
 platform: ruby
 authors:
 - Ribose Inc.
@@ -1753,6 +1753,7 @@ files:
 - spec/lutaml/model/consolidation_spec.rb
 - spec/lutaml/model/context_registry_spec.rb
 - spec/lutaml/model/conversion_caching_spec.rb
+- spec/lutaml/model/cow_fork_public_spec.rb
 - spec/lutaml/model/custom_bibtex_adapter_spec.rb
 - spec/lutaml/model/custom_collection_spec.rb
 - spec/lutaml/model/custom_from_empty_values_spec.rb