lutaml-model 0.8.143 → 0.8.144

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27c27a6e43a54c69e89e08cdeb8f749992155bc6ea072d5ccb1ba9867de9fc92
-  data.tar.gz: aab282e0b42b4a811529b58ab6b2dd5e8ab40287498802683c5283cfc6b55bdc
+  metadata.gz: ff4c24c792fe315c6798bf64b67dbc4924fc919fc447e4a0264467d169a80315
+  data.tar.gz: 15621c39ad1d06dddbca3c9b0ef809b1a87d13222ef850c0cdb557da3317ca1d
 SHA512:
-  metadata.gz: 5b6b43e0792d190536c648d6eebf21d7021e1a4f5c84f687f02394ee98b02dc255fd628c9cf07c130dab442a6f19eada2afaab7f1f7172806cb03cbff38ff836
-  data.tar.gz: 492f737e7ebddc49e140e454a78a01b4c240ef463de21cd0a0040b4b9048657125642eb7a9f2211a5842fe9311a9dfd627506209acbd9b17656fc6f27c4d4ad5
+  metadata.gz: 21de2545ba67ce8357cd0216e70a085648ea24153cff022a805005b677d7d90ab51af50869cfc6335d6aad5404f4bb4fde30ed9f6389a31ff9b7ac51580646b4
+  data.tar.gz: d46faf8a708c88622abb2d560bf2f533da86815553c81049b8d432f71d60cfad67a65e567858454a7ecad721b2d2e02c2c3d6bd8bc173416903dc5d4faab7065

data/lib/lutaml/model/serialize/initialization.rb

@@ -184,12 +184,16 @@ module Lutaml
           end
         end
 
-        private
-
         # Replace a shared structure with a class-owned copy. The copy
         # becomes the snapshot for every existing subclass, which is what
         # keeps post-fork mutations invisible to them (the eager-copy
         # semantics).
+        #
+        # Public on purpose: code that mutates `mappings`, `attributes`,
+        # `choices` or `registers` outside the DSL — sibling classes pruning
+        # inherited elements (relaton's Item-header prunes) or importing
+        # models — must fork the structure first, or the mutation lands on
+        # the object shared with the superclass and every sibling class.
         def lutaml_cow_fork!(structure)
           return if lutaml_cow_status(structure) == 1
 
@@ -220,8 +224,6 @@ module Lutaml
           lutaml_cow_set_status!(structure, 1)
         end
 
-        public
-
         # Return the mapping object a format DSL may mutate. Forking
         # the mappings structure copies every entry, so the object
         # returned here is this class's own.

data/lib/lutaml/model/version.rb

@@ -2,6 +2,6 @@
 
 module Lutaml
   module Model
-    VERSION = "0.8.143"
+    VERSION = "0.8.144"
   end
 end

data/spec/lutaml/model/cow_fork_public_spec.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+# Copy-on-write inheritance shares a subclass's structures with its
+# superclass until the class's own DSL forks them. External mutators — a
+# library pruning an inherited attribute on one subclass (relaton's
+# Item-header prunes) — need a supported way to claim ownership first, or
+# the mutation erases the attribute for every sibling class.
+RSpec.describe "Lutaml::Model::Serializable#lutaml_cow_fork!" do
+  let(:parent_class) do
+    Class.new(Lutaml::Model::Serializable) do
+      attribute :id, :string
+      attribute :shared, :string
+
+      xml do
+        root "parent"
+        map_attribute "id", to: :id
+        map_element "shared", to: :shared
+      end
+    end
+  end
+
+  let(:child_class) do
+    Class.new(parent_class)
+  end
+
+  it "is callable from outside the DSL" do
+    expect(child_class).to respond_to(:lutaml_cow_fork!)
+  end
+
+  it "gives the class a private copy without touching the superclass" do
+    parent_attributes = parent_class.class_attributes
+    child_class.lutaml_cow_fork!(:attributes)
+
+    expect(child_class.class_attributes).not_to equal(parent_attributes)
+    expect(parent_class.class_attributes).to equal(parent_attributes)
+  end
+
+  it "keeps post-fork mutations private to the forking class" do
+    child_class.lutaml_cow_fork!(:attributes)
+    child_class.lutaml_cow_fork!(:mappings)
+    child_class.class_attributes.delete(:id)
+    xml_attrs = child_class.mappings[:xml].instance_variable_get(:@attributes)
+    xml_attrs.delete("id")
+
+    expect(parent_class.class_attributes).to be_key(:id)
+    expect(parent_class.mappings[:xml]
+      .instance_variable_get(:@attributes)).to be_key("id")
+    expect(child_class.class_attributes).not_to be_key(:id)
+  end
+
+  it "does not fork an already-owned structure into a new object" do
+    child_class.lutaml_cow_fork!(:attributes)
+    owned = child_class.class_attributes
+    child_class.lutaml_cow_fork!(:attributes)
+
+    expect(child_class.class_attributes).to equal(owned)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lutaml-model
 version: !ruby/object:Gem::Version
-  version: 0.8.143
+  version: 0.8.144
 platform: ruby
 authors:
 - Ribose Inc.
@@ -1753,6 +1753,7 @@ files:
 - spec/lutaml/model/consolidation_spec.rb
 - spec/lutaml/model/context_registry_spec.rb
 - spec/lutaml/model/conversion_caching_spec.rb
+- spec/lutaml/model/cow_fork_public_spec.rb
 - spec/lutaml/model/custom_bibtex_adapter_spec.rb
 - spec/lutaml/model/custom_collection_spec.rb
 - spec/lutaml/model/custom_from_empty_values_spec.rb