lutaml-model 0.8.11 → 0.8.13

data/spec/lutaml/xml/opal_xml_spec.rb

@@ -0,0 +1,145 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe "XML with REXML under Opal", if: RUBY_ENGINE == "opal" do
+  before do
+    Lutaml::Model::Config.xml_adapter_type = :rexml
+  end
+
+  it "round-trips XML through parse and serialize" do
+    klass = Class.new do
+      include Lutaml::Model::Serialize
+
+      attribute :name, :string
+      xml do
+        element "person"
+        map_element "name", to: :name
+      end
+    end
+
+    instance = klass.from_xml("<person><name>Alice</name></person>")
+    expect(instance.name).to eq("Alice")
+    expect(instance.to_xml).to include("<name>Alice</name>")
+  end
+
+  it "handles XML attributes" do
+    klass = Class.new do
+      include Lutaml::Model::Serialize
+
+      attribute :id, :string
+      attribute :value, :string
+      xml do
+        element "item"
+        map_attribute "id", to: :id
+        map_element "value", to: :value
+      end
+    end
+
+    instance = klass.from_xml('<item id="42"><value>test</value></item>')
+    expect(instance.id).to eq("42")
+    expect(instance.value).to eq("test")
+  end
+
+  it "handles nested elements" do
+    address = Class.new do
+      include Lutaml::Model::Serialize
+
+      attribute :city, :string
+      xml do
+        element "address"
+        map_element "city", to: :city
+      end
+    end
+
+    person = Class.new do
+      include Lutaml::Model::Serialize
+
+      attribute :name, :string
+      attribute :address, address
+      xml do
+        element "person"
+        map_element "name", to: :name
+        map_element "address", to: :address
+      end
+    end
+
+    instance = person.from_xml("<person><name>Alice</name><address><city>NYC</city></address></person>")
+    expect(instance.name).to eq("Alice")
+    expect(instance.address.city).to eq("NYC")
+  end
+
+  it "handles element collections" do
+    list = Class.new do
+      include Lutaml::Model::Serialize
+
+      attribute :items, :string, collection: true
+      xml do
+        element "list"
+        map_element "item", to: :items
+      end
+    end
+
+    instance = list.from_xml("<list><item>a</item><item>b</item><item>c</item></list>")
+    expect(instance.items).to eq(%w[a b c])
+  end
+
+  it "handles mixed content" do
+    paragraph = Class.new do
+      include Lutaml::Model::Serialize
+
+      attribute :content, :string, collection: true
+      xml do
+        element "p"
+        mixed_content
+        map_content to: :content
+      end
+    end
+
+    instance = paragraph.from_xml("<p>Hello <b>world</b> end</p>")
+    expect(instance.content.join).to include("Hello")
+  end
+
+  it "serializes to XML with correct structure" do
+    item = Class.new do
+      include Lutaml::Model::Serialize
+
+      attribute :title, :string
+      attribute :count, :integer
+      xml do
+        element "item"
+        map_element "title", to: :title
+        map_element "count", to: :count
+      end
+    end
+
+    instance = item.new(title: "Widget", count: 5)
+    xml = instance.to_xml
+    expect(xml).to include("<title>Widget</title>")
+    expect(xml).to include("<count>5</count>")
+  end
+
+  it "handles XmlOrderable on plain model classes" do
+    plain_model = Class.new do
+      attr_accessor :data
+    end
+
+    Class.new do
+      include Lutaml::Model::Serialize
+
+      const_set(:MODEL_CLASS, plain_model)
+      model plain_model
+      attribute :data, :string
+      xml do
+        element "data"
+        map_element "data", to: :data
+      end
+    end
+
+    expect(plain_model.ancestors).to include(Lutaml::Xml::XmlOrderable)
+  end
+
+  it "uses REXML adapter by default under Opal" do
+    expect(Lutaml::Model::Config.xml_adapter_type).to eq(:rexml)
+  end
+end

data/spec/lutaml/xml/pipeline_integration_spec.rb

@@ -0,0 +1,145 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe "Full serialization pipeline" do
+  before do
+    item_class = Class.new do
+      include Lutaml::Model::Serialize
+
+      attribute :name, :string
+      attribute :value, :string
+
+      xml do
+        element "item"
+        map_element "name", to: :name
+        map_element "value", to: :value
+      end
+    end
+
+    stub_const("PipeItem", item_class)
+
+    doc_class = Class.new do
+      include Lutaml::Model::Serialize
+
+      attribute :title, :string
+      attribute :items, PipeItem, collection: true
+
+      xml do
+        element "document"
+        map_element "title", to: :title
+        map_element "item", to: :items
+      end
+    end
+
+    stub_const("PipeDoc", doc_class)
+  end
+
+  let(:model) do
+    PipeDoc.new(
+      title: "Test",
+      items: [
+        PipeItem.new(name: "a", value: "1"),
+        PipeItem.new(name: "b", value: "2"),
+      ],
+    )
+  end
+
+  it "produces identical output for identical models across multiple runs" do
+    first = model.to_xml
+    second = model.to_xml
+    expect(first).to eq(second)
+  end
+
+  it "handles declaration + doctype + content together" do
+    xml = model.to_xml(
+      declaration: true,
+      doctype: { name: "document", system_id: "doc.dtd" },
+    )
+
+    expect(xml).to start_with("<?xml")
+    expect(xml).to include("<!DOCTYPE document SYSTEM \"doc.dtd\">")
+    expect(xml).to include("<title>Test</title>")
+    expect(xml).to include("<name>a</name>")
+  end
+
+  it "CRLF + indent=4 + declaration produces correct output" do
+    xml = model.to_xml(
+      line_ending: "\r\n",
+      indent: 4,
+      declaration: true,
+    )
+
+    expect(xml.lines).to all(end_with("\r\n"))
+    expect(xml).to include("    <title>Test</title>")
+    expect(xml).to include("<?xml")
+  end
+
+  it "round-trips complex XML with all features preserved" do
+    input = <<~XML
+      <?xml version="1.0" encoding="UTF-8"?>
+      <document>
+        <title>Original</title>
+        <item>
+          <name>x</name>
+          <value>42</value>
+        </item>
+      </document>
+    XML
+
+    parsed = PipeDoc.from_xml(input)
+    expect(parsed.title).to eq("Original")
+    expect(parsed.items.length).to eq(1)
+    expect(parsed.items.first.name).to eq("x")
+    expect(parsed.items.first.value).to eq("42")
+
+    output = parsed.to_xml(declaration: true)
+    expect(output).to start_with("<?xml")
+    expect(output).to include("<title>Original</title>")
+    expect(output).to include("<name>x</name>")
+  end
+
+  it "round-trip preserves namespace declarations" do
+    ns = Class.new(Lutaml::Xml::W3c::XmlNamespace) do
+      uri "http://example.com/ns"
+      prefix_default "ex"
+    end
+
+    stub_const("PipeNs", ns)
+
+    ns_child = Class.new do
+      include Lutaml::Model::Serialize
+
+      attribute :content, :string
+
+      xml do
+        element "child"
+        namespace PipeNs
+        map_element "content", to: :content
+      end
+    end
+
+    stub_const("PipeNsChild", ns_child)
+
+    ns_parent = Class.new do
+      include Lutaml::Model::Serialize
+
+      attribute :child, PipeNsChild
+
+      xml do
+        element "parent"
+        map_element "child", to: :child
+      end
+    end
+
+    stub_const("PipeNsParent", ns_parent)
+
+    instance = PipeNsParent.new(child: PipeNsChild.new(content: "data"))
+    xml = instance.to_xml
+
+    expect(xml).to include("xmlns")
+
+    parsed = PipeNsParent.from_xml(xml)
+    expect(parsed.child.content).to eq("data")
+  end
+end

data/spec/lutaml/xml/schema_primer_spec.rb

@@ -44,7 +44,7 @@ module XmlSchemaPrimerFeaturesSpec
     attribute :work_address, AddressType
 
     xml do
-      root "Person"
+      element "Person"
       map_element "homeAddress", to: :home_address
       map_element "workAddress", to: :work_address
     end
@@ -69,7 +69,7 @@ module XmlSchemaPrimerFeaturesSpec
     attribute :ship_to, UsAddress
 
     xml do
-      root "purchaseOrder"
+      element "purchaseOrder"
       namespace PoNamespace
       map_element "shipTo", to: :ship_to
     end
@@ -85,7 +85,7 @@ module XmlSchemaPrimerFeaturesSpec
     attribute :comment, :string
 
     xml do
-      root "purchaseOrder"
+      element "purchaseOrder"
       namespace PoNamespaceQualified
 
       map_element "shipTo", to: :ship_to
@@ -103,7 +103,7 @@ module XmlSchemaPrimerFeaturesSpec
     attribute :comment, :string
 
     xml do
-      root "purchaseOrder"
+      element "purchaseOrder"
       namespace PoNamespacePrefixed
 
       map_element "shipTo", to: :ship_to
@@ -129,7 +129,7 @@ module XmlSchemaPrimerFeaturesSpec
     attribute :notes, :string
 
     xml do
-      root "supplier"
+      element "supplier"
       namespace MixedNamespace
 
       map_element "contact", to: :contact

data/spec/lutaml/xml/transformation_spec.rb

@@ -10,7 +10,7 @@ module TransformationSpecModels
     attribute :value, :integer
 
     xml do
-      root "SimpleModel"
+      element "SimpleModel"
       map_element "name", to: :name
       map_element "value", to: :value
     end
@@ -21,7 +21,7 @@ module TransformationSpecModels
     attribute :type, :string
 
     xml do
-      root "Model"
+      element "Model"
       map_attribute "id", to: :id
       map_attribute "type", to: :type
     end
@@ -31,7 +31,7 @@ module TransformationSpecModels
     attribute :text, :string
 
     xml do
-      root "Model"
+      element "Model"
       map_content to: :text
     end
   end
@@ -41,7 +41,7 @@ module TransformationSpecModels
     attribute :email, :string
 
     xml do
-      root "Contact"
+      element "Contact"
       map_element "name", to: :name
       map_element "email", to: :email
     end
@@ -52,7 +52,7 @@ module TransformationSpecModels
     attribute :name, :string
 
     xml do
-      root "Person"
+      element "Person"
       map_attribute "id", to: :id
       map_element "name", to: :name
     end
@@ -62,7 +62,7 @@ module TransformationSpecModels
     attribute :content, :string
 
     xml do
-      root "Note"
+      element "Note"
       map_content to: :content
     end
   end
@@ -72,7 +72,7 @@ module TransformationSpecModels
     attribute :city, :string
 
     xml do
-      root "Address"
+      element "Address"
       map_element "street", to: :street
       map_element "city", to: :city
     end
@@ -83,7 +83,7 @@ module TransformationSpecModels
     attribute :address, TransformationSpecModels::Address
 
     xml do
-      root "Person"
+      element "Person"
       map_element "name", to: :name
       map_element "Address", to: :address
     end
@@ -93,7 +93,7 @@ module TransformationSpecModels
     attribute :title, :string
 
     xml do
-      root "Book"
+      element "Book"
       map_element "title", to: :title
     end
   end
@@ -103,7 +103,7 @@ module TransformationSpecModels
     attribute :book, TransformationSpecModels::Book
 
     xml do
-      root "Library"
+      element "Library"
       map_element "name", to: :name
       map_element "Book", to: :book
     end
@@ -113,7 +113,7 @@ module TransformationSpecModels
     attribute :tags, :string, collection: true
 
     xml do
-      root "TagList"
+      element "TagList"
       map_element "tag", to: :tags
     end
   end
@@ -123,7 +123,7 @@ module TransformationSpecModels
     attribute :price, :float
 
     xml do
-      root "Item"
+      element "Item"
       map_element "name", to: :name
       map_element "price", to: :price
     end
@@ -133,7 +133,7 @@ module TransformationSpecModels
     attribute :items, TransformationSpecModels::Item, collection: true
 
     xml do
-      root "Cart"
+      element "Cart"
       map_element "Item", to: :items
     end
   end
@@ -149,7 +149,7 @@ module TransformationSpecModels
     attribute :value, :string
 
     xml do
-      root "Model"
+      element "Model"
       namespace TestNs::MyNamespace
       map_element "value", to: :value
     end
@@ -171,7 +171,7 @@ module TransformationSpecModels
     attribute :value, :string
 
     xml do
-      root "Child"
+      element "Child"
       namespace NsTest::Ns2
       map_element "value", to: :value
     end
@@ -182,7 +182,7 @@ module TransformationSpecModels
     attribute :child, TransformationSpecModels::Child
 
     xml do
-      root "Parent"
+      element "Parent"
       namespace NsTest::Ns1
       map_element "name", to: :name
       map_element "Child", to: :child
@@ -195,7 +195,7 @@ module TransformationSpecModels
     }
 
     xml do
-      root "Model"
+      element "Model"
       map_element "name", to: :name
     end
   end
@@ -204,7 +204,7 @@ module TransformationSpecModels
     attribute :status, :string, default: -> { "active" }
 
     xml do
-      root "Model"
+      element "Model"
       map_element "status", to: :status, render_default: false
     end
   end
@@ -213,7 +213,7 @@ module TransformationSpecModels
     attribute :optional, :string
 
     xml do
-      root "Model"
+      element "Model"
       map_element "optional", to: :optional, render_nil: true
     end
   end
@@ -222,7 +222,7 @@ module TransformationSpecModels
     attribute :value, :string
 
     xml do
-      root "Model"
+      element "Model"
       map_element "value", to: :value
     end
   end

data/spec/lutaml/xml/type_namespace/collector_spec.rb

@@ -30,7 +30,7 @@ RSpec.describe Lutaml::Xml::TypeNamespace::Collector do
       attribute :author, :string
 
       xml do
-        root "document"
+        element "document"
         map_element "title", to: :title
         map_element "author", to: :author
       end

data/spec/lutaml/xml/type_namespace/planner_spec.rb

@@ -33,7 +33,7 @@ RSpec.describe Lutaml::Xml::TypeNamespace::Planner do
       attribute :author, :string
 
       xml do
-        root "document"
+        element "document"
         map_element "title", to: :title
         map_element "author", to: :author
       end
@@ -155,7 +155,7 @@ RSpec.describe Lutaml::Xml::TypeNamespace::Planner do
           attribute :title, type
 
           xml do
-            root "document"
+            element "document"
             map_element "title", to: :title
           end
         end
@@ -183,7 +183,7 @@ RSpec.describe Lutaml::Xml::TypeNamespace::Planner do
           attribute :title, :string
 
           xml do
-            root "document"
+            element "document"
             map_element "title", to: :title
           end
         end

data/spec/lutaml/xml/xml_spec.rb

@@ -1,18 +1,34 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require "open3"
 require "lutaml/xml"
 
 RSpec.describe Lutaml::Xml do
-  describe "standalone loading" do
-    let(:lib_path) { File.expand_path("../../../lib", __dir__) }
+  let(:lib_path) { File.expand_path("../../../lib", __dir__) }
 
-    it "lazy-loads the schema namespace from the XML entry point" do
-      # rubocop:disable Style/CommandLiteral
-      result = `#{RbConfig.ruby} -I#{lib_path} -e 'require "lutaml/xml"; abort "missing Schema autoload" unless Lutaml::Xml.autoload?(:Schema); abort "missing Xsd autoload" unless Lutaml::Xml::Schema.const_defined?(:Xsd, false); puts :ok' 2>&1`
-      # rubocop:enable Style/CommandLiteral
+  def run_ruby(script)
+    stdout, stderr, status = Open3.capture3(
+      RbConfig.ruby, "-I#{lib_path}", "-e", script
+    )
 
-      expect($?.success?).to be(true), result
+    [stdout + stderr, status]
+  end
+
+  describe "standalone loading" do
+    it "lazy-loads the schema namespace from the XML entry point" do
+      script = <<~RUBY
+        require "lutaml/xml"
+        abort "missing Schema autoload" unless Lutaml::Xml.autoload?(:Schema)
+        unless Lutaml::Xml::Schema.const_defined?(:Xsd, false)
+          abort "missing Xsd autoload"
+        end
+        puts :ok
+      RUBY
+
+      result, status = run_ruby(script)
+
+      expect(status.success?).to be(true), result
       expect(result).to include("ok")
     end
   end
@@ -22,6 +38,44 @@ RSpec.describe Lutaml::Xml do
       expect(described_class::Schema.const_defined?(:Xsd, false))
         .to be(!Lutaml::Model::RuntimeCompatibility.opal?)
     end
+
+    it "does not autoload schema constants when loaded under Opal" do
+      script = <<~'RUBY'
+        require "lutaml/model/runtime_compatibility"
+
+        module Lutaml
+          module Model
+            module RuntimeCompatibility
+              def self.opal?
+                true
+              end
+            end
+          end
+        end
+
+        require "lutaml/xml/schema"
+
+        schema_constants = %i[
+          Xsd XsdSchema RelaxngSchema Builder BuiltinTypes
+        ]
+
+        loaded_constants = schema_constants.select do |constant_name|
+          Lutaml::Xml::Schema.autoload?(constant_name) ||
+            Lutaml::Xml::Schema.const_defined?(constant_name, false)
+        end
+
+        if loaded_constants.any?
+          abort "loaded schema constants: #{loaded_constants.join(', ')}"
+        end
+
+        puts :ok
+      RUBY
+
+      result, status = run_ruby(script)
+
+      expect(status.success?).to be(true), result
+      expect(result).to include("ok")
+    end
   end
 
   describe "schema methods" do
@@ -66,9 +120,6 @@ RSpec.describe Lutaml::Xml do
       hide_const("Ox") if Object.const_defined?(:Ox)
       hide_const("Oga") if Object.const_defined?(:Oga)
       hide_const("REXML") if Object.const_defined?(:REXML)
-
-      # Stub require to prevent any actual requires during testing
-      allow(Lutaml::Model::Utils).to receive(:require).and_return(true)
     end
 
     context "when Nokogiri is available" do
@@ -101,9 +152,9 @@ RSpec.describe Lutaml::Xml do
       end
     end
 
-    context "when no adapters are available" do
-      it "returns nil" do
-        expect(described_class.detect_xml_adapter).to be_nil
+    context "when no adapters are detected" do
+      it "falls back to moxml default (:nokogiri)" do
+        expect(described_class.detect_xml_adapter).to eq(:nokogiri)
       end
     end
 

data/spec/support/opal.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+# Opal runtime patches for lutaml-model specs
+if RUBY_ENGINE == "opal"
+  Lutaml::Model::Config.xml_adapter_type = :rexml
+end