lutaml-model 0.8.108 → 0.8.109

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 50f81556cebfd601f3ff6ede463ed9f20d31a0e2c12e8c1362c655b5dd9408e8
-  data.tar.gz: c9ec847109db4b87bbb4e4e46fde663eb83d7b9eae54d43f55e1c04024345013
+  metadata.gz: 45a348d47b61525553682dc4a12be7cde6239ba3d8367e1338e8a266c59ad806
+  data.tar.gz: 1a3816081d045d022bf6fcb94a6a82bdfe335644bdbc925d3bcf7676522b433c
 SHA512:
-  metadata.gz: cbce6698e13f0d52da843a92c4bae8ca69db7f11cdbd654f1dd924cd171f31ad227da0a610557a17de11856de2030460d5b497a248c3b37b7de76ca286398520
-  data.tar.gz: d4113a27b55316ad49f5a9263ac3b1d15616c3c7c65408faa1b0a4741ed1966fcd173a8519d85b19dec66a406ce168caf6439703b5e687318ae74dc586ee586d
+  metadata.gz: 8b0e82b390f6d56ae98f9f98c9c16b121e8c96290cb79c8db0c31723104a0e940d4bfe798f3facee8493b2257f47c4597b91920cf6dff93dfa89e0875970746b
+  data.tar.gz: c5e85f1a1a613112a08795db1e299bfda7ba41057091da39e371f24d03759ff739f56ad96b929c7d41b50ecd4bbbf41f87543205e850239c6494d89f3d334398

data/lib/lutaml/model/attribute.rb

@@ -398,11 +398,27 @@ module Lutaml
         # cast_items already returns a fresh array, so the plain-Array
         # collection needs no re-wrap — build_collection's
         # collection_class.new would copy it again.
+        assert_flat_collection_items!(items)
         return items if !custom_collection? && collection_class == ::Array
 
         build_collection(items, register: register)
       end
 
+      # Fail loudly on nested arrays. A collection's declared element
+      # type never admits an Array as an item; the legacy
+      # build_collection flatten silently absorbed mis-spliced builder
+      # output (expressir#506 surfaced it three frames away in a
+      # formatter). The error must land at the assignment boundary.
+      def assert_flat_collection_items!(items)
+        return unless items.any?(::Array)
+
+        raise TypeError,
+              "collection '#{name}': item " \
+              "#{items.index { |item| item.is_a?(::Array) }} is an Array " \
+              "where the declared element type is expected; nested arrays " \
+              "are not flattened — splice list results before assignment"
+      end
+
       # Plain Arrays count as list input. On singular attributes
       # collection_instance? matches Arrays too (their collection class is
       # Array), preserving the Array so strict cardinality can flag it.

data/lib/lutaml/model/version.rb

@@ -2,6 +2,6 @@
 
 module Lutaml
   module Model
-    VERSION = "0.8.108"
+    VERSION = "0.8.109"
   end
 end

data/spec/lutaml/model/collection_strict_assignment_spec.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe "strict collection assignment" do
+  let(:node_class) do
+    Class.new(Lutaml::Model::Serializable) do
+      attribute :id, :string
+    end
+  end
+
+  let(:holder_class) do
+    Class.new(Lutaml::Model::Serializable) do
+      attribute :items, "Node", collection: true
+    end
+  end
+
+  before do
+    stub_const("Node", node_class)
+    stub_const("Holder", holder_class)
+  end
+
+  it "raises at the constructor boundary" do
+    expect do
+      Holder.new(items: [[Node.new(id: "a")], Node.new(id: "b")])
+    end.to raise_error(Lutaml::Model::TypeError, /item 0 is an Array/)
+  end
+
+  it "raises at the writer boundary" do
+    holder = Holder.new
+    expect do
+      holder.items = [Node.new, [Node.new]]
+    end.to raise_error(Lutaml::Model::TypeError, /item 1 is an Array/)
+  end
+
+  it "raises for a custom collection class" do
+    custom = Class.new(Lutaml::Model::Collection) do
+      instances :node, "Node"
+    end
+    stub_const("NodeBag", custom)
+    wrapper = Class.new(Lutaml::Model::Serializable) do
+      attribute :bag, "NodeBag"
+    end
+    stub_const("BagHolder", wrapper)
+
+    expect do
+      BagHolder.new(bag: [[Node.new]])
+    end.to raise_error(Lutaml::Model::TypeError, /nested arrays are not flattened/)
+  end
+
+  it "keeps flat assignment untouched" do
+    holder = Holder.new(items: [Node.new(id: "x")])
+    expect(holder.items.map(&:id)).to eq(["x"])
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lutaml-model
 version: !ruby/object:Gem::Version
-  version: 0.8.108
+  version: 0.8.109
 platform: ruby
 authors:
 - Ribose Inc.
@@ -1724,6 +1724,7 @@ files:
 - spec/lutaml/model/collection_single_value_coercion_spec.rb
 - spec/lutaml/model/collection_spec.rb
 - spec/lutaml/model/collection_state_nesting_spec.rb
+- spec/lutaml/model/collection_strict_assignment_spec.rb
 - spec/lutaml/model/collection_validation_spec.rb
 - spec/lutaml/model/comparable_model_spec.rb
 - spec/lutaml/model/comparison_family_spec.rb