lutaml-model 0.7.3 → 0.7.5

data/spec/lutaml/model/attribute_spec.rb

@@ -15,6 +15,7 @@ RSpec.describe Lutaml::Model::Attribute do
     Class.new(Lutaml::Model::Serializable) do
       attribute :age, :integer
       attribute :image, :string
+      restrict :image, collection: 1..., pattern: /.*\.\w+$/
     end
   end
 
@@ -44,6 +45,45 @@ RSpec.describe Lutaml::Model::Attribute do
     )
   end
 
+  describe "#validate_name!" do
+    Lutaml::Model::Serializable.instance_methods.each do |method|
+      if Lutaml::Model::Attribute::ALLOW_OVERRIDING.include?(method)
+        before do
+          allow(Lutaml::Model::Logger).to receive(:warn)
+        end
+
+        it "does not raise an error when method is `#{method}`" do
+          expect do
+            Class.new(Lutaml::Model::Serializable) do
+              attribute method, :string
+            end
+          end.not_to raise_error
+        end
+
+        it "logs a warning, when method is `#{method}`" do
+          Class.new(Lutaml::Model::Serializable) do
+            attribute method, :string
+          end
+
+          expect(Lutaml::Model::Logger)
+            .to have_received(:warn)
+            .with("Attribute name `#{method}` conflicts with a built-in method")
+        end
+      else
+        it "raise exception, when method is `#{method}`" do
+          expect do
+            Class.new(Lutaml::Model::Serializable) do
+              attribute method, :string
+            end
+          end.to raise_error(
+            Lutaml::Model::InvalidAttributeNameError,
+            "Attribute name '#{method}' is not allowed",
+          )
+        end
+      end
+    end
+  end
+
   describe "#validate_options!" do
     let(:validate_options) { name_attr.method(:validate_options!) }
 
@@ -56,7 +96,7 @@ RSpec.describe Lutaml::Model::Attribute do
     it "raise exception if option is not allowed" do
       expect do
         validate_options.call({ foo: "bar" })
-      end.to raise_error(StandardError, "Invalid options given for `name` [:foo]")
+      end.to raise_error(Lutaml::Model::InvalidAttributeOptionsError, "Invalid options given for `name` [:foo]")
     end
 
     it "raise exception if pattern is given with non string type" do
@@ -71,49 +111,6 @@ RSpec.describe Lutaml::Model::Attribute do
     end
   end
 
-  describe "#validate_type!" do
-    let(:validate_type) { name_attr.method(:validate_type!) }
-
-    it "return true if type is a class" do
-      expect(validate_type.call(TestRecord)).to be(true)
-    end
-
-    it "return true if type is a valid symbol" do
-      expect(validate_type.call(:string)).to be(true)
-    end
-
-    it "return true if type is a valid string" do
-      expect(validate_type.call("String")).to be(true)
-    end
-
-    it "raise exception if type is invalid symbol" do
-      expect do
-        validate_type.call(:foo)
-      end.to raise_error(StandardError, "Unknown Lutaml::Model::Type: foo")
-    end
-
-    it "raise exception if type is invalid string" do
-      expect do
-        validate_type.call("foo")
-      end.to raise_error(StandardError, "Unknown Lutaml::Model::Type: foo")
-    end
-  end
-
-  describe "#cast_type!" do
-    it "cast :string to Lutaml::Model::Type::String" do
-      expect(name_attr.cast_type!(:string)).to eq(Lutaml::Model::Type::String)
-    end
-
-    it "cast :integer to Lutaml::Model::Type::Integer" do
-      expect(name_attr.cast_type!(:integer)).to eq(Lutaml::Model::Type::Integer)
-    end
-
-    it "raises ArgumentError on unknown type" do
-      expect { name_attr.cast_type!(:foobar) }
-        .to raise_error(ArgumentError, "Unknown Lutaml::Model::Type: foobar")
-    end
-  end
-
   describe "#derived?" do
     context "when type is set" do
       let(:attribute) { described_class.new("name", :string) }

data/spec/lutaml/model/choice_spec.rb

@@ -59,6 +59,29 @@ module ChoiceSpec
       map :last_name, to: :last_name
     end
   end
+
+  class ContactEmail < Lutaml::Model::Serializable
+    attribute :email, :string
+    xml { no_root }
+  end
+
+  class ContactPhone < Lutaml::Model::Serializable
+    attribute :phone, :string
+    xml { no_root }
+  end
+
+  class Person < Lutaml::Model::Serializable
+    choice(min: 1, max: 2) do
+      import_model_attributes ContactEmail
+      import_model_attributes ContactPhone
+    end
+
+    xml do
+      root "Person"
+      map_element :email, to: :email
+      map_element :phone, to: :phone
+    end
+  end
 end
 
 RSpec.describe "Choice" do
@@ -165,4 +188,25 @@ RSpec.describe "Choice" do
       end.to raise_error(Lutaml::Model::InvalidChoiceRangeError, "Choice lower bound `-1` must be positive")
     end
   end
+
+  context "with choice using import_model_attributes" do
+    it "parses XML with both email and phone using choice and import_model_attributes" do
+      xml = <<~XML
+        <Person>
+          <email>john.doe@example.com</email>
+          <phone>1234567890</phone>
+        </Person>
+      XML
+      person = ChoiceSpec::Person.from_xml(xml)
+      expect(person.email).to eq("john.doe@example.com")
+      expect(person.phone).to eq("1234567890")
+    end
+
+    it "raises error if no contact info is provided" do
+      xml = <<~XML
+        <Person></Person>
+      XML
+      expect { ChoiceSpec::Person.from_xml(xml).validate! }.to raise_error(Lutaml::Model::ValidationError)
+    end
+  end
 end