lutaml-model 0.7.1 → 0.7.3

data/spec/lutaml/model/transformation_spec.rb

@@ -56,7 +56,7 @@ module TransformationSpec
       import: ->(value) { value.to_s.downcase },
     }
     attribute :email, :string, transform: {
-      export: lambda(&:downcase),
+      export: lambda(&:upcase),
       import: lambda(&:downcase),
     }
     attribute :tags, :string, collection: true, transform: {
@@ -82,13 +82,36 @@ module TransformationSpec
         export: ->(value) { "Prof. #{value}" },
         import: ->(value) { value.gsub("Prof. ", "") },
       }
-      map_element "contact-email", to: :email, transform: {
+      map_attribute "contact-email", to: :email, transform: {
         export: ->(value) { "contact+#{value}" },
         import: ->(value) { value.gsub("contact+", "") },
       }
       map_element "skills", to: :tags
     end
   end
+
+  class RoundTripTransformations < Lutaml::Model::Serializable
+    attribute :number, :string, transform: {
+      import: ->(value) { (value.to_f + 1).to_s },
+      export: ->(value) { (value.to_f - 1).to_s },
+    }
+
+    json do
+      map "number", to: :number, transform: {
+        import: ->(value) { ((value.to_f * 10) + 1).to_s },
+        export: ->(value) { ((value.to_f - 1) / 10.0).to_s },
+      }
+    end
+
+    xml do
+      root "RoundTripTransformations"
+
+      map_element "number", to: :number, transform: {
+        import: ->(value) { ((value.to_f * 10) + 1).to_s },
+        export: ->(value) { ((value.to_f - 1) / 10.0).to_s },
+      }
+    end
+  end
 end
 
 RSpec.describe "Value Transformations" do
@@ -147,6 +170,18 @@ RSpec.describe "Value Transformations" do
       )
     end
 
+    let(:json) do
+      {
+        "fullName" => "Dr. bob",
+        "emailAddress" => "bobattest.com",
+        "labels" => "senior|lead",
+      }.to_json
+    end
+
+    let(:parsed) do
+      TransformationSpec::MappingTransformPerson.from_json(json)
+    end
+
     let(:expected_xml) do
       <<~XML
         <person>
@@ -165,16 +200,15 @@ RSpec.describe "Value Transformations" do
       expect(parsed["labels"]).to eq("developer-|-architect")
     end
 
-    it "applies mapping transformations during JSON deserialization" do
-      json = {
-        "fullName" => "Dr. bob",
-        "emailAddress" => "bobattest.com",
-        "labels" => "senior|lead",
-      }.to_json
-
-      parsed = TransformationSpec::MappingTransformPerson.from_json(json)
+    it "correctly deserialize name from JSON" do
       expect(parsed.name).to eq("Dr. bob")
+    end
+
+    it "correctly deserialize email from JSON" do
       expect(parsed.email).to eq("bob@test.com")
+    end
+
+    it "correctly deserialize tags from JSON" do
       expect(parsed.tags).to eq(["senior", "lead"])
     end
 
@@ -195,9 +229,8 @@ RSpec.describe "Value Transformations" do
 
     let(:expected_xml) do
       <<~XML
-        <person>
-          <full-name>Prof. carol</full-name>
-          <contact-email>contact+CAROL@TEST.COM</contact-email>
+        <person contact-email="contact+CAROL@TEST.COM">
+          <full-name>Prof. Carol</full-name>
           <skills>MANAGER-1</skills>
           <skills>AGILE-1</skills>
         </person>
@@ -208,7 +241,7 @@ RSpec.describe "Value Transformations" do
       json = combined_person.to_json
       parsed = JSON.parse(json)
 
-      expect(parsed["fullName"]).to eq("Prof. carol")
+      expect(parsed["fullName"]).to eq("Prof. Carol")
       expect(parsed["contactEmail"]).to eq("contact+CAROL@TEST.COM")
     end
 
@@ -217,7 +250,7 @@ RSpec.describe "Value Transformations" do
       json = combined_person.to_json
       parsed_json = TransformationSpec::CombinedTransformPerson.from_json(json)
       expect(parsed_json.name).to eq("carol")
-      expect(parsed_json.email).to eq("CAROL@TEST.COM")
+      expect(parsed_json.email).to eq("carol@test.com")
       expect(parsed_json.tags).to eq(["MANAGER-1", "AGILE-1"])
     end
 
@@ -227,4 +260,28 @@ RSpec.describe "Value Transformations" do
       expect(parsed_xml.to_xml).to be_equivalent_to(expected_xml)
     end
   end
+
+  describe "Custom Transformations all mappings applied" do
+    let(:xml) do
+      <<~XML
+        <RoundTripTransformations>
+          <number>10.0</number>
+        </RoundTripTransformations>
+      XML
+    end
+
+    let(:json) do
+      { number: "10.0" }.to_json
+    end
+
+    it "correctly round trips XML" do
+      parsed = TransformationSpec::RoundTripTransformations.from_xml(xml)
+      expect(parsed.to_xml).to be_equivalent_to(xml)
+    end
+
+    it "correctly round trips JSON" do
+      parsed = TransformationSpec::RoundTripTransformations.from_json(json)
+      expect(parsed.to_json).to be_equivalent_to(json)
+    end
+  end
 end

data/spec/lutaml/model/uninitialized_class_spec.rb

@@ -0,0 +1,96 @@
+# frozen_string_literal: true
+
+RSpec.describe Lutaml::Model::UninitializedClass do
+  subject(:uninitialized) { described_class.instance }
+
+  describe "#to_s" do
+    it "returns self" do
+      expect(uninitialized.to_s).to eq(uninitialized)
+    end
+  end
+
+  describe "#inspect" do
+    it "returns 'uninitialized'" do
+      expect(uninitialized.inspect).to eq("uninitialized")
+    end
+  end
+
+  describe "#uninitialized?" do
+    it "returns true" do
+      expect(uninitialized.uninitialized?).to be true
+    end
+  end
+
+  describe "#match?" do
+    it "returns false for any argument" do
+      expect(uninitialized).not_to match /pattern/
+      expect(uninitialized).not_to match "string"
+      expect(uninitialized).not_to match nil
+    end
+  end
+
+  describe "#include?" do
+    it "returns false for any argument" do
+      expect(uninitialized).not_to include "substring"
+      expect(uninitialized).not_to include nil
+    end
+  end
+
+  describe "#gsub" do
+    it "returns self regardless of arguments" do
+      expect(uninitialized.gsub("pattern", "replacement")).to eq(uninitialized)
+      expect(uninitialized.gsub("pattern", "replacement")).to eq(uninitialized)
+    end
+  end
+
+  describe "#to_yaml" do
+    it "returns nil" do
+      expect(uninitialized.to_yaml).to be_nil
+    end
+  end
+
+  describe "#to_f" do
+    it "returns self" do
+      expect(uninitialized.to_f).to eq(uninitialized)
+    end
+  end
+
+  describe "#size" do
+    it "returns 0" do
+      expect(uninitialized.size).to eq(0)
+    end
+  end
+
+  describe "#encoding" do
+    it "returns the default string encoding" do
+      expect(uninitialized.encoding).to eq("".encoding)
+    end
+  end
+
+  describe "method_missing" do
+    context "when method ends with '?'" do
+      it "returns false" do
+        expect(uninitialized).not_to be_empty
+        expect(uninitialized).not_to be_nil
+        expect(uninitialized).not_to be_blank
+      end
+    end
+
+    context "when method doesn't end with '?'" do
+      it "raises NoMethodError" do
+        expect { uninitialized.unknown_method }.to raise_error(NoMethodError)
+      end
+    end
+  end
+
+  describe "#respond_to_missing?" do
+    it "returns true for methods ending with ?" do
+      expect(uninitialized.respond_to?(:empty?)).to be true
+      expect(uninitialized.respond_to?(:nil?)).to be true
+    end
+
+    it "returns false for methods not ending with ?" do
+      expect(uninitialized.respond_to?(:unknown_method)).to be false
+    end
+  end
+end

data/spec/lutaml/model/xml/namespace_spec.rb

@@ -0,0 +1,57 @@
+require "spec_helper"
+
+module NamespaceSpec
+  class NestedChild < Lutaml::Model::Serializable
+    attribute :name, :string
+
+    xml do
+      root "NestedChild"
+
+      map_element :name, to: :name
+    end
+  end
+
+  class Child < Lutaml::Model::Serializable
+    attribute :nested_child, NestedChild
+
+    xml do
+      root "NestedChild"
+
+      map_element :NestedChild, to: :nested_child
+    end
+  end
+
+  class Parent < Lutaml::Model::Serializable
+    attribute :child, Child
+
+    xml do
+      root "Parent"
+      namespace "https://abc.com"
+
+      map_element :Child, to: :child
+    end
+  end
+end
+
+RSpec.describe "NamespaceSpec" do
+  let(:parsed) { NamespaceSpec::Parent.from_xml(xml) }
+  let(:xml) do
+    <<~XML
+      <Parent xmlns="https://abc.com">
+        <Child>
+          <NestedChild>
+            <name>Rogger moore</name>
+          </NestedChild>
+        </Child>
+      </Parent>
+    XML
+  end
+
+  it "parses nested child using root namespace" do
+    expect(parsed.child.nested_child.name).to eq("Rogger moore")
+  end
+
+  it "round-trips xml" do
+    expect(parsed.to_xml).to be_equivalent_to(xml)
+  end
+end

data/spec/lutaml/model/xml/xml_element_spec.rb

@@ -88,6 +88,6 @@ RSpec.describe "XmlElement" do
   end
 
   def create_element(name, attributes: {}, children: [], text: "")
-    Lutaml::Model::XmlAdapter::XmlElement.new(name, attributes, children, text)
+    Lutaml::Model::Xml::XmlElement.new(name, attributes, children, text)
   end
 end

data/spec/lutaml/model/xml_adapter/nokogiri_adapter_spec.rb

@@ -1,8 +1,8 @@
 require "spec_helper"
 require "nokogiri"
-require_relative "../../../../lib/lutaml/model/xml_adapter/nokogiri_adapter"
+require_relative "../../../../lib/lutaml/model/xml/nokogiri_adapter"
 
-RSpec.describe Lutaml::Model::XmlAdapter::NokogiriAdapter do
+RSpec.describe Lutaml::Model::Xml::NokogiriAdapter do
   let(:xml_string) do
     <<-XML
       <root xmlns="http://example.com/default" xmlns:prefix="http://example.com/prefixed">

data/spec/lutaml/model/xml_adapter/oga_adapter_spec.rb

@@ -1,8 +1,8 @@
 require "spec_helper"
 require "oga"
-require_relative "../../../../lib/lutaml/model/xml_adapter/oga_adapter"
+require_relative "../../../../lib/lutaml/model/xml/oga_adapter"
 
-RSpec.describe Lutaml::Model::XmlAdapter::OgaAdapter do
+RSpec.describe Lutaml::Model::Xml::OgaAdapter do
   let(:xml_string) do
     <<~XML
       <root xmlns="http://example.com/default" xmlns:prefix="http://example.com/prefixed">

data/spec/lutaml/model/xml_adapter/ox_adapter_spec.rb

@@ -1,8 +1,8 @@
 require "spec_helper"
 require "ox"
-require_relative "../../../../lib/lutaml/model/xml_adapter/ox_adapter"
+require_relative "../../../../lib/lutaml/model/xml/ox_adapter"
 
-RSpec.describe Lutaml::Model::XmlAdapter::OxAdapter do
+RSpec.describe Lutaml::Model::Xml::OxAdapter do
   let(:xml_string) do
     <<-XML
       <root xmlns="http://example.com/default" xmlns:prefix="http://example.com/prefixed">

data/spec/lutaml/model/xml_adapter/xml_namespace_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
-require "lutaml/model/xml_adapter/nokogiri_adapter"
-require "lutaml/model/xml_adapter/ox_adapter"
-require "lutaml/model/xml_adapter/oga_adapter"
+require "lutaml/model/xml/nokogiri_adapter"
+require "lutaml/model/xml/ox_adapter"
+require "lutaml/model/xml/oga_adapter"
 require "lutaml/model"
 
 RSpec.describe "XmlNamespace" do
@@ -354,15 +354,15 @@ RSpec.describe "XmlNamespace" do
     end
   end
 
-  describe Lutaml::Model::XmlAdapter::NokogiriAdapter do
+  describe Lutaml::Model::Xml::NokogiriAdapter do
     it_behaves_like "an XML namespace parser", described_class
   end
 
-  describe Lutaml::Model::XmlAdapter::OxAdapter do
+  describe Lutaml::Model::Xml::OxAdapter do
     it_behaves_like "an XML namespace parser", described_class
   end
 
-  describe Lutaml::Model::XmlAdapter::OgaAdapter do
+  describe Lutaml::Model::Xml::OgaAdapter do
     it_behaves_like "an XML namespace parser", described_class
   end
 end

data/spec/lutaml/model/xml_adapter_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
-require "lutaml/model/xml_adapter/nokogiri_adapter"
-require "lutaml/model/xml_adapter/ox_adapter"
-require "lutaml/model/xml_adapter/oga_adapter"
+require "lutaml/model/xml/nokogiri_adapter"
+require "lutaml/model/xml/ox_adapter"
+require "lutaml/model/xml/oga_adapter"
 require_relative "../../fixtures/sample_model"
 
 module XmlAdapterSpec
@@ -172,15 +172,15 @@ RSpec.describe "XmlAdapter" do
     end
   end
 
-  describe Lutaml::Model::XmlAdapter::NokogiriAdapter do
+  describe Lutaml::Model::Xml::NokogiriAdapter do
     it_behaves_like "an XML adapter", described_class
   end
 
-  describe Lutaml::Model::XmlAdapter::OxAdapter do
+  describe Lutaml::Model::Xml::OxAdapter do
     it_behaves_like "an XML adapter", described_class
   end
 
-  describe Lutaml::Model::XmlAdapter::OgaAdapter do
+  describe Lutaml::Model::Xml::OgaAdapter do
     it_behaves_like "an XML adapter", described_class
   end
 end

data/spec/lutaml/model/xml_mapping_rule_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
-require "lutaml/model/xml_adapter/ox_adapter"
-require "lutaml/model/xml_adapter/oga_adapter"
+require "lutaml/model/xml/ox_adapter"
+require "lutaml/model/xml/oga_adapter"
 
 def content_to_xml(model, parent, doc)
   content = model.all_content.sub(/^<div>/, "").sub(/<\/div>$/, "")
@@ -12,7 +12,7 @@ def content_from_xml(model, value)
   model.all_content = "<div>#{value}</div>"
 end
 
-RSpec.describe Lutaml::Model::XmlMappingRule do
+RSpec.describe Lutaml::Model::Xml::MappingRule do
   describe "#namespaced_name" do
     let(:namespaced_name) do
       mapping_rule.namespaced_name

data/spec/lutaml/model/xml_mapping_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
-require "lutaml/model/xml_adapter/ox_adapter"
-require "lutaml/model/xml_adapter/oga_adapter"
+require "lutaml/model/xml/ox_adapter"
+require "lutaml/model/xml/oga_adapter"
 
 # Define a sample class for testing map_content
 class Italic < Lutaml::Model::Serializable
@@ -320,7 +320,7 @@ module XmlMapping
   end
 end
 
-RSpec.describe Lutaml::Model::XmlMapping do
+RSpec.describe Lutaml::Model::Xml::Mapping do
   shared_examples "having XML Mappings" do |adapter_class|
     around do |example|
       old_adapter = Lutaml::Model::Config.xml_adapter
@@ -331,7 +331,7 @@ RSpec.describe Lutaml::Model::XmlMapping do
       Lutaml::Model::Config.xml_adapter = old_adapter
     end
 
-    let(:mapping) { Lutaml::Model::XmlMapping.new }
+    let(:mapping) { Lutaml::Model::Xml::Mapping.new }
 
     context "with attribute having namespace" do
       input_xml = <<~XML
@@ -365,7 +365,7 @@ RSpec.describe Lutaml::Model::XmlMapping do
     end
 
     # Skipping for OX because it does not handle namespaces
-    context "when overriding child namespace prefix", skip: adapter_class == Lutaml::Model::XmlAdapter::OxAdapter do
+    context "when overriding child namespace prefix", skip: adapter_class == Lutaml::Model::Xml::OxAdapter do
       let(:input_xml) do
         <<~XML
           <OverrideDefaultNamespacePrefix
@@ -496,9 +496,9 @@ RSpec.describe Lutaml::Model::XmlMapping do
                                                 ])
 
         {
-          Lutaml::Model::XmlAdapter::NokogiriAdapter => nokogiri_pattern,
-          Lutaml::Model::XmlAdapter::OxAdapter => oga_ox_pattern,
-          Lutaml::Model::XmlAdapter::OgaAdapter => oga_ox_pattern,
+          Lutaml::Model::Xml::NokogiriAdapter => nokogiri_pattern,
+          Lutaml::Model::Xml::OxAdapter => oga_ox_pattern,
+          Lutaml::Model::Xml::OgaAdapter => oga_ox_pattern,
         }
       end
 
@@ -508,7 +508,7 @@ RSpec.describe Lutaml::Model::XmlMapping do
 
       def create_pattern_mapping(array)
         array.map do |type, text|
-          Lutaml::Model::XmlAdapter::Element.new(type, text)
+          Lutaml::Model::Xml::Element.new(type, text)
         end
       end
 
@@ -845,7 +845,7 @@ RSpec.describe Lutaml::Model::XmlMapping do
       end
 
       let(:expected_street) do
-        if Lutaml::Model::Config.xml_adapter == Lutaml::Model::XmlAdapter::NokogiriAdapter
+        if Lutaml::Model::Config.xml_adapter == Lutaml::Model::Xml::NokogiriAdapter
           "\n      <a>N</a>\n      <p>adf</p>\n    "
         else
           "<a>N</a><p>adf</p>"
@@ -1248,7 +1248,7 @@ RSpec.describe Lutaml::Model::XmlMapping do
     end
 
     describe "validation errors" do
-      let(:mapping) { Lutaml::Model::XmlMapping.new }
+      let(:mapping) { Lutaml::Model::Xml::Mapping.new }
 
       it "raises error when neither :to nor :with provided" do
         expect do
@@ -1268,6 +1268,12 @@ RSpec.describe Lutaml::Model::XmlMapping do
         )
       end
 
+      it "does not raise error when :to is provided" do
+        expect do
+          mapping.map_element("test", to: :test, with: { from: "value" })
+        end.not_to raise_error
+      end
+
       describe "map_attribute validations" do
         it "raises error for invalid :with argument" do
           expect do
@@ -1277,6 +1283,12 @@ RSpec.describe Lutaml::Model::XmlMapping do
             ":with argument for mapping 'test' requires :to and :from keys",
           )
         end
+
+        it "does not raise error if to is provided" do
+          expect do
+            mapping.map_attribute("test", to: :test, with: { from: "value" })
+          end.not_to raise_error
+        end
       end
 
       describe "map_content validations" do
@@ -1292,15 +1304,15 @@ RSpec.describe Lutaml::Model::XmlMapping do
     end
   end
 
-  describe Lutaml::Model::XmlAdapter::NokogiriAdapter do
+  describe Lutaml::Model::Xml::NokogiriAdapter do
     it_behaves_like "having XML Mappings", described_class
   end
 
-  describe Lutaml::Model::XmlAdapter::OxAdapter do
+  describe Lutaml::Model::Xml::OxAdapter do
     it_behaves_like "having XML Mappings", described_class
   end
 
-  describe Lutaml::Model::XmlAdapter::OgaAdapter do
+  describe Lutaml::Model::Xml::OgaAdapter do
     it_behaves_like "having XML Mappings", described_class
   end
 end

data/spec/lutaml/model/xml_spec.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require "lutaml/model/xml"
+
+RSpec.describe Lutaml::Model::Xml do
+  describe ".detect_xml_adapter" do
+    before do
+      # Hide any existing constants first
+      hide_const("Nokogiri") if Object.const_defined?(:Nokogiri)
+      hide_const("Ox") if Object.const_defined?(:Ox)
+      hide_const("Oga") if Object.const_defined?(:Oga)
+    end
+
+    context "when Nokogiri is available" do
+      before do
+        stub_const("Nokogiri", Module.new)
+      end
+
+      it "returns :nokogiri" do
+        expect(described_class.detect_xml_adapter).to eq(:nokogiri)
+      end
+    end
+
+    context "when Ox is available" do
+      before do
+        stub_const("Ox", Module.new)
+      end
+
+      it "returns :ox" do
+        expect(described_class.detect_xml_adapter).to eq(:ox)
+      end
+    end
+
+    context "when Oga is available" do
+      before do
+        stub_const("Oga", Module.new)
+      end
+
+      it "returns :oga" do
+        expect(described_class.detect_xml_adapter).to eq(:oga)
+      end
+    end
+
+    context "when no adapters are available" do
+      it "returns nil" do
+        expect(described_class.detect_xml_adapter).to be_nil
+      end
+    end
+
+    context "when multiple adapters are available" do
+      before do
+        stub_const("Nokogiri", Module.new)
+        stub_const("Ox", Module.new)
+        stub_const("Oga", Module.new)
+      end
+
+      it "prefers Nokogiri" do
+        expect(described_class.detect_xml_adapter).to eq(:nokogiri)
+      end
+    end
+  end
+end

data/spec/lutaml/model/yaml_adapter_spec.rb

@@ -1,5 +1,4 @@
 require "spec_helper"
-require "lutaml/model/yaml_adapter"
 require_relative "../../fixtures/sample_model"
 
 RSpec.shared_examples "a YAML adapter" do |adapter_class|
@@ -7,7 +6,7 @@ RSpec.shared_examples "a YAML adapter" do |adapter_class|
   let(:model) { SampleModel.new(attributes) }
 
   let(:expected_yaml) do
-    if adapter_class == Lutaml::Model::YamlAdapter::StandardYamlAdapter
+    if adapter_class == Lutaml::Model::Yaml::StandardAdapter
       attributes.to_yaml
     end
   end
@@ -20,11 +19,10 @@ RSpec.shared_examples "a YAML adapter" do |adapter_class|
 
   it "deserializes from YAML" do
     new_model = adapter_class.parse(expected_yaml)
-    expect(new_model["name"]).to eq("John Doe")
-    expect(new_model["age"]).to eq(30)
+    expect(new_model).to eq(attributes)
   end
 end
 
-RSpec.describe Lutaml::Model::YamlAdapter::StandardYamlAdapter do
+RSpec.describe Lutaml::Model::Yaml::StandardAdapter do
   it_behaves_like "a YAML adapter", described_class
 end

data/spec/spec_helper.rb

@@ -22,9 +22,9 @@ end
 
 # configuration example
 require_relative "../lib/lutaml/model"
-require_relative "../lib/lutaml/model/xml_adapter/nokogiri_adapter"
-require_relative "../lib/lutaml/model/xml_adapter/ox_adapter"
-require_relative "../lib/lutaml/model/toml_adapter/toml_rb_adapter"
+# require_relative "../lib/lutaml/model/xml/nokogiri_adapter"
+# require_relative "../lib/lutaml/model/xml/ox_adapter"
+# require_relative "../lib/lutaml/model/toml_adapter/toml_rb_adapter"
 
 Lutaml::Model::Config.configure do |config|
   config.xml_adapter_type = :nokogiri